Re: Input validation observations

2010-12-03 Thread Noorul Islam K M
Julian Foad writes: > Noorul Islam K M wrote: > >> Julian Foad writes: >> > * "svn mkdir ^/ a" -> "Illegal repository URL 'a'"; should say "can't >> > mix URL and local targets"? > [...] >> Make 'svn mkdir' verify that both working copy paths and URLs are >> not passed. >> >> * subversion/svn

Re: Input validation observations

2010-12-03 Thread Noorul Islam K M
Julian Foad writes: > On Fri, 2010-12-03, Noorul Islam K M wrote: > >> Julian Foad writes: >> > I think we should change this behaviour and make "svn update" throw an >> > error if any target is a URL. >> >> Attached is the patch for same. > [...] >> Make 'svn update' verify that URLs are not p

Re: Input validation observations

2010-12-03 Thread Noorul Islam K M
Julian Foad writes: > Noorul Islam K M wrote: > >> Julian Foad writes: >> > * "svn info ^/b" -> "Not a valid URL"; should be "path '/b' not found >> > in revision REV"? >> >> Patch attached. > > Hi Noorul. > >> Make "svn info" to display the actual error message returned by API when >> illega

What repository to use? Re: collecting signatures for releases: thoughts on collect_sigs...@{2011-12-04}

2010-12-03 Thread Daniel Shahaf
Daniel Shahaf wrote on Sat, Dec 04, 2010 at 00:51:12 +0200: > the backing repository [where *.asc files are maintained prior to blessing > the release] For 1.6 we can use the subversion.tigris.org repository (to which blessed tarballs are eventually committed). It's not configured for CIA though

collecting signatures for releases: thoughts on collect_sigs...@{2011-12-04}

2010-12-03 Thread Daniel Shahaf
[ Summary: collect signatures for releases via a CGI that verifies signatures and commits them to a Subversion repository. ] We now have a CGI script[1] that collects the signatures for release, verifies them, and assembles them into *.asc files. That automates some work that previously fell upo

Re: svn commit: r1041839 - in /subversion/trunk/subversion: libsvn_client/diff.c tests/cmdline/depth_tests.py tests/cmdline/diff_tests.py

2010-12-03 Thread Stefan Sperling
On Fri, Dec 03, 2010 at 02:36:34PM -, kame...@apache.org wrote: > Author: kameshj > Date: Fri Dec 3 14:36:33 2010 > New Revision: 1041839 > > URL: http://svn.apache.org/viewvc?rev=1041839&view=rev > Log: > Follow-up to r1041068. > > In r1041068 I removed "." as the default path for "" to fix

RE: [PATCH] enhance diff to make it behave uniformly

2010-12-03 Thread Kamesh Jayachandran
> I understand your patch fixes the following two cases. > > 1. svn di -cN explicitly_reinstated_file_with_mod_at_rN >Hi Kamesh and Prabhu. >What you're describing here sounds good - it sounds like a simpler and >more definite change than what I understood before - but I'm not sure >precisely wh

Re: [PATCH] enhance diff to make it behave uniformly

2010-12-03 Thread Julian Foad
On Wed, 2010-12-01, Kamesh Jayachandran wrote: > Hi Prabhu, > > I understand your patch fixes the following two cases. > > 1. svn di -cN explicitly_reinstated_file_with_mod_at_rN Hi Kamesh and Prabhu. What you're describing here sounds good - it sounds like a simpler and more definite change th

Re: Inconsistent behavior in cat command

2010-12-03 Thread Julian Foad
On Thu, 2010-12-02, Noorul Islam K M wrote: > Noorul Islam K M writes: > > > When I was trying to come up with a patch for issue 3713, I observed the > > following. > > > > For example I have two files 1.txt and 2.txt in a repository located at > > file:///tmp/testrepo > > > > svn cat behaves dif

Re: Input validation observations

2010-12-03 Thread Julian Foad
On Fri, 2010-12-03 at 16:53 +, Julian Foad wrote: > On Fri, 2010-12-03, Julian Foad wrote: > > On Fri, 2010-12-03 at 19:15 +0530, Noorul Islam K M wrote: > > > Julian Foad writes: > > > > Noorul Islam K M wrote: > > > >> Julian Foad writes: > > > >> > * "svn mkdir ^/ a" -> "Illegal reposito

Re: subversion cross compile (arm)

2010-12-03 Thread Philip Martin
Takács András writes: > I checked my toolchain. It's using 32 bit file offsets. > I tried an other toolchain (ct-ng + eglibc). Same result. :( > > 2010/12/3 Philip Martin : >> Takács András writes: >> >>> Here at the nodrerev->data_rep section I preinted out the revision, >>> offset, size, enpan

Re: Input validation observations

2010-12-03 Thread Julian Foad
On Fri, 2010-12-03, Julian Foad wrote: > On Fri, 2010-12-03 at 19:15 +0530, Noorul Islam K M wrote: > > Julian Foad writes: > > > Noorul Islam K M wrote: > > >> Julian Foad writes: > > >> > * "svn mkdir ^/ a" -> "Illegal repository URL 'a'"; should say "can't > > >> > mix URL and local targets"

Re: subversion cross compile (arm)

2010-12-03 Thread Philip Martin
Philip Martin writes: > Takács András writes: > >> The next debug step is in the representation_string function. Before >> calling the apr_psprintf function, I printed out again the fields: >> >> rs rev 0 >> rs offs 4618628953320456192 > > in hex: 4018AA90 > >> rs size 4 >> rs exp size 4

Re: subversion cross compile (arm)

2010-12-03 Thread Takács András
I checked my toolchain. It's using 32 bit file offsets. I tried an other toolchain (ct-ng + eglibc). Same result. :( -- Takács András Skype: wakoond GTalk: wakoond MSN: wako...@freestart.hu 2010/12/3 Philip Martin : > Takács András writes: > >> One more interesting addition: >> >> The represen

Re: Input validation observations

2010-12-03 Thread Julian Foad
On Fri, 2010-12-03 at 19:15 +0530, Noorul Islam K M wrote: > Julian Foad writes: > > Noorul Islam K M wrote: > >> Julian Foad writes: > >> > * "svn mkdir ^/ a" -> "Illegal repository URL 'a'"; should say "can't > >> > mix URL and local targets"? > > [...] > > Does this validation make the check

Re: Input validation observations

2010-12-03 Thread Julian Foad
On Fri, 2010-12-03, Noorul Islam K M wrote: > Julian Foad writes: > > I think we should change this behaviour and make "svn update" throw an > > error if any target is a URL. > > Attached is the patch for same. [...] > Make 'svn update' verify that URLs are not passed as targets. > > * subversio

Re: Input validation observations

2010-12-03 Thread C. Michael Pilato
On 12/03/2010 06:51 AM, Julian Foad wrote: > Noorul Islam K M wrote: >> Julian Foad writes: [...] >> Index: subversion/svn/info-cmd.c >> === >> --- subversion/svn/info-cmd.c(revision 1041293) >> +++ subversion/svn/info-cmd.c

Re: subversion cross compile (arm)

2010-12-03 Thread Philip Martin
Takács András writes: > One more interesting addition: > > The representation_string function is called from svn_fs_fs__write_noderev. > Here at the nodrerev->data_rep section I preinted out the revision, > offset, size, enpanded_size fields from the noderev->data_rep > structure: > > rev 0 > off

Re: subversion cross compile (arm)

2010-12-03 Thread Takács András
One more interesting addition: The representation_string function is called from svn_fs_fs__write_noderev. Here at the nodrerev->data_rep section I preinted out the revision, offset, size, enpanded_size fields from the noderev->data_rep structure: rev 0 offs 4618629949752868864 size 4 exp size 4

Re: 1.5.9 up for testing/signing

2010-12-03 Thread Kamesh Jayachandran
On 12/03/2010 09:04 PM, Mark Phippard wrote: On Fri, Dec 3, 2010 at 10:28 AM, Kamesh Jayachandran wrote: Forgive my ignorance Paul. IIUC in 1.5.x we can only have neon or serf not both. Did you do 2 builds to test this? I think you are confusing it with 1.4.x. We added support in 1.5.x for su

Re: 1.5.9 up for testing/signing

2010-12-03 Thread Paul Burba
On Fri, Dec 3, 2010 at 10:34 AM, Mark Phippard wrote: > On Fri, Dec 3, 2010 at 10:28 AM, Kamesh Jayachandran > wrote: >> Forgive my ignorance Paul. IIUC in 1.5.x we can only have neon or serf not >> both. Did you do 2 builds to test this? > > I think you are confusing it with 1.4.x.  We added su

Re: 1.5.9 up for testing/signing

2010-12-03 Thread Mark Phippard
On Fri, Dec 3, 2010 at 10:28 AM, Kamesh Jayachandran wrote: > Forgive my ignorance Paul. IIUC in 1.5.x we can only have neon or serf not > both. Did you do 2 builds to test this? I think you are confusing it with 1.4.x. We added support in 1.5.x for supporting both: http://subversion.apache.org

Re: 1.5.9 up for testing/signing

2010-12-03 Thread Kamesh Jayachandran
On 12/03/2010 08:14 PM, Paul Burba wrote: On Thu, Dec 2, 2010 at 4:55 PM, Hyrum K. Wright wrote: 1.5.9 tarballs are up for testing and signing. The magic revision is r1041577: http://people.apache.org/~hwright/svn/1.5.9/ To sign the release, please input your signatures using the script her

Re: 1.5.9 up for testing/signing

2010-12-03 Thread Mark Phippard
SUMMARY: +1 to release PLATFORM: Windows 7 VS 2008 SP1 Java 1.6 COMPONENTS: Apache2.2.15 APR 1.4.2 APR-UTIL1.3.9 OpenSSL 1.0.0a Neon0.29.5 ZLib (from deps) VERIFIED: md5 and sha1 sums gpg signature verified TESTED: JavaHL ra_loca

Re: subversion cross compile (arm)

2010-12-03 Thread Takács András
The problems seems to be somewhere between the generation (representation_string) and the writing of the /var/svn/testrepo/db/transactions/0-0.txn/node.0.0 file. The bugous string will be in the file. I'll try to locate the bug at the weekend. András -- Takács András Skype: wakoond GTalk: wako

Re: 1.5.9 up for testing/signing

2010-12-03 Thread Paul Burba
On Thu, Dec 2, 2010 at 4:55 PM, Hyrum K. Wright wrote: > 1.5.9 tarballs are up for testing and signing.  The magic revision is > r1041577: > http://people.apache.org/~hwright/svn/1.5.9/ > > To sign the release, please input your signatures using the script here: > http://work.hyrumwright.org/pub

Re: svn commit: r1041068 - in /subversion/trunk/subversion: libsvn_client/diff.c tests/cmdline/depth_tests.py tests/cmdline/diff_tests.py

2010-12-03 Thread Kamesh Jayachandran
On 12/01/2010 11:57 PM, Kamesh Jayachandran wrote: Hi Kamesh, I don't think this change in diff output is desirable. In 1.6.x, you get lines like: Property changes on: . in a diff. You made it print: Property changes on: instead. Is there a way to fix the assertion problem without changing th

Re: Input validation observations

2010-12-03 Thread Noorul Islam K M
Julian Foad writes: > Noorul Islam K M wrote: > >> Julian Foad writes: >> > * "svn mkdir ^/ a" -> "Illegal repository URL 'a'"; should say "can't >> > mix URL and local targets"? > [...] >> Make 'svn mkdir' verify that both working copy paths and URLs are >> not passed. >> >> * subversion/svn

Re: 1.5.9 up for testing/signing

2010-12-03 Thread Philip Martin
Summary: +1 to release. Platform: Linux (Debian/stable). Verified: signatures, MD5 checksums, SHA1 checksums only expected difference compared to tags/1.5.9 Tested: 1.5.9 tarball with local dependencies (not deps tarball) (local, svn, svn+sasl, serf, neon, javahl) x (fsfs, bdb)

Re: diff-optimizations-tokens branch: I think I'm going to abandon it

2010-12-03 Thread Branko Čibej
On 02.12.2010 21:21, Johan Corveleyn wrote: > On Thu, Dec 2, 2010 at 6:18 PM, Bill Tutt wrote: >> Additional ignore whitespace related comment: >> * IIRC, Perforce had an interesting twist on ignoring whitespace. You >> could ignore just line leading/ending whitespace instead of all >> whitespace

Re: Input validation observations

2010-12-03 Thread Julian Foad
Noorul Islam K M wrote: > Julian Foad writes: > > * "svn mkdir ^/ a" -> "Illegal repository URL 'a'"; should say "can't > > mix URL and local targets"? [...] > Make 'svn mkdir' verify that both working copy paths and URLs are > not passed. > > * subversion/svn/mkdir-cmd.c, > subversion/libsvn

Re: Input validation observations

2010-12-03 Thread Julian Foad
Noorul Islam K M wrote: > Julian Foad writes: > > * "svn info ^/b" -> "Not a valid URL"; should be "path '/b' not found > > in revision REV"? > > Patch attached. Hi Noorul. > Make "svn info" to display the actual error message returned by API when > illegal URL is passed. > > * subversion/sv

Re: Input validation observations

2010-12-03 Thread Noorul Islam K M
Julian Foad writes: > I tried some potentially invalid inputs to "svn" a week or two ago and > made notes on what I found. Just posting here in case anyone wants to > do something about one or more of them. > > Noorul, I'm including you in the "To" addresses because you said you > were looking f

Re: Input validation observations

2010-12-03 Thread Noorul Islam K M
Julian Foad writes: > I tried some potentially invalid inputs to "svn" a week or two ago and > made notes on what I found. Just posting here in case anyone wants to > do something about one or more of them. > > Noorul, I'm including you in the "To" addresses because you said you > were looking f

Re: subversion cross compile (arm)

2010-12-03 Thread Philip Martin
Takács András writes: > 2010/12/3 Philip Martin : >> Takács András writes: >> >>> / # svn mkdir file:///var/svn/testrepo/xxx -m "aaa" >>> fs_fs: [LINE 2082] calling svn_fs_fs__read_noderev >>> fs_fs: [LINE 2140] calling read_rep_offsets '0 0 4 4 >>> 2d2977d1c96f487abe4a1e202dd03b4e' >>> read_rep

Re: subversion cross compile (arm)

2010-12-03 Thread Takács András
2010/12/3 Philip Martin : > Takács András writes: > >> / # svn mkdir file:///var/svn/testrepo/xxx -m "aaa" >> fs_fs: [LINE 2082] calling svn_fs_fs__read_noderev >> fs_fs: [LINE 2140] calling read_rep_offsets '0 0 4 4 >> 2d2977d1c96f487abe4a1e202dd03b4e' >> read_rep_offsets: [LINE 1947] '0 0 4 4 2d

Re: subversion cross compile (arm)

2010-12-03 Thread Philip Martin
Takács András writes: > / # svn mkdir file:///var/svn/testrepo/xxx -m "aaa" > fs_fs: [LINE 2082] calling svn_fs_fs__read_noderev > fs_fs: [LINE 2140] calling read_rep_offsets '0 0 4 4 > 2d2977d1c96f487abe4a1e202dd03b4e' > read_rep_offsets: [LINE 1947] '0 0 4 4 2d2977d1c96f487abe4a1e202dd03b4e' >

Re: Input validation observations

2010-12-03 Thread Noorul Islam K M
Julian Foad writes: > On Thu, 2010-12-02 at 13:58 +0530, Noorul Islam K M wrote: > >> Julian Foad writes: >> >> > On Tue, 2010-11-30 at 18:42 +0530, Noorul Islam K M wrote: >> > >> >> Julian Foad writes: >> >> >> >> > I tried some potentially invalid inputs to "svn" a week or two ago and >> >