Re: stat_tests.py 19 is failing?

2010-12-15 Thread Paul Burba
On Wed, Dec 15, 2010 at 3:03 PM, C. Michael Pilato wrote: > On 12/15/2010 03:00 PM, C. Michael Pilato wrote: >> On 12/15/2010 02:58 PM, Philip Martin wrote: >>> "C. Michael Pilato" writes: >>> On 12/15/2010 02:11 PM, Philip Martin wrote: > "C. Michael Pilato" writes: > >> Try r1

Re: stat_tests.py 19 is failing?

2010-12-15 Thread C. Michael Pilato
On 12/15/2010 03:00 PM, C. Michael Pilato wrote: > On 12/15/2010 02:58 PM, Philip Martin wrote: >> "C. Michael Pilato" writes: >> >>> On 12/15/2010 02:11 PM, Philip Martin wrote: "C. Michael Pilato" writes: > Try r1049668 -- see if stuff still passes for you in your default > co

Re: stat_tests.py 19 is failing?

2010-12-15 Thread C. Michael Pilato
On 12/15/2010 02:58 PM, Philip Martin wrote: > "C. Michael Pilato" writes: > >> On 12/15/2010 02:11 PM, Philip Martin wrote: >>> "C. Michael Pilato" writes: >>> Try r1049668 -- see if stuff still passes for you in your default configuration. >>> >>> Yes, it does. >> >> Cool. Thanks. >

Re: stat_tests.py 19 is failing?

2010-12-15 Thread Philip Martin
"C. Michael Pilato" writes: > On 12/15/2010 02:11 PM, Philip Martin wrote: >> "C. Michael Pilato" writes: >> >>> Try r1049668 -- see if stuff still passes for you in your default >>> configuration. >> >> Yes, it does. > > Cool. Thanks. It seems to fail on Windows: http://ci.apache.org/build

Re: stat_tests.py 19 is failing?

2010-12-15 Thread Philip Martin
"C. Michael Pilato" writes: > Try r1049668 -- see if stuff still passes for you in your default > configuration. Yes, it does. -- Philip

Re: [PATCH] svnrdump "help" displays subcommand-specific documentation

2010-12-15 Thread C. Michael Pilato
On 12/15/2010 08:37 AM, Prabhu Gnana Sundar wrote: > Hi, > > This patch makes the "svnrdump's" help to display the > subcommand-specific documentation. > ( similar to "svn", "svnlook", "svnadmin" ...) > > Previously, "svnrdump dump --help" does *not* display the > help-documentation correspondin

Re: stat_tests.py 19 is failing?

2010-12-15 Thread C. Michael Pilato
On 12/15/2010 02:11 PM, Philip Martin wrote: > "C. Michael Pilato" writes: > >> Try r1049668 -- see if stuff still passes for you in your default >> configuration. > > Yes, it does. Cool. Thanks. -- C. Michael Pilato CollabNet <> www.collab.net <> Distributed Development On Demand

Re: stat_tests.py 19 is failing?

2010-12-15 Thread C. Michael Pilato
On 12/15/2010 02:02 PM, Philip Martin wrote: > If I do > > pushd subversion/tests/cmdline > svnadmin create repo > ../../svn/svn co file://`pwd`/repo wc > mv wc/.svn . > popd > > then stat_tests.py 19 starts to FAIL. So it's running inside a 1.7 wc > that causes the problem. Try r1049668 -- see

Re: stat_tests.py 19 is failing?

2010-12-15 Thread Philip Martin
"C. Michael Pilato" writes: > On 12/15/2010 12:26 PM, Philip Martin wrote: >> Noorul Islam K M writes: >> My work-in-progress *shouldn't* have any relevance here, so I'm assuming that others are seeing this problem, too. Can someone confirm? >>> >>> I confirm that it is failing for m

Re: stat_tests.py 19 is failing?

2010-12-15 Thread C. Michael Pilato
On 12/15/2010 12:35 PM, Noorul Islam K M wrote: > "C. Michael Pilato" writes: >> And I'm building/running inside the source dir. That might explain the >> difference. > > Is it not because of 1045385? Yes, it is. -- C. Michael Pilato CollabNet <> www.collab.net <> Distributed Develop

Re: [PATCH]: transform_libtool_scripts.py

2010-12-15 Thread Philip Martin
Martin Furter writes: > Doing some more testing I found another out that non-existing > libraries have to be removed from LD_PRELOAD. Does this interact with --enable-runtime-module-search? That's the switch that causes Subversion to load RA/FS modules at runtime rather than linking them to the

Re: Subversion issue 2791

2010-12-15 Thread Martin Furter
Here's the latest patch. I ran the commit tests and svnlook tests and they passed. There seem to not be any other tests for hooks. - Martin [[[ Use svn_io_start_cmd2 in run_hook_cmd. * subversion/libsvn_repos/hooks.c (run_hook_cmd): Use svn_io_start_cmd2. ]]]Index: subversion/libsvn_repos

Re: [PATCH]: transform_libtool_scripts.py

2010-12-15 Thread Martin Furter
Doing some more testing I found another out that non-existing libraries have to be removed from LD_PRELOAD. So here's a new patch. - Martin On Wed, 15 Dec 2010, Martin Furter wrote: Here is version 2 of the patch. On Tue, 14 Dec 2010, Philip Martin wrote: Martin Furter writes: The g

Re: stat_tests.py 19 is failing?

2010-12-15 Thread Noorul Islam K M
"C. Michael Pilato" writes: > On 12/15/2010 12:26 PM, Philip Martin wrote: > >> Noorul Islam K M writes: >> My work-in-progress *shouldn't* have any relevance here, so I'm assuming that others are seeing this problem, too. Can someone confirm? >>> >>> I confirm that it is failing for

Re: stat_tests.py 19 is failing?

2010-12-15 Thread C. Michael Pilato
On 12/15/2010 12:26 PM, Philip Martin wrote: > Noorul Islam K M writes: > >>> My work-in-progress *shouldn't* have any relevance here, so I'm assuming >>> that others are seeing this problem, too. Can someone confirm? >> >> I confirm that it is failing for me also. I do not have any local >> cha

Re: stat_tests.py 19 is failing?

2010-12-15 Thread Philip Martin
Noorul Islam K M writes: >> My work-in-progress *shouldn't* have any relevance here, so I'm assuming >> that others are seeing this problem, too. Can someone confirm? > > I confirm that it is failing for me also. I do not have any local > changes. Passes for me. I'm building/running the tests

Re: stat_tests.py 19 is failing?

2010-12-15 Thread Philip Martin
Philip Martin writes: >> stat_tests.py 19 is a PASS for me, unmodified r11049592. > > s/r11049578/r1049592/ Gah! I mean r1049592. -- Philip

Re: stat_tests.py 19 is failing?

2010-12-15 Thread Philip Martin
Philip Martin writes: > "C. Michael Pilato" writes: > >> I'm seeing stat_tests.py 19 failing for what looks like a difference of >> abspath/relpath in the output: > > stat_tests.py 19 is a PASS for me, unmodified r11049592. s/r11049578/r1049592/ -- Philip

Re: stat_tests.py 19 is failing?

2010-12-15 Thread Philip Martin
"C. Michael Pilato" writes: > I'm seeing stat_tests.py 19 failing for what looks like a difference of > abspath/relpath in the output: stat_tests.py 19 is a PASS for me, unmodified r11049592. -- Philip

Re: stat_tests.py 19 is failing?

2010-12-15 Thread Noorul Islam K M
"C. Michael Pilato" writes: > I'm seeing stat_tests.py 19 failing for what looks like a difference of > abspath/relpath in the output: > > -svn: warning: > '/home/cmpilato/projects/subversion/trunk/subversion/tests/cmdline/svn-test-work/local_tmp/repos' > is not a working copy > -svn: warning: >

stat_tests.py 19 is failing?

2010-12-15 Thread C. Michael Pilato
I'm seeing stat_tests.py 19 failing for what looks like a difference of abspath/relpath in the output: -svn: warning: '/home/cmpilato/projects/subversion/trunk/subversion/tests/cmdline/svn-test-work/local_tmp/repos' is not a working copy -svn: warning: '/home/cmpilato/projects/subversion/trunk/sub

Re: Input validation observations

2010-12-15 Thread Julian Foad
On Wed, 2010-12-15, Noorul Islam K M wrote: > Julian Foad writes: > > > Noorul Islam K M wrote: > > > >> Julian Foad writes: > >> > Thank you for the updated patch. Even though this is a very > >> > simple-looking patch, I need a bit more information to help me review > >> > it. > >> > > >> > D

Re: [Issue 3758] New - svn-dev.el - Update paths and links

2010-12-15 Thread Noorul Islam K M
"C. Michael Pilato" writes: > On 12/10/2010 11:31 AM, Noorul Islam K M wrote: > >> Noorul Islam K M writes: >> >>> Attached is the patch. > > FIXED: >Sendingtools/dev/svn-dev.el >Transmitting file data . >Committed revision 1049557. Thank You! - Noorul

[PATCH] Remove redundant member - libsvn_wc/update_editor.c:file_baton.added_with_history

2010-12-15 Thread Arwin Arni
Hi, I was looking through the subversion/libsvn_wc/update_editor.c and noticed that there was a redundant member (added_with_history) in the file baton structure. This is not being set anywhere which results in some unreachable code. I have removed the member and the corresponding unreachable

Re: Move contrib/ to apache-extras.org

2010-12-15 Thread C. Michael Pilato
On 12/14/2010 11:28 PM, Hyrum K. Wright wrote: > I'd like to move everything in our contrib/ directory to the new > Apache Extras hosting. +`find trunk/contrib | wc -l`. -- C. Michael Pilato CollabNet <> www.collab.net <> Distributed Development On Demand signature.asc Description: O

Re: [Issue 3758] New - svn-dev.el - Update paths and links

2010-12-15 Thread C. Michael Pilato
On 12/10/2010 11:31 AM, Noorul Islam K M wrote: > Noorul Islam K M writes: > >> Attached is the patch. FIXED: Sendingtools/dev/svn-dev.el Transmitting file data . Committed revision 1049557. -- C. Michael Pilato CollabNet <> www.collab.net <> Distributed Development O

Re: Move contrib/ to apache-extras.org

2010-12-15 Thread Hyrum K. Wright
On Wed, Dec 15, 2010 at 8:02 AM, C. Michael Pilato wrote: > On 12/14/2010 11:28 PM, Hyrum K. Wright wrote: >> I'd like to move everything in our contrib/ directory to the new >> Apache Extras hosting. > > +`find trunk/contrib | wc -l`. $ find contrib | wc -l 592 $ find contrib | grep -v '.sv

Re: svn commit: r1049414 - /subversion/trunk/subversion/tests/svn_test_main.c

2010-12-15 Thread C. Michael Pilato
On 12/15/2010 04:32 AM, Branko Čibej wrote: > Are the sig* variants available on all platforms? I don't recall seeing > them in the C90 stdlib. `man setjmp` tells me: C89, C99, and POSIX.1-2001 specify setjmp(). POSIX.1-2001 specifies sigsetjmp(). -- C. Michael Pilato CollabNet <> www.col

[PATCH] svnrdump "help" displays subcommand-specific documentation

2010-12-15 Thread Prabhu Gnana Sundar
Hi, This patch makes the "svnrdump's" help to display the subcommand-specific documentation. ( similar to "svn", "svnlook", "svnadmin" ...) Previously, "svnrdump dump --help" does *not* display the help-documentation corresponding to "dump", but "svnrdump help dump" did as expected. Meanwhile,

Re: svn commit: r1049414 - /subversion/trunk/subversion/tests/svn_test_main.c

2010-12-15 Thread Hyrum K. Wright
On Wed, Dec 15, 2010 at 3:32 AM, Branko Čibej wrote: > On 15.12.2010 06:17, Blair Zajac wrote: >> On 12/14/10 8:21 PM, hwri...@apache.org wrote: >>> Author: hwright >>> Date: Wed Dec 15 04:21:23 2010 >>> New Revision: 1049414 >>> >>> URL: http://svn.apache.org/viewvc?rev=1049414&view=rev >>> Log:

Re: [Issue 3758] New - svn-dev.el - Update paths and links

2010-12-15 Thread Julian Foad
On Fri, 2010-12-10 at 22:01 +0530, Noorul Islam K M wrote: > Noorul Islam K M writes: > > > Attached is the patch. > > > > Thanks and Regards > > Noorul > > > > Index: tools/dev/svn-dev.el > > === > > --- tools/dev/svn-dev.el(rev

Re: [PATCH]: transform_libtool_scripts.py

2010-12-15 Thread Martin Furter
Here is version 2 of the patch. On Tue, 14 Dec 2010, Philip Martin wrote: Martin Furter writes: The generated script then has to be included into the tarball. I believe to remember that there's a script which creates the tarball. Can anyone give me a pointer where I can find it? tools/dis

RE: [RFC] diff-optimizations-bytes branch: avoiding function call overhead (?)

2010-12-15 Thread Bert Huijben
> -Original Message- > From: Johan Corveleyn [mailto:jcor...@gmail.com] > Sent: woensdag 15 december 2010 11:30 > To: Branko Čibej > Cc: dev@subversion.apache.org > Subject: Re: [RFC] diff-optimizations-bytes branch: avoiding function > call overhead (?) > > It was a Windows build (x86)

Re: [RFC] diff-optimizations-bytes branch: avoiding function call overhead (?)

2010-12-15 Thread Johan Corveleyn
On Wed, Dec 15, 2010 at 11:53 AM, Johan Corveleyn wrote: > On Wed, Dec 15, 2010 at 11:50 AM, Johan Corveleyn wrote: >> Also, I did my measurements with a blame operation on this very large >> file, which has ~2500 revisions. So that's 2500 diffs of a ~1,5 Mb >> file, with say on average 1 Mb of i

Re: [RFC] diff-optimizations-bytes branch: avoiding function call overhead (?)

2010-12-15 Thread Johan Corveleyn
On Wed, Dec 15, 2010 at 11:50 AM, Johan Corveleyn wrote: > On Wed, Dec 15, 2010 at 2:30 AM, Stefan Fuhrmann wrote: >> On 14.12.2010 23:35, Johan Corveleyn wrote: >>> >>> Hi all, >> >> Hi Johan ;) > > Hi Stefan, thanks for the input :). I suspected that you might have > some ideas about this ... >

Re: [RFC] diff-optimizations-bytes branch: avoiding function call overhead (?)

2010-12-15 Thread Johan Corveleyn
On Wed, Dec 15, 2010 at 2:30 AM, Stefan Fuhrmann wrote: > On 14.12.2010 23:35, Johan Corveleyn wrote: >> >> Hi all, > > Hi Johan ;) Hi Stefan, thanks for the input :). I suspected that you might have some ideas about this ... >> On the diff-optimizations-bytes branch, in diff_file.c, there are t

Re: [RFC] diff-optimizations-bytes branch: avoiding function call overhead (?)

2010-12-15 Thread Johan Corveleyn
On Wed, Dec 15, 2010 at 10:30 AM, Branko Čibej wrote: > On 15.12.2010 02:30, Stefan Fuhrmann wrote: >> On 14.12.2010 23:35, Johan Corveleyn wrote: >>> Some considerations: >>> - Maybe I can use APR_INLINE, with similar results? >>> >>> - Maybe I can put just the "critical section" into a macro (th

Re: [RFC] diff-optimizations-bytes branch: avoiding function call overhead (?)

2010-12-15 Thread Stefan Fuhrmann
On 15.12.2010 02:30, Stefan Fuhrmann wrote: On 14.12.2010 23:35, Johan Corveleyn wrote: Thoughts? Two things you might try: * introduce a local variable for afile[i] * replace the for() loop with two nested ones, keeping calls to other functions out of the hot spot: for (i=0; i < file_len;)

Re: svn commit: r1049414 - /subversion/trunk/subversion/tests/svn_test_main.c

2010-12-15 Thread Branko Čibej
On 15.12.2010 06:17, Blair Zajac wrote: > On 12/14/10 8:21 PM, hwri...@apache.org wrote: >> Author: hwright >> Date: Wed Dec 15 04:21:23 2010 >> New Revision: 1049414 >> >> URL: http://svn.apache.org/viewvc?rev=1049414&view=rev >> Log: >> Allow tests which cause segfaults to not disrupt the other t

Re: [RFC] diff-optimizations-bytes branch: avoiding function call overhead (?)

2010-12-15 Thread Branko Čibej
On 15.12.2010 02:30, Stefan Fuhrmann wrote: > On 14.12.2010 23:35, Johan Corveleyn wrote: >> Some considerations: >> - Maybe I can use APR_INLINE, with similar results? >> >> - Maybe I can put just the "critical section" into a macro (the curp++ >> / curp-- part), and call a function when a chunk b

Re: Move contrib/ to apache-extras.org

2010-12-15 Thread Rainer Jung
On 15.12.2010 07:05, Blair Zajac wrote: On 12/14/10 8:28 PM, Hyrum K. Wright wrote: I'd like to move everything in our contrib/ directory to the new Apache Extras hosting. As many might know, I've been on a personal crusade to stop the Subversion project from being a source code hosting system.