Re: svn commit: r1054701 - in /subversion/trunk/subversion/bindings/javahl/native: CopySources.cpp CreateJ.cpp EnumMapper.cpp ListCallback.cpp Revision.cpp RevisionRange.cpp StatusCallback.cpp org_apa

2011-01-10 Thread Johan Corveleyn
On Mon, Jan 10, 2011 at 11:59 PM, Hyrum Wright wrote: > On Mon, Jan 10, 2011 at 4:07 PM, Johan Corveleyn wrote: >> On Mon, Jan 3, 2011 at 7:34 PM,   wrote: >>> Author: hwright >>> Date: Mon Jan  3 18:34:35 2011 >>> New Revision: 1054701 >>> >>> URL: http://svn.apache.org/viewvc?rev=1054701&view=r

Re: svn commit: r1054701 - in /subversion/trunk/subversion/bindings/javahl/native: CopySources.cpp CreateJ.cpp EnumMapper.cpp ListCallback.cpp Revision.cpp RevisionRange.cpp StatusCallback.cpp org_apa

2011-01-10 Thread Hyrum Wright
On Mon, Jan 10, 2011 at 4:07 PM, Johan Corveleyn wrote: > On Mon, Jan 3, 2011 at 7:34 PM,   wrote: >> Author: hwright >> Date: Mon Jan  3 18:34:35 2011 >> New Revision: 1054701 >> >> URL: http://svn.apache.org/viewvc?rev=1054701&view=rev >> Log: >> Fix JavaHL build and test failures introduced in

Re: svn commit: r1054701 - in /subversion/trunk/subversion/bindings/javahl/native: CopySources.cpp CreateJ.cpp EnumMapper.cpp ListCallback.cpp Revision.cpp RevisionRange.cpp StatusCallback.cpp org_apa

2011-01-10 Thread Johan Corveleyn
On Mon, Jan 3, 2011 at 7:34 PM, wrote: > Author: hwright > Date: Mon Jan  3 18:34:35 2011 > New Revision: 1054701 > > URL: http://svn.apache.org/viewvc?rev=1054701&view=rev > Log: > Fix JavaHL build and test failures introduced in r1054680. > > * subversion/bindings/javahl/native/CreateJ.cpp, >  

Re: [PATCH] allow svnsync to translate non-UTF-8 log messages to UTF-8 (v. 3)

2011-01-10 Thread Daniel Shahaf
Danny Trebbien wrote on Mon, Jan 10, 2011 at 08:55:35 -0800: > >> Perhaps, though, I should use svn_subst_translate_string2() with the > >> encoding set to "UTF-8". It would greatly simplify normalize_string(), > > > > +1.  Just call it with encoding=NULL; using the same API in both > > branches ma

Re: [PATCH] allow svnsync to translate non-UTF-8 log messages to UTF-8 (v. 3)

2011-01-10 Thread Danny Trebbien
>> Perhaps, though, I should use svn_subst_translate_string2() with the >> encoding set to "UTF-8". It would greatly simplify normalize_string(), > > +1.  Just call it with encoding=NULL; using the same API in both > branches makes life easier for the next person to revv that API. One thing that w

Re: svn commit: r1004286 - in /subversion/trunk: ./ subversion/libsvn_subr/io.c

2011-01-10 Thread Ramkumar Ramachandra
Hi Julian and Daniel, Julian Foad writes: > Just a few comments on the implementation from me... Thanks for the wonderful review! I've also included a few of Daniel's suggestions (on IRC)- I hope I've got it right this time. I'm not sure the volatile qualifier is necessary either- I'm just using

Re: svn commit: r1004286 - in /subversion/trunk: ./ subversion/libsvn_subr/io.c

2011-01-10 Thread Julian Foad
Just a few comments on the implementation from me... Daniel Shahaf wrote: > I looked at this patch, I'm not happy with it, but my issues are so > specific (eg: variable's initialization has problem) that > I feel I'd be *dictating* a rewrite of the patch if I reviewed it. > > And that is bad f