Re: [PATCH] Add --dry-run flag to "svn update" client command

2011-03-15 Thread Arwin Arni
On Tuesday 15 March 2011 08:34 PM, Julian Foad wrote: On Wed, 2011-03-02, Arwin Arni wrote: In my effort to understand the delta editor API, I took it upon myself to try and implement the --dry-run flag for "svn update". http://subversion.tigris.org/issues/show_bug.cgi?id=2491 Hi Arwin. Ka

[Noorul Islam K M] Re: [PATCH] Fix for issue 3826

2011-03-15 Thread Noorul Islam K M
I wonder, why this patch was not considered for fixing issue 3826. I could see a fix 1081799 which I see very similar to what I have done. Did I miss anything here? Thanks and Regards Noorul --- Begin Message --- Julian Foad writes: > On Thu, 2011-03-03 at 22:48 +0530, Noorul Islam K M wrote:

Re: wc_db performance (was: wc_db API discussion)

2011-03-15 Thread Paul Burba
On Mon, Mar 14, 2011 at 2:36 PM, Hyrum K Wright wrote: > On Sat, Mar 12, 2011 at 6:47 AM, Stefan Sperling wrote: >> On Fri, Mar 11, 2011 at 10:43:46PM -0500, Greg Stein wrote: >>> 2011/3/11 Branko Čibej : >>> >... >>> > For the second task, I think the first order of business is to change >>> > t

Re: Subversion trunk (r1078338) HTTP(/WC?) performance problems?

2011-03-15 Thread Ivan Zhakov
On Tue, Mar 15, 2011 at 22:38, John Beranek wrote: > On 14/03/2011 19:52, Ivan Zhakov wrote: >> On Mon, Mar 14, 2011 at 22:47, John Beranek wrote: >>> On 14/03/2011 19:45, Ivan Zhakov wrote: On Mon, Mar 14, 2011 at 20:46, John Beranek wrote: > On 14/03/11 17:14, Philip Martin wrote: >>>

Re: wc_db performance

2011-03-15 Thread Philip Martin
Greg Stein writes: > Why can't we simply put restrictions on those callbacks? I'm unclear > on this part. We seem to be unsure if such a restriction is a good idea. Suppose a client calls proplist, what can it do when it sees a property of interest? Can it delete the property? Modify the valu

Re: wc_db performance

2011-03-15 Thread Philip Martin
Branko Čibej writes: > On 15.03.2011 15:34, Philip Martin wrote: >> So with the temporary table approach the callback really has to use a >> separate database connection to read/write the database from within the >> callback. >> >> However I think that is also the case if we were to avoid the tab

Re: wc_db performance

2011-03-15 Thread Greg Stein
On Tue, Mar 15, 2011 at 10:34, Philip Martin wrote: >... > So with the temporary table approach the callback really has to use a > separate database connection to read/write the database from within the > callback. > > However I think that is also the case if we were to avoid the table and > simpl

Re: Subversion trunk (r1078338) HTTP(/WC?) performance problems?

2011-03-15 Thread John Beranek
On 14/03/2011 19:52, Ivan Zhakov wrote: > On Mon, Mar 14, 2011 at 22:47, John Beranek wrote: >> On 14/03/2011 19:45, Ivan Zhakov wrote: >>> On Mon, Mar 14, 2011 at 20:46, John Beranek wrote: On 14/03/11 17:14, Philip Martin wrote: > Ivan Zhakov writes: > >> I investigated your p

Re: svn commit: r1081892 - in /subversion/trunk/subversion: include/private/svn_io_private.h libsvn_subr/io.c libsvn_wc/adm_ops.c libsvn_wc/questions.c libsvn_wc/wc.h tests/cmdline/revert_tests.py

2011-03-15 Thread Philip Martin
phi...@apache.org writes: > Author: philip > Date: Tue Mar 15 18:33:52 2011 > New Revision: 1081892 > > URL: http://svn.apache.org/viewvc?rev=1081892&view=rev > Log: > Make revert change file permissions on the basis of the current magic > properties and the current permissions, rather than on any

Re: wc_db performance

2011-03-15 Thread Branko Čibej
On 15.03.2011 15:34, Philip Martin wrote: > Philip Martin writes: > >> Branko Čibej writes: >> >>> The temporary table is: >>> >>> * in a different database, so the read lock on it does not affect >>> the main wc-db; >>> * per-connection, so even the same process using a different >

Re: [PATCH] Add --dry-run flag to "svn update" client command

2011-03-15 Thread Julian Foad
On Wed, 2011-03-02, Arwin Arni wrote: > In my effort to understand the delta editor API, I took it upon myself > to try and implement the --dry-run flag for "svn update". > http://subversion.tigris.org/issues/show_bug.cgi?id=2491 Hi Arwin. Kamesh asked for technical feedback about this patch s

Re: svn commit: r1079400 - /subversion/trunk/subversion/tests/cmdline/log_tests.py

2011-03-15 Thread Paul Burba
On Tue, Mar 15, 2011 at 9:56 AM, Daniel Shahaf wrote: > Paul Burba wrote on Tue, Mar 15, 2011 at 09:38:31 -0400: >> On Tue, Mar 15, 2011 at 12:24 AM, Daniel Shahaf >> wrote: >> > pbu...@apache.org wrote on Tue, Mar 08, 2011 at 15:46:10 -: >> >> +++ subversion/trunk/subversion/tests/cmdline/l

Re: wc_db performance

2011-03-15 Thread Philip Martin
Philip Martin writes: > Branko Čibej writes: > >> The temporary table is: >> >> * in a different database, so the read lock on it does not affect >> the main wc-db; >> * per-connection, so even the same process using a different >> database connection will not even see that t

Re: wc_db performance

2011-03-15 Thread Philip Martin
Branko Čibej writes: > The temporary table is: > > * in a different database, so the read lock on it does not affect > the main wc-db; > * per-connection, so even the same process using a different > database connection will not even see that temporary table. OK, so the proce

Re: wc_db performance

2011-03-15 Thread Stefan Sperling
On Tue, Mar 15, 2011 at 12:52:42PM +, Philip Martin wrote: > Yes, by the time we invoke the callbacks we have a read-lock. If we > simply ran a single transaction and made callbacks within the > transaction then it would have the same effect. I don't see what the > temporary table achieves.

RE: Race condition in libsvn_client code?

2011-03-15 Thread Bert Huijben
> -Original Message- > From: Philip Martin [mailto:philip.mar...@wandisco.com] > Sent: dinsdag 15 maart 2011 14:52 > To: C. Michael Pilato > Cc: Subversion Development > Subject: Re: Race condition in libsvn_client code? > > "C. Michael Pilato" writes: > > > [Tweaking Subject: for (hop

Re: svn commit: r1073366 - in /subversion/trunk: notes/wc-ng/pristine-store subversion/libsvn_wc/wc-queries.sql subversion/libsvn_wc/wc_db_pristine.c

2011-03-15 Thread Ivan Zhakov
On Tue, Mar 15, 2011 at 16:49, Julian Foad wrote: > Ivan Zhakov wrote: >> On Tue, Mar 1, 2011 at 21:13, Julian Foad wrote: >> > Bert Huijben wrote: >> >> > -Original Message- >> >> > From: Julian Foad [mailto:julian.f...@wandisco.com] >> >> > >> >> > I'm not clear exactly what problem we

Re: svn commit: r1079400 - /subversion/trunk/subversion/tests/cmdline/log_tests.py

2011-03-15 Thread Daniel Shahaf
Paul Burba wrote on Tue, Mar 15, 2011 at 09:38:31 -0400: > On Tue, Mar 15, 2011 at 12:24 AM, Daniel Shahaf > wrote: > > pbu...@apache.org wrote on Tue, Mar 08, 2011 at 15:46:10 -: > >> +++ subversion/trunk/subversion/tests/cmdline/log_tests.py Tue Mar  8 > >> 15:46:09 2011 > >> @@ -1148,9 +1

RE: svn commit: r1079508 - in /subversion/trunk/subversion: include/svn_client.h include/svn_wc.h libsvn_client/commit_util.c libsvn_client/deprecated.c svn/notify.c

2011-03-15 Thread Bert Huijben
> -Original Message- > From: Daniel Shahaf [mailto:d...@daniel.shahaf.name] > Sent: dinsdag 15 maart 2011 5:34 > To: dev@subversion.apache.org > Subject: Re: svn commit: r1079508 - in /subversion/trunk/subversion: > include/svn_client.h include/svn_wc.h libsvn_client/commit_util.c > libsv

Re: Race condition in libsvn_client code?

2011-03-15 Thread Philip Martin
"C. Michael Pilato" writes: > [Tweaking Subject: for (hopefully) additional visibility.] > > On 03/15/2011 09:15 AM, Daniel Shahaf wrote: >> C. Michael Pilato wrote on Tue, Mar 15, 2011 at 09:05:56 -0400: >>> On 03/15/2011 12:34 AM, Daniel Shahaf wrote: cmpil...@apache.org wrote on Tue, Mar

Re: wc_db performance

2011-03-15 Thread Branko Čibej
On 15.03.2011 11:26, Philip Martin wrote: > Branko Čibej writes: > >> The restriction that you may not invoke a callback from within a sqlite >> transaction remains. That's what the temporary results tables are for -- >> they live outside transactions on the main wc-db. > I don't understand the te

Re: svn commit: r1073366 - in /subversion/trunk: notes/wc-ng/pristine-store subversion/libsvn_wc/wc-queries.sql subversion/libsvn_wc/wc_db_pristine.c

2011-03-15 Thread Julian Foad
Ivan Zhakov wrote: > On Tue, Mar 1, 2011 at 21:13, Julian Foad wrote: > > Bert Huijben wrote: > >> > -Original Message- > >> > From: Julian Foad [mailto:julian.f...@wandisco.com] > >> > > >> > I'm not clear exactly what problem we would avoid by eliminating the > >> > "select a unique name

Re: svn commit: r1079400 - /subversion/trunk/subversion/tests/cmdline/log_tests.py

2011-03-15 Thread Paul Burba
On Tue, Mar 15, 2011 at 12:24 AM, Daniel Shahaf wrote: > pbu...@apache.org wrote on Tue, Mar 08, 2011 at 15:46:10 -: >> Author: pburba >> Date: Tue Mar  8 15:46:09 2011 >> New Revision: 1079400 >> >> URL: http://svn.apache.org/viewvc?rev=1079400&view=rev >> Log: >> Follow-up to rr1076726, fix

Race condition in libsvn_client code? (Was: svn commit: r1079508 ...)

2011-03-15 Thread C. Michael Pilato
[Tweaking Subject: for (hopefully) additional visibility.] On 03/15/2011 09:15 AM, Daniel Shahaf wrote: > C. Michael Pilato wrote on Tue, Mar 15, 2011 at 09:05:56 -0400: >> On 03/15/2011 12:34 AM, Daniel Shahaf wrote: >>> cmpil...@apache.org wrote on Tue, Mar 08, 2011 at 20:05:51 -: Autho

Re: svn commit: r1079508 - in /subversion/trunk/subversion: include/svn_client.h include/svn_wc.h libsvn_client/commit_util.c libsvn_client/deprecated.c svn/notify.c

2011-03-15 Thread Daniel Shahaf
C. Michael Pilato wrote on Tue, Mar 15, 2011 at 09:05:56 -0400: > On 03/15/2011 12:34 AM, Daniel Shahaf wrote: > > cmpil...@apache.org wrote on Tue, Mar 08, 2011 at 20:05:51 -: > >> Author: cmpilato > >> Date: Tue Mar 8 20:05:50 2011 > >> New Revision: 1079508 > > [...] > > >> svn_client_co

Re: svn commit: r1079508 - in /subversion/trunk/subversion: include/svn_client.h include/svn_wc.h libsvn_client/commit_util.c libsvn_client/deprecated.c svn/notify.c

2011-03-15 Thread C. Michael Pilato
On 03/15/2011 12:34 AM, Daniel Shahaf wrote: > cmpil...@apache.org wrote on Tue, Mar 08, 2011 at 20:05:51 -: >> Author: cmpilato >> Date: Tue Mar 8 20:05:50 2011 >> New Revision: 1079508 [...] >> svn_client_commit4(svn_commit_info_t **commit_info_p, >> const apr_array_he

Re: svn commit: r1079592 - /subversion/trunk/subversion/svn/main.c

2011-03-15 Thread C. Michael Pilato
On 03/15/2011 12:43 AM, Daniel Shahaf wrote: > s...@apache.org wrote on Tue, Mar 08, 2011 at 22:51:52 -: >> Author: stsp >> Date: Tue Mar 8 22:51:51 2011 >> New Revision: 1079592 >> >> URL: http://svn.apache.org/viewvc?rev=1079592&view=rev >> Log: >> * subversion/svn/main.c >> (svn_cl__cmd_t

Re: wc_db performance

2011-03-15 Thread Philip Martin
Stefan Sperling writes: > On Tue, Mar 15, 2011 at 10:26:15AM +, Philip Martin wrote: >> Branko Čibej writes: >> >> > The restriction that you may not invoke a callback from within a sqlite >> > transaction remains. That's what the temporary results tables are for -- >> > they live outside t

Re: svn commit: r1073366 - in /subversion/trunk: notes/wc-ng/pristine-store subversion/libsvn_wc/wc-queries.sql subversion/libsvn_wc/wc_db_pristine.c

2011-03-15 Thread Ivan Zhakov
On Tue, Mar 1, 2011 at 21:13, Julian Foad wrote: > Bert Huijben wrote: >> > -Original Message- >> > From: Julian Foad [mailto:julian.f...@wandisco.com] >> > >> > I'm not clear exactly what problem we would avoid by eliminating the >> > "select a unique name" step of this process.  Is it wh

Re: wc_db performance

2011-03-15 Thread Stefan Sperling
On Tue, Mar 15, 2011 at 10:26:15AM +, Philip Martin wrote: > Branko Čibej writes: > > > The restriction that you may not invoke a callback from within a sqlite > > transaction remains. That's what the temporary results tables are for -- > > they live outside transactions on the main wc-db. >

Re: Another svnadmin checksum mismatch

2011-03-15 Thread Daniel Shahaf
Ignore this thread; as Philip says it works fine with SVN_DBG_OUTPUT=stderr. Thanks. Philip Martin wrote on Tue, Mar 15, 2011 at 09:35:02 +: > Daniel Shahaf writes: > > > % $svnversion `.svn` > > 1081669M > > % $svn di `.svn` > > Index: subversion/libsvn_fs_fs/fs_fs.c > > ==

Re: wc_db performance

2011-03-15 Thread Philip Martin
Branko Čibej writes: > The restriction that you may not invoke a callback from within a sqlite > transaction remains. That's what the temporary results tables are for -- > they live outside transactions on the main wc-db. I don't understand the temporary table approach. Taking the temp__node_pr

Re: wc_db API discussion

2011-03-15 Thread Philip Martin
Philip Martin writes: > Update with no changes on NFS disk: > > 1.6: 2s > 1.7: 50s With the recent bump-post-update changes that 50s has become 23s. -- Philip

Re: svn commit: r1081390 - /subversion/trunk/subversion/tests/cmdline/merge_tests.py

2011-03-15 Thread Kamesh Jayachandran
On 03/14/2011 08:18 PM, Stefan Sperling wrote: On Mon, Mar 14, 2011 at 02:24:58PM -, kame...@apache.org wrote: Author: kameshj Date: Mon Mar 14 14:24:58 2011 New Revision: 1081390 URL: http://svn.apache.org/viewvc?rev=1081390&view=rev Log: Adds an XFail test to catch regression created by r

Re: Another svnadmin checksum mismatch

2011-03-15 Thread Philip Martin
Daniel Shahaf writes: > % $svnversion `.svn` > 1081669M > % $svn di `.svn` > Index: subversion/libsvn_fs_fs/fs_fs.c > === > --- subversion/libsvn_fs_fs/fs_fs.c (revision 1081669) > +++ subversion/libsvn_fs_fs/fs_fs.c (working cop