Layering violations in the FS cache code? (was "svn commit: r1091573 - /subversion/trunk/build.conf")

2011-04-12 Thread C. Michael Pilato
On 04/12/2011 05:11 PM, arfre...@apache.org wrote: > Author: arfrever > Date: Tue Apr 12 21:11:46 2011 > New Revision: 1091573 > > URL: http://svn.apache.org/viewvc?rev=1091573&view=rev > Log: > Followup to r1090784: > > * build.conf > (libsvn_ra.libs): Add libsvn_fs_util. Whoa. This doesn't

Re: svn commit: r1091262 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

2011-04-12 Thread Hyrum K Wright
On Tue, Apr 12, 2011 at 11:26 AM, Greg Stein wrote: >... >> >> > The whole idea behind static statements was to avoid SQL injection >> >> > attacks. >> >> > Allowing the *code* to construct statements opens us up. >> >> > >> >> > This is Not Good. >> >> >> >> This is still a prepared statement, ar

Re: Case-only renames on Windows (issue #3702)

2011-04-12 Thread Johan Corveleyn
On Fri, Mar 25, 2011 at 2:21 PM, Johan Corveleyn wrote: > On Sun, Mar 20, 2011 at 9:32 PM, Johan Corveleyn wrote: >> Some thoughts: >> >> - There is only a problem if the dst_path gets case-normalized to one >> of the source paths. Otherwise, the case-normalization really does >> need to happen.

Re: svn commit: r1091495 - in /subversion/trunk/subversion/libsvn_wc: wc.h workqueue.c

2011-04-12 Thread Greg Stein
On Tue, Apr 12, 2011 at 13:34, C. Michael Pilato wrote: > On 04/12/2011 01:08 PM, Philip Martin wrote: >> Greg Stein writes: >> + * If the text is unmodified and a write-lock is held this function + * will repair "broken" timestamps and filesizes. >>> >>> I don't understand what is repa

Re: svn commit: r1091495 - in /subversion/trunk/subversion/libsvn_wc: wc.h workqueue.c

2011-04-12 Thread C. Michael Pilato
On 04/12/2011 01:08 PM, Philip Martin wrote: > Greg Stein writes: > >>> + * If the text is unmodified and a write-lock is held this function >>> + * will repair "broken" timestamps and filesizes. >> >> I don't understand what is repaired. The database, or the file. If the file, >> then how do we

Re: svn commit: r1091495 - in /subversion/trunk/subversion/libsvn_wc: wc.h workqueue.c

2011-04-12 Thread Philip Martin
Greg Stein writes: >> + * If the text is unmodified and a write-lock is held this function >> + * will repair "broken" timestamps and filesizes. > > I don't understand what is repaired. The database, or the file. If the file, > then how do we repair its filesize? > > This notion of "repair" is eq

Re: svn commit: r1091474 - in /subversion/trunk/subversion: include/private/svn_wc_private.h libsvn_client/commit_util.c libsvn_wc/node.c

2011-04-12 Thread Philip Martin
rhuij...@apache.org writes: > Author: rhuijben > Date: Tue Apr 12 15:36:19 2011 > New Revision: 1091474 > > URL: http://svn.apache.org/viewvc?rev=1091474&view=rev > Log: > Another small step in cleaning up the commit harvester: Directly obtain > lock tokens for nodes, instead of using a separate d

Re: svn commit: r1091495 - in /subversion/trunk/subversion/libsvn_wc: wc.h workqueue.c

2011-04-12 Thread Greg Stein
On Apr 12, 2011 12:43 PM, wrote: > > Author: philip > Date: Tue Apr 12 16:43:23 2011 > New Revision: 1091495 > > URL: http://svn.apache.org/viewvc?rev=1091495&view=rev > Log: > Document timestamp repair function and use it during post-commit. > > * subversion/libsvn_wc/wc.h > (svn_wc__internal_fi

Re: 1.7 Roadmap Items Evaluation

2011-04-12 Thread Julian Foad
On Mon, 2011-04-11 at 11:08 -0400, C. Michael Pilato wrote: > On 04/07/2011 08:49 PM, Daniel Shahaf wrote: > > C. Michael Pilato wrote on Thu, Apr 07, 2011 at 11:19:48 -0400: > >> "Remove temp APIs": I would put this at "nice to have". These APIs are > >> private, so what's the penalty if they wi

Re: svn commit: r1091262 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

2011-04-12 Thread Greg Stein
On Apr 12, 2011 9:27 AM, "Hyrum K Wright" wrote: > > On Tue, Apr 12, 2011 at 2:12 AM, Greg Stein wrote: > > > > On Apr 11, 2011 10:58 PM, "Hyrum K Wright" wrote: > >> > >> On Mon, Apr 11, 2011 at 9:41 PM, Greg Stein wrote: > >> > Woah. When did svn_sqlite__prepare arrive? > >> > >> $ svnd blame

Re: svn commit: r1091262 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

2011-04-12 Thread Greg Stein
When it comes down to it, a single voice *can* veto a technical choice. We strive very hard to avoid that because of the many anti-social a specs, but the point still holds true. I have not seen anything yet that makes me go "oh, that should work great". Instead, I see a direction in our code that

Re: svn commit: r1091187 - in /subversion/trunk/subversion: include/svn_wc.h libsvn_client/switch.c libsvn_client/update.c libsvn_wc/deprecated.c libsvn_wc/update_editor.c

2011-04-12 Thread Julian Foad
Hi Bert. A question about the "server handles [depth] filtering" flag... On Mon, 2011-04-11, rhuij...@apache.org wrote: > Author: rhuijben > Date: Mon Apr 11 19:58:27 2011 > New Revision: 1091187 > > URL: http://svn.apache.org/viewvc?rev=1091187&view=rev > Log: > Update the svn_wc_get_update_edi

Re: svn commit: r1091470 - in /subversion/trunk/subversion: libsvn_wc/questions.c tests/cmdline/stat_tests.py

2011-04-12 Thread C. Michael Pilato
On 04/12/2011 11:34 AM, phi...@apache.org wrote: > Author: philip > Date: Tue Apr 12 15:34:31 2011 > New Revision: 1091470 > > URL: http://svn.apache.org/viewvc?rev=1091470&view=rev > Log: > Start making timestamp repair work in WCNG; revert now works but > not cleanup. Issue 3773. Excellent! A

Re: svn commit: r1091262 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

2011-04-12 Thread Johan Corveleyn
On Tue, Apr 12, 2011 at 3:40 PM, Bert Huijben wrote: > > >> -Original Message- >> From: Johan Corveleyn [mailto:jcor...@gmail.com] >> Sent: dinsdag 12 april 2011 15:27 >> To: Hyrum Wright >> Cc: C. Michael Pilato; Bert Huijben; Greg Stein; dev@subversion.apache.org >> Subject: Re: svn comm

Re: svn commit: r1089856 - /subversion/trunk/subversion/tests/cmdline/switch_tests.py

2011-04-12 Thread Philip Martin
"Bert Huijben" writes: > Ok, if I read this right you are assuming that that the switched path > doesn't have local modifications. No. Here's an example: svnadmin create repo svn mkdir -mm --parents file://`pwd`/repo/A/B/C svn cp -mm file://`pwd`/repo/A file://`pwd`/repo/X svn co file://`pwd`/

RE: svn commit: r1091262 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

2011-04-12 Thread Bert Huijben
> -Original Message- > From: Johan Corveleyn [mailto:jcor...@gmail.com] > Sent: dinsdag 12 april 2011 15:27 > To: Hyrum Wright > Cc: C. Michael Pilato; Bert Huijben; Greg Stein; dev@subversion.apache.org > Subject: Re: svn commit: r1091262 - > /subversion/trunk/subversion/libsvn_wc/wc_db.

Re: svn commit: r1091262 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

2011-04-12 Thread C. Michael Pilato
On 04/12/2011 09:14 AM, Hyrum Wright wrote: > I'll revert this work sometime today. Just in case it wasn't clear: I'm not suggesting that you unconditionally revert. Others in the thread are able to evaluate the technical merits of the approach you took in ways that currently I cannot. I'm real

Re: svn commit: r1091262 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

2011-04-12 Thread Mark Phippard
On Tue, Apr 12, 2011 at 9:27 AM, Hyrum K Wright wrote: >> Not sure. Maybe we can work through some ideas. But "we have no other >> choice" is not a good enough reason to keep this. That is an even worse >> slope to slide down. Doing things simply because they are "convenient". > > The general con

Re: svn commit: r1089856 - /subversion/trunk/subversion/tests/cmdline/switch_tests.py

2011-04-12 Thread C. Michael Pilato
On 04/12/2011 06:32 AM, Philip Martin wrote: > "Bert Huijben" writes: > >> I like to think of it this way (and the current WC-NG tree model agrees): >> >> A wc-wc copy is created from what is currently in your working copy and >> copies are not affected by BASE operations; just like a non svn cop

Re: svn commit: r1091262 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

2011-04-12 Thread Hyrum K Wright
On Tue, Apr 12, 2011 at 2:12 AM, Greg Stein wrote: > > On Apr 11, 2011 10:58 PM, "Hyrum K Wright" wrote: >> >> On Mon, Apr 11, 2011 at 9:41 PM, Greg Stein wrote: >> > Woah. When did svn_sqlite__prepare arrive? >> >> $ svnd blame subversion/libsvn_subr/sqlite.c | grep svn_sqlite__prepare >> 87545

Re: svn commit: r1091262 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

2011-04-12 Thread Johan Corveleyn
On Tue, Apr 12, 2011 at 3:14 PM, Hyrum Wright wrote: > On Tue, Apr 12, 2011 at 8:00 AM, C. Michael Pilato > wrote: >>> You are looking at changelists as a way to learn how to move operations into >>> wc_db properly, but just like that temp table for notifications I don't see >>> this as the way

Re: svn commit: r1091262 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

2011-04-12 Thread Hyrum Wright
On Tue, Apr 12, 2011 at 8:00 AM, C. Michael Pilato wrote: >> You are looking at changelists as a way to learn how to move operations into >> wc_db properly, but just like that temp table for notifications I don't see >> this as the way to go forward. >> >> I really don't see why users want to add

Re: svn commit: r1091262 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

2011-04-12 Thread C. Michael Pilato
> You are looking at changelists as a way to learn how to move operations into > wc_db properly, but just like that temp table for notifications I don't see > this as the way to go forward. > > I really don't see why users want to add thousands of nodes to changelists > while we still don't suppor

RE: svn commit: r1089856 - /subversion/trunk/subversion/tests/cmdline/switch_tests.py

2011-04-12 Thread Bert Huijben
> -Original Message- > From: Philip Martin [mailto:philip.mar...@wandisco.com] > Sent: dinsdag 12 april 2011 12:32 > To: Bert Huijben > Cc: 'C. Michael Pilato'; dev@subversion.apache.org > Subject: Re: svn commit: r1089856 - > /subversion/trunk/subversion/tests/cmdline/switch_tests.py >

Re: svn commit: r1089856 - /subversion/trunk/subversion/tests/cmdline/switch_tests.py

2011-04-12 Thread Philip Martin
"Bert Huijben" writes: > I like to think of it this way (and the current WC-NG tree model agrees): > > A wc-wc copy is created from what is currently in your working copy and > copies are not affected by BASE operations; just like a non svn copy would > do. > > So following this reasoning a copy

RE: svn commit: r1091262 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

2011-04-12 Thread Bert Huijben
> -Original Message- > From: Greg Stein [mailto:gst...@gmail.com] > Sent: dinsdag 12 april 2011 4:41 > To: dev@subversion.apache.org > Subject: Re: svn commit: r1091262 - > /subversion/trunk/subversion/libsvn_wc/wc_db.c > > Woah. When did svn_sqlite__prepare arrive? > > I'm basically -1

RE: SVN reports that all targets are not part of same working copy when there is an svn:external that points within the repository

2011-04-12 Thread Bert Huijben
> -Original Message- > From: Ryan J Ollos [mailto:ry...@physiosonics.com] > Sent: dinsdag 12 april 2011 0:36 > To: dev@subversion.apache.org > Subject: SVN reports that all targets are not part of same working copy when > there is an svn:external that points within the repository > > >

Re: [svnbench] Revision: 1090914 compiled Apr 11 2011, 00:21:21

2011-04-12 Thread Neels Hofmeyr
On Mon, 2011-04-11 at 08:10 -0500, Hyrum K Wright wrote: > matplotlib is fairly popular and flexible. You can find an example in > our repo in tools/dev/graph-dav-servers.py. There is also decent > online documentation. Wow, this looks like my new favourite way to plot! This is so great, I can h

Re: svn commit: r1091262 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

2011-04-12 Thread Greg Stein
On Apr 11, 2011 10:58 PM, "Hyrum K Wright" wrote: > > On Mon, Apr 11, 2011 at 9:41 PM, Greg Stein wrote: > > Woah. When did svn_sqlite__prepare arrive? > > $ svnd blame subversion/libsvn_subr/sqlite.c | grep svn_sqlite__prepare > 875453hwright > SVN_ERR(svn_sqlite__prepare(&db->prepared_stmts