In trunk (and in the 1.6 backport), the close_edit() function in the
subject does a simple 'return err' when svn_repos_fs_commit_txn() fails.
That err may be SVN_NO_ERROR.
Shouldn't close_edit() return a non-NULL error even if
svn_repos_fs_commit_txn() failed but returned SVN_NO_ERROR ?
False alarm. Sorry.
Found this while reviewing the 1.6.x-svn_fs_commit_txn backport, but
it's present in trunk as well:
When ERR does not contain SVN_ERR_REPOS_POST_COMMIT_HOOK_FAILED,
svn_repos__post_commit_error_str() sets hook_err2 to NULL (in the else{}
on line 629) and later dereferences it (to get the ->message
rhuij...@apache.org wrote on Thu, Apr 21, 2011 at 22:00:57 -:
> Modified: subversion/trunk/subversion/tests/libsvn_client/client-test.c
> URL:
> http://svn.apache.org/viewvc/subversion/trunk/subversion/tests/libsvn_client/client-test.c?rev=1095829&r1=1095828&r2=1095829&view=diff
>
Hyrum K Wright wrote:
> On Thu, Apr 21, 2011 at 1:33 PM, Hyrum K Wright wrote:
> > On Thu, Apr 21, 2011 at 10:00 AM, Julian Foad
> > wrote:
> >> This is a post-1.7 RFC.
> >>
> >> Most libsvn_client APIs allow the caller to throw either URLs or working
> >> copy paths at the API and then it just
On 04/21/2011 12:52 PM, Greg Stein wrote:
> haha... no, they don't mean anything that I'm aware of. Just an extra
> bit of style the logo designer put in there.
Yup. What he said.
--
C. Michael Pilato
CollabNet <> www.collab.net <> Distributed Development On Demand
On Thu, Apr 21, 2011 at 1:33 PM, Hyrum K Wright wrote:
> On Thu, Apr 21, 2011 at 10:00 AM, Julian Foad
> wrote:
>> This is a post-1.7 RFC.
>>
>> Most libsvn_client APIs allow the caller to throw either URLs or working
>> copy paths at the API and then it just does the right thing. But does
>> t
On Thu, Apr 21, 2011 at 20:33, Hyrum K Wright wrote:
> On Thu, Apr 21, 2011 at 10:00 AM, Julian Foad
> wrote:
>> This is a post-1.7 RFC.
>>
>> Most libsvn_client APIs allow the caller to throw either URLs or working
>> copy paths at the API and then it just does the right thing. But does
>> thi
> Add a simple property verifyer to the upgrade tests to test if the upgrade
> code correctly handles property upgrades. This makes issue #2530 visible on
> the current test data.
>
> * subversion/tests/cmdline/upgrade_tests.py
> (simple_property_verify): New helper function.
> (do_x3_upgrade): V
On Wed, 2011-04-20 at 21:24 +0200, Bert Huijben wrote:
>
> > -Original Message-
> > From: C. Michael Pilato [mailto:cmpil...@collab.net]
> > Sent: woensdag 20 april 2011 19:45
> > To: dev@subversion.apache.org
> > Subject: Re: svn commit: r1095130 - in /subversion/trunk/subversion:
> > lib
On Thu, Apr 21, 2011 at 10:00 AM, Julian Foad wrote:
> This is a post-1.7 RFC.
>
> Most libsvn_client APIs allow the caller to throw either URLs or working
> copy paths at the API and then it just does the right thing. But does
> this paradigm make sense for APIs such as this one?
Julian,
Does t
On Thu, Apr 21, 2011 at 10:00 AM, Julian Foad wrote:
> This is a post-1.7 RFC.
I'm happy to make this a 1.7 RFC, since we're already rev'd the client
API, and the question is coming up now. The effort shouldn't be that
involved.[1]
-Hyrum
[1] Yes, I'm volunteering, and yes those are famous las
On Thu, Apr 21, 2011 at 11:00, Julian Foad wrote:
> This is a post-1.7 RFC.
If you have time and can do it for 1.7, then I don't think we can stop you :-P
>...
> Thoughts?
Yeah. Split them!
Cheers,
-g
On 21.04.2011 17:00, Julian Foad wrote:
This is a post-1.7 RFC.
Most libsvn_client APIs allow the caller to throw either URLs or working
copy paths at the API and then it just does the right thing. But does
this paradigm make sense for APIs such as this one?
svn_client_propset4() operates on e
rhuij...@apache.org wrote on Fri, Apr 08, 2011 at 15:06:45 -:
> Author: rhuijben
> Date: Fri Apr 8 15:06:44 2011
> New Revision: 1090288
>
> URL: http://svn.apache.org/viewvc?rev=1090288&view=rev
> Log:
> Fix a test for wc-ng, by removing the assumption that you can chdir to any
> directory i
rhuij...@apache.org wrote on Thu, Apr 21, 2011 at 15:47:25 -:
> +int
> +main(int argc, const char *argv[])
> +{
> + apr_pool_t *pool;
> + int exit_code = EXIT_SUCCESS;
> + svn_error_t *err;
> + svn_boolean_t recursive;
> +
> + if (argc < 2 || argc > 3)
> +{
> + fprintf(stderr, USA
On Thu, Apr 21, 2011 at 11:47, wrote:
>...
> +++ subversion/trunk/build.conf Thu Apr 21 15:47:25 2011
> @@ -1026,6 +1026,12 @@ install = test
> libs = libsvn_ra libsvn_subr apriconv apr
> testing = skip
>
> +[lock-wc-dir]
> +type = exe
> +path = subversion/tests/cmdline
> +sources = lock-wc-dir
haha... no, they don't mean anything that I'm aware of. Just an extra
bit of style the logo designer put in there.
And note the official logo is on a blue background. (a black
background would be a derivative work of a registered trademark...
probably not a good idea to do ;-) )
On Thu, Apr 21, 2
Going to true paths is expensive and a lot of work, so it does this
only when requested. (It has to do a check at every directory level).
In subversion 1.5 we had some accidental truepath checks which were
directly visible as bottleneck in the profiler.
Bert
Bert Huijben (Cell phone) From: Danie
rhuij...@apache.org wrote on Thu, Apr 21, 2011 at 15:47:25 -:
> +#define KEY_OLD_PROPVAL "old_value_p"
> +#define KEY_NEW_PROPVAL "value"
> +
Unused constant.
On Thu, 2011-04-21 at 17:30 +0200, Stefan Fuhrmann wrote:
> On 21.04.2011 16:37, Neels Hofmeyr wrote:
> > Hi all,
> >
> > finalizing the T-shirt design for our Subversion hackathon coming up in
> > May, I've just been working with the Subversion logo again (the slanted
> > S on black background).
>
Johan Corveleyn wrote on Thu, Apr 14, 2011 at 23:49:16 +0200:
> On Tue, Apr 12, 2011 at 11:14 PM, Johan Corveleyn wrote:
> > On Fri, Mar 25, 2011 at 2:21 PM, Johan Corveleyn wrote:
> >> On Sun, Mar 20, 2011 at 9:32 PM, Johan Corveleyn wrote:
> >>> Some thoughts:
> >>>
> >>> - There is only a pro
On 21.04.2011 16:37, Neels Hofmeyr wrote:
Hi all,
finalizing the T-shirt design for our Subversion hackathon coming up in
May, I've just been working with the Subversion logo again (the slanted
S on black background).
Any chance to get one of these?
It came to my notice that it actually has fo
This is a post-1.7 RFC.
Most libsvn_client APIs allow the caller to throw either URLs or working
copy paths at the API and then it just does the right thing. But does
this paradigm make sense for APIs such as this one?
svn_client_propset4() operates on either WC paths or URLs. Although its
purp
Hi all,
finalizing the T-shirt design for our Subversion hackathon coming up in
May, I've just been working with the Subversion logo again (the slanted
S on black background).
It came to my notice that it actually has four dots near the lower left
corner. Do they mean anything? A secret society's
Johan Corveleyn wrote on Mon, Apr 18, 2011 at 20:01:20 +0200:
> - In fact: the same problem holds true for other commands as well: how
> to revert both sides of this move? Ok, one can revert in two steps ...
>
> - Maybe a more general solution is needed, so all commands can
> adequately see which
Thanks, Committed this patch in r1095662.
With regards
Kamesh Jayachandran
On 04/18/2011 04:05 PM, Arwin Arni wrote:
Hi All,
This patch adds a test case to
subversion/tests/cmdline/dav-mirror-autocheck.sh to showcase the
following bug.
In a master/slave repositories setup where writes are p
Chad Nouis writes:
> I believe setting rbaton to NULL immediately after the call to
> libsvn_repos_1!svn_repos_finish_report would eliminate the invalid
> handle exception. I’m not sure if this is the most elegant solution.
> See the attached patch.
>
> [[[
> Fix invalid handle exception when tem
28 matches
Mail list logo
