Re: [PATCH] NODES.dav_cache in wc.db is always set to NULL in serf.

2011-05-03 Thread Greg Stein
Following up to try and direct a solution... On Wed, Apr 20, 2011 at 03:15, Arwin Arni wrote: > Hi, > > From what I've read in the responses, I understand that the dav_cache is not > a NON-NULL field... and that neon uses it and serf doesn't. > > I've also not gone deep enough into the code to un

Re: svn commit: r1099304 - /subversion/trunk/subversion/libsvn_client/ra.c

2011-05-03 Thread Greg Stein
On Tue, May 3, 2011 at 20:21, wrote: > Author: rhuijben > Date: Wed May  4 00:21:15 2011 > New Revision: 1099304 > > URL: http://svn.apache.org/viewvc?rev=1099304&view=rev > Log: > * subversion/libsvn_client/ra.c >  (push_wc_prop): Following up on r1096562, fix typo in pool name and >    rename p

Re: svn commit: r1099292 - /subversion/trunk/subversion/libsvn_client/delete.c

2011-05-03 Thread Greg Stein
On Tue, May 3, 2011 at 19:12, wrote: >... > +++ subversion/trunk/subversion/libsvn_client/delete.c Tue May  3 23:12:48 > 2011 >... > @@ -245,16 +233,19 @@ delete_urls(const apr_array_header_t *pa >   /* Call the path-based editor driver. */ >   err = svn_delta_path_driver(editor, edit_baton, SVN

Re: svn commit: r1098610 - /subversion/trunk/subversion/libsvn_delta/editor.c

2011-05-03 Thread Hyrum K Wright
On Tue, May 3, 2011 at 4:35 PM, Greg Stein wrote: > > On May 2, 2011 4:00 PM, "Hyrum K Wright" wrote: >> >> On Mon, May 2, 2011 at 2:52 PM, Greg Stein wrote: >> > On Mon, May 2, 2011 at 10:55,   wrote: >> >> Author: hwright >> >> Date: Mon May  2 14:55:34 2011 >> >> New Revision: 1098610 >> >> >

Re: [RFC] Case-only renames on Windows - how to proceed?

2011-05-03 Thread Greg Stein
I suggest (1). Fix issue 3865 with a new WC API to normalize targets, usable by higher levels. That API would follow the 3-step process described at the end of the issue description. Cheers, -g On May 3, 2011 5:41 PM, "Johan Corveleyn" wrote: > Hi all, > > After the discussions in [1] and [2], I'

Re: [PATCH] First step for issue #3702 (case-only renames on Windows) - now blocked by libsvn_client

2011-05-03 Thread Daniel Shahaf
Johan Corveleyn wrote on Tue, May 03, 2011 at 23:29:26 +0200: > On Tue, May 3, 2011 at 10:17 PM, Daniel Shahaf > wrote: > > Johan Corveleyn wrote on Tue, May 03, 2011 at 21:49:48 +0200: > >> On Mon, Apr 25, 2011 at 11:26 PM, Daniel Shahaf > >> wrote: > >> > Johan Corveleyn wrote on Mon, Apr 25,

Re: svn commit: r1099273 - in /subversion/trunk/subversion: libsvn_wc/ tests/libsvn_wc/

2011-05-03 Thread Greg Stein
On May 3, 2011 5:43 PM, wrote: > > Author: rhuijben > Date: Tue May 3 21:42:57 2011 > New Revision: 1099273 > > URL: http://svn.apache.org/viewvc?rev=1099273&view=rev > Log: > Remove two unused arguments from svn_wc__db_base_get_info(). The recorded size > and recorded modification time values on

[RFC] Case-only renames on Windows - how to proceed?

2011-05-03 Thread Johan Corveleyn
Hi all, After the discussions in [1] and [2], I'd like to know if and how to proceed with making case-only renames work on Windows (or case-insensitive filesystems in general). Following my attempted patch ([1]), I got some good feedback from brane and danielsh, but I'd like some more opinions, id

Re: [PATCH] First step for issue #3702 (case-only renames on Windows) - now blocked by libsvn_client

2011-05-03 Thread Johan Corveleyn
On Tue, May 3, 2011 at 10:17 PM, Daniel Shahaf wrote: > Johan Corveleyn wrote on Tue, May 03, 2011 at 21:49:48 +0200: >> On Mon, Apr 25, 2011 at 11:26 PM, Daniel Shahaf >> wrote: >> > Johan Corveleyn wrote on Mon, Apr 25, 2011 at 23:10:21 +0200: >> >> On Mon, Apr 25, 2011 at 5:03 PM, Daniel Shah

Re: svn commit: r1098610 - /subversion/trunk/subversion/libsvn_delta/editor.c

2011-05-03 Thread Greg Stein
On May 2, 2011 4:00 PM, "Hyrum K Wright" wrote: > > On Mon, May 2, 2011 at 2:52 PM, Greg Stein wrote: > > On Mon, May 2, 2011 at 10:55, wrote: > >> Author: hwright > >> Date: Mon May 2 14:55:34 2011 > >> New Revision: 1098610 > >> > >> URL: http://svn.apache.org/viewvc?rev=1098610&view=rev > >

Re: svn commit: r1095914 - in /subversion/trunk/subversion: include/svn_wc.h libsvn_client/merge.c libsvn_wc/deprecated.c libsvn_wc/props.c libsvn_wc/props.h libsvn_wc/update_editor.c

2011-05-03 Thread Greg Stein
How about after r1099145? On May 3, 2011 12:15 PM, "Philip Martin" wrote: > Philip Martin writes: > >> Greg Stein writes: >> >>> Update: this is caused by CONTENT_STATE in close_file() not getting a >>> proper value when fb->obstruction_found==1. It affects the >>> notification later in the func

Re: svn commit: r1099218 - /subversion/trunk/subversion/libsvn_wc/info.c

2011-05-03 Thread Hyrum K Wright
On Tue, May 3, 2011 at 3:25 PM, Greg Stein wrote: > On Tue, May 3, 2011 at 16:03,   wrote: >>... >> +++ subversion/trunk/subversion/libsvn_wc/info.c Tue May  3 20:03:13 2011 >> @@ -172,11 +172,12 @@ build_info_for_entry(svn_info2_t **info, >>   /* A default */ >>   tmpinfo->size = SVN_INVALID_FILE

Re: svn commit: r1099193 - in /subversion/trunk/subversion: libsvn_client/deprecated.c libsvn_wc/info.c tests/cmdline/info_tests.py

2011-05-03 Thread Hyrum K Wright
On Tue, May 3, 2011 at 3:23 PM, Greg Stein wrote: > On Tue, May 3, 2011 at 15:35, Hyrum K Wright wrote: >> On Tue, May 3, 2011 at 2:24 PM, Greg Stein wrote: >>> On Tue, May 3, 2011 at 15:04,   wrote: Author: hwright Date: Tue May  3 19:04:24 2011 New Revision: 1099193 UR

Re: svn commit: r1099218 - /subversion/trunk/subversion/libsvn_wc/info.c

2011-05-03 Thread Greg Stein
On Tue, May 3, 2011 at 16:03, wrote: >... > +++ subversion/trunk/subversion/libsvn_wc/info.c Tue May  3 20:03:13 2011 > @@ -172,11 +172,12 @@ build_info_for_entry(svn_info2_t **info, >   /* A default */ >   tmpinfo->size = SVN_INVALID_FILESIZE; > > -  SVN_ERR(svn_wc__node_get_schedule(&tmpinfo->w

Re: svn commit: r1099193 - in /subversion/trunk/subversion: libsvn_client/deprecated.c libsvn_wc/info.c tests/cmdline/info_tests.py

2011-05-03 Thread Greg Stein
On Tue, May 3, 2011 at 15:35, Hyrum K Wright wrote: > On Tue, May 3, 2011 at 2:24 PM, Greg Stein wrote: >> On Tue, May 3, 2011 at 15:04,   wrote: >>> Author: hwright >>> Date: Tue May  3 19:04:24 2011 >>> New Revision: 1099193 >>> >>> URL: http://svn.apache.org/viewvc?rev=1099193&view=rev >>> Log

Re: [PATCH] First step for issue #3702 (case-only renames on Windows) - now blocked by libsvn_client

2011-05-03 Thread Daniel Shahaf
Johan Corveleyn wrote on Tue, May 03, 2011 at 21:49:48 +0200: > On Mon, Apr 25, 2011 at 11:26 PM, Daniel Shahaf > wrote: > > Johan Corveleyn wrote on Mon, Apr 25, 2011 at 23:10:21 +0200: > >> On Mon, Apr 25, 2011 at 5:03 PM, Daniel Shahaf > >> wrote: > >> > Johan Corveleyn wrote on Mon, Apr 25,

Re: [PATCH] First step for issue #3702 (case-only renames on Windows) - now blocked by libsvn_client

2011-05-03 Thread Johan Corveleyn
On Mon, Apr 25, 2011 at 11:26 PM, Daniel Shahaf wrote: > Johan Corveleyn wrote on Mon, Apr 25, 2011 at 23:10:21 +0200: >> On Mon, Apr 25, 2011 at 5:03 PM, Daniel Shahaf >> wrote: >> > Johan Corveleyn wrote on Mon, Apr 25, 2011 at 01:08:24 +0200: >> >> 2011/4/22 Branko Čibej : >> >> > Meh. For no

Re: svn commit: r1099193 - in /subversion/trunk/subversion: libsvn_client/deprecated.c libsvn_wc/info.c tests/cmdline/info_tests.py

2011-05-03 Thread Hyrum K Wright
On Tue, May 3, 2011 at 2:24 PM, Greg Stein wrote: > On Tue, May 3, 2011 at 15:04,   wrote: >> Author: hwright >> Date: Tue May  3 19:04:24 2011 >> New Revision: 1099193 >> >> URL: http://svn.apache.org/viewvc?rev=1099193&view=rev >> Log: >> For info, don't fake a completely bogus revision for adde

Re: svn commit: r1099193 - in /subversion/trunk/subversion: libsvn_client/deprecated.c libsvn_wc/info.c tests/cmdline/info_tests.py

2011-05-03 Thread Greg Stein
On Tue, May 3, 2011 at 15:04, wrote: > Author: hwright > Date: Tue May  3 19:04:24 2011 > New Revision: 1099193 > > URL: http://svn.apache.org/viewvc?rev=1099193&view=rev > Log: > For info, don't fake a completely bogus revision for added nodes, just > report an invalid revision. > > In updating

Re: svn info doesn't report simple conflicts

2011-05-03 Thread Hyrum K Wright
On Tue, May 3, 2011 at 1:54 PM, Stefan Küng wrote: > On 03.05.2011 19:46, Hyrum K Wright wrote: >> >> On Tue, May 3, 2011 at 12:40 PM, Stefan Küng >>  wrote: >>> >>> On 03.05.2011 19:40, Hyrum K Wright wrote: On Tue, May 3, 2011 at 12:33 PM, Stefan Küng  wrote: > > Hi, >

Re: svn info doesn't report simple conflicts

2011-05-03 Thread Stefan Küng
On 03.05.2011 19:46, Hyrum K Wright wrote: On Tue, May 3, 2011 at 12:40 PM, Stefan Küng wrote: On 03.05.2011 19:40, Hyrum K Wright wrote: On Tue, May 3, 2011 at 12:33 PM, Stefan Küng wrote: Hi, Using a build from three days ago, I found that svn info conflicted_file doesn't report the si

Re: svn info --recursive isn't reporting tree-conflict-only nodes

2011-05-03 Thread Hyrum K Wright
On Tue, May 3, 2011 at 12:46 PM, Hyrum K Wright wrote: > On Tue, May 3, 2011 at 12:33 PM, Julian Foad wrote: >> On Tue, 2011-05-03 at 17:10 +0100, Julian Foad wrote: >>> On Tue, 2011-05-03 at 18:02 +0200, Bert Huijben wrote: >>> > >>> > > -Original Message- >>> > > From: Hyrum K Wright [m

Re: svn info doesn't report simple conflicts

2011-05-03 Thread Hyrum K Wright
On Tue, May 3, 2011 at 12:40 PM, Stefan Küng wrote: > On 03.05.2011 19:40, Hyrum K Wright wrote: >> >> On Tue, May 3, 2011 at 12:33 PM, Stefan Küng >>  wrote: >>> >>> Hi, >>> >>> Using a build from three days ago, I found that >>> svn info conflicted_file >>> doesn't report the simple conflict (no

Re: svn info --recursive isn't reporting tree-conflict-only nodes

2011-05-03 Thread Hyrum K Wright
On Tue, May 3, 2011 at 12:33 PM, Julian Foad wrote: > On Tue, 2011-05-03 at 17:10 +0100, Julian Foad wrote: >> On Tue, 2011-05-03 at 18:02 +0200, Bert Huijben wrote: >> > >> > > -Original Message- >> > > From: Hyrum K Wright [mailto:hy...@hyrumwright.org] >> > > Sent: dinsdag 3 mei 2011 17

Re: svn info doesn't report simple conflicts

2011-05-03 Thread Stefan Küng
On 03.05.2011 19:40, Hyrum K Wright wrote: On Tue, May 3, 2011 at 12:33 PM, Stefan Küng wrote: Hi, Using a build from three days ago, I found that svn info conflicted_file doesn't report the simple conflict (not a tree conflict but a text conflict). The doc string for 'conflicts' in the svn_w

Re: svn info doesn't report simple conflicts

2011-05-03 Thread Hyrum K Wright
On Tue, May 3, 2011 at 12:33 PM, Stefan Küng wrote: > Hi, > > Using a build from three days ago, I found that > svn info conflicted_file > doesn't report the simple conflict (not a tree conflict but a text > conflict). > > The doc string for 'conflicts' in the svn_wc_info_t struct reads: > Array o

svn info doesn't report simple conflicts

2011-05-03 Thread Stefan Küng
Hi, Using a build from three days ago, I found that svn info conflicted_file doesn't report the simple conflict (not a tree conflict but a text conflict). The doc string for 'conflicts' in the svn_wc_info_t struct reads: Array of const svn_wc_conflict_description2_t * which contains info on an

RE: svn info --recursive isn't reporting tree-conflict-only nodes

2011-05-03 Thread Julian Foad
On Tue, 2011-05-03 at 17:10 +0100, Julian Foad wrote: > On Tue, 2011-05-03 at 18:02 +0200, Bert Huijben wrote: > > > > > -Original Message- > > > From: Hyrum K Wright [mailto:hy...@hyrumwright.org] > > > Sent: dinsdag 3 mei 2011 17:49 > > > To: Julian Foad > > > Cc: Philip Martin; dev@subv

Re: svn commit: r1095914 - in /subversion/trunk/subversion: include/svn_wc.h libsvn_client/merge.c libsvn_wc/deprecated.c libsvn_wc/props.c libsvn_wc/props.h libsvn_wc/update_editor.c

2011-05-03 Thread Philip Martin
Philip Martin writes: > Greg Stein writes: > >> Update: this is caused by CONTENT_STATE in close_file() not getting a >> proper value when fb->obstruction_found==1. It affects the >> notification later in the function. >> >> I'll tease out the logic tomorrow... > > I get a valgrind errors: Bert

RE: svn info --recursive isn't reporting tree-conflict-only nodes

2011-05-03 Thread Julian Foad
On Tue, 2011-05-03 at 18:02 +0200, Bert Huijben wrote: > > > -Original Message- > > From: Hyrum K Wright [mailto:hy...@hyrumwright.org] > > Sent: dinsdag 3 mei 2011 17:49 > > To: Julian Foad > > Cc: Philip Martin; dev@subversion.apache.org > > Subject: Re: svn info --recursive isn't report

RE: svn info --recursive isn't reporting tree-conflict-only nodes

2011-05-03 Thread Bert Huijben
> -Original Message- > From: Hyrum K Wright [mailto:hy...@hyrumwright.org] > Sent: dinsdag 3 mei 2011 17:49 > To: Julian Foad > Cc: Philip Martin; dev@subversion.apache.org > Subject: Re: svn info --recursive isn't reporting tree-conflict-only nodes > > On Tue, May 3, 2011 at 10:19 AM, J

Re: svn info --recursive isn't reporting tree-conflict-only nodes

2011-05-03 Thread Julian Foad
On Tue, 2011-05-03 at 16:56 +0100, Julian Foad wrote: > On Tue, 2011-05-03 at 18:46 +0300, Daniel Shahaf wrote: > > Julian Foad wrote on Tue, May 03, 2011 at 14:31:47 +0100: > > > + # Check recursive info. > > > +# ### This is currently dependent on ordering of the dict entries. > > > + expec

Re: svn info --recursive isn't reporting tree-conflict-only nodes

2011-05-03 Thread Julian Foad
On Tue, 2011-05-03 at 18:46 +0300, Daniel Shahaf wrote: > Julian Foad wrote on Tue, May 03, 2011 at 14:31:47 +0100: > > + # Check recursive info. > > +# ### This is currently dependent on ordering of the dict entries. > > + expected_infos = [{ 'Path' : r'.*[/\\]G' }] > >for fname, action,

RE: [hackathon] Keysigning

2011-05-03 Thread Bob Archer
> C. Michael Pilato wrote on Mon, May 02, 2011 at 13:20:30 -0400: > > On 04/27/2011 02:42 AM, Daniel Shahaf wrote: > > > to add other keys if you want) to > ^/subversion/site/keys/$username.asc . > > > > I wonder if we couldn't reduce data duplication by instead > recommending that > > committers u

Re: svn info --recursive isn't reporting tree-conflict-only nodes

2011-05-03 Thread Hyrum K Wright
On Tue, May 3, 2011 at 10:19 AM, Julian Foad wrote: > On Tue, 2011-05-03 at 14:36 +0100, Philip Martin wrote: >> Julian Foad writes: >> >> > I found a bug in "svn info -R": it doesn't report a node that has a tree >> > conflict but otherwise is nonexistent, except if this node is the root >> > no

Re: svn info --recursive isn't reporting tree-conflict-only nodes

2011-05-03 Thread Daniel Shahaf
Julian Foad wrote on Tue, May 03, 2011 at 14:31:47 +0100: > + # Check recursive info. > +# ### This is currently dependent on ordering of the dict entries. > + expected_infos = [{ 'Path' : r'.*[/\\]G' }] >for fname, action, reason in scenarios: > +expected_str = ".*local %s, incoming

Re: svn info --recursive isn't reporting tree-conflict-only nodes

2011-05-03 Thread Julian Foad
On Tue, 2011-05-03 at 14:36 +0100, Philip Martin wrote: > Julian Foad writes: > > > I found a bug in "svn info -R": it doesn't report a node that has a tree > > conflict but otherwise is nonexistent, except if this node is the root > > node of the requested target path. > > I think that's an act

Re: svn commit: r1099044 - /subversion/trunk/subversion/libsvn_ra_serf/commit.c

2011-05-03 Thread Philip Martin
Hyrum K Wright writes: >>   SVN_ERR(svn_io_open_unique_file3(&ctx->svndiff, NULL, NULL, >> -                                   svn_io_file_del_on_pool_cleanup, >> +                                   svn_io_file_del_on_close, >>                                    ctx->pool, ctx->pool)); > > This i

Re: svn commit: r1099044 - /subversion/trunk/subversion/libsvn_ra_serf/commit.c

2011-05-03 Thread Hyrum K Wright
On Tue, May 3, 2011 at 8:15 AM, wrote: > Author: philip > Date: Tue May  3 13:14:59 2011 > New Revision: 1099044 > > URL: http://svn.apache.org/viewvc?rev=1099044&view=rev > Log: > Commits that affect large numbers of files should work on systems that > limit the number of files that can be open

Re: svn commit: r1098610 - /subversion/trunk/subversion/libsvn_delta/editor.c

2011-05-03 Thread Ivan Zhakov
On Tue, May 3, 2011 at 17:20, C. Michael Pilato wrote: > On 05/03/2011 09:10 AM, Julian Foad wrote: >> FWIW, personally I prefer the foo->bar(...) style. > > As do I.   > +1. -- Ivan Zhakov

Re: svn info --recursive isn't reporting tree-conflict-only nodes

2011-05-03 Thread Philip Martin
Julian Foad writes: > I found a bug in "svn info -R": it doesn't report a node that has a tree > conflict but otherwise is nonexistent, except if this node is the root > node of the requested target path. I think that's an actual-only node. See http://subversion.tigris.org/issues/show_bug.cgi?

svn info --recursive isn't reporting tree-conflict-only nodes

2011-05-03 Thread Julian Foad
I found a bug in "svn info -R": it doesn't report a node that has a tree conflict but otherwise is nonexistent, except if this node is the root node of the requested target path. The test for "info -R" in info_tests.py was not correctly checking the output, and has been passing despite this bug.

Re: svn commit: r1098610 - /subversion/trunk/subversion/libsvn_delta/editor.c

2011-05-03 Thread C. Michael Pilato
On 05/03/2011 09:10 AM, Julian Foad wrote: > FWIW, personally I prefer the foo->bar(...) style. As do I. -- C. Michael Pilato CollabNet <> www.collab.net <> Distributed Development On Demand signature.asc Description: OpenPGP digital signature

Re: svn commit: r1098610 - /subversion/trunk/subversion/libsvn_delta/editor.c

2011-05-03 Thread Julian Foad
On Mon, 2011-05-02, Yellow wrote: > Hyrum K Wright wrote on Mon, May 02, 2011 at 15:00:45 -0500: > > On Mon, May 2, 2011 at 2:52 PM, Greg Stein wrote: > > > On Mon, May 2, 2011 at 10:55, wrote: > > >> Log: > > >> Use our "typical" function call syntax when using function pointers in > > >> the

Re: svn commit: r1095914 - in /subversion/trunk/subversion: include/svn_wc.h libsvn_client/merge.c libsvn_wc/deprecated.c libsvn_wc/props.c libsvn_wc/props.h libsvn_wc/update_editor.c

2011-05-03 Thread Philip Martin
Greg Stein writes: > Update: this is caused by CONTENT_STATE in close_file() not getting a > proper value when fb->obstruction_found==1. It affects the > notification later in the function. > > I'll tease out the logic tomorrow... I get a valgrind errors: CMD: svn co file:///home/pm/sw/subvers

Re: Reversion of copied directories with depth != infinity

2011-05-03 Thread Philip Martin
"Markus Schaber" writes: > I'm currently working on integration of Subversion support into > CoDeSys[2], using the latest SharpSVN based on subversion 1.6.16. > > One current problem is that the revert command refuses to work on a > copied directory with a depth different to infinity. This seems

Re: svn commit: r1095914 - in /subversion/trunk/subversion: include/svn_wc.h libsvn_client/merge.c libsvn_wc/deprecated.c libsvn_wc/props.c libsvn_wc/props.h libsvn_wc/update_editor.c

2011-05-03 Thread Greg Stein
Update: this is caused by CONTENT_STATE in close_file() not getting a proper value when fb->obstruction_found==1. It affects the notification later in the function. I'll tease out the logic tomorrow... On Mon, May 2, 2011 at 07:32, Greg Stein wrote: > I have local failures on checkout_test 4 5 6