> -Original Message-
> From: Mark Phippard [mailto:markp...@gmail.com]
> Sent: dinsdag 10 mei 2011 1:16
> To: Julian Foad
> Cc: dev@subversion.apache.org
> Subject: Re: [PATCH] WC DB verification 1
>
> Could we tie it into cleanup? Then other tools like TortoiseSVN,
> Subclipse, AnkhSVN
Could we tie it into cleanup? Then other tools like TortoiseSVN,
Subclipse, AnkhSVN could invoke it too.
On Mon, May 9, 2011 at 6:30 PM, Julian Foad wrote:
> I'm planning to commit the attached wc-db-verification-1.patch, subject
> to any advice on how to best fit it in to the code base or othe
On Thu, 2011-05-05 at 14:40 -0400, Greg Stein wrote:
> On Thu, May 5, 2011 at 11:20, Julian Foad wrote:
> > I keep coming across simple bugs in untested APIs, and sometimes I try
> > to write simple unit tests for those APIs. To make this easier, I have
> > started to create a "svn_test__sandbox"
I'm planning to commit the attached wc-db-verification-1.patch, subject
to any advice on how to best fit it in to the code base or other
concerns, in order to get a DB "self-check" function started.
I think we need something like this. Earlier today I found that "svn
status" showed I had a clean,
stef...@apache.org wrote on Mon, May 09, 2011 at 20:54:37 -:
> Author: stefan2
> Date: Mon May 9 20:54:37 2011
> New Revision: 1101219
>
> URL: http://svn.apache.org/viewvc?rev=1101219&view=rev
> Log:
> * notes/knobs: reformat; add all SVN-specific defines used by #ifdef or
> #ifndef
>
Nic
On Mon, May 9, 2011 at 4:58 PM, Stefan Sperling wrote:
> On Mon, May 09, 2011 at 04:53:15PM -0500, Hyrum K Wright wrote:
>> On Mon, May 9, 2011 at 3:46 PM, Hyrum K Wright wrote:
>> > On Mon, May 9, 2011 at 3:20 PM, Hyrum K Wright
>> > wrote:
>> >> A small bug I ran across. I'll eventually dig
On Mon, May 09, 2011 at 04:53:15PM -0500, Hyrum K Wright wrote:
> On Mon, May 9, 2011 at 3:46 PM, Hyrum K Wright wrote:
> > On Mon, May 9, 2011 at 3:20 PM, Hyrum K Wright
> > wrote:
> >> A small bug I ran across. I'll eventually dig deeper, but if anybody
> >> has the time, they are welcome to
On Mon, May 9, 2011 at 3:46 PM, Hyrum K Wright wrote:
> On Mon, May 9, 2011 at 3:20 PM, Hyrum K Wright wrote:
>> A small bug I ran across. I'll eventually dig deeper, but if anybody
>> has the time, they are welcome to look. This is with a r1101202 trunk
>> client.
>>
>> [[[
>> $ svn cp ^/apr/s
> -Original Message-
> From: Greg Stein [mailto:gst...@gmail.com]
> Sent: maandag 9 mei 2011 22:44
> To: dev@subversion.apache.org
> Subject: Re: svn commit: r1101071 - in
> /subversion/trunk/subversion/libsvn_wc: upgrade.c wc-metadata.sql
> wc_db.c
>
> On Mon, May 9, 2011 at 11:43, wr
Nick Piper wrote:
> Add svn_stream_close_on_cleanup(), which will register a stream to be
> automatically closed when the pool is destroyed.
First impression: the public name makes it sound like a user-level
thing, but this is for use by a stream's implementation, right? Not by
its users.
I don'
On Mon, May 9, 2011 at 3:20 PM, Hyrum K Wright wrote:
> A small bug I ran across. I'll eventually dig deeper, but if anybody
> has the time, they are welcome to look. This is with a r1101202 trunk
> client.
>
> [[[
> $ svn cp ^/apr/site/trunk/docs/download.cgi .
> svn: E160013: '/repos/asf/!svn/
On Mon, May 9, 2011 at 11:43, wrote:
>...
> +++ subversion/trunk/subversion/libsvn_wc/wc-metadata.sql Mon May 9 15:43:56
> 2011
> @@ -530,7 +530,64 @@ BEGIN
> WHERE checksum = OLD.checksum;
> END;
>
> +-- STMT_CREATE_EXTERNALS
>
> +CREATE TABLE EXTERNALS (
> + /* Working copy location relat
On Mon, May 9, 2011 at 3:41 PM, Hyrum K Wright wrote:
>> I realize there are some projects that have had success with this sort
>> of thing, I just do not think we are one of them. My main concern is
>> that it would actually slow down the release process as we get to a
>> point where we are som
A small bug I ran across. I'll eventually dig deeper, but if anybody
has the time, they are welcome to look. This is with a r1101202 trunk
client.
[[[
$ svn cp ^/apr/site/trunk/docs/download.cgi .
svn: E160013: '/repos/asf/!svn/bc/30/apr/site/trunk/docs/download.cgi'
path not found
$ svn st
A +
On 05/09/2011 02:01 PM, phi...@apache.org wrote:
> Author: philip
> Date: Mon May 9 18:01:59 2011
> New Revision: 1101126
>
> URL: http://svn.apache.org/viewvc?rev=1101126&view=rev
> Log:
> * subversion/libsvn_ra_neon/commit.c
> (commit_open_root): Use VTXN stubs with VTXN name.
Doh! Thanks f
On Thu, May 5, 2011 at 6:07 PM, Mark Phippard wrote:
> On Thu, May 5, 2011 at 6:02 PM, Hyrum K Wright wrote:
>
>> We've still got bugs (we'll always have bugs), but I think getting
>> more testing via the pre-releases is important at this stage, and I
>> see branching as a step toward cutting pre
On Tue, Jul 13, 2010 at 10:19 AM, Stefan Sperling wrote:
> On Tue, Jul 13, 2010 at 03:07:30PM +0100, Hyrum K. Wright wrote:
>> Could you file the issue?
>
> Sure: http://subversion.tigris.org/issues/show_bug.cgi?id=3680
Hi All,
So how do we resolve this issue? The crux seems to be:
In r95973
On May 9, 2011 10:48 AM, "Julian Foad" wrote:
>
> Hyrum K Wright wrote:
> > On Sun, May 8, 2011 at 3:34 AM, wrote:
> > > -for (i = relpath_depth(local_relpath); i > op_depth; --i)
> > > +for (i = (int)relpath_depth(local_relpath); i > op_depth; --i)
> > >
> > > -for (i = relpath_
On Thu, May 5, 2011 at 9:37 AM, Hyrum K Wright wrote:
> On Mon, May 2, 2011 at 3:38 PM, Hyrum K Wright wrote:
>> Hi all,
>>
>> There have a been a couple of user-requested fixes nominated or
>> backported to 1.6.17, and there are several pending fixes. So let's
>> fire up the release machine and
On May 9, 2011 12:36 PM, wrote:
>
> Author: stefan2
> Date: Mon May 9 16:36:28 2011
> New Revision: 1101102
>
> URL: http://svn.apache.org/viewvc?rev=1101102&view=rev
> Log:
> Fix conversion and signedness comparison warnings concerning the "fuzz"
> factor. That value is non-negative, thus we can
This version:
* Makes the new behaviour optional, via stream_close_on_cleanup()
(which the Python API then uses.) (Thanks Bert.)
* Uses apr_pool_cleanup_register() rather than the 'pre' variant, in
order to match the reset of svn and be compatible with older APR (thanks
Philip.)
[[[
Add svn_stre
stef...@apache.org writes:
> Author: stefan2
> Date: Mon May 9 16:28:16 2011
> New Revision: 1101091
> (svn_cache__membuffer_cache_create): formatting fixes; add missing cast
> - c = apr_palloc(pool, segment_count * sizeof(*c));
> + c = (svn_membuffer_t *)apr_palloc(pool, segment_count * si
On 08.05.2011 18:40, Daniel Shahaf wrote:
A few questions:
stef...@apache.org wrote on Sun, May 08, 2011 at 13:48:33 -:
Author: stefan2
Date: Sun May 8 13:48:33 2011
New Revision: 1100738
URL: http://svn.apache.org/viewvc?rev=1100738&view=rev
Log:
Make membuffer cache segmentation dynamic
stef...@apache.org wrote:
> * subversion/libsvn_subr/cache-membuffer.c
> (MIN_SEGMENT_SIZE): ensure that cache sizes > 4GB work
> (svn_cache__membuffer_cache_create): formatting fixes; add missing cast
>/* allocate cache as an array of segments / cache objects */
> - c = apr_palloc(pool,
Bert Huijben wrote on Mon, May 09, 2011 at 17:49:52 +0200:
>
>
> > -Original Message-
> > From: Daniel Shahaf [mailto:danie...@elego.de]
> > Sent: maandag 9 mei 2011 17:31
> > To: Nick Piper
> > Cc: dev@subversion.apache.org
> > Subject: Re: AW: Python bindings: Use of svn_swig_py_make_st
On Sat, May 7, 2011 at 6:27 AM, Daniel Shahaf wrote:
> Someone added %lld and %llu codes to svn_string.c:
>
> return svn_error_return(
> svn_error_createf(SVN_ERR_INCORRECT_PARAMS, NULL,
> _("Number '%s' is out of range '[%lld, %lld]'"),
>
Julian Foad writes:
> Alternatively... I'd like to change all our uses of apr_int64_t for
> (wc_id, repos_id, op_depth) to plain "int". I think that would be
> better because it would only occupy one syllable of thought-space rather
> than eight syllables. And I believe there's no functional or
> -Original Message-
> From: Daniel Shahaf [mailto:danie...@elego.de]
> Sent: maandag 9 mei 2011 17:31
> To: Nick Piper
> Cc: dev@subversion.apache.org
> Subject: Re: AW: Python bindings: Use of svn_swig_py_make_stream() -
> avoiding leaking fds
>
> Nick Piper wrote on Mon, May 09, 2011
Daniel Shahaf writes:
>> @@ -73,6 +95,9 @@ svn_stream_create(void *baton, apr_pool_t *pool)
>>stream->mark_fn = NULL;
>>stream->seek_fn = NULL;
>>stream->buffered_fn = NULL;
>> + stream->pool = pool;
>> + apr_pool_pre_cleanup_register(stream->pool, stream,
>> +
Nick Piper wrote on Mon, May 09, 2011 at 16:19:23 +0100:
> Thanks for reviewing.
>
> On 09/05/11 15:53, Daniel Shahaf wrote:
> > Nick Piper wrote on Mon, May 09, 2011 at 15:31:53 +0100:
>
> >> + /* This is used to close the stream if the pool is being destroyed.
> >> + It was first introduce
Thanks for reviewing.
On 09/05/11 15:53, Daniel Shahaf wrote:
> Nick Piper wrote on Mon, May 09, 2011 at 15:31:53 +0100:
>> + /* This is used to close the stream if the pool is being destroyed.
>> + It was first introduced for the Python API, to allow implicit
>> + closing.
>> + */
>>
Nick Piper wrote on Mon, May 09, 2011 at 15:31:53 +0100:
> On 09/05/11 12:59, Philip Martin wrote:
>
> > Yes, that would work. An alternative would be to deregister the pool
> > cleanup on an explicit close.
>
> Here is a version that does this. It's tested with the existing tests,
> plus my sma
On Sun, May 8, 2011 at 10:22 AM, wrote:
> Author: rhuijben
> Date: Sun May 8 15:22:01 2011
> New Revision: 1100756
>
> URL: http://svn.apache.org/viewvc?rev=1100756&view=rev
> Log:
> Extract some logic from the update_editor's merge_file code to its own
> function
> to allow reusing it from the
Hyrum K Wright wrote:
> On Sun, May 8, 2011 at 3:34 AM, wrote:
> > -for (i = relpath_depth(local_relpath); i > op_depth; --i)
> > +for (i = (int)relpath_depth(local_relpath); i > op_depth; --i)
> >
> > -for (i = relpath_depth(current_relpath); i > op_depth; i--)
> > +for (
> -Original Message-
> From: Hyrum K Wright [mailto:hy...@hyrumwright.org]
> Sent: maandag 9 mei 2011 16:32
> To: dev@subversion.apache.org
> Cc: comm...@subversion.apache.org
> Subject: Re: svn commit: r1100704 -
> /subversion/trunk/subversion/libsvn_wc/wc_db.c
> Instead of all the castin
On 09/05/11 12:59, Philip Martin wrote:
> Yes, that would work. An alternative would be to deregister the pool
> cleanup on an explicit close.
Here is a version that does this. It's tested with the existing tests,
plus my small test case, and it stops the leaking.
[[[
Automatically svn_stream_c
On Sun, May 8, 2011 at 3:34 AM, wrote:
> Author: rhuijben
> Date: Sun May 8 08:34:56 2011
> New Revision: 1100704
>
> URL: http://svn.apache.org/viewvc?rev=1100704&view=rev
> Log:
> * subversion/libsvn_wc/wc_db.c
> (scan_addition_txn,
> wclock_obtain_cb,
> svn_wc__db_wclock_obtain,
> svn_
Ok, the tagging and referencing the tags is a solution, but...
...governing approx. 400 common files with in their wanted revisions for
approx 4 -6 similar projects would have been challenging enough in the
svn:externals. At least one could write a tool on top if necessary.
If I imagine the repo
Philip Martin wrote on Mon, May 09, 2011 at 13:26:29 +0100:
> Daniel Shahaf writes:
>
> > SunOS 5.10's /bin/sh chokes:
> >
> > $ echo $((5*2))
> > syntax error: `(' unexpected
> >
> > Daniel
> > (I didn't test it before because the host I used has a time-based login
> > policy)
>
> SunOS's /bin
Daniel Shahaf writes:
> SunOS 5.10's /bin/sh chokes:
>
> $ echo $((5*2))
> syntax error: `(' unexpected
>
> Daniel
> (I didn't test it before because the host I used has a time-based login
> policy)
SunOS's /bin/sh is Bourne, not POSIX. SunOS provides /usr/xpg4/bin/sh
which is POSIX.
--
Phil
Daniel Shahaf wrote on Mon, May 09, 2011 at 11:25:08 +0300:
> Arfrever Frehtes Taifersar Arahesis wrote on Mon, May 09, 2011 at 00:03:31
> +0200:
> > 2011-05-08 13:53:14 danie...@apache.org napisał(a):
> > > + FILECOUNT=`echo 2 \* $FILECOUNT | bc`
> >
> > bc is an external program, which might b
Daniel Shahaf writes:
> Philip Martin wrote on Mon, May 09, 2011 at 12:33:14 +0100:
>> Daniel Shahaf writes:
>>
>> > +static apr_status_t
>> > +close_stream_cleanup(void *stream)
>> > +{
>> > + apr_status_t apr_err = APR_SUCCESS;
>> > + svn_error_t *err;
>> > +
>> > + err = svn_stream_clos
On Mon, 2011-05-09 at 14:41 +0300, Daniel Shahaf wrote:
> Julian Foad wrote on Mon, May 09, 2011 at 12:17:43 +0100:
> > On Fri, 2011-05-06 at 21:47 -0400, C. Michael Pilato wrote:
> > > On 05/06/2011 07:08 PM, Greg Stein wrote:
> > > > On Fri, May 6, 2011 at 17:06, Hyrum K Wright
> > > > wrote:
>
Philip Martin wrote on Mon, May 09, 2011 at 12:33:14 +0100:
> Daniel Shahaf writes:
>
> > +static apr_status_t
> > +close_stream_cleanup(void *stream)
> > +{
> > + apr_status_t apr_err = APR_SUCCESS;
> > + svn_error_t *err;
> > +
> > + err = svn_stream_close(stream);
> > + if (err)
> > +
Julian Foad wrote on Mon, May 09, 2011 at 12:17:43 +0100:
> On Fri, 2011-05-06 at 21:47 -0400, C. Michael Pilato wrote:
> > On 05/06/2011 07:08 PM, Greg Stein wrote:
> > > On Fri, May 6, 2011 at 17:06, Hyrum K Wright
> > > wrote:
> > >> On Fri, May 6, 2011 at 4:01 PM, C. Michael Pilato
> > >> w
Daniel Shahaf writes:
> +static apr_status_t
> +close_stream_cleanup(void *stream)
> +{
> + apr_status_t apr_err = APR_SUCCESS;
> + svn_error_t *err;
> +
> + err = svn_stream_close(stream);
> + if (err)
> +{
> + apr_err = err->apr_err;
> + svn_error_clear(err);
> +}
> +
>
Nick Piper wrote on Mon, May 09, 2011 at 11:21:10 +0100:
>
>
> On 09/05/11 09:05, Markus Schaber wrote:
> > Hi, Hick,
> >
> >> Von: Piper, Nick [mailto:nick.pi...@logica.com]
> >
> >> In Python, f is a "file" instance, but that will be converted to a
> >> svn_stream_t by swig (by svn_swig_py_m
On Fri, 2011-05-06 at 21:47 -0400, C. Michael Pilato wrote:
> On 05/06/2011 07:08 PM, Greg Stein wrote:
> > On Fri, May 6, 2011 at 17:06, Hyrum K Wright wrote:
> >> On Fri, May 6, 2011 at 4:01 PM, C. Michael Pilato
> >> wrote:
> >>> Is there a convention in HTTP user-agent strings to use whitesp
On 09/05/11 09:05, Markus Schaber wrote:
> Hi, Hick,
>
>> Von: Piper, Nick [mailto:nick.pi...@logica.com]
>
>> In Python, f is a "file" instance, but that will be converted to a
>> svn_stream_t by swig (by svn_swig_py_make_stream()).
>>
>> That file then goes out of scope in Python, but the fi
On Sun, May 08, 2011 at 08:08:54PM -0400, Greg Stein wrote:
> On Sun, May 8, 2011 at 18:44, wrote:
> > Author: stsp
> > Date: Sun May 8 22:44:29 2011
> > New Revision: 1100830
> >
> > URL: http://svn.apache.org/viewvc?rev=1100830&view=rev
> > Log:
> > Add --depth option support to svn log --diff
Arfrever Frehtes Taifersar Arahesis wrote on Mon, May 09, 2011 at 00:11:13
+0200:
> 2011-05-08 14:46:21 danie...@apache.org napisał(a):
> > Author: danielsh
> > Date: Sun May 8 12:46:20 2011
> > New Revision: 1100726
> >
> > URL: http://svn.apache.org/viewvc?rev=1100726&view=rev
> > Log:
> > Mor
Arfrever Frehtes Taifersar Arahesis wrote on Mon, May 09, 2011 at 00:03:31
+0200:
> 2011-05-08 13:53:14 danie...@apache.org napisał(a):
> > + FILECOUNT=`echo 2 \* $FILECOUNT | bc`
>
> bc is an external program, which might be unavailable.
> The portable solution is $((...)) syntax:
> http://pubs
Greg Stein wrote on Sun, May 08, 2011 at 20:14:39 -0400:
> On Sun, May 8, 2011 at 08:46, wrote:
> >...
> > +++ subversion/trunk/tools/dev/benchmarks/large_dirs/create_bigdir.sh Sun
> > May 8 12:46:20 2011
> > @@ -99,6 +99,13 @@ echo
> > rm -rf $WC
> > ${SVN} co $URL $WC > /dev/null
> >
> > +#
Hi, Hick,
> Von: Piper, Nick [mailto:nick.pi...@logica.com]
> In Python, f is a "file" instance, but that will be converted to a
> svn_stream_t by swig (by svn_swig_py_make_stream()).
>
> That file then goes out of scope in Python, but the file descriptor is
> never closed. I don't see where we
54 matches
Mail list logo
