RE: svn commit: r1102843 - /subversion/trunk/subversion/libsvn_wc/wc-metadata.sql

2011-05-13 Thread Bert Huijben
> -Original Message- > From: Bert Huijben [mailto:b...@qqmail.nl] > Sent: zaterdag 14 mei 2011 8:06 > To: Greg Stein; dev@subversion.apache.org > Subject: RE: svn commit: r1102843 - > /subversion/trunk/subversion/libsvn_wc/wc-metadata.sql > > The format 20 bump introduces a foreign key (

RE: svn commit: r1102843 - /subversion/trunk/subversion/libsvn_wc/wc-metadata.sql

2011-05-13 Thread Bert Huijben
The format 20 bump introduces a foreign key (now) which breaks upgrades if you have md5 checksums. When we originally bumped to 20 this constraint wasn't there yet (added in January as 'small' change without impact. danielsh reported a broken update caused by this change on IRC. Bert Huijben (Ce

Re: svn commit: r1102843 - /subversion/trunk/subversion/libsvn_wc/wc-metadata.sql

2011-05-13 Thread Greg Stein
On Fri, May 13, 2011 at 14:13, wrote: > Author: rhuijben > Date: Fri May 13 18:13:06 2011 > New Revision: 1102843 > > URL: http://svn.apache.org/viewvc?rev=1102843&view=rev > Log: > * subversion/libsvn_wc/wc-metadata.sql >  (STMT_UPGRADE_TO_20): Following up on r1102837, update BASE_NODE and >  

Re: svn commit: r1102912 - in /subversion/trunk/subversion: include/private/svn_wc_private.h libsvn_client/prop_commands.c libsvn_wc/externals.c libsvn_wc/wc_db.c tests/libsvn_wc/db-test.c

2011-05-13 Thread Greg Stein
On Fri, May 13, 2011 at 18:23, wrote: > Author: rhuijben > Date: Fri May 13 22:22:59 2011 > New Revision: 1102912 > > URL: http://svn.apache.org/viewvc?rev=1102912&view=rev > Log: > Make the svn_client_proplist3 funtion capable of reading properties from > new style file externals. Huh? I though

Re: svn commit: r1102837 - /subversion/trunk/subversion/libsvn_wc/wc-metadata.sql

2011-05-13 Thread Greg Stein
On Fri, May 13, 2011 at 14:09, wrote: > Author: rhuijben > Date: Fri May 13 18:09:06 2011 > New Revision: 1102837 > > URL: http://svn.apache.org/viewvc?rev=1102837&view=rev > Log: > * subversion/libsvn_wc/wc-metadata.sql >  (STMT_UPGRADE_TO_20): Fix upgrading to format 20 for whoever has MD5 >  

Re: svn commit: r1102619 - /subversion/trunk/subversion/libsvn_client/externals.c

2011-05-13 Thread Greg Stein
On Fri, May 13, 2011 at 05:13, wrote: > Author: rhuijben > Date: Fri May 13 09:13:49 2011 > New Revision: 1102619 > > URL: http://svn.apache.org/viewvc?rev=1102619&view=rev > Log: > * subversion/libsvn_client/externals.c >  (handle_external_item_change_wrapper): Following up on r1102502, revert >

Re: svn commit: r1094150 - in /subversion/trunk/subversion/libsvn_fs_fs: caching.c fs.h fs_fs.c fs_fs.h tree.c

2011-05-13 Thread Daniel Shahaf
stef...@apache.org wrote on Sun, Apr 17, 2011 at 14:48:34 -: > Author: stefan2 > Date: Sun Apr 17 14:48:33 2011 > New Revision: 1094150 > > URL: http://svn.apache.org/viewvc?rev=1094150&view=rev > Log: > Support concurrent transactions on FSFS: reset txn-local caches upon > closing the txn (i.

Re: svn commit: r1094150 - in /subversion/trunk/subversion/libsvn_fs_fs: caching.c fs.h fs_fs.c fs_fs.h tree.c

2011-05-13 Thread Daniel Shahaf
stef...@apache.org wrote on Sun, Apr 17, 2011 at 14:48:34 -: > +static svn_error_t * > +init_txn_callbacks(svn_cache__t **cache, > + apr_pool_t *pool) > +{ ... > @@ -386,10 +426,17 @@ svn_fs_fs__initialize_txn_caches(svn_fs_ > pool)); >

Re: svn commit: r1093983 - in /subversion/trunk/subversion: include/private/svn_cache.h libsvn_fs_fs/caching.c libsvn_subr/cache-inprocess.c libsvn_subr/cache-membuffer.c libsvn_subr/cache-memcache.c

2011-05-13 Thread Daniel Shahaf
stef...@apache.org wrote on Sat, Apr 16, 2011 at 13:06:07 -: > Author: stefan2 > Date: Sat Apr 16 13:06:07 2011 > New Revision: 1093983 > > URL: http://svn.apache.org/viewvc?rev=1093983&view=rev > Log: > In symmetry to svn_cache__get_partial, introduce a partial > setter / modifier API functio

Re: svn commit: r1102775 - /subversion/site/publish/docs/community-guide/issues.part.html

2011-05-13 Thread Daniel Shahaf
Thanks for writing it up; #milestones-open is a good text to link users@ and issues@ queriers to. cmpil...@apache.org wrote on Fri, May 13, 2011 at 14:57:05 -: > Author: cmpilato > Date: Fri May 13 14:57:04 2011 > New Revision: 1102775 > > URL: http://svn.apache.org/viewvc?rev=1102775&view=re

Re: svn commit: r1102775 - /subversion/site/publish/docs/community-guide/issues.part.html

2011-05-13 Thread Daniel Shahaf
Can you please update the "table of contents" at the top of that file too? cmpil...@apache.org wrote on Fri, May 13, 2011 at 14:57:05 -: > Author: cmpilato > Date: Fri May 13 14:57:04 2011 > New Revision: 1102775 > > URL: http://svn.apache.org/viewvc?rev=1102775&view=rev > Log: > * site/publi

Re: svnrdump revision inconsistency bugs

2011-05-13 Thread C. Michael Pilato
On 05/13/2011 05:13 PM, C. Michael Pilato wrote: > On 05/12/2011 04:26 PM, Mark Eichin wrote: >> The third bug is that "svnrdump -r 3:HEAD" says "E205000: Unsupported >> revision specifier used; use only integer values or 'HEAD'" (which is >> why the attached script goes out of its way to parse rev

Re: svnrdump revision inconsistency bugs

2011-05-13 Thread C. Michael Pilato
On 05/12/2011 04:26 PM, Mark Eichin wrote: > I'm working on some svn migration-with-history between repos from > different companies, git-svn isn't cutting it (close, but it loses > properties entirely, and doesn't really give me enough control) so I > thought I'd give svnrdump a try, given that it

Re: svn commit: r1102690 - in /subversion/trunk/subversion: libsvn_ra_serf/replay.c tests/cmdline/svnsync_tests.py

2011-05-13 Thread C. Michael Pilato
On 05/13/2011 04:28 PM, Kamesh Jayachandran wrote: >>Naturally, in such situations, you don't want to open your file batons in >>pools that will be destroyed when their parent directory baton's pool is >>also destroyed. You need instead for file baton's to have lifetimes that's >>about as long as

RE: svn commit: r1102690 - in /subversion/trunk/subversion: libsvn_ra_serf/replay.c tests/cmdline/svnsync_tests.py

2011-05-13 Thread Kamesh Jayachandran
>[For the record, I'm not saying your code is wrong -- I didn't even look at >it. I'm only correcting your statement about simultaneous open files.] >Because transmitting file contents is generally considered the most costly >part of describing a tree delta, the editor interface allows you to de

Re: svn commit: r1102690 - in /subversion/trunk/subversion: libsvn_ra_serf/replay.c tests/cmdline/svnsync_tests.py

2011-05-13 Thread Mark Phippard
On Fri, May 13, 2011 at 3:05 PM, Kamesh Jayachandran wrote: > >>Yeah, Kamesh is just incorrect on this.  The editor interface has always >>allowed multiple simultaneous open files to support what it calls "postfix >>text-deltas". > > I could not understand that. I will try to understand that and f

Re: svn commit: r1102690 - in /subversion/trunk/subversion: libsvn_ra_serf/replay.c tests/cmdline/svnsync_tests.py

2011-05-13 Thread C. Michael Pilato
On 05/13/2011 03:31 PM, Mark Phippard wrote: > On Fri, May 13, 2011 at 3:05 PM, Kamesh Jayachandran > wrote: >> >>> Yeah, Kamesh is just incorrect on this. The editor interface has always >>> allowed multiple simultaneous open files to support what it calls "postfix >>> text-deltas". >> >> I cou

Re: svn commit: r1102690 - in /subversion/trunk/subversion: libsvn_ra_serf/replay.c tests/cmdline/svnsync_tests.py

2011-05-13 Thread C. Michael Pilato
On 05/13/2011 03:05 PM, Kamesh Jayachandran wrote: > >>Yeah, Kamesh is just incorrect on this. The editor interface has always >>allowed multiple simultaneous open files to support what it calls "postfix >>text-deltas". > > I could not understand that. I will try to understand that and fix my c

RE: svn commit: r1102690 - in /subversion/trunk/subversion: libsvn_ra_serf/replay.c tests/cmdline/svnsync_tests.py

2011-05-13 Thread Kamesh Jayachandran
>Yeah, Kamesh is just incorrect on this. The editor interface has always >allowed multiple simultaneous open files to support what it calls "postfix >text-deltas". I could not understand that. I will try to understand that and fix my code. With regards Kamesh Jayachandran

Re: svn commit: r1102690 - in /subversion/trunk/subversion: libsvn_ra_serf/replay.c tests/cmdline/svnsync_tests.py

2011-05-13 Thread C. Michael Pilato
Yeah, Kamesh is just incorrect on this. The editor interface has always allowed multiple simultaneous open files to support what it calls "postfix text-deltas". On 05/13/2011 12:54 PM, Bert Huijben wrote: > The standard commit processing in libsvn client also violates that. > > Bert Huijben (Cel

RE: svn commit: r1102690 - in /subversion/trunk/subversion: libsvn_ra_serf/replay.c tests/cmdline/svnsync_tests.py

2011-05-13 Thread Bert Huijben
The standard commit processing in libsvn client also violates that. Bert Huijben (Cell phone) From: Justin Erenkrantz Sent: vrijdag 13 mei 2011 18:25 To: Kamesh Jayachandran Cc: dev@subversion.apache.org Subject: Re: svn commit: r1102690 - in /subversion/trunk/subversion: libsvn_ra_serf/replay.c t

Re: svnrdump revision inconsistency bugs

2011-05-13 Thread Mark Eichin
cool, I'll admit I didn't take the time to look at existing test cases to see what style to write them in (partly because I was mostly simplifying the script I was using to perform the original goal); looks like I didn't include trap "rm -rf" 0 lines either (but for debugging the problem one proba

Re: svn commit: r1102690 - in /subversion/trunk/subversion: libsvn_ra_serf/replay.c tests/cmdline/svnsync_tests.py

2011-05-13 Thread Justin Erenkrantz
On Fri, May 13, 2011 at 7:53 AM, Kamesh Jayachandran wrote: > As per delta editor contract... one can not open two files at once on the > same editor drive, so no issue. Don't get C-Mike started...but, no ra_serf does violate that one. =) -- justin

Re: svnrdump revision inconsistency bugs

2011-05-13 Thread C. Michael Pilato
Just contributing a version of the recipe script that's a bit more flexible. -- C. Michael Pilato CollabNet <> www.collab.net <> Distributed Development On Demand #!/bin/sh -xe # --- SVN=svn SVNADMIN=svnadmin SVNRDUMP=svnrdump REPO_DIR1

Re: Further diff optimization ideas

2011-05-13 Thread Stefan Fuhrmann
On 13.05.2011 10:44, Julian Foad wrote: Johan Corveleyn wrote: Ok, to wrap this up for now: r1102471 finally put these thoughts into notes/diff-optimizations.txt, with some of Stefan2's feedback/ideas integrated into it. Johan, thank you for writing down the ideas you've thought through so much

Re: svn commit: r1102690 - in /subversion/trunk/subversion: libsvn_ra_serf/replay.c tests/cmdline/svnsync_tests.py

2011-05-13 Thread Kamesh Jayachandran
On 05/13/2011 07:51 PM, Bert Huijben wrote: -Original Message- From: kame...@apache.org [mailto:kame...@apache.org] Sent: vrijdag 13 mei 2011 14:22 To: comm...@subversion.apache.org Subject: svn commit: r1102690 - in /subversion/trunk/subversion: libsvn_ra_serf/replay.c tests/cmdline/sv

RE: svn commit: r1102690 - in /subversion/trunk/subversion: libsvn_ra_serf/replay.c tests/cmdline/svnsync_tests.py

2011-05-13 Thread Bert Huijben
> -Original Message- > From: kame...@apache.org [mailto:kame...@apache.org] > Sent: vrijdag 13 mei 2011 14:22 > To: comm...@subversion.apache.org > Subject: svn commit: r1102690 - in /subversion/trunk/subversion: > libsvn_ra_serf/replay.c tests/cmdline/svnsync_tests.py > > Author: kamesh

RE: [PATCH] Fix for issue3870 - File descriptor leaks during svnsync

2011-05-13 Thread Kamesh Jayachandran
Committed it in 1102690. -Original Message- From: Kamesh Jayachandran [mailto:kam...@collab.net] Sent: Thu 5/12/2011 10:38 PM To: dev@subversion.apache.org Subject: [PATCH] Fix for issue3870 - File descriptor leaks during svnsync Hi All, Attached patch fixes the File descriptor leaks i

Re: Further diff optimization ideas

2011-05-13 Thread Julian Foad
Johan Corveleyn wrote: > Ok, to wrap this up for now: r1102471 finally put these thoughts into > notes/diff-optimizations.txt, with some of Stefan2's feedback/ideas > integrated into it. Johan, thank you for writing down the ideas you've thought through so much, where we can find them later, in ad

Re: svn commit: r1102321 - /subversion/trunk/subversion/libsvn_wc/entries.c

2011-05-13 Thread Philip Martin
"Bert Huijben" writes: >>case svn_wc_schedule_replace: >> +if (parent_node->base && parent_node->work) >> + return svn_error_createf(SVN_ERR_UNSUPPORTED_FEATURE, NULL, >> + _("Cannot upgrade with copied/replaced directory '%s'"), >> + s

Re: svn commit: r1102502 - /subversion/trunk/subversion/libsvn_client/externals.c

2011-05-13 Thread Johan Corveleyn
On Fri, May 13, 2011 at 12:53 AM, wrote: > Author: rhuijben > Date: Thu May 12 22:53:02 2011 > New Revision: 1102502 > > URL: http://svn.apache.org/viewvc?rev=1102502&view=rev > Log: > * subversion/libsvn_client/externals.c >  (svn_client__do_external_status): Fix typo in comment. > > Modified: >