AW: [PATCH] Speed-up of libsvn_diff using token counts

Hi, Morten, > Von: Morten Kloster [mailto:mor...@gmail.com] > I haven't changed the index/count types yet. What's the right type to use > to get signed 32 bit on 32-bit machines and signed 64 bit on 64-bit > machines? You should use intptr_t from stdint.h, I'd guess. Regards, Markus Schaber -

[svnbench] Revision: 1128977 compiled May 30 2011, 00:21:17

/home/neels/svnbench/20110530-002334 Started at Mon May 30 00:23:34 UTC 2011 - Results for dir levels: 5 spread: 5 Timings for 5x5_1.6 N min max avgoperation (unit is seconds) 6 597.09 612.32 606.92 T

Re: complicated build, subversion client

On Sun, May 29, 2011 at 11:19:05PM +0200, rupert THURNER wrote: > and we separate out the apache module, but imo a client should not contain > svnserve, svnsync, svndumpfilter, etc., see > http://www.opencsw.org/search/subversion/ for list of files we have > currently in subversion. currently we ha

Re: [PATCH] Speed-up of libsvn_diff using token counts

Here's a version that resolves conflicts from r1128921. Index: subversion/libsvn_diff/diff.c === --- subversion/libsvn_diff/diff.c (revision 1128966) +++ subversion/libsvn_diff/diff.c (working copy) @@ -33,7 +33,39 @@ #i

Re: [PATCH] Speed-up of libsvn_diff by reworking fp argument

On 29.05.2011 16:01, Morten Kloster wrote: (stefan) wrote: Hi Morten, Did you activate compiler optimizations (e.g. use the release build in VS)? While your patch makes the code easier to read, the GCC output is the same as for the unchanged code - except for an additional NOP to ensure optimina

Re: complicated build, subversion client

On Sun, May 29, 2011 at 20:16, Stefan Sperling wrote: > On Sun, May 29, 2011 at 06:56:13AM -0700, rupert.thurner wrote: > > for some time i participate in a small group of people packaging > > subversion for solaris within the opencsw project. while we love to > > use subversion a lot because it

Re: complicated build, subversion client

On Sun, May 29, 2011 at 06:56:13AM -0700, rupert.thurner wrote: > for some time i participate in a small group of people packaging > subversion for solaris within the opencsw project. while we love to > use subversion a lot because it easily scales to terabytes of data > managed, we continue to hav

Re: [PATCH] Speed-up of libsvn_diff using token counts

On Sun, May 29, 2011 at 6:17 PM, Morten Kloster wrote: > On Sun, May 29, 2011 at 6:00 PM, Bert Huijben wrote: >> >> >>> -Original Message- >>> From: Morten Kloster [mailto:mor...@gmail.com] >>> Sent: zondag 29 mei 2011 17:35 >>> To: Julian Foad >>> Cc: Mark Phippard; dev@subversion.apache

Re: [PATCH] Speed-up of libsvn_diff using token counts

On Sun, May 29, 2011 at 6:00 PM, Bert Huijben wrote: > > >> -Original Message- >> From: Morten Kloster [mailto:mor...@gmail.com] >> Sent: zondag 29 mei 2011 17:35 >> To: Julian Foad >> Cc: Mark Phippard; dev@subversion.apache.org >> Subject: Re: [PATCH] Speed-up of libsvn_diff using token

RE: [PATCH] Speed-up of libsvn_diff using token counts

> -Original Message- > From: Morten Kloster [mailto:mor...@gmail.com] > Sent: zondag 29 mei 2011 17:35 > To: Julian Foad > Cc: Mark Phippard; dev@subversion.apache.org > Subject: Re: [PATCH] Speed-up of libsvn_diff using token counts > > On Fri, May 27, 2011 at 7:57 PM, Julian Foad > wr

Re: [PATCH] Speed-up of libsvn_diff using token counts

On Fri, May 27, 2011 at 7:57 PM, Julian Foad wrote: > Morten Kloster wrote: >> On Fri, May 27, 2011 at 4:55 PM, Julian Foad >> wrote: >> > Morten Kloster wrote: >> >> I haven't changed the index/count types yet. What's the right type >> >> to use to get signed 32 bit on 32-bit machines and signe

Re: [PATCH] Speed-up of libsvn_diff by reworking fp argument

(stefan) wrote: > Hi Morten, > Did you activate compiler optimizations (e.g. use the release build in VS)? > While your patch makes the code easier to read, the GCC output is > the same as for the unchanged code - except for an additional NOP > to ensure optiminal branch target alignment. > -- Stef

Final(?) format bump for 1.7: Format 29

Hi, I intend to bump the working copy format to format 29 tomorrow Monday May 29, in the late afternoon/early evening (CEST). This format bump will rename all the pristines files from earlier WC-NG formats to have the extension .svn-base and it will add the EXTERNALS table. The externals

complicated build, subversion client

for some time i participate in a small group of people packaging subversion for solaris within the opencsw project. while we love to use subversion a lot because it easily scales to terabytes of data managed, we continue to have two problems building, for years now: 1. client build personally i fi

Re: [PATCH] Speed-up of libsvn_diff by reworking fp argument

On 27.05.2011 20:41, Morten Kloster wrote: [[[ Faster LCS algorithm in libsvn_diff by reworking fp argument * subversion/libsvn_diff/lcs.c (svn_diff__snake): fp and k arguments are added by caller ]]] Calling svn_diff__snake with fp+k as argument instead of both as separate arguments reduces

RE: Windows build, nonexistent functions

> -Original Message- > From: Stefan Küng [mailto:tortoise...@gmail.com] > Sent: zondag 29 mei 2011 14:41 > To: Bert Huijben > Cc: 'Greg Stein'; 'Subversion Development'; 'Daniel Shahaf' > Subject: Re: Windows build, nonexistent functions > > On 29.05.2011 14:25, Bert Huijben wrote: > >

Re: Windows build, nonexistent functions

On 29.05.2011 14:25, Bert Huijben wrote: I've adjusted the TSVN build to remove those functions from the extractor.py output. So it's not a big deal for me. But I'm still wondering whether the Windows build for the svn client works. Can anyone here try it? If it works, those functions could stay

RE: Windows build, nonexistent functions

> -Original Message- > From: Stefan Küng [mailto:tortoise...@gmail.com] > Sent: zondag 29 mei 2011 10:03 > To: Greg Stein > Cc: Subversion Development; Daniel Shahaf > Subject: Re: Windows build, nonexistent functions > > On 29.05.2011 09:54, Greg Stein wrote: > > > > On May 29, 2011 2:5

Re: [PATCH] Speed-up of libsvn_diff by reworking fp argument

Here is an updated version that resolves conflicts with revision 1128852. Index: subversion/libsvn_diff/lcs.c === --- subversion/libsvn_diff/lcs.c(revision 1128868) +++ subversion/libsvn_diff/lcs.c(working copy) @@ -48,

Re: [PATCH] Simplification/speed-up of libsvn_diff by eliminating idx

On 28.05.2011 12:25, Morten Kloster wrote: On Sat, May 28, 2011 at 10:18 AM, Johan Corveleyn wrote: [] Actually, about the theory behind the algorithm: I think it would be quite beneficial if lcs.c would contain more high level documentation about how the algorithm works, and why it works. Righ

Re: [PATCH] Simplification/speed-up of libsvn_diff by eliminating idx

On 27.05.2011 19:29, Morten Kloster wrote: On Fri, May 27, 2011 at 3:13 PM, Julian Foad wrote: On Fri, 2011-05-27 at 13:32 +0200, Johan Corveleyn wrote: On Fri, May 27, 2011 at 12:47 PM, Fuhrmann Stefan (ETAS/ESA1) wrote: Morten Kloster wrote: [[[ Simpler/faster LCS algorithm in libsvn_di

Re: Windows build, nonexistent functions

Stefan Küng wrote on Sun, May 29, 2011 at 10:03:01 +0200: > But I'm still wondering whether the Windows build for the svn client > works. Can anyone here try it? The build works every day for N windows-based devs and 2 windows buildbots. If you're going to ask "Does the Windows build work", I sug

Re: Windows build, nonexistent functions

On 29.05.2011 09:54, Greg Stein wrote: On May 29, 2011 2:55 AM, "Stefan Küng" mailto:tortoise...@gmail.com>> wrote: > > On 29.05.2011 04:31, Greg Stein wrote: >> On May 28, 2011 1:39 PM, "Stefan Küng" mailto:tortoise...@gmail.com> >>

Re: Windows build, nonexistent functions

On May 29, 2011 2:55 AM, "Stefan Küng" wrote: > > On 29.05.2011 04:31, Greg Stein wrote: >> On May 28, 2011 1:39 PM, "Stefan Küng" > > wrote: >... >> > >> > I did a grep search for those functions, and the only files they >> showed up were the headers, no other file

Re: [RFC] Final approach for issue #3702 (case-only renames on Windows)?

On 29.05.2011 08:43, Johan Corveleyn wrote: On Tue, May 24, 2011 at 11:02 AM, Johan Corveleyn wrote: 1) Rev svn_client_args_to_target_array to take an argument "is_move". That's really the only case where something special needs to happen. Something like this: if (is_move&& input_targets-