Re: svn commit: r1136294 - in /subversion/trunk/subversion/libsvn_ra_serf: ra_serf.h util.c

2011-06-15 Thread Lieven Govaerts
Hi Greg, On Thu, Jun 16, 2011 at 8:00 AM, wrote: > Author: gstein > Date: Thu Jun 16 06:00:55 2011 > New Revision: 1136294 > > URL: http://svn.apache.org/viewvc?rev=1136294&view=rev > Log: > Sketch out some structures for pausing the XML parsing of the "update" > report. This will allow us to ap

Re: diff wish

2011-06-15 Thread Daniel Shahaf
Branko Čibej wrote on Wed, Jun 15, 2011 at 14:44:45 +0200: > On 15.06.2011 14:11, Johan Corveleyn wrote: > >> If you have a different definition of "mis-synchronizes", please explain. > > No, I don't mean a broken diff. The diff should at all times be > > *correct*. That was indeed never questioned

Re: [PATCH] Issue #3919: fix for spurious property conflict during merge

2011-06-15 Thread Daniel Shahaf
Brian Neal wrote on Wed, Jun 15, 2011 at 14:22:52 -0500: > I probably not would have been able to write the initial patch without > it. Once I had all the pre-requisite build tools installed in Ubuntu, apt-get build-dep subversion ? > all I had to do was type "make" and watch it go to town. It wa

Re: API change - make svn_tristate_to_word/_from_word() private?

2011-06-15 Thread Daniel Shahaf
Stefan Fuhrmann wrote on Wed, Jun 15, 2011 at 21:29:32 +0200: > On 15.06.2011 16:45, Daniel Shahaf wrote: > >> * svnserve:main.c which uses it simply to detect whether a > >>command-line option is "true"/"yes"/"on", and doesn't actually care > >>about the tri-state-ness. > >> > Well, not specifyi

Re: svn commit: r1136114 - /subversion/trunk/configure.ac

2011-06-15 Thread Daniel Shahaf
Stefan Sperling wrote on Wed, Jun 15, 2011 at 19:54:48 +0200: > On Wed, Jun 15, 2011 at 06:28:28PM +0100, Philip Martin wrote: > > Stefan Sperling writes: > > >> Is cmp as portable as diff? Is it always available with the same > > >> behaviour? autoconf generates calls to diff, so we know that u

Re: 1.7.0 blocking issues / branching

2011-06-15 Thread Greg Stein
On Wed, Jun 15, 2011 at 16:46, Mark Phippard wrote: >... > I want to reiterate my objections to further delaying our release > process with these interim releases. In my mind, I was just thinking of a couple weeks with a label ("beta") that people might actually try out. >... > I do not think an

Re: 1.7.0 blocking issues / branching

2011-06-15 Thread Mark Phippard
On Wed, Jun 15, 2011 at 4:19 PM, Hyrum K Wright wrote: >> ps. and if you *don't* think it is good enough for 1.7.0, then it sure >> isn't an RC1. if we roll RC*, then we can't say "oh, but it isn't >> final. we'll have bugs to fix." that isn't an RC. seen too much of >> that nonsense in the past..

Re: 1.7.0 blocking issues / branching

2011-06-15 Thread Hyrum K Wright
On Wed, Jun 15, 2011 at 8:10 PM, Greg Stein wrote: > On Wed, Jun 15, 2011 at 15:08, Stefan Sperling wrote: >> On Wed, Jun 15, 2011 at 02:33:04PM -0400, Mark Phippard wrote: >>> Given that the most common distinction between alpha and beta is >>> "feature complete" I have been arguing all along th

Re: 1.7.0 blocking issues / branching

2011-06-15 Thread Greg Stein
On Wed, Jun 15, 2011 at 15:08, Stefan Sperling wrote: > On Wed, Jun 15, 2011 at 02:33:04PM -0400, Mark Phippard wrote: >> Given that the most common distinction between alpha and beta is >> "feature complete" I have been arguing all along that the existing >> "alpha" release should have been label

Re: API change - make svn_tristate_to_word/_from_word() private?

2011-06-15 Thread Stefan Fuhrmann
On 15.06.2011 16:45, Daniel Shahaf wrote: [ bcc stefan2 ] Julian Foad wrote on Wed, Jun 15, 2011 at 15:14:53 +0100: New in 1.7 in svn_types.h: svn_tristate_t svn_tristate_to_word() # yields "true"/"false"/NULL svn_tristate_from_word() # takes "true"/"yes"/"on"/.../ The _to/from_word

Re: API change - rename svn_hash_get_cstring/bool() to svn_config_hash_get_*()

2011-06-15 Thread Stefan Fuhrmann
On 15.06.2011 15:29, Julian Foad wrote: A heads-up: I'm renaming svn_hash_get_bool() to svn_config_hash_get_bool(), and svn_hash_get_cstring() to svn_config_hash_get(), moving them from svn_hash.h to svn_config.h. They are being used only for config hashes, and don't seem like general-purpose has

Re: [PATCH] Issue #3919: fix for spurious property conflict during merge

2011-06-15 Thread Brian Neal
Hi Stefan - On Wed, Jun 15, 2011 at 9:23 AM, Stefan Sperling wrote: > > Committed in r1136063. Thank you! > >> > Also, did you already run the regression tests with your patch ("make >> > check")? My suggestion might affect the output of 'svn' so tests would >> > need to be run again (but I wil

Re: [Issue 3922] New - pass client cert as stream to auth provider

2011-06-15 Thread Stefan Sperling
On Wed, Jun 15, 2011 at 11:55:24AM -0700, stevek...@tigris.org wrote: > http://subversion.tigris.org/issues/show_bug.cgi?id=3922 > Issue #|3922 > Summary|pass client cert as stream to auth provider >Component|subversion > Version|tr

Re: 1.7.0 blocking issues / branching

2011-06-15 Thread C. Michael Pilato
On 06/15/2011 03:13 PM, Stefan Küng wrote: > On 14.06.2011 22:22, C. Michael Pilato wrote: > >> If anybody (ahem, Stefan Küng) is sitting on API improvements or >> requirements tracked solely in their heads, it's time to put them into the >> tracker. Please do not delay. > > Point taken :) > >

Re: 1.7.0 blocking issues / branching

2011-06-15 Thread Stefan Küng
On 14.06.2011 22:22, C. Michael Pilato wrote: If anybody (ahem, Stefan Küng) is sitting on API improvements or requirements tracked solely in their heads, it's time to put them into the tracker. Please do not delay. Point taken :) Filed the following issues: http://subversion.tigris.org/issu

Re: 1.7.0 blocking issues / branching

2011-06-15 Thread Stefan Sperling
On Wed, Jun 15, 2011 at 02:33:04PM -0400, Mark Phippard wrote: > Given that the most common distinction between alpha and beta is > "feature complete" I have been arguing all along that the existing > "alpha" release should have been labelled "beta". I would be +1 on > changing that for the next r

Re: svn propchange: r1136137 - svn:log

2011-06-15 Thread Hyrum K Wright
On Wed, Jun 15, 2011 at 6:36 PM, wrote: > Author: philip > Revision: 1136137 > Modified property: svn:log > > Modified: svn:log at Wed Jun 15 18:36:01 2011 > -- > --- svn:log (original) > +++ svn:log Wed Jun 15 18:36:01 2

Re: 1.7.0 blocking issues / branching

2011-06-15 Thread C. Michael Pilato
On 06/15/2011 02:23 PM, Greg Stein wrote: > I dunno what kind of review the alpha is getting. Moving it to "beta" > would get more users. Of course, we still wouldn't know what kind of > review it is getting, but I would say "more" :-) Yeah, I rather suspect that the alphas serve exactly one purpo

Re: 1.7.0 blocking issues / branching

2011-06-15 Thread Mark Phippard
On Wed, Jun 15, 2011 at 2:23 PM, Greg Stein wrote: > On Wed, Jun 15, 2011 at 14:18, Hyrum K Wright wrote: >> On Wed, Jun 15, 2011 at 4:40 PM, C. Michael Pilato >> wrote: >>> On 06/15/2011 12:36 PM, Greg Stein wrote: I would also request that should the serf issues be resolved during o

Re: 1.7.0 blocking issues / branching

2011-06-15 Thread Greg Stein
On Wed, Jun 15, 2011 at 14:18, Hyrum K Wright wrote: > On Wed, Jun 15, 2011 at 4:40 PM, C. Michael Pilato > wrote: >> On 06/15/2011 12:36 PM, Greg Stein wrote: >>> I would also request that should the serf issues be resolved during >>> our stabilization period, that we ship with the default as s

Re: svn commit: r1136137 - /subversion/trunk/subversion/libsvn_wc/workqueue.c

2011-06-15 Thread Greg Stein
On Wed, Jun 15, 2011 at 14:12, wrote: > Author: philip > Date: Wed Jun 15 18:12:20 2011 > New Revision: 1136137 > > URL: http://svn.apache.org/viewvc?rev=1136137&view=rev > Log: > Revert part of r1136038 as it is unnecessary.  Add some > SVN_DEBUG_WORK_QUEUE code. > > * subversion/libsvn_wc/workq

Re: 1.7.0 blocking issues / branching

2011-06-15 Thread Hyrum K Wright
On Wed, Jun 15, 2011 at 4:40 PM, C. Michael Pilato wrote: > On 06/15/2011 12:36 PM, Greg Stein wrote: >> I would also request that should the serf issues be resolved during >> our stabilization period, that we ship with the default as serf. ie. >> don't toss it because it may miss the branchpoint

Re: svn commit: r1136101 - /subversion/trunk/notes/api-changes-1.7.txt

2011-06-15 Thread C. Michael Pilato
On 06/15/2011 01:55 PM, Greg Stein wrote: > Yeah. I think we embedded content within XML using the quoprint style > when possible. It made them easier to read. ... but then we switched > to base64 or somesuch. I mean really... who needs to read this stuff? > :-P > > +1 to full deprecation. I thou

Re: svn commit: r1136101 - /subversion/trunk/notes/api-changes-1.7.txt

2011-06-15 Thread Greg Stein
On Wed, Jun 15, 2011 at 13:14, Bert Huijben wrote: > > >> -Original Message- >> From: julianf...@apache.org [mailto:julianf...@apache.org] >> Sent: woensdag 15 juni 2011 18:07 >> To: comm...@subversion.apache.org >> Subject: svn commit: r1136101 - /subversion/trunk/notes/api-changes- >> 1.

Re: svn commit: r1136114 - /subversion/trunk/configure.ac

2011-06-15 Thread Stefan Sperling
On Wed, Jun 15, 2011 at 06:28:28PM +0100, Philip Martin wrote: > Stefan Sperling writes: > >> Is cmp as portable as diff? Is it always available with the same > >> behaviour? autoconf generates calls to diff, so we know that using diff > >> will work anywhere that autoconf works. As far as I ca

Re: svn commit: r1136114 - /subversion/trunk/configure.ac

2011-06-15 Thread Greg Hudson
On Wed, 2011-06-15 at 13:28 -0400, Philip Martin wrote: > Do they all support -s? cmp -s is one of the most portable Unix command invocations in existence (from general knowledge; I can't give a reference).

Re: svn commit: r1136114 - /subversion/trunk/configure.ac

2011-06-15 Thread Philip Martin
Stefan Sperling writes: > On Wed, Jun 15, 2011 at 06:11:31PM +0100, Philip Martin wrote: >> pet...@apache.org writes: >> >> > Author: peters >> > Date: Wed Jun 15 16:43:24 2011 >> > New Revision: 1136114 >> > >> > URL: http://svn.apache.org/viewvc?rev=1136114&view=rev >> > Log: >> > * configure.

Re: svn commit: r1136114 - /subversion/trunk/configure.ac

2011-06-15 Thread Stefan Sperling
On Wed, Jun 15, 2011 at 06:11:31PM +0100, Philip Martin wrote: > pet...@apache.org writes: > > > Author: peters > > Date: Wed Jun 15 16:43:24 2011 > > New Revision: 1136114 > > > > URL: http://svn.apache.org/viewvc?rev=1136114&view=rev > > Log: > > * configure.ac: Followup r1134219: Use 'cmp -s' i

RE: svn commit: r1136101 - /subversion/trunk/notes/api-changes-1.7.txt

2011-06-15 Thread Bert Huijben
> -Original Message- > From: julianf...@apache.org [mailto:julianf...@apache.org] > Sent: woensdag 15 juni 2011 18:07 > To: comm...@subversion.apache.org > Subject: svn commit: r1136101 - /subversion/trunk/notes/api-changes- > 1.7.txt > > Author: julianfoad > Date: Wed Jun 15 16:06:44 20

Re: svn commit: r1136114 - /subversion/trunk/configure.ac

2011-06-15 Thread Philip Martin
pet...@apache.org writes: > Author: peters > Date: Wed Jun 15 16:43:24 2011 > New Revision: 1136114 > > URL: http://svn.apache.org/viewvc?rev=1136114&view=rev > Log: > * configure.ac: Followup r1134219: Use 'cmp -s' instead of 'diff' to >detect changes to svn_private_config.h. Take advantage

Re: diff wish

2011-06-15 Thread Johan Corveleyn
On Wed, Jun 15, 2011 at 5:41 PM, Greg Hudson wrote: > On Wed, 2011-06-15 at 11:30 -0400, Johan Corveleyn wrote: >> Okay, I guess we should then also rip out --ignore-space-change and >> --ignore-eol-style, and perhaps --show-c-function. Or, if it's >> preferred that ignore-space-change and ignore-

Re: API review - svn_dirent_uri.h

2011-06-15 Thread Greg Stein
On Wed, Jun 15, 2011 at 12:56, Julian Foad wrote: > On Wed, 2011-06-15, Greg Stein wrote: >> On Wed, Jun 15, 2011 at 12:32, Julian Foad wrote: >> > On Fri, 2011-06-10 at 09:06 +0100, Julian Foad wrote: >> >> I (Julian Foad) wrote: >> >> > On Thu, 2011-06-09, I (Julian Foad) wrote: >> >> > > svn_d

Re: API review - svn_dirent_uri.h

2011-06-15 Thread Julian Foad
On Wed, 2011-06-15, Greg Stein wrote: > On Wed, Jun 15, 2011 at 12:32, Julian Foad wrote: > > On Fri, 2011-06-10 at 09:06 +0100, Julian Foad wrote: > >> I (Julian Foad) wrote: > >> > On Thu, 2011-06-09, I (Julian Foad) wrote: > >> > > svn_dirent_uri.h > >> > > svn_relpath_internal_style() > >> >

Re: API review - svn_dirent_uri.h

2011-06-15 Thread Greg Stein
On Wed, Jun 15, 2011 at 12:52, Julian Foad wrote: > On Wed, 2011-06-15 at 12:42 -0400, Greg Stein wrote: >... > And this step of splitting _dirent_skip_ancestor into two variants with > the two different semantic meanings which are currently conflated - does > that now make sense to you as it does

Re: API review - svn_dirent_uri.h

2011-06-15 Thread Julian Foad
On Wed, 2011-06-15 at 12:42 -0400, Greg Stein wrote: > On Wed, Jun 15, 2011 at 12:32, Julian Foad wrote: > > On Fri, 2011-06-10 at 09:06 +0100, Julian Foad wrote: > >> I (Julian Foad) wrote: > >> > On Thu, 2011-06-09, I (Julian Foad) wrote: > >> > > svn_dirent_uri.h > >> > > svn_relpath_internal

Re: API review - svn_dirent_uri.h

2011-06-15 Thread C. Michael Pilato
On 06/15/2011 12:42 PM, Greg Stein wrote: > On Wed, Jun 15, 2011 at 12:32, Julian Foad wrote: >> Many callers of svn_dirent_skip_ancestor(), on the other hand, expect >> the 'child' input to be returned if it is not in fact a child. I am >> splitting the function into two: >> >> svn_dirent_skip_

Re: API change - make svn_tristate_to_word/_from_word() private?

2011-06-15 Thread Greg Stein
On Wed, Jun 15, 2011 at 10:14, Julian Foad wrote: > New in 1.7 in svn_types.h: >  svn_tristate_t >  svn_tristate_to_word()  # yields "true"/"false"/NULL >  svn_tristate_from_word()  # takes "true"/"yes"/"on"/.../ >... > At least, and at first, we should remove the second and third usages > listed

Re: 1.7.0 blocking issues / branching

2011-06-15 Thread Greg Stein
On Wed, Jun 15, 2011 at 12:40, C. Michael Pilato wrote: > On 06/15/2011 12:36 PM, Greg Stein wrote: >... >> I would also request that should the serf issues be resolved during >> our stabilization period, that we ship with the default as serf. ie. >> don't toss it because it may miss the branchpoi

Re: API review - svn_dirent_uri.h

2011-06-15 Thread Greg Stein
On Wed, Jun 15, 2011 at 12:32, Julian Foad wrote: > On Fri, 2011-06-10 at 09:06 +0100, Julian Foad wrote: >> I (Julian Foad) wrote: >> > On Thu, 2011-06-09, I (Julian Foad) wrote: >> > > svn_dirent_uri.h >> > >   svn_relpath_internal_style() >> > >   svn_relpath_local_style() >> > >     # These tw

Re: 1.7.0 blocking issues / branching

2011-06-15 Thread C. Michael Pilato
On 06/15/2011 12:36 PM, Greg Stein wrote: > On Tue, Jun 14, 2011 at 16:22, C. Michael Pilato wrote: >> I'm cautiously optimistic that we're approaching a branchable point, and >> just wanted to give a heads-up that the very second that I notice that there >> remain zero or Serf-only issues into th

Re: 1.7.0 blocking issues / branching

2011-06-15 Thread Greg Stein
On Tue, Jun 14, 2011 at 16:22, C. Michael Pilato wrote: > Our 1.7.0 blocking issues collection currently looks like so: > > 3875    Serf SEGV in pool handling on error > 3888    ra_serf unbound memory usage on checkout/export/update > 3899    Auto-resolve conflicts at wc-wc copy/move destination >

Re: API review - mod_*.h, svn_auth ... svn_hash.h

2011-06-15 Thread Julian Foad
An update on my observations on this batch of headers. I am updating to reflect this too. On Thu, 2011-06-09, I (Julian Foad) wrote: > svn_cache_config.h > # Why is the cache config header separate from the cache header? Was answered to my satisfaction. > svn_get_cache_config() > svn_set

Re: API review - svn_dirent_uri.h

2011-06-15 Thread Julian Foad
On Fri, 2011-06-10 at 09:06 +0100, Julian Foad wrote: > I (Julian Foad) wrote: > > On Thu, 2011-06-09, I (Julian Foad) wrote: > > > svn_dirent_uri.h > > > svn_relpath_internal_style() > > > svn_relpath_local_style() > > > # These two are inappropriate: only dirents have a 'local' style. > >

Re: diff wish

2011-06-15 Thread Morten Kloster
On Wed, Jun 15, 2011 at 1:08 AM, Johan Corveleyn wrote: > On Tue, Jun 14, 2011 at 5:33 PM, Stefan Sperling wrote: >> On Tue, Jun 14, 2011 at 05:21:27PM +0200, Neels J Hofmeyr wrote: >>> Hi Johan, >>> >>> it's been a while and I still haven't sent you my diff wish we briefly >>> touched on the Sub

Re: diff wish

2011-06-15 Thread Greg Hudson
On Wed, 2011-06-15 at 11:30 -0400, Johan Corveleyn wrote: > Okay, I guess we should then also rip out --ignore-space-change and > --ignore-eol-style, and perhaps --show-c-function. Or, if it's > preferred that ignore-space-change and ignore-eol-style be used by > default ("because humans are normal

Re: diff wish

2011-06-15 Thread Johan Corveleyn
2011/6/15 Branko Čibej : > On 15.06.2011 15:38, Johan Corveleyn wrote: >> 2011/6/15 Branko Čibej : >>> On 15.06.2011 14:11, Johan Corveleyn wrote: > If you have a different definition of "mis-synchronizes", please explain. No, I don't mean a broken diff. The diff should at all times be >>>

Re: diff wish

2011-06-15 Thread Julian Foad
Let's all take a breather and calm down before saying any more, shall we? - Julian

Re: diff wish

2011-06-15 Thread Johan Corveleyn
On Wed, Jun 15, 2011 at 5:15 PM, Greg Hudson wrote: > On Wed, 2011-06-15 at 09:38 -0400, Johan Corveleyn wrote: >> But I don't like the hand-waving discussion that it will always be >> superior, period. That's just not true. And it would be a big mistake, >> IMHO, to only support a heuristic diff.

Re: diff wish

2011-06-15 Thread Greg Hudson
On Wed, 2011-06-15 at 09:38 -0400, Johan Corveleyn wrote: > But I don't like the hand-waving discussion that it will always be > superior, period. That's just not true. And it would be a big mistake, > IMHO, to only support a heuristic diff. If it's a big mistake to use a "heuristic" diff by defau

Re: svn commit: r1136067 - /subversion/site/publish/download/download.html

2011-06-15 Thread C. Michael Pilato
On 06/15/2011 10:27 AM, rhuij...@apache.org wrote: > Author: rhuijben > Date: Wed Jun 15 14:27:45 2011 > New Revision: 1136067 > > URL: http://svn.apache.org/viewvc?rev=1136067&view=rev > Log: > * site/publish/download/download.html > Move the selected="selected" inside the start element for ftp

Re: API change - make svn_tristate_to_word/_from_word() private?

2011-06-15 Thread Daniel Shahaf
[ bcc stefan2 ] Julian Foad wrote on Wed, Jun 15, 2011 at 15:14:53 +0100: > New in 1.7 in svn_types.h: > svn_tristate_t > svn_tristate_to_word() # yields "true"/"false"/NULL > svn_tristate_from_word() # takes "true"/"yes"/"on"/.../ > > The _to/from_word() functions don't seem canonically

Re: [PATCH] Issue #3919: fix for spurious property conflict during merge

2011-06-15 Thread Stefan Sperling
On Wed, Jun 15, 2011 at 07:41:47AM -0500, Brian Neal wrote: > > Instead of doing nothing, I think this should set the *state to 'merged' > > using > > > >        set_prop_merge_state(state, svn_wc_notify_state_merged); > > > > Just like apply_single_prop_add() already does. > > > > Do you agree? If

Re: SVN 1.7.0. alpha source code

2011-06-15 Thread C. Michael Pilato
On 06/15/2011 03:39 AM, Tony Stevenson wrote: > I have also made sure it has been applied to the EU, and US mirrors. So > it should be live for all now. Looks good. Thanks, Tony. -- C. Michael Pilato CollabNet <> www.collab.net <> Distributed Development On Demand signature.asc Des

API change - make svn_tristate_to_word/_from_word() private?

2011-06-15 Thread Julian Foad
New in 1.7 in svn_types.h: svn_tristate_t svn_tristate_to_word() # yields "true"/"false"/NULL svn_tristate_from_word() # takes "true"/"yes"/"on"/.../ The _to/from_word() functions don't seem canonically purposed: some users want a single representation of the values, for use in on-the-wire

Re: diff wish

2011-06-15 Thread Branko Čibej
On 15.06.2011 15:38, Johan Corveleyn wrote: > 2011/6/15 Branko Čibej : >> On 15.06.2011 14:11, Johan Corveleyn wrote: If you have a different definition of "mis-synchronizes", please explain. >>> No, I don't mean a broken diff. The diff should at all times be >>> *correct*. That was indeed nev

Re: diff wish

2011-06-15 Thread Johan Corveleyn
2011/6/15 Branko Čibej : > On 15.06.2011 14:11, Johan Corveleyn wrote: >>> If you have a different definition of "mis-synchronizes", please explain. >> No, I don't mean a broken diff. The diff should at all times be >> *correct*. That was indeed never questioned. >> >> I mean something like the exa

Re: API change - rename svn_hash_get_cstring/bool() to svn_config_hash_get_*()

2011-06-15 Thread Julian Foad
n.b. These two functions are new in 1.7. - Julian On Wed, 2011-06-15 at 14:29 +0100, Julian Foad wrote: > A heads-up: I'm renaming svn_hash_get_bool() to > svn_config_hash_get_bool(), and svn_hash_get_cstring() to > svn_config_hash_get(), moving them from svn_hash.h to svn_config.h. > They are b

API change - rename svn_hash_get_cstring/bool() to svn_config_hash_get_*()

2011-06-15 Thread Julian Foad
A heads-up: I'm renaming svn_hash_get_bool() to svn_config_hash_get_bool(), and svn_hash_get_cstring() to svn_config_hash_get(), moving them from svn_hash.h to svn_config.h. They are being used only for config hashes, and don't seem like general-purpose hash functions. In particular, _get_bool() l

Re: [PATCH] Issue #3919: fix for spurious property conflict during merge

2011-06-15 Thread Philip Martin
Brian Neal writes: > I was wondering if you had unit/regression tests > but I did not see anything about that in the docs, although it is > quite possible I missed it. http://subversion.apache.org/docs/community-guide/building.html#automated-tests Short answer 'make check'. -- Philip

Re: diff wish

2011-06-15 Thread Julian Foad
Johan Corveleyn wrote: > On Wed, Jun 15, 2011 at 1:24 PM, Julian Foad wrote: > > On Wed, 2011-06-15 at 13:16 +0200, Johan Corveleyn wrote: > >> On Wed, Jun 15, 2011 at 12:53 PM, Stefan Sperling wrote: > >> But I'm not convinced that we should simply drop support for "minimal > >> diffs" [...] > >

Re: diff wish

2011-06-15 Thread Branko Čibej
On 15.06.2011 14:11, Johan Corveleyn wrote: >> If you have a different definition of "mis-synchronizes", please explain. > No, I don't mean a broken diff. The diff should at all times be > *correct*. That was indeed never questioned. > > I mean something like the example Neels gave with his initial

Re: [PATCH] Issue #3919: fix for spurious property conflict during merge

2011-06-15 Thread Brian Neal
Hi Stefan, > thanks for this patch. > > I have one suggestion: > > [...] > > Instead of doing nothing, I think this should set the *state to 'merged' > using > >        set_prop_merge_state(state, svn_wc_notify_state_merged); > > Just like apply_single_prop_add() already does. > > Do you agree? If

Re: diff wish

2011-06-15 Thread Johan Corveleyn
On Wed, Jun 15, 2011 at 1:24 PM, Julian Foad wrote: > On Wed, 2011-06-15 at 13:16 +0200, Johan Corveleyn wrote: >> On Wed, Jun 15, 2011 at 12:53 PM, Stefan Sperling wrote: >> > On Wed, Jun 15, 2011 at 12:34:31PM +0200, Branko Čibej wrote: >> >> I'd say not to worry about --minimal and --nice and

Re: [PATCH] Issue #3919: fix for spurious property conflict during merge

2011-06-15 Thread Stefan Sperling
On Sat, Jun 11, 2011 at 03:05:59PM -0500, Brian Neal wrote: > Hello - > > Attached is a patch for issue #3919 [1]. Please review when you have a > chance. Thanks! > > Possible commit message: > > [[[ > Fix issue #3919. During a merge of a property, add a check against the > incoming new property

AW: diff wish

2011-06-15 Thread Markus Schaber
Hi, Johan, Von: Johan Corveleyn [mailto:jcor...@gmail.com] > But I'm not convinced that we should simply drop support for "minimal > diffs" when we arrive at the point that we have a "nice" format. A "nice" > diff will always be based on heuristics, taking guesses at what should be > considered a

Re: diff wish

2011-06-15 Thread Julian Foad
On Wed, 2011-06-15 at 13:16 +0200, Johan Corveleyn wrote: > On Wed, Jun 15, 2011 at 12:53 PM, Stefan Sperling wrote: > > On Wed, Jun 15, 2011 at 12:34:31PM +0200, Branko Čibej wrote: > >> I'd say not to worry about --minimal and --nice and whatnot. Just make > >> diff output the sanest, nicest dif

Re: Fresh checkout vs 'svn upgrade': How good is good enough?

2011-06-15 Thread Johan Corveleyn
On Wed, Jun 15, 2011 at 1:52 AM, Philip Martin wrote: > Philip Martin writes: > >> Johan Corveleyn writes: >> >>> Also, has anyone tested this on an NFS-working copy? Or CIFS? >> >> Working copy on NFS, Linux client and server. >> >> Checkout using 1.6: >> Elapsed:  96s CPU: 16s >> >> Upgrade us

Re: diff wish

2011-06-15 Thread Johan Corveleyn
On Wed, Jun 15, 2011 at 12:53 PM, Stefan Sperling wrote: > On Wed, Jun 15, 2011 at 12:34:31PM +0200, Branko Čibej wrote: >> I'd say not to worry about --minimal and --nice and whatnot. Just make >> diff output the sanest, nicest diff it can find. I think it's a bad idea >> to give diff user-visibl

Re: diff wish

2011-06-15 Thread Stefan Sperling
On Wed, Jun 15, 2011 at 12:34:31PM +0200, Branko Čibej wrote: > I'd say not to worry about --minimal and --nice and whatnot. Just make > diff output the sanest, nicest diff it can find. I think it's a bad idea > to give diff user-visible options that change the output in ways that > are hard to exp

Re: svn commit: r1135635 - /subversion/trunk/subversion/libsvn_wc/props.c

2011-06-15 Thread Stefan Sperling
On Wed, Jun 15, 2011 at 12:22:13PM +0200, Bert Huijben wrote: > The problem for application builders is that you can't just get the property > here. > > You can get the new BASE version of the property and the new ACTUAL version > of the property (which is usually the old actual property on proper

Re: diff wish

2011-06-15 Thread Branko Čibej
On 15.06.2011 01:08, Johan Corveleyn wrote: > On Tue, Jun 14, 2011 at 5:33 PM, Stefan Sperling wrote: >> On Tue, Jun 14, 2011 at 05:21:27PM +0200, Neels J Hofmeyr wrote: >>> Hi Johan, >>> >>> it's been a while and I still haven't sent you my diff wish we briefly >>> touched on the Subversion hacka

RE: svn commit: r1135635 - /subversion/trunk/subversion/libsvn_wc/props.c

2011-06-15 Thread Bert Huijben
> -Original Message- > From: Stefan Sperling [mailto:s...@elego.de] > Sent: woensdag 15 juni 2011 12:12 > To: dev@subversion.apache.org > Subject: Re: svn commit: r1135635 - > /subversion/trunk/subversion/libsvn_wc/props.c > > On Wed, Jun 15, 2011 at 06:55:19AM +0300, Daniel Shahaf wrote

Re: svn commit: r1135635 - /subversion/trunk/subversion/libsvn_wc/props.c

2011-06-15 Thread Stefan Sperling
On Wed, Jun 15, 2011 at 06:55:19AM +0300, Daniel Shahaf wrote: > Daniel Shahaf wrote on Wed, Jun 15, 2011 at 06:33:46 +0300: > > s...@apache.org wrote on Tue, Jun 14, 2011 at 15:10:50 -: > > > + svn_stringbuf_appendcstr(buf, _("Local property value:\n")); > > > + if (mine_is_binary) >

FSFS caching doc strings

2011-06-15 Thread Julian Foad
Stefan2, I'm posting this attempt to add more detail to some of the FSFS caching doc strings. It's incomplete but I've had this sitting in my WC for a couple of weeks now and am unlikely to look deeper in the short term. [[[ Index: subversion/libsvn_fs_fs/fs.h

Re: SVN 1.7.0. alpha source code

2011-06-15 Thread Tony Stevenson
On Wed, Jun 15, 2011 at 04:25:07AM +0400, Konstantin Kolinko wrote: > Looking at the mirrors.cgi script at > /site/trunk/content/dyn/mirrors/mirrors.cgi at the above link, I > think there is a bug there. > > There is the following code fragment in parse_mirrors(): > > # Check if the requested