AW: Does fsfs revprop packing no longer allow usage of traditional backup software?

2011-07-01 Thread Markus Schaber
Hi, Daniel, Von: Daniel Shahaf [mailto:d...@daniel.shahaf.name] It should be easy to implement editing revprops without using SQLite: in case someone modify revprop non-packed revprop file is created, in read operation non-packed revprop file should be considered as more up-to-date. In

[PATCH] Re: svn commit: r1141447 - /subversion/branches/svn-bisect/BRANCH-MILESTONES

2011-07-01 Thread Prabhu Gnana Sundar
On Thursday 30 June 2011 08:19 PM, C. Michael Pilato wrote: On 06/30/2011 04:58 AM, ar...@apache.org wrote: Author: arwin Date: Thu Jun 30 08:58:11 2011 New Revision: 1141447 URL: http://svn.apache.org/viewvc?rev=1141447view=rev Log: Added branch milestones document. * BRANCH-MILESTONES : New

Re: svn commit: r1141845 - /subversion/trunk/subversion/mod_dav_svn/util.c

2011-07-01 Thread Ivan Zhakov
On Fri, Jul 1, 2011 at 11:15, i...@apache.org wrote: Author: ivan Date: Fri Jul  1 07:15:26 2011 New Revision: 1141845 URL: http://svn.apache.org/viewvc?rev=1141845view=rev Log: mod_dav_svn: Accept HTTPv2 style URIs in X-SVN-VR-Base header. This fixes problem that ra_serf client downloads

Re: svn commit: r1141683 - /subversion/branches/svn_mutex/

2011-07-01 Thread Stefan Fuhrmann
On 30.06.2011 22:21, Hyrum K Wright wrote: With such a tantalizing name, I look forward to seeing the BRANCH-README more fully explaining this branches purpose. Done in r1141868. -- Stefan^2. -Hyrum On Thu, Jun 30, 2011 at 2:43 PM,stef...@apache.org wrote: Author: stefan2 Date: Thu Jun 30

wc-ng and recoverability of corrupt wc's

2011-07-01 Thread Johan Corveleyn
Hi, Sometimes, a (part of a) working copy gets corrupted (errors like 'checksum mismatch ...' while running 'update'). Maybe it happened because a third-party tool has messed with the base files, or with the entries file, or ... or maybe it happened because of a bug in svn. This was/is deemed

Re: wc-ng and recoverability of corrupt wc's

2011-07-01 Thread Philip Martin
Johan Corveleyn jcor...@gmail.com writes: AFAICS, this will no longer be possible with wc-ng. Has anyone thought about this problem? Any ideas on how one could recover cheaply from a small (local to a single directory or file) corruption in the wc (either incorrect meta-data, or corrupt

Re: wc-ng and recoverability of corrupt wc's

2011-07-01 Thread Noorul Islam K M
Johan Corveleyn jcor...@gmail.com writes: Hi, Sometimes, a (part of a) working copy gets corrupted (errors like 'checksum mismatch ...' while running 'update'). Maybe it happened because a third-party tool has messed with the base files, or with the entries file, or ... or maybe it happened

Re: wc-ng and recoverability of corrupt wc's

2011-07-01 Thread Johan Corveleyn
On Fri, Jul 1, 2011 at 11:32 AM, Noorul Islam K M noo...@collab.net wrote: Johan Corveleyn jcor...@gmail.com writes: Hi, Sometimes, a (part of a) working copy gets corrupted (errors like 'checksum mismatch ...' while running 'update'). Maybe it happened because a third-party tool has messed

RE: Does fsfs revprop packing no longer allow usage of traditional backup software?

2011-07-01 Thread Bolstridge, Andrew
-Original Message- From: Peter Samuelson [mailto:pe...@p12n.org] Sent: 30 June 2011 23:58 To: dev@subversion.apache.org Subject: Re: Does fsfs revprop packing no longer allow usage of traditional backup software? [Hyrum K Wright] I like this idea, but it would seem to

[PATCH] Follow-up to r1141600: Update a deprecated function call

2011-07-01 Thread vijay
Hi, This is follow-up to r1141600. This patch updates a deprecated function call in libsvn_repos/repos.c. Attaching the patch and log. Thanks Regards, Vijayaguru Index: subversion/libsvn_repos/repos.c === ---

Issue #3690 - svn log with ignore property changes

2011-07-01 Thread Noorul Islam K M
I am revisiting this issue after 6 months. I stopped working on this because everyone was busy working towards 1.7 release. The then thread was getting little attention. Link to the issue is http://subversion.tigris.org/issues/show_bug.cgi?id=3690 and following is the initial comment in the

Re: Does fsfs revprop packing no longer allow usage of traditional backup software?

2011-07-01 Thread Daniel Shahaf
Markus Schaber wrote on Fri, Jul 01, 2011 at 08:51:43 +0200: Hi, Daniel, Von: Daniel Shahaf [mailto:d...@daniel.shahaf.name] It should be easy to implement editing revprops without using SQLite: in case someone modify revprop non-packed revprop file is created, in read operation

do away with db/revprops/*/, and a question about 'upgrade' concurrency (was: Re: Does fsfs revprop packing no longer allow usage of traditional backup software?)

2011-07-01 Thread Daniel Shahaf
Hyrum K Wright wrote on Thu, Jun 30, 2011 at 16:33:16 -0500: On Thu, Jun 30, 2011 at 3:27 PM, Peter Samuelson pe...@p12n.org wrote: [Ivan Zhakov] It should be easy to implement editing revprops without using SQLite: in case someone modify revprop non-packed revprop file is created, in

Re: revprop packing: why aren't _all_ revprops packed?

2011-07-01 Thread Daniel Shahaf
I replied elsethread (basically saying +1). I'll also go ahead and file a 1.7 blocker issue for the improvements suggested in this thread. (All of them require changing the f5 format, and will require more headache if they have to be done as f6 on top of current f5) Peter Samuelson wrote on

Re: revprop packing: why aren't _all_ revprops packed?

2011-07-01 Thread Mark Phippard
On Thu, Jun 30, 2011 at 5:21 PM, Peter Samuelson pe...@p12n.org wrote: [kmra...@rockwellcollins.com] I would love to have revprop packing, but not at the cost of potentially disabling the use of traditional backup software. Is there a way to disable fsfs revprop packing, or at least have it

Re: revprop packing: why aren't _all_ revprops packed?

2011-07-01 Thread Daniel Shahaf
http://subversion.tigris.org/issues/show_bug.cgi?id=3944 Daniel Shahaf wrote on Fri, Jul 01, 2011 at 16:07:55 +0300: I'll also go ahead and file a 1.7 blocker issue for the improvements suggested in this thread. (All of them require changing the f5 format, and will require more headache if

Re: revprop packing: why aren't _all_ revprops packed?

2011-07-01 Thread Daniel Shahaf
Mark Phippard wrote on Fri, Jul 01, 2011 at 09:10:31 -0400: On Thu, Jun 30, 2011 at 5:21 PM, Peter Samuelson pe...@p12n.org wrote: [kmra...@rockwellcollins.com] I would love to have revprop packing, but not at the cost of potentially disabling the use of traditional backup software.

Re: revprop packing: why aren't _all_ revprops packed?

2011-07-01 Thread Mark Phippard
On Fri, Jul 1, 2011 at 9:22 AM, Daniel Shahaf danie...@elego.de wrote: Mark Phippard wrote on Fri, Jul 01, 2011 at 09:10:31 -0400: On Thu, Jun 30, 2011 at 5:21 PM, Peter Samuelson pe...@p12n.org wrote: [kmra...@rockwellcollins.com] I would love to have revprop packing, but not at the cost

Re: Issue 3930 - Subversion, libtool, APR, and all the junk in-between

2011-07-01 Thread Philip Martin
I plan to apply the second patch in the issue, it restores the 1.6 libtool detection and fixes the the --with-experimental-libtool problem. The code did require maintenance in the past, and may require maintenance in the future, but it hasn't required any maintenance in the last three years on

RE: svn commit: r1141845 - /subversion/trunk/subversion/mod_dav_svn/util.c

2011-07-01 Thread Bert Huijben
-Original Message- From: i...@visualsvn.com [mailto:i...@visualsvn.com] On Behalf Of Ivan Zhakov Sent: vrijdag 1 juli 2011 10:05 To: Subversion Development Subject: Re: svn commit: r1141845 - /subversion/trunk/subversion/mod_dav_svn/util.c On Fri, Jul 1, 2011 at 11:15,

Re: revprop packing: why aren't _all_ revprops packed?

2011-07-01 Thread Daniel Shahaf
[ strictly speaking I'm not addressing /all/ your points, if I missed any feel free to re-raise them ] Mark Phippard wrote on Fri, Jul 01, 2011 at 09:27:57 -0400: On Fri, Jul 1, 2011 at 9:22 AM, Daniel Shahaf danie...@elego.de wrote: Mark Phippard wrote on Fri, Jul 01, 2011 at 09:10:31 -0400:

Re: svn commit: r1141868 - /subversion/branches/svn_mutex/BRANCH-README

2011-07-01 Thread Daniel Shahaf
stef...@apache.org wrote on Fri, Jul 01, 2011 at 08:34:20 -: Author: stefan2 Date: Fri Jul 1 08:34:20 2011 New Revision: 1141868 URL: http://svn.apache.org/viewvc?rev=1141868view=rev Log: On the svn_mutex branch, add a readme as requested. * BRANCH-README: new file Added:

Re: Does fsfs revprop packing no longer allow usage of traditional backup software?

2011-07-01 Thread Peter Samuelson
Especially since the common case, as you put it, is that the open() returns ENOENT, file not found.  _That_ case may or may not be expensive, but it's quite different from the usual consideration of whether stat() is expensive.  Not least because stat() is usually considered in context

Re: wc-ng and recoverability of corrupt wc's

2011-07-01 Thread Daniel Shahaf
Philip Martin wrote on Fri, Jul 01, 2011 at 10:26:34 +0100: Johan Corveleyn jcor...@gmail.com writes: AFAICS, this will no longer be possible with wc-ng. Has anyone thought about this problem? Any ideas on how one could recover cheaply from a small (local to a single directory or file)

Re: do away with db/revprops/*/, and a question about 'upgrade' concurrency

2011-07-01 Thread Philip Martin
Daniel Shahaf danie...@elego.de writes: Unrelated question: how do we handle the case of a client, linked to libsvn_fs 1.6, that opens an svn_fs_t object and then, concurrently, someone runs 'svnadmin1.7 upgrade'? The FS object is now invalid (and must be closed), but would the old client

Re: wc-ng and recoverability of corrupt wc's

2011-07-01 Thread Philip Martin
Daniel Shahaf d...@daniel.shahaf.name writes: Philip Martin wrote on Fri, Jul 01, 2011 at 10:26:34 +0100: Corrupt pristine can be recovered by doing: $ svn up -r0 wc/some/path $ svn up wc That will also work for some, but by no means all, instances of corrupt metadata. And 'svn up

Re: Does fsfs revprop packing no longer allow usage of traditional backup software?

2011-07-01 Thread Ivan Zhakov
On Fri, Jul 1, 2011 at 19:04, Peter Samuelson pe...@p12n.org wrote: Especially since the common case, as you put it, is that the open() returns ENOENT, file not found.  _That_ case may or may not be expensive, but it's quite different from the usual consideration of whether stat() is

Re: Does fsfs revprop packing no longer allow usage of traditional backup software?

2011-07-01 Thread Peter Samuelson
[Bolstridge, Andrew] Ok, but a) why can't the list of unpacked revprop files be cached at startup and updated as revprops are edited. Because there's more than one server process. I have a repository at work that is accessed over file://, svn://, and https://. (Someone used to use svn+ssh://

Re: Issue 3930 - Subversion, libtool, APR, and all the junk in-between

2011-07-01 Thread C. Michael Pilato
On 07/01/2011 09:56 AM, Philip Martin wrote: I plan to apply the second patch in the issue, it restores the 1.6 libtool detection and fixes the the --with-experimental-libtool problem. There's a Nike slogan which comes to mind right about now... -- C. Michael Pilato cmpil...@collab.net

Re: do away with db/revprops/*/, and a question about 'upgrade' concurrency (was: Re: Does fsfs revprop packing no longer allow usage of traditional backup software?)

2011-07-01 Thread Hyrum K Wright
On Fri, Jul 1, 2011 at 8:05 AM, Daniel Shahaf danie...@elego.de wrote: Hyrum K Wright wrote on Thu, Jun 30, 2011 at 16:33:16 -0500: On Thu, Jun 30, 2011 at 3:27 PM, Peter Samuelson pe...@p12n.org wrote: [Ivan Zhakov] It should be easy to implement editing revprops without using SQLite:

Re: do away with db/revprops/*/, and a question about 'upgrade' concurrency (was: Re: Does fsfs revprop packing no longer allow usage of traditional backup software?)

2011-07-01 Thread Daniel Shahaf
Hyrum K Wright wrote on Fri, Jul 01, 2011 at 11:21:58 -0500: On Fri, Jul 1, 2011 at 8:05 AM, Daniel Shahaf danie...@elego.de wrote: Hyrum K Wright wrote on Thu, Jun 30, 2011 at 16:33:16 -0500: On Thu, Jun 30, 2011 at 3:27 PM, Peter Samuelson pe...@p12n.org wrote: [Ivan Zhakov] It

Re: API review - svn_ra_get_mergeinfo2()

2011-07-01 Thread Paul Burba
On Wed, Jun 29, 2011 at 11:16 AM, Paul Burba ptbu...@gmail.com wrote: On Wed, Jun 29, 2011 at 4:48 AM, Julian Foad julian.f...@wandisco.com wrote: On Tue, 2011-06-28, C. Michael Pilato wrote: On 06/28/2011 01:37 PM, Paul Burba wrote: Hi Julian, I hadn't realized using in-out parameters

Re: svn commit: r1141981 - in /subversion/trunk/subversion: include/ libsvn_client/ libsvn_ra/ libsvn_ra_local/ libsvn_ra_neon/ libsvn_ra_serf/ libsvn_ra_svn/ mod_dav_svn/ mod_dav_svn/reports/ svnserv

2011-07-01 Thread Daniel Shahaf
pbu...@apache.org wrote on Fri, Jul 01, 2011 at 16:31:22 -: Author: pburba Date: Fri Jul 1 16:31:21 2011 New Revision: 1141981 URL: http://svn.apache.org/viewvc?rev=1141981view=rev Log: Get svn_ra_get_mergeinfo2 out of the business of communicating server capabilities via an in-out

Re: svn commit: r1141845 - /subversion/trunk/subversion/mod_dav_svn/util.c

2011-07-01 Thread Ivan Zhakov
On Fri, Jul 1, 2011 at 18:14, Bert Huijben b...@qqmail.nl wrote: -Original Message- From: i...@visualsvn.com [mailto:i...@visualsvn.com] On Behalf Of Ivan Zhakov Sent: vrijdag 1 juli 2011 10:05 To: Subversion Development Subject: Re: svn commit: r1141845 -

Re: Does fsfs revprop packing no longer allow usage of traditional backup software?

2011-07-01 Thread Peter Samuelson
2011/7/1 Peter Samuelson pe...@p12n.org: If this is too much trouble, b) why not write a list of edited revprop files to a single file instead (...) Opening, reading, and parsing this file isn't going to be cheaper than a _single_ attempt to open a revprop file that does not exist.

RE: svn commit: r1141845 - /subversion/trunk/subversion/mod_dav_svn/util.c

2011-07-01 Thread Bert Huijben
Passing just the revision is not enough to allow the server to provide the svndiff. It really needs the fspath and the revision (or the update report) to fetch the base revision for a path in a separate (stateless) request while supporting switched paths. Bert Huijben (Cell phone) From: Ivan

Re: do away with db/revprops/*/, and a question about 'upgrade' concurrency (was: Re: Does fsfs revprop packing no longer allow usage of traditional backup software?)

2011-07-01 Thread Peter Samuelson
[Hyrum K Wright] My understanding would be that we'd pack revprops just like we pack revision (one single concat'd file per shard), and then store any edits in separate files. We'd then repack the edits into the pack files when an admin subsequently runs 'svnadmin pack'. Aside from the

Re: do away with db/revprops/*/, and a question about 'upgrade' concurrency (was: Re: Does fsfs revprop packing no longer allow usage of traditional backup software?)

2011-07-01 Thread Daniel Shahaf
Daniel Shahaf wrote on Fri, Jul 01, 2011 at 19:29:50 +0300: Hyrum K Wright wrote on Fri, Jul 01, 2011 at 11:21:58 -0500: On Fri, Jul 1, 2011 at 8:05 AM, Daniel Shahaf danie...@elego.de wrote: Hyrum K Wright wrote on Thu, Jun 30, 2011 at 16:33:16 -0500: On Thu, Jun 30, 2011 at 3:27 PM,

Re: do away with db/revprops/*/, and a question about 'upgrade' concurrency (was: Re: Does fsfs revprop packing no longer allow usage of traditional backup software?)

2011-07-01 Thread Daniel Shahaf
Daniel Shahaf wrote on Fri, Jul 01, 2011 at 21:30:15 +0300: Daniel Shahaf wrote on Fri, Jul 01, 2011 at 19:29:50 +0300: Hyrum K Wright wrote on Fri, Jul 01, 2011 at 11:21:58 -0500: On Fri, Jul 1, 2011 at 8:05 AM, Daniel Shahaf danie...@elego.de wrote: Hyrum K Wright wrote on Thu, Jun 30,

Re: svn propchange: r1141981 - svn:log

2011-07-01 Thread Daniel Shahaf
Thanks. (And sorry for the tone/implication in the previous email) pbu...@apache.org wrote on Fri, Jul 01, 2011 at 18:19:07 -: Author: pburba Revision: 1141981 Modified property: svn:log Modified: svn:log at Fri Jul 1 18:19:07 2011

Re: svn commit: r1142026 - in /subversion/branches/svn_mutex/subversion: include/private/svn_mutex.h libsvn_subr/svn_mutex.c

2011-07-01 Thread Blair Zajac
On Jul 1, 2011, at 12:04 PM, stef...@apache.org wrote: Author: stefan2 Date: Fri Jul 1 19:04:29 2011 New Revision: 1142026 URL: http://svn.apache.org/viewvc?rev=1142026view=rev Log: Introduce the svn_mutex API and implement it * subversion/include/private/svn_mutex.h new private

Re: svn commit: r1141981 - in /subversion/trunk/subversion: include/ libsvn_client/ libsvn_ra/ libsvn_ra_local/ libsvn_ra_neon/ libsvn_ra_serf/ libsvn_ra_svn/ mod_dav_svn/ mod_dav_svn/reports/ svnserv

2011-07-01 Thread Paul Burba
On Fri, Jul 1, 2011 at 1:14 PM, Daniel Shahaf d...@daniel.shahaf.name wrote: pbu...@apache.org wrote on Fri, Jul 01, 2011 at 16:31:22 -: Author: pburba Date: Fri Jul  1 16:31:21 2011 New Revision: 1141981 URL: http://svn.apache.org/viewvc?rev=1141981view=rev Log: Get

Re: svn propchange: r1141981 - svn:log

2011-07-01 Thread Paul Burba
On Fri, Jul 1, 2011 at 3:03 PM, Daniel Shahaf d...@daniel.shahaf.name wrote: Thanks.  (And sorry for the tone/implication in the previous email) No offense taken Daniel, the log message was wrong after all. Regardless, it's the Friday before a long weekend here, so not much is going to bother me

Re: svn commit: r1142088 - /subversion/trunk/subversion/libsvn_wc/workqueue.c

2011-07-01 Thread Daniel Shahaf
Daniel Shahaf wrote on Fri, Jul 01, 2011 at 23:46:54 +0300: rhuij...@apache.org wrote on Fri, Jul 01, 2011 at 20:42:37 -: Author: rhuijben Date: Fri Jul 1 20:42:36 2011 New Revision: 1142088 URL: http://svn.apache.org/viewvc?rev=1142088view=rev Log: When renaming a file in

'svn up -r0' doesn't.

2011-07-01 Thread Daniel Shahaf
Philip mentioned 'svn up -r0' in another thread. I did: [[[ % $svn checkout --depth=empty https://svn.eu.apache.org/repos/infra/infrastructure infra-freshwc % cd infra-freshwc % $svn up --set-depth=immediates . subdir1 subdir2 % $svn up --set-depth=infinity subdir3 trunk % cd trunk % $svn up

Re: svn commit: r1142026 - in /subversion/branches/svn_mutex/subversion: include/private/svn_mutex.h libsvn_subr/svn_mutex.c

2011-07-01 Thread Greg Stein
On Fri, Jul 1, 2011 at 15:04, stef...@apache.org wrote: ... +++ subversion/branches/svn_mutex/subversion/include/private/svn_mutex.h Fri Jul  1 19:04:29 2011 ... +#ifndef SVN_MUTEX_H +#define SVN_MUTEX_H + +#include apr_thread_mutex.h +#include svn_error.h Typical style is to put blank

Re: svn commit: r1142130 - in /subversion/branches/svn_mutex/subversion/libsvn_fs_fs: fs.c fs.h fs_fs.c

2011-07-01 Thread Blair Zajac
On Jul 1, 2011, at 5:27 PM, stef...@apache.org wrote: Author: stefan2 Date: Sat Jul 2 00:27:28 2011 New Revision: 1142130 URL: http://svn.apache.org/viewvc?rev=1142130view=rev Log: Replace usage of plain APR thread mutex API with the new svn_mutex API in FSFS. -#if APR_HAS_THREADS -