Re: svn commit: r1209610 - /subversion/trunk/subversion/libsvn_subr/debug.c

2012-01-07 Thread Johan Corveleyn
On Sat, Jan 7, 2012 at 7:14 PM, Greg Stein wrote: > > On Jan 7, 2012 8:39 AM, "Johan Corveleyn" wrote: >>... > >> BTW, I noticed that, before r1209610, my release build was failing for >> another reason: >> >> ..\..\..\subversion\libsvn_subr\debug.c(111): error C4013: 'SVN_DBG' >> undefined; assu

Re: svn commit: r1209610 - /subversion/trunk/subversion/libsvn_subr/debug.c

2012-01-07 Thread Greg Stein
On Jan 7, 2012 8:39 AM, "Johan Corveleyn" wrote: >... > On Sat, Jan 7, 2012 at 10:30 AM, Bert Huijben wrote: > > This patch broke the debug shared library builds on Windows. > > Release and/or static builds still work. > > > > Note that a similar patch was applied and later reverted last year for

Re: svn commit: r1209610 - /subversion/trunk/subversion/libsvn_subr/debug.c

2012-01-07 Thread Johan Corveleyn
> From: Johan Corveleyn > Sent: 6-1-2012 23:50 > To: Daniel Shahaf > Cc: Subversion Development; Hyrum Wright > Subject: Re: svn commit: r1209610 > - /subversion/trunk/subversion/libsvn_subr/debug.c > On Fri, Jan 6, 2012 at 2:45 AM, Daniel Shahaf wrote: >> Johan Corveleyn wrote on Fri, Jan 06, 201

Re: svn commit: r1224647 - in /subversion/trunk/subversion: include/svn_string.h libsvn_fs_base/id.c libsvn_fs_fs/fs_fs.c libsvn_fs_fs/id.c libsvn_fs_fs/tree.c libsvn_ra_neon/session.c libsvn_ra_serf/

2012-01-07 Thread Julian Foad
Travis wrote: > stef...@apache.org wrote on Sun, Dec 25, 2011 at 21:40:37 -: >> +    if (csep == '\0' || sep[2] != '\0') >> +      return apr_strtok(NULL, sep, str); > > Entirely possible that I'm not understanding, but shouldn't that be > >   sep[1] != '\0' Yes; that's already been fixed

RE: svn commit: r1209610 - /subversion/trunk/subversion/libsvn_subr/debug.c

2012-01-07 Thread Bert Huijben
This patch broke the debug shared library builds on Windows. Release and/or static builds still work. Note that a similar patch was applied and later reverted last year for exactly the same reason. I think this patch should be reverted again. Bert Huijben (Cell phone) From: Johan Corveleyn Sent: