On Tue, Jan 24, 2012 at 5:58 AM, Trent Nelson tr...@snakebite.org wrote:
On Jan 24, 2012, at 12:11 AM, Daniel Shahaf wrote:
Trent Nelson wrote on Mon, Jan 23, 2012 at 15:07:20 -0500:
Fix a memory leak in convert_rangelist by *always* Py_DECREF'ing the object
returned by convert_to_swigtype
Trent Nelson wrote on Mon, Jan 23, 2012 at 15:07:20 -0500:
Fix a memory leak in convert_rangelist by *always* Py_DECREF'ing the object
returned by convert_to_swigtype (a SWIG wrapper around svn_merge_range_t)
once we've established it's not NULL.
This is required because PyList_Append takes
A few comments on the testsuite part of the patch.
First, I intend to test the patch using the attached pastebin script by
Trent, in addition to 'make check'.
Second:
Trent Nelson wrote on Mon, Jan 23, 2012 at 15:07:20 -0500:
Index: subversion/bindings/swig/python/tests/mergeinfo.py
Johan Corveleyn jcor...@gmail.com writes:
On Mon, Jan 23, 2012 at 4:28 PM, Philip Martin
philip.mar...@wandisco.com wrote:
Is that sufficient? Given three files foo, FOO and Foo, one in
wc.db, one on disk and one on the command line, is that the same file?
Add another fOO to the database.
Philip Martin wrote on Tue, Jan 24, 2012 at 13:45:49 +:
Johan Corveleyn jcor...@gmail.com writes:
On Mon, Jan 23, 2012 at 4:28 PM, Philip Martin
philip.mar...@wandisco.com wrote:
Is that sufficient? Given three files foo, FOO and Foo, one in
wc.db, one on disk and one on the
On Tue, Jan 24, 2012 at 1:54 PM, Daniel Shahaf danie...@elego.de wrote:
Philip Martin wrote on Tue, Jan 24, 2012 at 13:45:49 +:
Johan Corveleyn jcor...@gmail.com writes:
On Mon, Jan 23, 2012 at 4:28 PM, Philip Martin
philip.mar...@wandisco.com wrote:
Is that sufficient? Given three
Hyrum K Wright wrote on Tue, Jan 24, 2012 at 13:57:28 +:
On Tue, Jan 24, 2012 at 1:54 PM, Daniel Shahaf danie...@elego.de wrote:
Philip Martin wrote on Tue, Jan 24, 2012 at 13:45:49 +:
Johan Corveleyn jcor...@gmail.com writes:
On Mon, Jan 23, 2012 at 4:28 PM, Philip Martin
On Tue, Jan 24, 2012 at 2:45 PM, Philip Martin
philip.mar...@wandisco.com wrote:
Johan Corveleyn jcor...@gmail.com writes:
On Mon, Jan 23, 2012 at 4:28 PM, Philip Martin
philip.mar...@wandisco.com wrote:
Is that sufficient? Given three files foo, FOO and Foo, one in
wc.db, one on disk and
On Tue, Jan 24, 2012 at 3:03 PM, Daniel Shahaf danie...@elego.de wrote:
Hyrum K Wright wrote on Tue, Jan 24, 2012 at 13:57:28 +:
On Tue, Jan 24, 2012 at 1:54 PM, Daniel Shahaf danie...@elego.de wrote:
Philip Martin wrote on Tue, Jan 24, 2012 at 13:45:49 +:
Johan Corveleyn
Daniel Shahaf danie...@elego.de writes:
Given three files foo, FOO and Foo, one in
wc.db, one on disk and one on the command line, is that the same file?
My understanding is that a Windows user expects those to be the same
file. So svn st FOO, svn st foo and svn st Foo all refer to the
Daniel Shahaf wrote on Tue, Jan 24, 2012 at 13:36:07 +0200:
Trent Nelson wrote on Mon, Jan 23, 2012 at 15:07:20 -0500:
Fix a memory leak in convert_rangelist by *always* Py_DECREF'ing the object
returned by convert_to_swigtype (a SWIG wrapper around svn_merge_range_t)
once we've established
On Tue, Jan 24, 2012 at 03:44:04AM -0800, Daniel Shahaf wrote:
Trent Nelson wrote on Mon, Jan 23, 2012 at 15:07:20 -0500:
Index: subversion/bindings/swig/python/tests/mergeinfo.py
===
---
Trent Nelson wrote on Tue, Jan 24, 2012 at 10:17:24 -0500:
On Tue, Jan 24, 2012 at 03:44:04AM -0800, Daniel Shahaf wrote:
Trent Nelson wrote on Mon, Jan 23, 2012 at 15:07:20 -0500:
Index: subversion/bindings/swig/python/tests/mergeinfo.py
On 01/21/2012 09:05 AM, Ivan Zhakov wrote:
On Thu, Jan 19, 2012 at 03:23, Paul Burba ptbu...@gmail.com wrote:
Yeah, I've been thinking about this. As you say, the solution for our
own inheritable properties is simple. Since Subversion already
reserves properties beginning with svn: for its
On 01/21/2012 09:05 AM, Ivan Zhakov wrote:
On Thu, Jan 19, 2012 at 03:23, Paul Burba ptbu...@gmail.com wrote:
Yeah, I've been thinking about this. As you say, the solution for our
own inheritable properties is simple. Since Subversion already
reserves properties beginning with svn: for its
On Tue, Jan 24, 2012 at 1:18 AM, Johan Corveleyn jcor...@gmail.com wrote:
[ ... ]
I'd like to note though that #4023 is also potentially an issue for
svn 1.7 (pre-wcng). At least if you're thinking about
non-commandline usage. As of #3865, one can now also run into this
situation with the
On Jan 25, 2012, at 1:47 , Johan Corveleyn wrote:
Just to confirm this point: I've been able to reproduce #4023 (or a
variation thereof) with TortoiseSVN 1.6:
- Add 'foo' as a versioned file. Commit.
- Delete 'foo' from filesystem (non-svn delete).
- Create new file 'FOO'.
-
17 matches
Mail list logo