Re: Why do we check the base checksum so often?

2012-02-04 Thread Greg Hudson
On 02/04/2012 08:02 PM, Hyrum K Wright wrote: > I don't know if apr has a sha256 implementation, but it wouldn't be hard to > find one. I'll point out that we're nearing the end of a selection process for SHA-3, with a winner expected to be announced some time this year. The winner may wind up b

Re: Why do we check the base checksum so often?

2012-02-04 Thread Hyrum K Wright
On Sat, Feb 4, 2012 at 4:12 PM, Bert Huijben wrote: > We already assume Sha-1 is unique in wc-Ng, so introducing sha256 would > not help. Well, it wouldn't be difficult to bump the wc version and recompute sha256s for all the pristines. I'm not advocating that course of action, just saying it wo

RE: Why do we check the base checksum so often?

2012-02-04 Thread Bert Huijben
We already assume Sha-1 is unique in wc-Ng, so introducing sha256 would not help. It is also much more expensive to obtain then sha1 and md5. Bert Huijben (Cell phone) From: Hyrum K Wright Sent: 4-2-2012 10:51 To: Bert Huijben Cc: Julian Foad; Subversion Development Subject: Re: Why do we check th

Re: broke the shims (was: svn commit: r1240370 ...)

2012-02-04 Thread Hyrum K Wright
As of r1240597, I think everything is back to functional. (Only 15 test failures with the shims enabled.) -Hyrum On Fri, Feb 3, 2012 at 4:21 PM, Hyrum K Wright wrote: > No problem.  I'll take a look at it over the weekend. > > -Hyrum > > On Fri, Feb 3, 2012 at 4:15 PM, Greg Stein wrote: >> Hyr

Re: Why do we check the base checksum so often?

2012-02-04 Thread Branko Čibej
On 04.02.2012 19:51, Hyrum K Wright wrote: > On Sat, Feb 4, 2012 at 11:06 AM, Bert Huijben wrote: >> We could change that for Ev2 but how are you going to change Subversion >> 1.0-1.7? >> >> Can I borrow your time-machine? ;-) >> >> Md5 is not unique enough to pick a base. > Is SHA-1 sufficient?

Re: Why do we check the base checksum so often?

2012-02-04 Thread Hyrum K Wright
On Sat, Feb 4, 2012 at 11:06 AM, Bert Huijben wrote: > We could change that for Ev2 but how are you going to change Subversion > 1.0-1.7? > > Can I borrow your time-machine? ;-) > > Md5 is not unique enough to pick a base. Is SHA-1 sufficient? Should we be using SHA-256 to identify content in Ev

Re: Why do we check the base checksum so often?

2012-02-04 Thread Hyrum K Wright
On Sat, Feb 4, 2012 at 10:59 AM, Julian Foad wrote: > Hyrum K Wright wrote: > >> Julian Foad wrote: >>>  Hyrum K Wright wrote:  The Ev2 shims get in the way of how text deltas are transmitted, by  reconstituting the full text, and then just streaming that to the  receiver via svn_tx

RE: Why do we check the base checksum so often?

2012-02-04 Thread Bert Huijben
We could change that for Ev2 but how are you going to change Subversion 1.0-1.7? Can I borrow your time-machine? ;-) Md5 is not unique enough to pick a base. Bert Huijben (Cell phone) From: Hyrum K Wright Sent: 4-2-2012 7:46 To: Julian Foad Cc: Subversion Development Subject: Re: Why do we check

Re: Why do we check the base checksum so often?

2012-02-04 Thread Julian Foad
Hyrum K Wright wrote: > Julian Foad wrote: >> Hyrum K Wright wrote: >>> The Ev2 shims get in the way of how text deltas are transmitted, by >>> reconstituting the full text, and then just streaming that to the >>> receiver via svn_txdelta_send_stream().  I've got a patch which >>> actually st

Re: Why do we check the base checksum so often?

2012-02-04 Thread Hyrum K Wright
On Sat, Feb 4, 2012 at 9:36 AM, Julian Foad wrote: > Hyrum K Wright wrote: > >> The Ev2 shims get in the way of how text deltas are transmitted, by >> reconstituting the full text, and then just streaming that to the >> receiver via svn_txdelta_send_stream().  I've got a patch which >> actually st

Re: Why do we check the base checksum so often?

2012-02-04 Thread Julian Foad
Hyrum K Wright wrote: > The Ev2 shims get in the way of how text deltas are transmitted, by > reconstituting the full text, and then just streaming that to the > receiver via svn_txdelta_send_stream().  I've got a patch which > actually starts reporting the base checksum---which with the shims > w

RE: Why do we check the base checksum so often?

2012-02-04 Thread Bert Huijben
> -Original Message- > From: Hyrum K Wright [mailto:hyrum.wri...@wandisco.com] > Sent: zaterdag 4 februari 2012 6:04 > To: Subversion Development > Subject: Why do we check the base checksum so often? > > The Ev2 shims get in the way of how text deltas are transmitted, by > reconstitutin

Why do we check the base checksum so often?

2012-02-04 Thread Hyrum K Wright
The Ev2 shims get in the way of how text deltas are transmitted, by reconstituting the full text, and then just streaming that to the receiver via svn_txdelta_send_stream(). I've got a patch which actually starts reporting the base checksum---which with the shims will always be the "empty" checksu

Re: Let's discuss about unicode compositions for filenames!

2012-02-04 Thread Hiroaki Nakamura
2012/2/3 Julian Foad : > You may well be correct that NFC is never longer than NFD, but that's not the > question.  The question is whether NFC may be longer than the current paths > (which are not normalized to normalization form C or to form D).  And the > answer is yes it may be longer.  See