Re: svn commit: r1345740 - /subversion/trunk/subversion/libsvn_auth_kwallet/kwallet.cpp

2012-06-03 Thread Greg Stein
On Jun 3, 2012 6:42 PM, "Peter Samuelson" wrote: > > > [Greg Stein] > > > - int argc = 1; > > > - app = new QCoreApplication(argc, (char *[1]) {(char *) "svn"}); > > > + int argc = q_argc; > > > + app = new QCoreApplication(argc, q_argv); > > > > Why keep argc around? Just use

[svnbench] Revision: 1345809 compiled Jun 4 2012, 00:21:27

2012-06-03 Thread neels
/home/neels/svnbench/20120604-002445 Started at Mon Jun 4 00:24:45 UTC 2012 *Disclaimer:* this tests only file://-URL access on a GNU/Linux VM. This is intended to measure changes in performance of the local working copy layer, *only*. These results are *not* generally true for everyone. Average

Re: svn commit: r1345740 - /subversion/trunk/subversion/libsvn_auth_kwallet/kwallet.cpp

2012-06-03 Thread Peter Samuelson
[Greg Stein] > > - int argc = 1; > > - app = new QCoreApplication(argc, (char *[1]) {(char *) "svn"}); > > + int argc = q_argc; > > + app = new QCoreApplication(argc, q_argv); > > Why keep argc around? Just use q_argc. Because argc is passed by reference (int &argc) and I fig

Re: svn commit: r1345740 - /subversion/trunk/subversion/libsvn_auth_kwallet/kwallet.cpp

2012-06-03 Thread Greg Stein
On Jun 3, 2012 2:54 PM, wrote: >... > +++ subversion/trunk/subversion/libsvn_auth_kwallet/kwallet.cpp Sun Jun 3 18:54:26 2012 > @@ -60,6 +60,9 @@ > /* KWallet simple provider, puts passwords in KWallet */ > /*---*/ > > +static

RE: svn commit: r1345479 - /subversion/trunk/tools/buildbot/slaves/win32-SharpSvn/svntest-test.cmd

2012-06-03 Thread Bert Huijben
Yes, I see that problem on my local pc too. But on that buildbot ipv6 is not enabled on the system and not in apr, so it shouldn't be affected. but it was still slow. It is nice that it can test both ra_svn and ra_serf in about one hour now, where it used to take two. B