Re: SEGFAULT committing against tigris.org with HEAD client code.

2012-06-14 Thread C. Michael Pilato
On 06/15/2012 03:40 AM, C. Michael Pilato wrote: > I noticed tonight that my attempts to commit to the ViewVC repository on > Tigris.org are now failing due to a client-side SEGFAULT. So far, all I > know is that the failure is due to a call to svn_ra_serf__set_prop() (at > subversion/libsvn_ra_se

SEGFAULT committing against tigris.org with HEAD client code.

2012-06-14 Thread C. Michael Pilato
I noticed tonight that my attempts to commit to the ViewVC repository on Tigris.org are now failing due to a client-side SEGFAULT. So far, all I know is that the failure is due to a call to svn_ra_serf__set_prop() (at subversion/libsvn_ra_serf/commit.c:1470) with a NULL path. Because Tigris.org i

Re: Committing part of a changed file

2012-06-14 Thread Branko Čibej
On 14.06.2012 20:15, Stefan Küng wrote: > On 14.06.2012 18:18, Johan Corveleyn wrote: >> During elego's SvnDay in Berlin today, the topic of "committing part >> of a file" came up (during stefan2's talk about TortoiseSVN (future) >> features). As Michael suggested, it would be nice if this could >>

Re: Changing the log API is not worth it

2012-06-14 Thread Julian Foad
Stefan Fuhrmann wrote: > Yesterday, I discovered an inconsistency in our log API. > svn_revnum_t is a long while the "limit" parameter is > an int. It is not semantically necessary to be able to request an arbitrarily large batch of log messages -- in other words, for the "limit" parameter to be

Re: Committing part of a changed file

2012-06-14 Thread Stefan Küng
On 14.06.2012 18:18, Johan Corveleyn wrote: During elego's SvnDay in Berlin today, the topic of "committing part of a file" came up (during stefan2's talk about TortoiseSVN (future) features). As Michael suggested, it would be nice if this could someday become a feature of core svn. It just so h

Committing part of a changed file

2012-06-14 Thread Johan Corveleyn
During elego's SvnDay in Berlin today, the topic of "committing part of a file" came up (during stefan2's talk about TortoiseSVN (future) features). As Michael suggested, it would be nice if this could someday become a feature of core svn. It just so happens that one of my colleagues (svn user) wa

Re: serf w/SurfShield crash in authz_tests.py#15

2012-06-14 Thread Justin Erenkrantz
On Thu, Jun 14, 2012 at 5:02 PM, Daniel Shahaf wrote: > I know pf(4) on openbsd has some specific "Be unreliable" options. > Would they be useful for this? Since we're using TCP, I expect that such pf filters would just cause delays that TCP would essentially recover from and might not even be vi

Re: serf w/SurfShield crash in authz_tests.py#15

2012-06-14 Thread Daniel Shahaf
Justin Erenkrantz wrote on Thu, Jun 14, 2012 at 15:52:17 +0200: > It was a good way of capturing some of the more subtle race conditions > that we've never triggered reliably elsewhere. -- justin I know pf(4) on openbsd has some specific "Be unreliable" options. Would they be useful for this? Fo

Re: [PATCH] Enable downstream caching of versioned GET responses

2012-06-14 Thread Justin Erenkrantz
On Thu, Jun 14, 2012 at 2:06 PM, Justin Erenkrantz wrote: > I checked the wireshark traffic on a checkout and it looks like all > the right headers are set - with this patch, we now have > Cache-Control, ETag, and Last-Modified all set.  When mod_deflate is > run, it'll set the appropriate vary he

Re: serf w/SurfShield crash in authz_tests.py#15

2012-06-14 Thread Justin Erenkrantz
On Thu, Jun 14, 2012 at 3:14 PM, Johan Corveleyn wrote: > Great! I can now successfully run the entire testsuite over ra_serf > with AVG SurfShield enabled. For the first time ever :-). Yay! > Thanks for all the bugfixes. No problem. Thanks for providing the underpowered laptop with the nutty

Re: [PATCH] JavaHL: New method for creating java objects linked to their C++ counterpart

2012-06-14 Thread Hyrum K Wright
On Thu, Jun 14, 2012 at 3:11 PM, Greg Stein wrote: > On Thu, Jun 14, 2012 at 8:54 AM, Vladimir Berezniker > wrote: >> On Thu, Jun 14, 2012 at 8:48 AM, Hyrum K Wright >> wrote: >>... >>> The RA layer (on trunk) already exposes Ev2 via the >>> svn_ra__get_commit_ev2() API.  Feel free to use it, k

Re: [PATCH] JavaHL: New method for creating java objects linked to their C++ counterpart

2012-06-14 Thread Greg Stein
On Thu, Jun 14, 2012 at 8:54 AM, Vladimir Berezniker wrote: > On Thu, Jun 14, 2012 at 8:48 AM, Hyrum K Wright > wrote: >... >> The RA layer (on trunk) already exposes Ev2 via the >> svn_ra__get_commit_ev2() API.  Feel free to use it, knowing that its >> implementation is still quite experimental,

Re: serf w/SurfShield crash in authz_tests.py#15

2012-06-14 Thread Johan Corveleyn
On Thu, Jun 14, 2012 at 12:27 PM, Justin Erenkrantz wrote: > On Wed, Jun 13, 2012 at 11:28 PM, Johan Corveleyn wrote: >> With latest trunk (@1349944) I get a crash in authz_tests.py 15 >> ("authz issue #3242 - access required at repo root") when running with > > I have confirmed on your machine t

Re: [PATCH] JavaHL: New method for creating java objects linked to their C++ counterpart

2012-06-14 Thread Vladimir Berezniker
On Thu, Jun 14, 2012 at 8:48 AM, Hyrum K Wright wrote: > On Thu, Jun 14, 2012 at 2:40 PM, Vladimir Berezniker > wrote: > > > > > > On Thu, Jun 14, 2012 at 8:13 AM, Hyrum K Wright < > hyrum.wri...@wandisco.com> > > wrote: > >> * We're in the middle of a rather large effort to move from the > >> cu

Re: [PATCH] JavaHL: New method for creating java objects linked to their C++ counterpart

2012-06-14 Thread Vladimir Berezniker
Sorry missed bunch of inline responses first time around. not used to this in gmail. On Thu, Jun 14, 2012 at 8:13 AM, Hyrum K Wright wrote: > On Mon, Jun 11, 2012 at 2:39 PM, Vladimir Berezniker > wrote: > > > > > > On Mon, Jun 11, 2012 at 6:20 AM, Hyrum K Wright < > hyrum.wri...@wandisco.com> >

Re: [PATCH] JavaHL: New method for creating java objects linked to their C++ counterpart

2012-06-14 Thread Hyrum K Wright
On Thu, Jun 14, 2012 at 2:40 PM, Vladimir Berezniker wrote: > > > On Thu, Jun 14, 2012 at 8:13 AM, Hyrum K Wright > wrote: >> * We're in the middle of a rather large effort to move from the >> current delta editor to something called Ev2.  Ev2 should be simpler >> from a bindings perspective, but

Re: svn commit: r1350021 - in /subversion/trunk/subversion: libsvn_subr/adler32.c libsvn_subr/cache-membuffer.c libsvn_subr/cache.c libsvn_subr/string.c mod_authz_svn/mod_authz_svn.c svnserve/main.c

2012-06-14 Thread Stefan Fuhrmann
On 06/14/2012 08:16 AM, Greg Stein wrote: Adjust the log message to note the incorrect main change, and the revision where it was reverted? Done. On Jun 13, 2012 11:22 PM, > wrote: Author: stefan2 Date: Wed Jun 13 21:22:24 2012 New Revision: 1350021

Re: [PATCH] JavaHL: New method for creating java objects linked to their C++ counterpart

2012-06-14 Thread Vladimir Berezniker
On Thu, Jun 14, 2012 at 8:13 AM, Hyrum K Wright wrote: > On Mon, Jun 11, 2012 at 2:39 PM, Vladimir Berezniker > wrote: > > > > > > On Mon, Jun 11, 2012 at 6:20 AM, Hyrum K Wright < > hyrum.wri...@wandisco.com> > > wrote: > >> > >> On Thu, Jun 7, 2012 at 4:03 AM, Vladimir Berezniker > > >> wrote:

Re: svn commit: r1344616 - in /subversion/trunk/subversion/tests/cmdline/svntest: actions.py main.py

2012-06-14 Thread Johan Corveleyn
On Mon, Jun 4, 2012 at 10:53 PM, Johan Corveleyn wrote: > On Mon, Jun 4, 2012 at 9:25 PM, Johan Corveleyn wrote: >> On Thu, May 31, 2012 at 11:28 AM,   wrote: >>> Author: rhuijben >>> Date: Thu May 31 09:28:13 2012 >>> New Revision: 1344616 >>> >>> URL: http://svn.apache.org/viewvc?rev=1344616&vi

Re: [PATCH] JavaHL: New method for creating java objects linked to their C++ counterpart

2012-06-14 Thread Hyrum K Wright
On Mon, Jun 11, 2012 at 2:39 PM, Vladimir Berezniker wrote: > > > On Mon, Jun 11, 2012 at 6:20 AM, Hyrum K Wright > wrote: >> >> On Thu, Jun 7, 2012 at 4:03 AM, Vladimir Berezniker >> wrote: >> > Hi All, >> > >> > The intention if this patch is to introduce reusable logic for creating >> > java

Re: [PATCH] JavaHL: New method for creating java objects linked to their C++ counterpart

2012-06-14 Thread Vladimir Berezniker
On Thu, Jun 14, 2012 at 4:37 AM, Hyrum K Wright wrote: > On Thu, Jun 14, 2012 at 10:16 AM, Mat Booth > wrote: > > On 12 June 2012 03:11, Vladimir Berezniker wrote: > >> > >> > >> On Mon, Jun 11, 2012 at 8:39 AM, Vladimir Berezniker < > v...@hitechman.com> > >> wrote: > >>> > >>> > >>> > >>> On M

[PATCH] Enable downstream caching of versioned GET responses

2012-06-14 Thread Justin Erenkrantz
Hey, lookie, a bunch of ###'s. =) I'm not quite sure whether we would want to set Cache-Control to just "public" and not specify a max-age. Or, perhaps we need to add some configuration directives to allow the admin to tweak the value. I checked the wireshark traffic on a checkout and it looks

Re: Type narrowing warnings on Mac OS x64 as of r1349288

2012-06-14 Thread Branko Čibej
On 14.06.2012 12:45, Stefan Fuhrmann wrote: > On 06/12/2012 02:35 PM, Philip Martin wrote: >> Branko Čibej writes: >> >>> Better than spamming #svn-dev, here's the current list of 64-32bit >>> narrowing warnings I get on my 64-bit mac wit Xcode 4.3.3's gcc. Taking >>> a quick look at these, every

Changing the log API is not worth it

2012-06-14 Thread Stefan Fuhrmann
Hi all, Yesterday, I discovered an inconsistency in our log API. svn_revnum_t is a long while the "limit" parameter is an int. Since we have a practical limit of 2^31 on our revision numbers and because int is (at least) 32 bits on all our targets, switching the limit parameter to long is a pret

Re: Shell script to make a log message template

2012-06-14 Thread Stefan Fuhrmann
On 06/11/2012 03:41 PM, Julian Foad wrote: For anyone interested, attached is the shell script I use to generate a log message template for a particular svn diff. It runs 'svn status' on the given target(s) to find what files to include, then 'svn diff' for each file, and writes to stdout a lo

Re: Type narrowing warnings on Mac OS x64 as of r1349288

2012-06-14 Thread Stefan Fuhrmann
On 06/12/2012 02:35 PM, Philip Martin wrote: Branko Čibej writes: Better than spamming #svn-dev, here's the current list of 64-32bit narrowing warnings I get on my 64-bit mac wit Xcode 4.3.3's gcc. Taking a quick look at these, every case appears to be a valid warning that needs to be looked a

Re: serf w/SurfShield crash in authz_tests.py#15

2012-06-14 Thread Justin Erenkrantz
On Wed, Jun 13, 2012 at 11:28 PM, Johan Corveleyn wrote: > With latest trunk (@1349944) I get a crash in authz_tests.py 15 > ("authz issue #3242 - access required at repo root") when running with I have confirmed on your machine that the fix in r1350179 doesn't cause a crash any more. Thanks! -

Re: svn commit: r1349944 - /subversion/trunk/gen-make.py

2012-06-14 Thread Hyrum K Wright
On Thu, Jun 14, 2012 at 11:36 AM, Bert Huijben wrote: > > >> -Original Message- >> From: Greg Stein [mailto:gst...@gmail.com] >> Sent: Thursday, June 14, 2012 10:44 AM >> To: Bert Huijben; Hyrum K Wright >> Cc: dev@subversion.apache.org >> Subject: Re: svn commit: r1349944 - /subversion/tr

RE: svn commit: r1349944 - /subversion/trunk/gen-make.py

2012-06-14 Thread Bert Huijben
> -Original Message- > From: Greg Stein [mailto:gst...@gmail.com] > Sent: Thursday, June 14, 2012 10:44 AM > To: Bert Huijben; Hyrum K Wright > Cc: dev@subversion.apache.org > Subject: Re: svn commit: r1349944 - /subversion/trunk/gen-make.py > > I agree: we should not make changes to Sub

Re: svn commit: r1349944 - /subversion/trunk/gen-make.py

2012-06-14 Thread Greg Stein
I agree: we should not make changes to Subversion simply to support some buildbots. That is the wrong direction. The buildbots must compensate for changes in *our* codebase. If we add new dependencies, then they must adjust. If we remove dependencies, then they must adjust. On Thu, Jun 14, 2012 a

Re: [PATCH] JavaHL: New method for creating java objects linked to their C++ counterpart

2012-06-14 Thread Hyrum K Wright
On Thu, Jun 14, 2012 at 10:16 AM, Mat Booth wrote: > On 12 June 2012 03:11, Vladimir Berezniker wrote: >> >> >> On Mon, Jun 11, 2012 at 8:39 AM, Vladimir Berezniker >> wrote: >>> >>> >>> >>> On Mon, Jun 11, 2012 at 6:20 AM, Hyrum K Wright >>> wrote: On Thu, Jun 7, 2012 at 4:03 AM, Vla

Re: [PATCH] JavaHL: New method for creating java objects linked to their C++ counterpart

2012-06-14 Thread Mat Booth
On 12 June 2012 03:11, Vladimir Berezniker wrote: > > > On Mon, Jun 11, 2012 at 8:39 AM, Vladimir Berezniker > wrote: >> >> >> >> On Mon, Jun 11, 2012 at 6:20 AM, Hyrum K Wright >> wrote: >>> >>> On Thu, Jun 7, 2012 at 4:03 AM, Vladimir Berezniker >>> wrote: >>> > Hi All, >>> > >>> > The intent

Re: svn commit: r1349944 - /subversion/trunk/gen-make.py

2012-06-14 Thread Hyrum K Wright
On Thu, Jun 14, 2012 at 1:23 AM, Bert Huijben wrote: > > >> -Original Message- >> From: Hyrum K Wright [mailto:hyrum.wri...@wandisco.com] >> Sent: Thursday, June 14, 2012 12:33 AM >> To: Bert Huijben >> Cc: Michael Pilato; Subversion Development >> Subject: Re: svn commit: r1349944 - /subv