Re: 'svn mergeinfo' graph bikeshed patch

2012-10-26 Thread Peter Samuelson
[Branko Čibej] > On 26.10.2012 21:04, C. Michael Pilato wrote: > > Just felt like painting. > > The only problem I see with this is that, in many monospaced fonts, ' > and ` glyphs are not mirror images; whereas / and \ almost always are. Well, note that his patch uses the symmetry of ` and , wh

Re: 'svn mergeinfo' graph bikeshed patch

2012-10-26 Thread C. Michael Pilato
On 10/26/2012 06:10 PM, Julian Foad wrote: >> From: Branko Čibej > >> To: dev@subversion.apache.org Cc: Sent: Friday, 26 October 2012, 22:13 >> Subject: Re: 'svn mergeinfo' graph bikeshed patch >> >> On 26.10.2012 21:04, C. Michael Pilato wrote: >>> Just felt like painting. >> >> The only prob

Re: 'svn mergeinfo' graph bikeshed patch

2012-10-26 Thread Julian Foad
> From: Branko Čibej > To: dev@subversion.apache.org > Cc: > Sent: Friday, 26 October 2012, 22:13 > Subject: Re: 'svn mergeinfo' graph bikeshed patch > > On 26.10.2012 21:04, C. Michael Pilato wrote: >> Just felt like painting. > > The only problem I see with this is that, in many monospaced

Re: 'svn mergeinfo' graph bikeshed patch

2012-10-26 Thread Branko Čibej
On 26.10.2012 21:04, C. Michael Pilato wrote: > Just felt like painting. The only problem I see with this is that, in many monospaced fonts, ' and ` glyphs are not mirror images; whereas / and \ almost always are. Also there's no guarantee that dash and waka (->) will be properly aligned to form a

'svn mergeinfo' graph bikeshed patch

2012-10-26 Thread C. Michael Pilato
Just felt like painting. -- C. Michael Pilato CollabNet <> www.collab.net <> Enterprise Cloud Development Index: subversion/svn/mergeinfo-cmd.c === --- subversion/svn/mergeinfo-cmd.c (revision 1402614) +++ subversion/sv

Re: Issue with Revision 955787

2012-10-26 Thread Sean Farrell
I've verified the fix. The "text_status" for the "svn_wc_status2_t" object now has the value of "svn_wc_status_normal". Will this fix go out in a 1.7.8 and/or 1.8? Also, I'm trying to track down what releases have this bug. It looks like starting with 1.6.12 on up, which includes all of 1.7.x

Re: [PATCH] Implement svnadmin verify --force

2012-10-26 Thread Daniel Shahaf
Stefan Sperling wrote on Fri, Oct 26, 2012 at 12:45:49 +0200: > On Fri, Oct 26, 2012 at 11:57:12AM +0200, Daniel Shahaf wrote: > > Using terminology from : if X is "I am > > not comfortable writings loops in DOS batch", I don't think applying > > your patch to trunk

Re: Wiki Access

2012-10-26 Thread Ben Reser
On Fri, Oct 26, 2012 at 4:57 PM, Daniel Shahaf wrote: > Added you to http://wiki.apache.org/subversion/AdminGroup#preview > > If you don't want admin access, feel free to add yourself to > ContributorsGroup and drop yourself from AdminGroup Thanks, admin access is fine.

Re: Wiki Access

2012-10-26 Thread Daniel Shahaf
Added you to http://wiki.apache.org/subversion/AdminGroup#preview If you don't want admin access, feel free to add yourself to ContributorsGroup and drop yourself from AdminGroup Ben Reser wrote on Fri, Oct 26, 2012 at 16:41:45 +0100: > Can someone please grant me edit rights to the wiki. Userna

Re: [RFC] auto-props-sdc Branch : Ready for Review

2012-10-26 Thread C. Michael Pilato
On 10/26/2012 11:34 AM, Philip Martin wrote: > Philip Martin writes: > >>> ==15116== Source and destination overlap in memcpy(0x9e3f078, 0x98aca80, >>> 160094512) >>> ==15116==at 0x4C25F6A: memcpy (mc_replace_strmem.c:497) >>> ==15116==by 0x5A25229: svn_string_ncreate (string.c:165) >>>

Re: [RFC] auto-props-sdc Branch : Ready for Review

2012-10-26 Thread Paul Burba
On Fri, Oct 26, 2012 at 11:34 AM, Philip Martin wrote: > Philip Martin writes: > >>> ==15116== Source and destination overlap in memcpy(0x9e3f078, 0x98aca80, >>> 160094512) >>> ==15116==at 0x4C25F6A: memcpy (mc_replace_strmem.c:497) >>> ==15116==by 0x5A25229: svn_string_ncreate (string.c

Wiki Access

2012-10-26 Thread Ben Reser
Can someone please grant me edit rights to the wiki. Username: BenReser Thanks.

Re: [RFC] auto-props-sdc Branch : Ready for Review

2012-10-26 Thread Philip Martin
Philip Martin writes: >> ==15116== Source and destination overlap in memcpy(0x9e3f078, 0x98aca80, >> 160094512) >> ==15116==at 0x4C25F6A: memcpy (mc_replace_strmem.c:497) >> ==15116==by 0x5A25229: svn_string_ncreate (string.c:165) >> ==15116==by 0x5A2541B: svn_string_dup (string.c:22

Re: [RFC] auto-props-sdc Branch : Ready for Review

2012-10-26 Thread Paul Burba
On Fri, Oct 26, 2012 at 11:21 AM, Philip Martin wrote: > Philip Martin writes: > >> ==15116== Conditional jump or move depends on uninitialised value(s) >> ==15116==at 0x4E3A6DF: svn_client__get_paths_auto_props (add.c:244) >> ==15116==by 0x4E3A914: add_file (add.c:300) >> ==15116==by

Re: [RFC] auto-props-sdc Branch : Ready for Review

2012-10-26 Thread Philip Martin
Philip Martin writes: > ==15116== Conditional jump or move depends on uninitialised value(s) > ==15116==at 0x4E3A6DF: svn_client__get_paths_auto_props (add.c:244) > ==15116==by 0x4E3A914: add_file (add.c:300) > ==15116==by 0x4E3C464: add (add.c:1031) > ==15116==by 0x4E3C9C4: svn_c

Re: [RFC] auto-props-sdc Branch : Ready for Review

2012-10-26 Thread Philip Martin
Paul Burba writes: > Is import_tests.py 5: 'import should honor the eol-style property' > also failing for you as it does on the buildbot? Yes. -- Join us this October at Subversion Live 2012 http://www.wandisco.com/svn-live-2012

Re: [RFC] auto-props-sdc Branch : Ready for Review

2012-10-26 Thread Philip Martin
"C. Michael Pilato" writes: > On 10/26/2012 10:33 AM, Philip Martin wrote: >> Paul Burba writes: >> It's been almost two weeks with no objections, so I will be merging this branch back to trunk today. >>> >>> Done, r1401908. >> >> This causes autoprop_tests.py to fail on my Linux box

Re: [RFC] auto-props-sdc Branch : Ready for Review

2012-10-26 Thread Paul Burba
On Fri, Oct 26, 2012 at 10:46 AM, C. Michael Pilato wrote: > On 10/26/2012 10:33 AM, Philip Martin wrote: >> Paul Burba writes: >> It's been almost two weeks with no objections, so I will be merging this branch back to trunk today. >>> >>> Done, r1401908. >> >> This causes autoprop_test

Re: [RFC] auto-props-sdc Branch : Ready for Review

2012-10-26 Thread C. Michael Pilato
On 10/26/2012 10:33 AM, Philip Martin wrote: > Paul Burba writes: > >>> It's been almost two weeks with no objections, so I will be merging >>> this branch back to trunk today. >> >> Done, r1401908. > > This causes autoprop_tests.py to fail on my Linux box and the centos > buildbot: > > http://

Re: [RFC] auto-props-sdc Branch : Ready for Review

2012-10-26 Thread Paul Burba
On Fri, Oct 26, 2012 at 10:33 AM, Philip Martin wrote: > Paul Burba writes: > >>> It's been almost two weeks with no objections, so I will be merging >>> this branch back to trunk today. >> >> Done, r1401908. > > This causes autoprop_tests.py to fail on my Linux box and the centos > buildbot: Hi

Re: Issue with Revision 955787

2012-10-26 Thread Philip Martin
Sean Farrell writes: > (*status)->text_status = old_status->node_status; > (*status)->prop_status = old_status->prop_status; > > (*status)->repos_text_status = old_status->repos_node_status; > (*status)->repos_prop_status = old_status->repos_prop_status; > > /* Some values might be inherited

Re: [RFC] auto-props-sdc Branch : Ready for Review

2012-10-26 Thread Philip Martin
Paul Burba writes: >> It's been almost two weeks with no objections, so I will be merging >> this branch back to trunk today. > > Done, r1401908. This causes autoprop_tests.py to fail on my Linux box and the centos buildbot: http://ci.apache.org/builders/svn-x64-centos-gcc/builds/7466 I see "s

Re: sqlite locking and svn client concurrency

2012-10-26 Thread Philip Martin
Johan Corveleyn writes: > - This 10 second timeout, for a read operation that is blocked by some > write transaction: is this implemented somewhere in the svn source > code (if so, where?), or is this some configuration setting for the > sqlite connection or something like that? It's hard-coded,

Re: [PATCH] Implement svnadmin verify --force

2012-10-26 Thread Stefan Sperling
On Thu, Oct 25, 2012 at 08:33:17PM +0530, Prabhu Gnana Sundar wrote: > > Thanks Daniel, these are really good pointers for me. Shall I > continue with this and submit a patch > with the changes. In my opinion, yes, please do so. Thanks!

Re: [PATCH] Implement svnadmin verify --force

2012-10-26 Thread Stefan Sperling
On Fri, Oct 26, 2012 at 11:57:12AM +0200, Daniel Shahaf wrote: > Using terminology from : if X is "I am > not comfortable writings loops in DOS batch", I don't think applying > your patch to trunk is the correct Y. I still don't get why you're so much objected to th

Re: [PATCH] Implement svnadmin verify --force

2012-10-26 Thread Daniel Shahaf
Using terminology from : if X is "I am not comfortable writings loops in DOS batch", I don't think applying your patch to trunk is the correct Y. Prabhu Gnana Sundar wrote on Thu, Oct 25, 2012 at 20:33:17 +0530: > > Thanks Daniel, these are really good pointers for

Re: [PATCH] Implement svnadmin verify --force

2012-10-26 Thread Prabhu Gnana Sundar
Thanks Daniel, these are really good pointers for me. Shall I continue with this and submit a patch with the changes. Regards Prabhu On 10/21/2012 10:42 PM, Daniel Shahaf wrote: BTW, I'd like to point out a few further problems with the patch; even if it doesn't get applied, you might find

Re: [Issue 4225] Add --include-externals option to 'svn list'

2012-10-26 Thread vijay
On Wednesday 24 October 2012 07:16 PM, C. Michael Pilato wrote: On 10/24/2012 09:25 AM, vijay wrote: On Wednesday 24 October 2012 02:33 AM, Ben Reser wrote: Does it make more sense to make --include-externals behave something more like --depth rather than a simple boolean? E.G. it'd behave lik

Re: [Issue 4225] Add --include-externals option to 'svn list'

2012-10-26 Thread vijay
On Wednesday 24 October 2012 07:16 PM, C. Michael Pilato wrote: On 10/24/2012 09:25 AM, vijay wrote: On Wednesday 24 October 2012 02:33 AM, Ben Reser wrote: Does it make more sense to make --include-externals behave something more like --depth rather than a simple boolean? E.G. it'd behave lik

Re: svn_delta_path_driver deprecation

2012-10-26 Thread Stefan Fuhrmann
On Thu, Oct 25, 2012 at 7:36 PM, C. Michael Pilato wrote: > On 10/25/2012 01:02 PM, Stefan Fuhrmann wrote: > > Hi, > > > > We've managed to widely eliminate the use of deprecated > > functions except for a few cases. One of them is > > svn_delta_path_driver. > > > > The problem is that svn_delta_p