Re: svn commit: r1406870 - in /subversion/trunk/subversion: libsvn_wc/update_editor.c libsvn_wc/wc_db_wcroot.c tests/cmdline/special_tests.py

2012-11-07 Thread Daniel Shahaf
Daniel Shahaf wrote on Thu, Nov 08, 2012 at 09:07:07 +0200: > Branko Čibej wrote on Thu, Nov 08, 2012 at 06:13:22 +0100: > > On 08.11.2012 05:26, Daniel Shahaf wrote: > > > Branko Čibej wrote on Thu, Nov 08, 2012 at 04:13:52 +0100: > > >> I believe that the correct approach would be to always treat

Re: svn commit: r1406870 - in /subversion/trunk/subversion: libsvn_wc/update_editor.c libsvn_wc/wc_db_wcroot.c tests/cmdline/special_tests.py

2012-11-07 Thread Daniel Shahaf
Branko Čibej wrote on Thu, Nov 08, 2012 at 06:13:22 +0100: > On 08.11.2012 05:26, Daniel Shahaf wrote: > > Branko Čibej wrote on Thu, Nov 08, 2012 at 04:13:52 +0100: > >> I believe that the correct approach would be to always treat a changed > >> node kind (that's either the appearance/disappearanc

Re: Hanging tests mergeinfo-test.exe 12, 15 and skel-test.exe 4 on WinXP with VS2010 release build

2012-11-07 Thread Stefan Fuhrmann
On Tue, Nov 6, 2012 at 10:29 PM, Johan Corveleyn wrote: > On Tue, Nov 6, 2012 at 10:53 AM, Stefan Fuhrmann > wrote: > > On Mon, Nov 5, 2012 at 2:00 AM, Johan Corveleyn > wrote: > >> > >> Before I look into this further, I'd like to know if anyone else has > seen > >> this or can reproduce this

Re: svn commit: r1406870 - in /subversion/trunk/subversion: libsvn_wc/update_editor.c libsvn_wc/wc_db_wcroot.c tests/cmdline/special_tests.py

2012-11-07 Thread Branko Čibej
On 08.11.2012 05:26, Daniel Shahaf wrote: > Branko Čibej wrote on Thu, Nov 08, 2012 at 04:13:52 +0100: >> I believe that the correct approach would be to always treat a changed >> node kind (that's either the appearance/disappearance of the svn:symlink >> property, or a change of the initial keywor

Re: svn commit: r1406870 - in /subversion/trunk/subversion: libsvn_wc/update_editor.c libsvn_wc/wc_db_wcroot.c tests/cmdline/special_tests.py

2012-11-07 Thread Daniel Shahaf
Branko Čibej wrote on Thu, Nov 08, 2012 at 04:13:52 +0100: > On 08.11.2012 03:19, Philip Martin wrote: > > phi...@apache.org writes: > > > >> Author: philip > >> Date: Wed Nov 7 23:49:06 2012 > >> New Revision: 1406870 > >> > >> URL: http://svn.apache.org/viewvc?rev=1406870&view=rev > >> Log: > >>

Re: [PATCH] enabling ruby in the subversion build

2012-11-07 Thread Michael Chletsos
OK - this should fix your issues, tested on ruby1.9.3 and ruby1.8.7 - passed for me, let me know what you get. On Wed, Nov 7, 2012 at 4:40 PM, Philip Martin wrote: > Michael Chletsos writes: > >> Here is a complete patch that I tested - more work needs to be done on >> the tests, but currently a

Re: svn commit: r1406870 - in /subversion/trunk/subversion: libsvn_wc/update_editor.c libsvn_wc/wc_db_wcroot.c tests/cmdline/special_tests.py

2012-11-07 Thread Branko Čibej
On 08.11.2012 03:19, Philip Martin wrote: > phi...@apache.org writes: > >> Author: philip >> Date: Wed Nov 7 23:49:06 2012 >> New Revision: 1406870 >> >> URL: http://svn.apache.org/viewvc?rev=1406870&view=rev >> Log: >> Fix issue 4091, symlink-ness change causes spurious tree-conflict. >> >> * sub

Re: [PATCH] enabling ruby in the subversion build

2012-11-07 Thread Philip Martin
Michael Chletsos writes: > Here is a complete patch that I tested - more work needs to be done on > the tests, but currently all tests that are run, succeed on my system. It breaks the tests when run with ruby 1.8.7 on my Debian/testing machine which is a regression since they pass without the p

Re: svn commit: r1406870 - in /subversion/trunk/subversion: libsvn_wc/update_editor.c libsvn_wc/wc_db_wcroot.c tests/cmdline/special_tests.py

2012-11-07 Thread Philip Martin
phi...@apache.org writes: > Author: philip > Date: Wed Nov 7 23:49:06 2012 > New Revision: 1406870 > > URL: http://svn.apache.org/viewvc?rev=1406870&view=rev > Log: > Fix issue 4091, symlink-ness change causes spurious tree-conflict. > > * subversion/libsvn_wc/update_editor.c > (close_file): On

Re: [PATCH] enabling ruby in the subversion build

2012-11-07 Thread Michael Chletsos
Here is a complete patch that I tested - more work needs to be done on the tests, but currently all tests that are run, succeed on my system. I based this on trunk today. On Wed, Nov 7, 2012 at 8:57 AM, Michael Chletsos wrote: > Sorry - I am having one of those morning - this one should be good,

Re: disregarding svn:global-ignores

2012-11-07 Thread Daniel Shahaf
Paul Burba wrote on Wed, Nov 07, 2012 at 16:10:00 -0500: > However I strongly believe that the default behavior of svn:auto-props > should not be tied the config:miscellany:enable-auto-props runtime > setting. Doing so makes it too easy for users to permanently (and > perhaps accidentally) disrega

Inheritable svn:auto-props and the enable-auto-props config [was: disregarding svn:global-ignores]

2012-11-07 Thread Julian Foad
Paul Burba wrote: > As best I can tell we all agree now that a user should be able to > disregard the svn:auto-props with --no-auto-props option.  Having > digested everyone's arguments on that topic I'm fine with that now. > > However I strongly believe that the default behavior of svn:auto-prop

Re: Random serf checkout failures

2012-11-07 Thread Lieven Govaerts
Hi, we seem to be raising and discussing a few different issues in this thread. I've tried to summarize current status with some added observations. I propose to start up separate mail threads when discussing one of these specific issues. 1. When a very low Timeout is set in the apache server co

Re: disregarding svn:global-ignores

2012-11-07 Thread Paul Burba
On Wed, Nov 7, 2012 at 3:40 AM, Johan Corveleyn wrote: > On Wed, Nov 7, 2012 at 8:52 AM, Daniel Shahaf wrote: >> Paul Burba wrote on Tue, Nov 06, 2012 at 12:01:54 -0500: >>> Also keep in mind that if you really want to add an ignored file you >>> can make the file the target of the 'svn add' comm

Re: disregarding svn:global-ignores

2012-11-07 Thread Paul Burba
On Wed, Nov 7, 2012 at 6:06 AM, Johan Corveleyn wrote: > On Wed, Nov 7, 2012 at 11:48 AM, Stefan Sperling wrote: >> On Wed, Nov 07, 2012 at 09:40:48AM +0100, Johan Corveleyn wrote: >>> I haven't tested, but wouldn't something like 'svn add --config-option >>> config:miscellany:enable-auto-props=n

Re: [PATCH] enabling ruby in the subversion build

2012-11-07 Thread Michael Chletsos
Sorry - I am having one of those morning - this one should be good, I keep reversing my files and my thoughts . . . I will check out trunk later and fix the patches and this patch and make them all nice and be real. On Wed, Nov 7, 2012 at 8:54 AM, Peter Samuelson wrote: > > [Michael Chletsos]

Re: [PATCH] enabling ruby in the subversion build

2012-11-07 Thread Peter Samuelson
[Michael Chletsos] > sorry about confusion - here is the updated patch, with swig updates. Your patch seems to be reversed ('diff -u {new} {old}' whereas what everyone wants to see is 'diff -u {old} {new}' or 'svn diff'), and also seems to have been developed against something older than Subversi

Re: [PATCH] enabling ruby in the subversion build

2012-11-07 Thread Michael Chletsos
sorry about confusion - here is the updated patch, with swig updates. On Wed, Nov 7, 2012 at 8:06 AM, Philip Martin wrote: > Michael Chletsos writes: > >> Sorry for delay. Patch for configure is attached. > > You don't patch configure, that's a generated file. You patch > configure.ac. > > -

Re: [PATCH] enabling ruby in the subversion build

2012-11-07 Thread Philip Martin
Philip Martin writes: > Michael Chletsos writes: > >> Sorry for delay. Patch for configure is attached. > > You don't patch configure, that's a generated file. You patch > configure.ac. Some of configure is generated from build/ac-macros/swig.m4. The original patch for the testsuite no longe

Re: [PATCH] enabling ruby in the subversion build

2012-11-07 Thread Philip Martin
Michael Chletsos writes: > Sorry for delay. Patch for configure is attached. You don't patch configure, that's a generated file. You patch configure.ac. -- Certified & Supported Apache Subversion Downloads: http://www.wandisco.com/subversion/download

Re: [PATCH] enabling ruby in the subversion build

2012-11-07 Thread Michael Chletsos
Sorry for delay. Patch for configure is attached. It also updates Config to RbConfig which will remove annoying errors and is backwards compatible. On Wed, Nov 7, 2012 at 5:43 AM, Philip Martin wrote: > Michael Chletsos writes: > >> The current patch I used does not fix the configure script, I

Re: disregarding svn:global-ignores

2012-11-07 Thread Paul Burba
On Tue, Nov 6, 2012 at 1:49 PM, Paul Burba wrote: > If we ultimately decide[1] to allow svn:global-ignores to be > disregarded with the --no-ignore option, then I suggest it makes sense > for 'svn add' and 'svn import' to disregard the svn:auto-props > property when the --no-auto-props option is

Re: [PATCH] enabling ruby in the subversion build

2012-11-07 Thread Philip Martin
Michael Chletsos writes: > The current patch I used does not fix the configure script, I could > modify that to only use <= 1.8.7 or >= 1.9.3 if you like. yes, please. -- Certified & Supported Apache Subversion Downloads: http://www.wandisco.com/subversion/download

Re: [PATCH] enabling ruby in the subversion build

2012-11-07 Thread Michael Chletsos
I would support 1.9.3 - ruby 1.9.2 and 1.9.1 are not considered good versions and are problematic. The current patch I used does not fix the configure script, I could modify that to only use <= 1.8.7 or >= 1.9.3 if you like. On Wed, Nov 7, 2012 at 5:31 AM, Philip Martin wrote: > Michael Chletsos

Re: [PATCH] enabling ruby in the subversion build

2012-11-07 Thread Philip Martin
Michael Chletsos writes: > OK - first, I would not support ruby 1.9.1 - I assume that you really > have 1.9.2 (debian/ubuntu uses a meta-package)- can you show me the > output of ruby -v > > I would support ruby 1.9.3 and above - there were issues with 1.9.1 and 1.9.2. I used whatever was part o

Re: [PATCH] Implement '--include-externals' option to 'svn list'

2012-11-07 Thread Stefan Fuhrmann
On Wed, Nov 7, 2012 at 3:02 PM, vijay wrote: > On Tuesday 06 November 2012 08:09 PM, Stefan Fuhrmann wrote: > >> On Mon, Nov 5, 2012 at 5:24 PM, vijay > > wrote: >> >> Hi, >> >> This patch implements '--include-externals' option to 'svn list' >> [Issue #4225]

Re: [PATCH] enabling ruby in the subversion build

2012-11-07 Thread Michael Chletsos
OK - first, I would not support ruby 1.9.1 - I assume that you really have 1.9.2 (debian/ubuntu uses a meta-package)- can you show me the output of ruby -v I would support ruby 1.9.3 and above - there were issues with 1.9.1 and 1.9.2. If installing on debian/ubuntu, here are the steps for 1.9.3:

Re: [PATCH] enabling ruby in the subversion build

2012-11-07 Thread Philip Martin
Michael Chletsos writes: > Hi Philip - > > Not sure if you remember me from the Subversion Live! event the other > week (Michael with Assembla), anyhow . . . I was able to run the ruby > swig tests - though one test failed because of encoding, not a huge > deal breaker, and the regular make test

Re: [PATCH] Implement '--include-externals' option to 'svn list'

2012-11-07 Thread Stefan Sperling
On Wed, Nov 07, 2012 at 07:54:33PM +0530, vijay wrote: > Thanks stefan for your detailed review. > > I will keep in mind all your review comments. I will correct my > mistakes in future patches. > > Attached the updated patch and log message. This patch looks fine to me overall. I have one more

Re: [PATCH] Implement '--include-externals' option to 'svn list'

2012-11-07 Thread vijay
Thanks stefan for your detailed review. I will keep in mind all your review comments. I will correct my mistakes in future patches. Attached the updated patch and log message. Thanks & Regards, Vijayaguru On Tuesday 06 November 2012 07:31 PM, Stefan Sperling wrote: On Mon, Nov 05, 2012 at

Re: [PATCH] enabling ruby in the subversion build

2012-11-07 Thread Michael Chletsos
Hi Philip - Not sure if you remember me from the Subversion Live! event the other week (Michael with Assembla), anyhow . . . I was able to run the ruby swig tests - though one test failed because of encoding, not a huge deal breaker, and the regular make test ran fine - were you talking about some

Re: [PATCH] Implement '--include-externals' option to 'svn list'

2012-11-07 Thread vijay
On Tuesday 06 November 2012 08:09 PM, Stefan Fuhrmann wrote: On Mon, Nov 5, 2012 at 5:24 PM, vijay mailto:vi...@collab.net>> wrote: Hi, This patch implements '--include-externals' option to 'svn list' [Issue #4225] [1]. All tests pass with 'make check' & 'make davautocheck'.

Re: disregarding svn:global-ignores

2012-11-07 Thread Daniel Shahaf
Johan Corveleyn wrote on Wed, Nov 07, 2012 at 12:06:22 +0100: > On Wed, Nov 7, 2012 at 11:48 AM, Stefan Sperling wrote: > > On Wed, Nov 07, 2012 at 09:40:48AM +0100, Johan Corveleyn wrote: > >> I haven't tested, but wouldn't something like 'svn add --config-option > >> config:miscellany:enable-aut

Re: disregarding svn:global-ignores

2012-11-07 Thread Daniel Shahaf
Stefan Sperling wrote on Wed, Nov 07, 2012 at 11:48:59 +0100: > On Wed, Nov 07, 2012 at 09:40:48AM +0100, Johan Corveleyn wrote: > > I haven't tested, but wouldn't something like 'svn add --config-option > > config:miscellany:enable-auto-props=no' do something like that? > > Nobody wants to type

Re: Random serf checkout failures

2012-11-07 Thread Philip Martin
Ivan Zhakov writes: > Could please test attached serf patch. This patch should fix problem > with reading one connection for long time without reading from other > connections. I still see assertions with your patch and Lieven's patch together. -- Certified & Supported Apache Subversion Downlo

Re: disregarding svn:global-ignores

2012-11-07 Thread Johan Corveleyn
On Wed, Nov 7, 2012 at 11:48 AM, Stefan Sperling wrote: > On Wed, Nov 07, 2012 at 09:40:48AM +0100, Johan Corveleyn wrote: >> I haven't tested, but wouldn't something like 'svn add --config-option >> config:miscellany:enable-auto-props=no' do something like that? > > Nobody wants to type that! :)

Re: Random serf checkout failures

2012-11-07 Thread Philip Martin
Justin Erenkrantz writes: > Sure sounds like an early TCP close causing a lost response. httpd > shouldn't be closing the TCP connection in the middle of the response > as that's not when httpd would evaluate the Timeout directive...but, > if you are going over a loopback connection, I think I'v

Re: [PATCH] enabling ruby in the subversion build

2012-11-07 Thread Philip Martin
mpchlets writes: > I am also very interested in seeing this get to a state of usability - > I am willing to help also. > > If there is a current status or anyone working on this, I would love > to pitch in and get this finalized. The patch allowed the tests to build when I tried it but I could n

Re: disregarding svn:global-ignores

2012-11-07 Thread Stefan Sperling
On Wed, Nov 07, 2012 at 09:40:48AM +0100, Johan Corveleyn wrote: > I haven't tested, but wouldn't something like 'svn add --config-option > config:miscellany:enable-auto-props=no' do something like that? Nobody wants to type that! :) And you realise the --no-auto-props option already exists in 1

Re: disregarding svn:global-ignores

2012-11-07 Thread Peter Samuelson
[Branko Čibej] > "ignored" has /never/ meant that you couldn't "svn add" a file that > matches the ignore pattern. Therefore, --no-ignores should always > ignore all ignores. And for people who want the other behavior, maybe we could add a --no-ignores-well-ok-fine-maybe-some-ignores-but-not-all-

Re: AW: disregarding svn:global-ignores

2012-11-07 Thread Branko Čibej
On 07.11.2012 08:40, Markus Schaber wrote: > In my eyes, "ignored" != "forbidden". Precisely. "ignored" has /never/ meant that you couldn't "svn add" a file that matches the ignore pattern. Therefore, --no-ignores should always ignore all ignores. -- Brane

AW: disregarding svn:global-ignores

2012-11-07 Thread Markus Schaber
Hi, -Ursprüngliche Nachricht- > Von: Paul Burba [mailto:ptbu...@gmail.com] > >> On 11/06/2012 10:29 AM, Julian Foad wrote: > >>> We have three ways of specifying ignores, and we have an option > >>> that disregards them, only in one cammand it disregards all of the > >>> ways and in tw

Re: disregarding svn:global-ignores

2012-11-07 Thread Johan Corveleyn
On Wed, Nov 7, 2012 at 8:52 AM, Daniel Shahaf wrote: > Paul Burba wrote on Tue, Nov 06, 2012 at 12:01:54 -0500: >> Also keep in mind that if you really want to add an ignored file you >> can make the file the target of the 'svn add' command. Just like with >> the runtime config global-ignores and