Re: buildbot failure in ASF Buildbot on svn-slik-w2k3-x64-local

2012-12-28 Thread Dana Benson
unsubscribe On Thu, Dec 27, 2012 at 9:54 AM, wrote: > The Buildbot has detected a new failure on builder svn-slik-w2k3-x64-local > while building ASF Buildbot. > Full details are available at: > http://ci.apache.org/builders/svn-slik-w2k3-x64-local/builds/9516 > > Buildbot URL: http://ci.apach

Re: [PATCH] fix for diff optimization bug

2012-12-28 Thread Daniel Shahaf
Hi Hideki, thanks for the patch. I hope Johan or Julian will have a look (probably next year), but if you don't get a response please ping the thread and I'll have a look. Hideki IWAMOTO wrote on Sat, Dec 29, 2012 at 08:25:07 +0900: > Hi, Daniel. > > > Because I assumed using svn_diff_mem_* woul

Re: [PATCH] fix for diff optimization bug

2012-12-28 Thread Hideki IWAMOTO
Hi, Daniel. > Because I assumed using svn_diff_mem_* would reproduce issue #4133. If > it doesn't, the test should be amended to use an API that will reproduce > the issue. The cause of issue #4133 is a bugs in the calculations of svn_diff__file_token_t::norm_offset. The test that you added is

Re: 1.6.20 up for testing/signing

2012-12-28 Thread Stefan Sperling
On Thu, Dec 27, 2012 at 12:54:00PM -0800, Ben Reser wrote: > The 1.6.20 release artifacts are now available for testing/signing. > Please get the tarballs from > https://dist.apache.org/repos/dist/dev/subversion > and add your signatures there. I plan to try and release on January > 4th so please

Re: svn commit: r1426399 - /subversion/trunk/tools/server-side/svnauthz-validate.c

2012-12-28 Thread Daniel Shahaf
bre...@apache.org wrote on Fri, Dec 28, 2012 at 04:35:12 -: > Author: breser > Date: Fri Dec 28 04:35:11 2012 > New Revision: 1426399 > > URL: http://svn.apache.org/viewvc?rev=1426399&view=rev > Log: > Fix errors in usage output for svnauthz-validate. > > * tools/server-side/svnauthz-validate

Re: [PATCH] Update to out-of-date code comments

2012-12-28 Thread Daniel Shahaf
Gabriela Gibson wrote on Fri, Dec 28, 2012 at 11:47:08 +: > Corrections attached, thanks for the advice! Applie in r1426480 with minimal tweaks to the log message. Thanks!

Re: [PATCH] Update to out-of-date code comments

2012-12-28 Thread Gabriela Gibson
Corrections attached, thanks for the advice! (please pardon the thread mess, I had mail issues) Index: subversion/tests/svn_test_main.c === --- subversion/tests/svn_test_main.c (revision 1426301) +++ subversion/tests/svn_test_main.c