svn diff fix for bug 2044

2013-03-19 Thread Gabriela Gibson
Hi, I've made some changes to meet some feature requests regarding svn diff. Could you please take a look and let me know if I'm on the right track? thanks, Gabriela [[[ Change "svn diff" to allow removal of "-u" and use of arbitrary strings in place of current hard-coded "-L" switch. Thi

Re: svn diff fix for bug 2044

2013-03-19 Thread Philip Martin
Gabriela Gibson writes: > Index: subversion/libsvn_subr/io.c > === > --- subversion/libsvn_subr/io.c (revision 1458203) > +++ subversion/libsvn_subr/io.c (working copy) > @@ -2831,7 +2831,105 @@ svn_io_run_cmd(const char

Re: SVN upgrade error

2013-03-19 Thread Philip Martin
Scott Hartman writes: > In file > > 'D:\Development\SVN\Releases\TortoiseSVN-1.7.11\ext\subversion\subversion\libsvn_wc\entries.c' > line 1666: assertion failed (parent_node || entry->schedule == > svn_wc_schedule_normal) Were there any "Upgraded ..." lines printed before this error? Do you

Re: [PATCH] Adding tests for some function in svn_checksum.h in SWIG bindings for python

2013-03-19 Thread Philip Martin
Shivani Poddar writes: > Index: subversion/bindings/swig/python/tests/checksum.py > === > --- subversion/bindings/swig/python/tests/checksum.py (revision 1448005) > +++ subversion/bindings/swig/python/tests/checksum.py (working copy)

Re: [PATCH] Adding tests for some function in svn_checksum.h in SWIG bindings for python

2013-03-19 Thread Shivani Poddar
On Tue, Mar 19, 2013 at 5:58 PM, Philip Martin wrote: > Shivani Poddar writes: > > > Index: subversion/bindings/swig/python/tests/checksum.py > > === > > --- subversion/bindings/swig/python/tests/checksum.py (revision 1448005) > > ++

Re: svn diff fix for bug 2044

2013-03-19 Thread Julian Foad
Hi Gabriela. Gabriela Gibson wrote: > I've made some changes to meet some feature requests regarding svn diff. > > Could you please take a look and let me know if I'm on the right track? > [[[ > Change "svn diff" to allow removal of "-u" and use of > arbitrary strings in place of current hard-

Re: [PATCH] Adding tests for some function in svn_checksum.h in SWIG bindings for python

2013-03-19 Thread Philip Martin
Shivani Poddar writes: > On Tue, Mar 19, 2013 at 5:58 PM, Philip Martin > wrote: > >> Shivani Poddar writes: >> >> > Index: subversion/bindings/swig/python/tests/checksum.py >> > === >> > --- subversion/bindings/swig/python/tests/ch

Memory leak in svn log (1.7.5) with svn+ssh?

2013-03-19 Thread Vincent Lefevre
On Debian and Ubuntu GNU/Linux machines, when I run "svn log" in some working copy or on some repository URL using the svn+ssh scheme, such as with svn log | tail or, if this is too fast, svn log | less (and searching for a pattern near the end of the output), I notice that the RES memory o

Re: Security advisories

2013-03-19 Thread C. Michael Pilato
On 03/18/2013 06:07 PM, Ben Reser wrote: > I think we should produce advisories for all vulnerabilities in > Subversion. +1. (Which, in response to such a thorough email, feels about the same as "me too!". But I really did read and comprehend your mail, I swear!) -- C. Michael Pilato CollabNe

Re: Issue 3247 "merge doesn't honour specified source"

2013-03-19 Thread Paul Burba
On Mon, Mar 18, 2013 at 6:40 PM, Philip Martin wrote: > Paul Burba writes: > >> On Mon, Mar 18, 2013 at 3:26 PM, Philip Martin >> wrote: >>> This is one of the issues blocking 1.8. I don't really understand the >>> merge behaviour. Consider this test case: a file in a directory, >>> branch, mod

Re: Issue 3247 "merge doesn't honour specified source"

2013-03-19 Thread Philip Martin
Paul Burba writes: > Where we can improve is in skipping the '[Recording | Eliding] > mergeinfo' notifications if nothing was actually merged. Essentially we are skipping a reverse merge because we cannot record it. That's fine by me so long as we make it clear to the user. This is clear: $ sv

Re: Memory leak in svn log (1.7.5) with svn+ssh?

2013-03-19 Thread Philip Martin
Vincent Lefevre writes: > On Debian and Ubuntu GNU/Linux machines, when I run "svn log" in some > working copy or on some repository URL using the svn+ssh scheme, such > as with > > svn log | tail > > or, if this is too fast, > > svn log | less > > (and searching for a pattern near the end of

Re: Issue 3247 "merge doesn't honour specified source"

2013-03-19 Thread Paul Burba
On Tue, Mar 19, 2013 at 10:56 AM, Philip Martin wrote: > Paul Burba writes: > >> Where we can improve is in skipping the '[Recording | Eliding] >> mergeinfo' notifications if nothing was actually merged. > > Essentially we are skipping a reverse merge because we cannot record > it. That's fine by

Re: [PATCH] Adding tests for some function in svn_checksum.h in SWIG bindings for python

2013-03-19 Thread Shivani Poddar
On Tue, Mar 19, 2013 at 7:05 PM, Philip Martin wrote: > Shivani Poddar writes: > > > On Tue, Mar 19, 2013 at 5:58 PM, Philip Martin > > wrote: > > > >> Shivani Poddar writes: > >> > >> > Index: subversion/bindings/swig/python/tests/checksum.py > >> > =

Re: [PATCH] Adding tests for some function in svn_checksum.h in SWIG bindings for python

2013-03-19 Thread Philip Martin
Shivani Poddar writes: > Unless I don't assign the kind and digest some value for the object I > declare here , calling svn_checksum_clear() on it will give me a > segmentation fault , could you please elaborate more as to why should I > have to call svn_checksum_clear() before assigning the dige

Re: [PATCH] Adding tests for some function in svn_checksum.h in SWIG bindings for python

2013-03-19 Thread Philip Martin
Philip Martin writes: > Shivani Poddar writes: > >> Unless I don't assign the kind and digest some value for the object I >> declare here , calling svn_checksum_clear() on it will give me a >> segmentation fault , could you please elaborate more as to why should I >> have to call svn_checksum_cl

Re: [Issue 3295] diff local changes against arbitrary URL@REV ignores local add

2013-03-19 Thread Paul Burba
On Sun, Feb 10, 2013 at 12:51 PM, wrote: > http://subversion.tigris.org/issues/show_bug.cgi?id=3295 > > User rhuijben changed the following: > > What|Old value |New value > >

Re: [PATCH] Adding tests for some function in svn_checksum.h in SWIG bindings for python

2013-03-19 Thread Philip Martin
Philip Martin writes: > 'd41d8cd98f00b204e9800998ecf8427e' is the MD5 of the empty string and > Subversion has special handling of that checksum. I made a mistake here. 'd41d8cd98f00b204e9800998ecf8427e' is the checksum of the empty string: $ echo -n | md5sum d41d8cd98f00b204e9800998ecf8

Re: [Issue 4098] Possible bug in 1.7: svn cleanup can't recover after a failed update (with 1.6 it was possible)

2013-03-19 Thread Paul Burba
On Mon, Jan 21, 2013 at 10:29 AM, wrote: > http://subversion.tigris.org/issues/show_bug.cgi?id=4098 > > User rhuijben changed the following: > > What|Old value |New value > >

Re: [PATCH] Adding tests for some function in svn_checksum.h in SWIG bindings for python

2013-03-19 Thread Shivani Poddar
Yes, so as of now both these checksums should be handles by svn_checksum() itself. On Tue, Mar 19, 2013 at 10:35 PM, Philip Martin wrote: > Philip Martin writes: > > > 'd41d8cd98f00b204e9800998ecf8427e' is the MD5 of the empty string and > > Subversion has special handling of that checksum. > >

API review: "repository relative URL" or "relative repository URL"

2013-03-19 Thread C. Michael Pilato
svn_path.h added two new APIs since 1.7.x, svn_path_is_repos_relative_url() and svn_path_resolve_repos_relative_url(). These functions have in common this nomenclature of a "repository relative URL". But elsewhere, I see references to a "relative repository URL". Do we have a preferred syntax fo

Re: svn diff fix for bug 2044

2013-03-19 Thread Gabriela Gibson
On 19/03/13 13:09, Julian Foad wrote: Julian Foad wrote: > For the record, the summary line of issue #2044 is 'Fully customizable > external diff invocations'. (I like to mention the summary alongside > the number as I am not good at memorizing issue numbers.) I'm curious > about your patch becau

Re: API review: "repository relative URL" or "relative repository URL"

2013-03-19 Thread Julian Foad
C. Michael Pilato wrote: > svn_path.h added two new APIs since 1.7.x, svn_path_is_repos_relative_url() > and svn_path_resolve_repos_relative_url().  These functions have in common > this nomenclature of a "repository relative URL".  But elsewhere, I see > references to a "relative repository URL".

Re: svn diff fix for bug 2044

2013-03-19 Thread Johan Corveleyn
On Tue, Mar 19, 2013 at 8:56 PM, Gabriela Gibson wrote: > On 19/03/13 13:09, Julian Foad wrote: > > Julian Foad wrote: > >> For the record, the summary line of issue #2044 is 'Fully customizable >> external diff invocations'. (I like to mention the summary alongside >> the number as I am not good

Re: svn diff fix for bug 2044

2013-03-19 Thread Julian Foad
Gabriela Gibson wrote: > On 19/03/13 13:09, Julian Foad wrote: >> For the record, the summary line of issue #2044 is 'Fully customizable >> external diff invocations'. (I like to mention the summary alongside >> the number as I am not good at memorizing issue numbers.) I'm curious >> about you

Re: svn diff fix for bug 2044

2013-03-19 Thread Julian Foad
I (Julian Foad) wrote: > [...]  For example, one possibility is we could use some sort of > pattern-substitution in a specified template: we could take a pattern > argument, in which any text enclosed in angle brackets is a special > keyword that Subversion replaces with one of a small fixed set of

Re: svn diff fix for bug 2044

2013-03-19 Thread Stefan Sperling
On Tue, Mar 19, 2013 at 09:28:50PM +, Julian Foad wrote: > Of course, users won't normally want to be typing this configuration > on the command line, they'll want it to be in a config file.  But it's > useful to have the possibility of doing it on the command line as > well. If it's a config

RE: SVN upgrade error

2013-03-19 Thread Bert Huijben
> -Original Message- > From: MARTIN PHILIP [mailto:codematt...@ntlworld.com] On Behalf Of > Philip Martin > Sent: dinsdag 19 maart 2013 05:10 > To: Scott Hartman > Cc: dev@subversion.apache.org > Subject: Re: SVN upgrade error > > Scott Hartman writes: > > > In file > > 'D:\Developmen

RE: svn commit: r1458301 - /subversion/trunk/subversion/include/svn_dav.h

2013-03-19 Thread Bert Huijben
> -Original Message- > From: cmpil...@apache.org [mailto:cmpil...@apache.org] > Sent: dinsdag 19 maart 2013 07:15 > To: comm...@subversion.apache.org > Subject: svn commit: r1458301 - > /subversion/trunk/subversion/include/svn_dav.h > > Author: cmpilato > Date: Tue Mar 19 14:14:52 2013 >

[PATCH] subversion/svn/cl.h comment tidying

2013-03-19 Thread Gabriela Gibson
[[[ Align comments for easier reading. *subversion/svn/cl.h: (svn_cl__opt_state_t): align comments. Patch by: Gabriela Gibson ]]] (this has been catching my eye every time I saw the file ;-) Index: subversion/svn/cl.h === ---

Re: svn commit: r1458301 - /subversion/trunk/subversion/include/svn_dav.h

2013-03-19 Thread C. Michael Pilato
On 03/19/2013 07:47 PM, Bert Huijben wrote: > This makes the total string to long according to the maximum defined > length in the documentation somewhere. (62 or 64 if I remember > correctly?) > > It won't break Subversion, but it might break some other WEBDAV clients. > (I think you were the on

Re: [PATCH] subversion/svn/cl.h comment tidying

2013-03-19 Thread Daniel Shahaf
Gabriela Gibson wrote on Tue, Mar 19, 2013 at 23:51:06 +: > [[[ > Align comments for easier reading. > > *subversion/svn/cl.h: >(svn_cl__opt_state_t): align comments. > > Patch by: Gabriela Gibson > ]]] > > (this has been catching my eye every time I saw the file ;-) +1

Re: API review: "repository relative URL" or "relative repository URL"

2013-03-19 Thread Branko Čibej
On 19.03.2013 21:38, Julian Foad wrote: > C. Michael Pilato wrote: > >> svn_path.h added two new APIs since 1.7.x, svn_path_is_repos_relative_url() >> and svn_path_resolve_repos_relative_url(). These functions have in common >> this nomenclature of a "repository relative URL". But elsewhere, I se

Re: Use svn_hash_gets

2013-03-19 Thread Branko Čibej
On 20.03.2013 04:47, Daniel Shahaf wrote: > See attached patch. Any objections to doing that (and similar changes > to the rest of the code)? Must we do this just before branching? I suppose it's a benign change, but it /is/ a lot of code churn. -- Brane -- Branko Čibej Director of Subversion

Re: [Issue 3913] "svnrdump load" is not working in interactive mode

2013-03-19 Thread Branko Čibej
On 18.03.2013 16:12, phi...@tigris.org wrote: > http://subversion.tigris.org/issues/show_bug.cgi?id=3913 > > --- Additional comments from phi...@tigris.org Mon Mar 18 08:12:42 -0700 > 2013 --- > The current behaviour is a deliberate design, see the log for r1424037. The > clients automati