Re: svn commit: r1464228 - in /subversion/trunk/subversion/libsvn_ra_serf: sb_bucket.c util.c

2013-04-04 Thread Branko Čibej
On 04.04.2013 23:17, Daniel Shahaf wrote: > Lieven Govaerts wrote on Thu, Apr 04, 2013 at 22:03:35 +0200: >> Hi Branko, >> >> On Thu, Apr 4, 2013 at 8:59 PM, Branko Čibej wrote: >>> On 04.04.2013 20:46, Lieven Govaerts wrote: On Thu, Apr 4, 2013 at 1:28 PM, Philip Martin wrote: > Li

Re: Denial of Service: PROPFIND on Activity URL

2013-04-04 Thread Ben Reser
The fix for this issue is included in the 1.6.21 and 1.7.9 versions of Subversion. Our advisory for this issue is public and published here: http://subversion.apache.org/security/CVE-2013-1849-advisory.txt On Thu, Mar 28, 2013 at 9:48 PM, Ben Reser wrote: > Fix for this is included in the 1.6.21

Re: [PATCH] Sleep for timestamps in the right places

2013-04-04 Thread Julian Foad
Julian Foad wrote: >>[...]   As it is >> right now if you're keeping your clocks in sync it should work okay. >> But unless I'm missing something that's not the case after this >> change. > > That's true, given that the current implementation doesn't look at the > timestamps when deciding whe

Re: svn commit: r1464228 - in /subversion/trunk/subversion/libsvn_ra_serf: sb_bucket.c util.c

2013-04-04 Thread Daniel Shahaf
Lieven Govaerts wrote on Thu, Apr 04, 2013 at 22:03:35 +0200: > Hi Branko, > > On Thu, Apr 4, 2013 at 8:59 PM, Branko Čibej wrote: > > On 04.04.2013 20:46, Lieven Govaerts wrote: > >> On Thu, Apr 4, 2013 at 1:28 PM, Philip Martin > >> wrote: > >>> Lieven Govaerts writes: > >>> > On Thu, Ap

Apache Subversion 1.7.9 released

2013-04-04 Thread Ben Reser
I'm happy to announce the release of Apache Subversion 1.7.9. Please choose the mirror closest to you by visiting: http://subversion.apache.org/download/?update=201304041700#recommended-release This release addesses five security issues: CVE-2013-1845: mod_dav_svn excessive memory usage

Subversion 1.6.21 released

2013-04-04 Thread Ben Reser
I'm happy to announce the release of Subversion 1.6.21. Please choose the mirror closest to you by visiting: http://subversion.apache.org/download/#supported-releases This release addesses four security issues: CVE-2013-1845: mod_dav_svn excessive memory usage from property changes CV

Re: [PATCH] Sleep for timestamps in the right places

2013-04-04 Thread Julian Foad
Ben Reser wrote: > On Tue, Apr 2, 2013 at 1:04 PM, Julian Foad wrote: >> Philip Martin wrote: >>> Could we check use-commit-times and avoid the sleep?  Either before >>> sleeping or perhaps where we set sleep_here TRUE. >> >> OK, thanks; I did that (inside update_internal()), and a few more things

Re: svn commit: r1464228 - in /subversion/trunk/subversion/libsvn_ra_serf: sb_bucket.c util.c

2013-04-04 Thread Lieven Govaerts
Hi Branko, On Thu, Apr 4, 2013 at 8:59 PM, Branko Čibej wrote: > On 04.04.2013 20:46, Lieven Govaerts wrote: >> On Thu, Apr 4, 2013 at 1:28 PM, Philip Martin >> wrote: >>> Lieven Govaerts writes: >>> On Thu, Apr 4, 2013 at 12:55 AM, phi...@apache.org wrote: > Author: philip

Re: svn commit: r1464228 - in /subversion/trunk/subversion/libsvn_ra_serf: sb_bucket.c util.c

2013-04-04 Thread Branko Čibej
On 04.04.2013 20:46, Lieven Govaerts wrote: > On Thu, Apr 4, 2013 at 1:28 PM, Philip Martin > wrote: >> Lieven Govaerts writes: >> >>> On Thu, Apr 4, 2013 at 12:55 AM, phi...@apache.org >>> wrote: Author: philip Date: Wed Apr 3 22:55:37 2013 New Revision: 1464228 URL:

Re: svn commit: r1464228 - in /subversion/trunk/subversion/libsvn_ra_serf: sb_bucket.c util.c

2013-04-04 Thread Lieven Govaerts
On Thu, Apr 4, 2013 at 1:28 PM, Philip Martin wrote: > Lieven Govaerts writes: > >> On Thu, Apr 4, 2013 at 12:55 AM, phi...@apache.org wrote: >>> Author: philip >>> Date: Wed Apr 3 22:55:37 2013 >>> New Revision: 1464228 >>> >>> URL: http://svn.apache.org/r1464228 >>> Log: >>> Remove (void) cas

Re: Horrible error message on refused diff

2013-04-04 Thread Ben Reser
On Thu, Apr 4, 2013 at 3:19 AM, Bert Huijben wrote: > (The stacktrace above the error is maintainer only) Yup I realized this. I left it in to help me or anyone else who wanted to try and figure it out. > I added a regression test reproducing the specific error in r1464416, which > should make

Re: Problems Reintegrating the fsfs-format7 branch

2013-04-04 Thread Julian Foad
Paul Burba wrote: > On Fri, Mar 22, 2013 at 2:39 PM, Julian Foad wrote: >> Paul Burba wrote: >>> On Fri, Mar 8, 2013 at 4:17 PM, Paul Burba wrote: The attached patch accomplishes, let's call it "2.5", because it handles the more general case I outlined above, but not the case repres

Re: issue 4345: switch/delete/commit confusion

2013-04-04 Thread Philip Martin
"Bert Huijben" writes: >> -Original Message- >> From: MARTIN PHILIP [mailto:codematt...@ntlworld.com] On Behalf Of >> Philip Martin >> Sent: donderdag 4 april 2013 14:23 >> To: Bert Huijben >> Cc: 'Philip Martin'; dev@subversion.apache.org >> Subject: Re: issue 4345: switch/delete/commit

RE: issue 4345: switch/delete/commit confusion

2013-04-04 Thread Bert Huijben
> -Original Message- > From: MARTIN PHILIP [mailto:codematt...@ntlworld.com] On Behalf Of > Philip Martin > Sent: donderdag 4 april 2013 14:23 > To: Bert Huijben > Cc: 'Philip Martin'; dev@subversion.apache.org > Subject: Re: issue 4345: switch/delete/commit confusion > > "Bert Huijben"

Re: issue 4345: switch/delete/commit confusion

2013-04-04 Thread Philip Martin
"Bert Huijben" writes: >> -Original Message- >> From: MARTIN PHILIP [mailto:codematt...@ntlworld.com] On Behalf Of >> Philip Martin >> Sent: donderdag 4 april 2013 13:19 >> To: dev@subversion.apache.org >> Subject: issue 4345: switch/delete/commit confusion >> >> Prompted by a question o

RE: issue 4345: switch/delete/commit confusion

2013-04-04 Thread Bert Huijben
> -Original Message- > From: MARTIN PHILIP [mailto:codematt...@ntlworld.com] On Behalf Of > Philip Martin > Sent: donderdag 4 april 2013 13:19 > To: dev@subversion.apache.org > Subject: issue 4345: switch/delete/commit confusion > > Prompted by a question on users: > http://subversion.ti

Re: svnadmin info command was: svn commit: r1464089 - /subversion/branches/fsfs-format7/BRANCH-README

2013-04-04 Thread Daniel Shahaf
Stefan Fuhrmann wrote on Thu, Apr 04, 2013 at 12:00:44 +0200: > Maybe, we can display the last packed rev plus an estimate > of how many files will get saved by running svnadmin pack. FWIW, as an admin I'm also interested in the size of those files, since packing a 1GB shard on filesystem with sna

Re: svn commit: r1464228 - in /subversion/trunk/subversion/libsvn_ra_serf: sb_bucket.c util.c

2013-04-04 Thread Philip Martin
Lieven Govaerts writes: > On Thu, Apr 4, 2013 at 12:55 AM, phi...@apache.org wrote: >> Author: philip >> Date: Wed Apr 3 22:55:37 2013 >> New Revision: 1464228 >> >> URL: http://svn.apache.org/r1464228 >> Log: >> Remove (void) casts of ignored return values from ra_serf. >> >> * subversion/libs

issue 4345: switch/delete/commit confusion

2013-04-04 Thread Philip Martin
Prompted by a question on users: http://subversion.tigris.org/issues/show_bug.cgi?id=4345 - switch a file - delete the switched file - run status/info - commit The behaviour varies with client version: 1.6) status: D and S, info: switched URL, commit: switched URL. 1.7) status: D, info: s

Re: svn commit: r1464228 - in /subversion/trunk/subversion/libsvn_ra_serf: sb_bucket.c util.c

2013-04-04 Thread Lieven Govaerts
Hi Philip, On Thu, Apr 4, 2013 at 12:55 AM, phi...@apache.org wrote: > Author: philip > Date: Wed Apr 3 22:55:37 2013 > New Revision: 1464228 > > URL: http://svn.apache.org/r1464228 > Log: > Remove (void) casts of ignored return values from ra_serf. > > * subversion/libsvn_ra_serf/util.c > (sv

RE: Horrible error message on refused diff

2013-04-04 Thread Bert Huijben
> -Original Message- > From: Ben Reser [mailto:b...@reser.org] > Sent: donderdag 4 april 2013 06:09 > To: Subversion Development > Subject: Horrible error message on refused diff > > Was trying to look at a commit that was in another part of the ASF > repo today. Wanted to see the log a

Re: BDB segv with NULL checksum

2013-04-04 Thread Philip Martin
That makes sense, I've committed r1464413. Ben Reser writes: > You should apply the later one. The check for the kind is redundant. > > Just before this check we call svn_fs_base__dag_file_checksum() and > specify that we want tb->base_checksum->kind. Ultimately, this calls > svn_fs_base__rep_

Re: svnadmin info command was: svn commit: r1464089 - /subversion/branches/fsfs-format7/BRANCH-README

2013-04-04 Thread Stefan Fuhrmann
On Wed, Apr 3, 2013 at 7:15 PM, Daniel Shahaf wrote: > Mark Phippard wrote on Wed, Apr 03, 2013 at 13:10:54 -0400: > > On Wed, Apr 3, 2013 at 12:15 PM, wrote: > > > > > > +(danielsh adds: if we do this, would be nice to have 'svnadmin info' > command > > > +that prints the equivalent of `cat fs-

Re: Horrible error message on refused diff

2013-04-04 Thread Stefan Sperling
On Thu, Apr 04, 2013 at 09:43:52AM +0200, Stefan Sperling wrote: > My favourite new bad error message in 1.8 is the one that says > "decompression failed" (or something like that, from serf) > which happens when I commit to svn.a.o and update immediately > after (before the EU mirror has caught up

Re: Horrible error message on refused diff

2013-04-04 Thread Stefan Sperling
On Wed, Apr 03, 2013 at 09:09:10PM -0700, Ben Reser wrote: > The 1.8 error message to be frank, stinks. There are many many bad error messages in SVN. Poor error messages have always been an issue: http://subversion.tigris.org/issues/show_bug.cgi?id=1254 I've collected some reasons and hilarious