On Sun Aug 18 18:23:17 2013, Ivan Zhakov wrote:
> Do we localize commas in current code? (I do not have source code
> acces now)
Not that I'm aware of but I can say that '%s' is turned into »%s« in
German. Branko has already given an example of a locale where commas
would be changed. I see no
On 8/15/13 8:15 PM, Ben Reser wrote:
> Not sure if this is really complete. I don't think the directory case
> or the property case really should be using the dst_rev_pool. In fact
> I really don't understand why the replay_ctx->file_pool exists as well
> as the info->pool. I think we should pr
On Sunday, August 18, 2013, Branko Čibej wrote:
> On 18.08.2013 20:04, Ivan Zhakov wrote:
> > The code could be improved btw: remove ', ' and ': ' from loclized
> > strings and them seaparately to prevent translators broke output
> > accidently.
>
> That assumes that both ', ' and ': ' are valid i
1.7.0@1181106 vs. trunk@1515237
Started at Mon Aug 19 00:26:03 UTC 2013
*DISCLAIMER* - This tests only file://-URL access on a GNU/Linux VM.
This is intended to measure changes in performance of the local working
copy layer, *only*. These results are *not* generally true for everyone.
Charts of t
On 8/18/13 12:03 PM, Branko Čibej wrote:
> On 18.08.2013 20:04, Ivan Zhakov wrote:
>> The code could be improved btw: remove ', ' and ': ' from loclized
>> strings and them seaparately to prevent translators broke output
>> accidently.
>
> That assumes that both ', ' and ': ' are valid in all lang
On Sun Aug 18 09:51:13 2013, build...@apache.org wrote:
> The Buildbot has detected a restored build on builder
> svn-backport-conflicts-1.6.x while building ASF Buildbot.
> Full details are available at:
> http://ci.apache.org/builders/svn-backport-conflicts-1.6.x/builds/1059
>
> Buildbot URL: h
On Sun, Aug 18, 2013 at 10:01:51PM +0300, Daniel Shahaf wrote:
> Ivan Zhakov wrote on Sun, Aug 18, 2013 at 22:04:58 +0400:
> > > * r1514785
> > > ra_serf: Improve SSL certificate verification failure message.
> > > @@ -211,6 +210,8 @@ Candidate changes:
> > > informative. Regression fro
On 18.08.2013 20:04, Ivan Zhakov wrote:
> The code could be improved btw: remove ', ' and ': ' from loclized
> strings and them seaparately to prevent translators broke output
> accidently.
That assumes that both ', ' and ': ' are valid in all languages, which
is very likely not the case.
-- Bran
Ivan Zhakov wrote on Sun, Aug 18, 2013 at 22:04:58 +0400:
> > * r1514785
> > ra_serf: Improve SSL certificate verification failure message.
> > @@ -211,6 +210,8 @@ Candidate changes:
> > informative. Regression from Subversion 1.7.x
> > Votes:
> > +1: ivan, stefan2
> > + d
> * r1514785
> ra_serf: Improve SSL certificate verification failure message.
> @@ -211,6 +210,8 @@ Candidate changes:
> informative. Regression from Subversion 1.7.x
> Votes:
> +1: ivan, stefan2
> + danielsh: I believe chopping off the last 2 bytes is wrong, _(", ")
> wou
On 8/18/13 5:34 AM, Daniel Shahaf wrote:
> Haven't looked at the rest of the patch, perhaps Ben will as he reviewed
> an earlier iteration. (but I know he is a bit busy this week, including
> a release tomorrow and several other things..)
It's starred in my mailbox.
Masaru Tsuchiyama wrote on Sun, Aug 18, 2013 at 22:58:09 +0900:
>> To further explain this consideration: even if both existence and
>> permissions were checked, the code would *still* be wrong if args[0]
>> were a directory. If an .isdir() check were added, the code would
>> still be wrong if arg
Daniel Shahaf wrote:
r1515111, thanks.
Masaru Tsuchiyama wrote on Sun, Aug 18, 2013 at 22:43:58 +0900:
- # client converts to local encoding and local eoln style.
+ # client converts to local encoding and local eol style.
thanks
--
Masaru Tsuchiyama
To further explain this consideration: even if both existence and
permissions were checked, the code would *still* be wrong if args[0]
were a directory. If an .isdir() check were added, the code would
still be wrong if args[0] were a dangling symlink. And so on.
Calling open() will detect all t
r1515111, thanks.
Masaru Tsuchiyama wrote on Sun, Aug 18, 2013 at 22:43:58 +0900:
> - # client converts to local encoding and local eoln style.
> + # client converts to local encoding and local eol style.
I attach a patch to fix typo in comment.
[[[
fix typo in comment
* subversion/tests/cmdline/prop_tests.py
(prop_value_conversions) : fix typo in comment.
]]]
Regards.
--
Masaru Tsuchiyama
Index: subversion/tests/cmdline/prop_tests.py
Daniel Shahaf wrote on Sun, Aug 18, 2013 at 16:30:45 +0300:
> Masaru Tsuchiyama wrote on Sun, Aug 18, 2013 at 22:13:54 +0900:
> > Daniel Shahaf wrote:
> >> I think that's the wrong fix. Input validation should be done by
> >> checking that the input is valid, not by ruling out every known invalid
Masaru Tsuchiyama wrote on Sun, Aug 18, 2013 at 22:13:54 +0900:
> Daniel Shahaf wrote:
>> I think that's the wrong fix. Input validation should be done by
>> checking that the input is valid, not by ruling out every known invalid
>> value.[1] In this case: by checking os.path.exists() at the poin
Daniel Shahaf wrote:
I think that's the wrong fix. Input validation should be done by
checking that the input is valid, not by ruling out every known invalid
value.[1] In this case: by checking os.path.exists() at the point in the
code that tries to interpret the argument as a filename.
Fixed
Daniel Shahaf wrote:
+# pass "--" to tell commands that 'self.__repospath' is not a
command-line option.
+cmd = [ self.__svn_path, "log", "-l 1", "-q", "--", self.__repospath ]
["-l 1"] should be either ["-l1"] or ["-l", "1"].
Fixed in the attached patch.
--
Masaru Tsuchiya
Masaru Tsuchiyama wrote on Thu, Aug 15, 2013 at 15:06:12 +0900:
> I added "--" to the command line options.
Thanks.
> +# pass "--" to tell commands that 'self.__repospath' is not a
> command-line option.
> +cmd = [ self.__svn_path, "log", "-l 1", "-q", "--", self.__repospath
> ]
On 18.08.2013 14:25, Branko Čibej wrote:
> On 18.08.2013 14:15, stef...@apache.org wrote:
>> Author: stefan2
>> Date: Sun Aug 18 12:15:01 2013
>> New Revision: 1515088
>>
>> URL: http://svn.apache.org/r1515088
>> Log:
>> On the log-addressing branch: For low-overhead checksumming,
>> add standard
On 18.08.2013 14:15, stef...@apache.org wrote:
> Author: stefan2
> Date: Sun Aug 18 12:15:01 2013
> New Revision: 1515088
>
> URL: http://svn.apache.org/r1515088
> Log:
> On the log-addressing branch: For low-overhead checksumming,
> add standard FNV-1a and a faster modified version of that to
> t
> Index: gen-make.py
> ===
> --- gen-make.py (revision 1514179)
> +++ gen-make.py (working copy)
> @@ -278,6 +278,9 @@ if __name__ == '__main__':
>except getopt.GetoptError, e:
> _usage_exit(str(e))
>
> + if arg
Ben Reser wrote on Thu, Aug 15, 2013 at 21:27:40 -0700:
> Probably should fix 1.7.x to not try to use the none command when ruby
> isn't detected and to emit a proper error message.
FWIW, this is reproducible in trunk,
% RUBY=none ./configure
% make
% make swig-rb
I've looked into a patch. Att
Bert Huijben wrote on Mon, Aug 12, 2013 at 14:16:40 +0200:
>
>
> > -Original Message-
> > From: Ivan Zhakov [mailto:i...@visualsvn.com]
> > Sent: maandag 15 juli 2013 18:35
> > To: Subversion Development; Daniel Shahaf
> > Cc: Bert Huijben
> > Subject: Re: Semantics of svn_error_t->apr_er
26 matches
Mail list logo
