syntax for --invoke-diff-cmd (was: Branch 'invoke-diff-cmd-feature' is ready for half-way review)

2013-10-28 Thread Johan Corveleyn
[ Changing subject because perhaps some more discussion might arise. More below. ] On Mon, Oct 28, 2013 at 11:48 PM, Johan Corveleyn wrote: > On Fri, Oct 18, 2013 at 8:29 PM, Gabriela Gibson > wrote: > ... >> 2.) The delimiter: >> >> There appears to be some team miscommunication here -- afaik,

Re: Branch 'invoke-diff-cmd-feature' is ready for half-way review

2013-10-28 Thread Johan Corveleyn
On Fri, Oct 18, 2013 at 8:29 PM, Gabriela Gibson wrote: ... > 2.) The delimiter: > > There appears to be some team miscommunication here -- afaik, the last > status was that danielsh asked me to implement the semi-colon, so this > is what you got^Whad :) > > Now I had a long think and realised the

Re: 1.8.4 up for testing/signing

2013-10-28 Thread Ben Reser
On 10/23/13 1:47 PM, Ben Reser wrote: > Yeah that's definitely the problem. When Apple built APR they did the > following to set their C compiler: CC=`xcrun --find cc` which finds the C > compiler in the XCode install instead of using the command line tool mapping > that is now optional. The prob

Re: depth-test.py failing

2013-10-28 Thread Philip Martin
Branko Čibej writes: >> We should write a regression test for out SQLite wrapper code with a >> statement that has a successful step before a failed step. Does that >> mean it has to be a SELECT? If so, how do we get it to fail after a >> successful step? Could we use a scalar function to do t

Re: depth-test.py failing

2013-10-28 Thread Branko Čibej
On 28.10.2013 13:48, Philip Martin wrote: > Branko Čibej writes: > >> On 28.10.2013 12:24, Philip Martin wrote: >>> Branko Čibej writes: >>> On 28.10.2013 10:07, Branko Čibej wrote: > It turns out that sqlite3_reset fails, which is why we ultimately get > the assertion during pool cl

Re: depth-test.py failing

2013-10-28 Thread Philip Martin
Branko Čibej writes: > On 28.10.2013 12:24, Philip Martin wrote: >> Branko Čibej writes: >> >>> On 28.10.2013 10:07, Branko Čibej wrote: It turns out that sqlite3_reset fails, which is why we ultimately get the assertion during pool cleanup. This appears to be due to a bug in our

Re: depth-test.py failing

2013-10-28 Thread Branko Čibej
On 28.10.2013 12:24, Philip Martin wrote: > Branko Čibej writes: > >> On 28.10.2013 10:07, Branko Čibej wrote: >>> It turns out that sqlite3_reset fails, which is why we ultimately get >>> the assertion during pool cleanup. This appears to be due to a bug in >>> our code; we call svn_sqlite__reset

Re: depth-test.py failing

2013-10-28 Thread Philip Martin
Branko Čibej writes: > On 28.10.2013 10:07, Branko Čibej wrote: >> It turns out that sqlite3_reset fails, which is why we ultimately get >> the assertion during pool cleanup. This appears to be due to a bug in >> our code; we call svn_sqlite__reset (and thus sqlite3_reset) if >> sqlite3_step fail

Re: depth-test.py failing

2013-10-28 Thread Branko Čibej
On 28.10.2013 10:07, Branko Čibej wrote: > On 28.10.2013 07:03, Branko Čibej wrote: >> On 27.10.2013 03:36, Branko Čibej wrote: >>> I'm getting really weird failures in depth-test.py on Mac OS. I noticed >>> it first in my trunk working copy (out-of-source build); a test was >>> asserting in libsvn

Re: depth-test.py failing

2013-10-28 Thread Branko Čibej
On 28.10.2013 07:03, Branko Čibej wrote: > On 27.10.2013 03:36, Branko Čibej wrote: >> I'm getting really weird failures in depth-test.py on Mac OS. I noticed >> it first in my trunk working copy (out-of-source build); a test was >> asserting in libsvn_subr/sqlite.c:856 (i.e., a statement was not >