Re: svn commit: r1543985 - in /subversion/trunk/subversion/bindings/javahl: native/ native/jniwrapper/ src/org/apache/subversion/javahl/types/ src/org/apache/subversion/javahl/util/ tests/org/apache/s

2013-11-20 Thread Branko Čibej
On 21.11.2013 03:11, Bert Huijben wrote: > Branko, > > I might have found the cause of the error. See snippet below Ouch. Thanks for the review; and of course you're right. -- Brane > *From:* Branko Čibej > *Sent:* ‎Thursday‎, ‎November‎ ‎21‎, ‎2013 ‎12‎:‎43‎ ‎AM > *To

[PATCH] Fix for `svn patch` changing permissions of patched files

2013-11-20 Thread Cathy Fitzpatrick
Hello, Currently the `svn patch` command changes the permissions on any file it patches to 600. This occurs because it creates a file under the system temporary directory for applying the patch, and then copies this file to the final destination. `apr_file_mktemp` sensibly assigns mode 600 to file

Re: svn commit: r1540590 - bad use of SVN_INT_ERR

2013-11-20 Thread Stefan Fuhrmann
On Wed, Nov 20, 2013 at 6:00 PM, Julian Foad wrote: > > URL: http://svn.apache.org/r1540590 > > > > Added: subversion/trunk/subversion/libsvn_subr/object_pool.c > > > == > [...] > > +/* Cleanup function called when an obje

Re: svn commit: r1543985 - in /subversion/trunk/subversion/bindings/javahl: native/ native/jniwrapper/ src/org/apache/subversion/javahl/types/ src/org/apache/subversion/javahl/util/ tests/org/apache/s

2013-11-20 Thread Bert Huijben
Branko, I might have found the cause of the error. See snippet below Bert Sent from Windows Mail From: Branko Čibej Sent: ‎Thursday‎, ‎November‎ ‎21‎, ‎2013 ‎12‎:‎43‎ ‎AM To: comm...@subversion.apache.org +class KeywordHashBuilder +{ +public: + explicit KeywordHashBuilder(const SVN

Re: Auth providers and problems with our packaging

2013-11-20 Thread Ben Reser
On 6/14/13 5:20 AM, Ben Reser wrote: > Actually now that I think about it a bit more I'm not sure that helps. > It'll probably just shift it to a link time error because the defines > will be there so it'll build, SWIG will generate wrappers for them > that depend on the functions in our libraries

Re: 1.8.5 up for testing/signing

2013-11-20 Thread Paul Burba
On Thu, Nov 14, 2013 at 9:13 PM, Ben Reser wrote: > The 1.8.5 release artifacts are now available for testing/signing. > Please get the tarballs from > https://dist.apache.org/repos/dist/dev/subversion > and add your signatures there. I plan to try and release on November > 25th so please try a

Re: 1.7.14 up for testing/signing

2013-11-20 Thread Paul Burba
On Wed, Nov 20, 2013 at 9:30 AM, Johan Corveleyn wrote: > On Wed, Nov 20, 2013 at 2:39 PM, Paul Burba wrote: > ... >> checkout_tests.py 14: 'checkout from the root of a Windows drive' >> fails for all permutations tested. In his test results Johan >> mentioned that he saw the same thing and it w

Re: svn commit: r1540590 - bad use of SVN_INT_ERR

2013-11-20 Thread Julian Foad
> URL: http://svn.apache.org/r1540590 > Added: subversion/trunk/subversion/libsvn_subr/object_pool.c > == [...] > +/* Cleanup function called when an object_ref_t gets released. > + */ > +static apr_status_t > +object_ref

Re: 1.7.14 up for testing/signing

2013-11-20 Thread Johan Corveleyn
On Wed, Nov 20, 2013 at 2:39 PM, Paul Burba wrote: ... > checkout_tests.py 14: 'checkout from the root of a Windows drive' > fails for all permutations tested. In his test results Johan > mentioned that he saw the same thing and it was due to "test suite > problem because of backported r1518184 w

Re: 1.7.14 up for testing/signing

2013-11-20 Thread Paul Burba
On Thu, Nov 14, 2013 at 8:17 PM, Ben Reser wrote: > The 1.7.14 release artifacts are now available for testing/signing. > Please get the tarballs from > https://dist.apache.org/repos/dist/dev/subversion > and add your signatures there. I plan to try and release on November > 25th so please try

Re: Warning for missing sentinel arguments

2013-11-20 Thread Julian Foad
Branko Čibej wrote: > On 19.11.2013 18:19, Julian Foad wrote: >> [...] I was referring to the change of SVN_NO_ERROR from '0' to '(void *)0'. > I hope you mean (svn_error_t*)0, not (void*)0? Oops, yes I did mean that. >> But now I see that the real issue with svn_cl__try is its variable argumen

Re: [PATCH] initialize some variables in test to prevent -Wmaybe-uninitialized

2013-11-20 Thread Julian Foad
Hi, Andreas. +1 to commit. That's me stating my approval. You're listed as a committer on the translations, so you can just add a line in the log message saying "Approved by: julianfoad" (or "Approved by: danielsh" since he said so in the previous email) and you should be able to commit it your

Re: svn_mime_type_is_binary, libmagic and application/xml

2013-11-20 Thread Stefan Sperling
On Wed, Nov 20, 2013 at 12:55:51AM -0800, Ben Reser wrote: > libmagic is causing us to set application/xml on any XML file regardless of > file extension. This default comes the system's MAGIC file, and is configurable. > In order for a user to configure around this by setting > auto-props they'l

Re: svn_mime_type_is_binary, libmagic and application/xml

2013-11-20 Thread Ben Reser
On 11/19/13 11:39 PM, Stefan Sperling wrote: > Hmm... I don't see a need to change anything. > > libmagic is used as a last resort. Subversion already offers several > ways of configuring the svn:mime-type property, all of which supersede > libmagic (svn propset/propedit, auto-props, svn:auto-prop

Re: svn_mime_type_is_binary, libmagic and application/xml

2013-11-20 Thread Johan Corveleyn
On Wed, Nov 20, 2013 at 9:31 AM, Stefan Sperling wrote: > On Wed, Nov 20, 2013 at 09:19:16AM +0100, Johan Corveleyn wrote: >> I'm not sure, but isn't libmagic support in svn unix-only? I've never >> seen it being part of a Windows build. Maybe there's a Windows >> alternative, but I've never seen

Re: svn_mime_type_is_binary, libmagic and application/xml

2013-11-20 Thread Stefan Sperling
On Wed, Nov 20, 2013 at 09:19:16AM +0100, Johan Corveleyn wrote: > I'm not sure, but isn't libmagic support in svn unix-only? I've never > seen it being part of a Windows build. Maybe there's a Windows > alternative, but I've never seen it in an svn build. Oh, I believe this is simply because nobo

Re: svn_mime_type_is_binary, libmagic and application/xml

2013-11-20 Thread Johan Corveleyn
On Wed, Nov 20, 2013 at 8:39 AM, Stefan Sperling wrote: > On Tue, Nov 19, 2013 at 11:23:39PM -0800, Ben Reser wrote: >> I suggest that we do two things: >> >> 1) update our defaults for some mime types to be text >> >> 2) make which mime types are treated as text user configurable with a new >> "

Re: 1.7.14 up for testing/signing

2013-11-20 Thread Johan Corveleyn
On Fri, Nov 15, 2013 at 2:17 AM, Ben Reser wrote: > The 1.7.14 release artifacts are now available for testing/signing. > Please get the tarballs from > https://dist.apache.org/repos/dist/dev/subversion > and add your signatures there. I plan to try and release on November > 25th so please try