Re: [serf-dev] Re: [PATCH] Serf crash on spurious data between responses

2015-01-12 Thread Philip Martin
Lieven Govaerts l...@mobsol.be writes: You're trying to capture the situation where serf has: - finished writing a request ( req_bkt == NULL writing_started ) - has no more requests in the pending queue - and receives actual bytes of data. Right? Looks like your patch is a correct way to

Re: svn commit: r1649012 [1/3] - in /subversion/trunk: ./ subversion/libsvn_fs_x/

2015-01-12 Thread Ivan Zhakov
On 5 January 2015 at 15:43, Stefan Fuhrmann stefan.fuhrm...@wandisco.com wrote: On Fri, Jan 2, 2015 at 2:24 PM, Ivan Zhakov i...@visualsvn.com wrote: On 2 January 2015 at 15:43, stef...@apache.org wrote: Author: stefan2 Date: Fri Jan 2 12:43:42 2015 New Revision: 1649012 URL:

Re: Testing equality between svnrdump and svnadmin dump

2015-01-12 Thread Branko Čibej
On 12.01.2015 13:54, Julian Foad wrote: I (Julian Foad) wrote: The few differences I have found seem to be already known (but not necessarily adequately addressed). These include: svnrdump always sets 'Prop-delta: true' even when unnecessary; svnrdump doesn't output some of the checksum

Re: [serf-dev] Re: [PATCH] Serf crash on spurious data between responses

2015-01-12 Thread Lieven Govaerts
On Mon, Jan 12, 2015 at 12:22 PM, Philip Martin philip.mar...@wandisco.com wrote: Lieven Govaerts l...@mobsol.be writes: You're trying to capture the situation where serf has: - finished writing a request ( req_bkt == NULL writing_started ) - has no more requests in the pending queue - and

Re: Testing equality between svnrdump and svnadmin dump

2015-01-12 Thread Julian Foad
I (Julian Foad) wrote: The few differences I have found seem to be already known (but not necessarily adequately addressed). These include: svnrdump always sets 'Prop-delta: true' even when unnecessary; svnrdump doesn't output some of the checksum headers that svnadmin does; they put

Re: [serf-dev] Re: [PATCH] Serf crash on spurious data between responses

2015-01-12 Thread Lieven Govaerts
Hi, On Sat, Jan 10, 2015 at 1:07 PM, Philip Martin philip.mar...@wandisco.com wrote: Philip Martin philip.mar...@wandisco.com writes: Philip Martin philip.mar...@wandisco.com writes: While debugging a problem reported on users I accidentally sent an extra byte to the client: I sent

Re: svn commit: r1649029 - in /subversion/trunk/subversion/libsvn_fs_x: ./ dag.c tree.c

2015-01-12 Thread Branko Čibej
On 12.01.2015 16:54, Ivan Zhakov wrote: On 12 January 2015 at 18:39, Julian Foad julianf...@btopenworld.com wrote: Ivan Zhakov wrote: URL: http://svn.apache.org/r1649029 Log: Sync FSX with FSFS: Merge DAG-related sub-pool introduction patches r1647905, r1648243, r1648253 and r1648272 from

Re: svn commit: r1649029 - in /subversion/trunk/subversion/libsvn_fs_x: ./ dag.c tree.c

2015-01-12 Thread Julian Foad
Ivan Zhakov wrote: On 12 January 2015 at 18:39, Julian Foad wrote: Ivan Zhakov wrote: URL: http://svn.apache.org/r1649029 Log: Sync FSX with FSFS: Merge DAG-related sub-pool introduction patches r1647905, r1648243, r1648253 and r1648272 from FSFS and resolve the usual text conflicts due to

Re: svn commit: r1649029 - in /subversion/trunk/subversion/libsvn_fs_x: ./ dag.c tree.c

2015-01-12 Thread Ivan Zhakov
On 12 January 2015 at 18:39, Julian Foad julianf...@btopenworld.com wrote: Ivan Zhakov wrote: URL: http://svn.apache.org/r1649029 Log: Sync FSX with FSFS: Merge DAG-related sub-pool introduction patches r1647905, r1648243, r1648253 and r1648272 from FSFS and resolve the usual text conflicts

Re: svn commit: r1649029 - in /subversion/trunk/subversion/libsvn_fs_x: ./ dag.c tree.c

2015-01-12 Thread Stefan Sperling
On Mon, Jan 12, 2015 at 06:54:22PM +0300, Ivan Zhakov wrote: Subversion community guide is very specific about proper log messages and I don't understand why this commit (and other previous FSX merge commits) does not follow it. Quoting Subversion community guide [1] again: [[[ The log

Re: [serf-dev] Re: [PATCH] Serf crash on spurious data between responses

2015-01-12 Thread Philip Martin
Philip Martin philip.mar...@wandisco.com writes: $ valgrind -q test/test_all ==11901== Invalid read of size 8 ==11901==at 0x403E7CF: serf_config_get_object (config_store.c:278) ==11901==by 0x403F88A: serf__log (logging.c:146) ==11901==by 0x4048E79: serf_log_wrapped_readline

Re: Testing equality between svnrdump and svnadmin dump

2015-01-12 Thread Julian Foad
Branko Čibej wrote: On 12.01.2015 13:54, Julian Foad wrote: svnmucc_tests.py 2 'basic svnmucc tests' generates a no-op modification to an empty file, in revision 16. 'svnadmin dump' outputs this:   [[[   I: Node-path: boozle/buz/svnmucc-test.py   I: Node-kind: file   I: Node-action: change   I:

Re: svn commit: r1649029 - in /subversion/trunk/subversion/libsvn_fs_x: ./ dag.c tree.c

2015-01-12 Thread Ivan Zhakov
5 January 2015 at 15:49, Stefan Fuhrmann stefan.fuhrm...@wandisco.com wrote: On Fri, Jan 2, 2015 at 3:21 PM, Ivan Zhakov i...@visualsvn.com wrote: On 2 January 2015 at 16:46, stef...@apache.org wrote: Author: stefan2 Date: Fri Jan 2 13:46:57 2015 New Revision: 1649029 URL:

Re: svn commit: r1649029 - in /subversion/trunk/subversion/libsvn_fs_x: ./ dag.c tree.c

2015-01-12 Thread Julian Foad
Ivan Zhakov wrote: URL: http://svn.apache.org/r1649029 Log: Sync FSX with FSFS: Merge DAG-related sub-pool introduction patches r1647905, r1648243, r1648253 and r1648272 from FSFS and resolve the usual text conflicts due to naming differences. Block revisions r1648230, r1648238, r1648241,

Re: [serf-dev] Re: [PATCH] Serf crash on spurious data between responses

2015-01-12 Thread Philip Martin
Lieven Govaerts l...@mobsol.be writes: On Mon, Jan 12, 2015 at 12:22 PM, Philip Martin I'm not familiar with serf's testsuite. The scenario: - client sends first request - server sends response - server sends extra data, say '\n' - client handles first request - client creates

Re: [serf-dev] Re: [PATCH] Serf crash on spurious data between responses

2015-01-12 Thread Philip Martin
Philip Martin philip.mar...@wandisco.com writes: Lieven Govaerts l...@mobsol.be writes: Is there a reason you specifically mention pipelined here? The first response has been handled so it's just synchronous communication. The point is that the client reads data from the server before