Re: 1.9/trunk build errors when building without OpenSSL

2015-07-20 Thread Branko Čibej
On 20.07.2015 16:20, Stefan Hett wrote: > Hi, > > following several hours of investigation and discussion on IRC with > danielsh, philipm and bert I believe there to be some issue in the > build generator for Windows. > > Running the python command: > python gen-make.py -t vcproj --with-zlib=..\zli

Re: inconsistency between mergeinfo records

2015-07-20 Thread Stefan Hett
Hi Stefan^2, Hi Stefan, First of all, thank you for the detailed feedback! It is very helpful. I spent the last two weeks refactoring and reworking the tool. The main changes: * explicit --verbose mode, much quieter without it * progress output * only one common 'normalize' sub-command; acti

svn-normalizer tool error E160013

2015-07-20 Thread Stefan Hett
Hi, (sending to dev rather than to user since it's still an unreleased tool) I just tried to do a test-run on another checked-out path from the same repository I already ran svn-normalizer on, but get a weird error which I don't understand the reason for... Maybe you have an idea? E:\[projec

Re: crash in svn-mergeinfo-normalizer

2015-07-20 Thread Stefan Hett
On Wed, Jul 15, 2015 at 12:03 PM, Stefan Hett > wrote: Hi Stefan^2, I've just tried to rerun the latest svn-mergeinfo-normalizer. Running the command "svn-mergeinfo-normalizer normalize" the application crashes in local_lookup() in missing-branches.c i

[PATCH] Error out with proper error message when using Python >= 3.0 (was: building SVN trunk on Windows fails on python gen-make.py)

2015-07-20 Thread Stefan Hett
[ moved from users@ to dev@; tldr: trunk gen-make.py fails with py3.4/windows ] Stefan Hett wrote on Mon, Jun 22, 2015 at 15:12:31 +0200: On Mon, Jun 22, 2015 at 12:45 PM, Stefan Hett wrote: File "E:\Python34\lib\encodings\cp1252.py", line 23, in decodereturn codecs.charmap_decode(input

Re: [Issue 4584] New - Non-canonical $HOME crashes GPG-agent support code

2015-07-20 Thread Julian Foad
Bert said on IRC: "julianf: I would recommend fixing the api implementation (to follow our common rule: all passed paths are canonical, unless documented otherwise) and just backporting the fix." The minimal fix is committed to trunk in r1691928. Note that this fixes the *only* caller that exists

Re: 1.9/trunk build errors when building without OpenSSL

2015-07-20 Thread Stefan Hett
added patchnotes: [[[ Fix building SVN under Windows without OpenSSL/Serf. * build/generator/gen_win.py (get_win_libs): skip serf/openssl dependencies, if these optional libs are not present ]]] Regards, Stefan

1.9/trunk build errors when building without OpenSSL

2015-07-20 Thread Stefan Hett
Hi, following several hours of investigation and discussion on IRC with danielsh, philipm and bert I believe there to be some issue in the build generator for Windows. Running the python command: python gen-make.py -t vcproj --with-zlib=..\zlib --with-apr=..\apr --with-apr-util=..\apr-util -

Re: [Issue 4584] New - Non-canonical $HOME crashes GPG-agent support code

2015-07-20 Thread Julian Foad
I (Julian Foad) wrote: > I have a one-line fix for this issue, which I've tested by hand: > [...] > I don't have an automated regression test. Should I go ahead and commit > the fix anyway, and propose for backport to 1.8 and 1.9? Of course, we would like to have a regression test. Can anyone hel

Re: [Issue 4584] New - Non-canonical $HOME crashes GPG-agent support code

2015-07-20 Thread Julian Foad
I have a one-line fix for this issue, which I've tested by hand: [[[ Index: subversion/libsvn_subr/gpg_agent.c === --- subversion/libsvn_subr/gpg_agent.c (revision 1688253) +++ subversion/libsvn_subr/gpg_agent.c (working copy) @@ -232

[PATCH] Fix build warnings on Windows, if building without OpenSSL

2015-07-20 Thread Stefan Hett
Hi, the following patch was suggested by philipm on IRC. I've tested it and it resolved the problem I had when building trunk: "Warning: Using undeclared dependency '$(SVN_OPENSSL_LIBS'." [[[ Following up on r1504208, add openSSL to the list of optional libraries to properly surpress gen-make

Re: svn commit: r1691712 - /subversion/trunk/INSTALL

2015-07-20 Thread Stefan Hett
Thanks for applying the patch to trunk. :-) I applied the trunk patch, hoping it would trigger some additional improvements. Once we are there +1 on backporting, but I don't think we should do that on every separate patch. Bert --