Re: Announcing MaxSVN

2015-09-23 Thread Daniel Shahaf
Evgeny Kotkov wrote on Wed, Sep 23, 2015 at 21:12:19 +0300: > Stefan Hett writes: > > > So unless some new arguments will influence my mind again, this is the > > version scheme I'd aim for: > > (magic numbers are temporary, I didn't quite check them yet) > > > > MaxSVN 1.7.22.1 -> MaxSVN 1.7.22_

Re: Announcing MaxSVN

2015-09-23 Thread Evgeny Kotkov
Stefan Hett writes: > So unless some new arguments will influence my mind again, this is the > version scheme I'd aim for: > (magic numbers are temporary, I didn't quite check them yet) > > MaxSVN 1.7.22.1 -> MaxSVN 1.7.22_0-1 > MaxSVN 1.7.22.2 -> MaxSVN 1.7.22_0-2 > MaxSVN 1.8.14.1 -> MaxSVN 1.8

Re: svn commit: r1704317 - in /subversion/trunk/subversion/libsvn_ra_serf: commit.c options.c ra_serf.h serf.c

2015-09-23 Thread Evgeny Kotkov
Daniel Shahaf writes: >> Makes sense. Something along these lines? > > +1 Committed in r1704891. Regards, Evgeny Kotkov

Re: svn commit: r1555133 - in /subversion/trunk: ./ subversion/include/ subversion/include/private/ subversion/libsvn_client/ subversion/libsvn_delta/ subversion/libsvn_fs_fs/ subversion/libsvn_fs_x/

2015-09-23 Thread Julian Foad
Bert, ping? - Julian On 28 August 2015, Ivan Zhakov wrote: > On 3 January 2014 at 19:11, wrote: >> Author: rhuijben >> Date: Fri Jan 3 16:10:59 2014 >> New Revision: 1555133 >> >> URL: http://svn.apache.org/r1555133 >> Log: >> Get rid of the ever increasing number of private apis in svn_sort

Re: svn commit: r1704374 - in /subversion/trunk/subversion: include/svn_diff.h include/svn_error_codes.h libsvn_diff/binary_diff.c libsvn_diff/diff.h libsvn_diff/parse-diff.c tests/cmdline/patch_tests

2015-09-23 Thread Julian Foad
Johan Corveleyn wrote: > Bert Huijben wrote: >> Johan Corveleyn wrote: >>> Without completely understanding how the binary diff / patch is now >>> implemented, I'd say: better to error out in this case. If it helps >>> detecting corruption of the binary diff (say it was randomly changed >>> by som

Re: svn commit: r1704374 - in /subversion/trunk/subversion: include/svn_diff.h include/svn_error_codes.h libsvn_diff/binary_diff.c libsvn_diff/diff.h libsvn_diff/parse-diff.c tests/cmdline/patch_tests

2015-09-23 Thread Johan Corveleyn
On Wed, Sep 23, 2015 at 3:34 PM, Bert Huijben wrote: > > >> -Original Message- >> From: Johan Corveleyn [mailto:jcor...@gmail.com] >> Sent: woensdag 23 september 2015 14:51 >> To: Julian Foad >> Cc: Bert Huijben ; Stefan Sperling ; dev >> >> Subject: Re: svn commit: r1704374 - in /subver

Re: No-op changes no longer dumped by 'svnadmin dump' in 1.9

2015-09-23 Thread Daniel Shahaf
Daniel Shahaf wrote on Wed, Sep 23, 2015 at 13:07:31 +: > Julian Foad wrote on Tue, Sep 22, 2015 at 12:54:58 +0200: > > Daniel Shahaf wrote: > > > Johan Corveleyn wrote: > > >> [...], revision N-1 contains a real > > >> change, but only a short log message; and revision N has a no-op > > >> cha

Re: svn commit: r1704847 - /subversion/trunk/subversion/libsvn_ra_serf/serf.c

2015-09-23 Thread Daniel Shahaf
Bert Huijben wrote on Wed, Sep 23, 2015 at 15:42:29 +0200: > Perhaps we should move the serf version to the standard list of linked > dependencies and do something smarter there. > > Now it is just extending an ra implementation description, while ra_svn > doesn't report the version of Cyrus Sasl

Re: XDG Base Directory Support

2015-09-23 Thread Daniel Shahaf
Earnestly wrote on Thu, Sep 17, 2015 at 23:29:54 +0100: > This is a proposal for supporting the XDG Base Directory Specification[1] in > subversion. I've filed this as issue #4599: http://subversion.tigris.org/issues/show_bug.cgi?id=4599 Note we're about to change issue trackers: http://mail-arch

RE: svn commit: r1704847 - /subversion/trunk/subversion/libsvn_ra_serf/serf.c

2015-09-23 Thread Bert Huijben
> -Original Message- > From: Daniel Shahaf [mailto:danie...@apache.org] > Sent: woensdag 23 september 2015 15:39 > To: Ivan Zhakov > Cc: dev@subversion.apache.org > Subject: Re: svn commit: r1704847 - > /subversion/trunk/subversion/libsvn_ra_serf/serf.c > > Ivan Zhakov wrote on Wed, Sep

Re: svn commit: r1704847 - /subversion/trunk/subversion/libsvn_ra_serf/serf.c

2015-09-23 Thread Daniel Shahaf
Ivan Zhakov wrote on Wed, Sep 23, 2015 at 16:32:15 +0300: > On 23 September 2015 at 16:29, wrote: > > Author: danielsh > > Date: Wed Sep 23 13:29:30 2015 > > New Revision: 1704847 > > > > URL: http://svn.apache.org/viewvc?rev=1704847&view=rev > > Log: > > * subversion/libsvn_ra_serf/serf.c > >

Re: [ANNOUNCE] Apache Subversion 1.9.2 released

2015-09-23 Thread Daniel Shahaf
Mark Phippard wrote on Wed, Sep 23, 2015 at 09:36:10 -0400: > I thought the release was happening on September 30th as it says in CHANGES? It was rescheduled: http://mail-archives.apache.org/mod_mbox/subversion-dev/201509.mbox/%3ccap_gpnhwxprvyrcvthrgdtfwz-p7pdaoca23rq+derkyngd...@mail.gmail.com%3

Re: [ANNOUNCE] Apache Subversion 1.9.2 released

2015-09-23 Thread Mark Phippard
I thought the release was happening on September 30th as it says in CHANGES? Mark On Wed, Sep 23, 2015 at 9:30 AM, Evgeny Kotkov wrote: > I'm happy to announce the release of Apache Subversion 1.9.2. > Please choose the mirror closest to you by visiting: > > http://subversion.apache.org/do

Re: No-op changes no longer dumped by 'svnadmin dump' in 1.9

2015-09-23 Thread Daniel Shahaf
Johan Corveleyn wrote on Wed, Sep 23, 2015 at 11:03:43 +0200: > Just one small addition on the fundamental part: I still think (like > we discussed during breakfast last Friday in Berlin :-)) there is no > problem in having / preserving / exposing null-text-changes to paths > in Subversion. I tend

RE: svn commit: r1704374 - in /subversion/trunk/subversion: include/svn_diff.h include/svn_error_codes.h libsvn_diff/binary_diff.c libsvn_diff/diff.h libsvn_diff/parse-diff.c tests/cmdline/patch_tests

2015-09-23 Thread Bert Huijben
> -Original Message- > From: Johan Corveleyn [mailto:jcor...@gmail.com] > Sent: woensdag 23 september 2015 14:51 > To: Julian Foad > Cc: Bert Huijben ; Stefan Sperling ; dev > > Subject: Re: svn commit: r1704374 - in /subversion/trunk/subversion: > include/svn_diff.h include/svn_error_c

Re: svn commit: r1704847 - /subversion/trunk/subversion/libsvn_ra_serf/serf.c

2015-09-23 Thread Ivan Zhakov
On 23 September 2015 at 16:29, wrote: > Author: danielsh > Date: Wed Sep 23 13:29:30 2015 > New Revision: 1704847 > > URL: http://svn.apache.org/viewvc?rev=1704847&view=rev > Log: > * subversion/libsvn_ra_serf/serf.c > (ra_serf_version): Report both built- and run-time versions of libserf, >

[ANNOUNCE] Apache Subversion 1.9.2 released

2015-09-23 Thread Evgeny Kotkov
I'm happy to announce the release of Apache Subversion 1.9.2. Please choose the mirror closest to you by visiting: http://subversion.apache.org/download.cgi#recommended-release The SHA1 checksums are: fb9db3b7ddf48ae37aa8785872301b59bfcc7017 subversion-1.9.2.tar.bz2 4c57828c07d21b477

The svn-warnings bot has false negatives

2015-09-23 Thread Daniel Shahaf
The svn-warning bot is supposed to turn either orange or red when a build has compiler warnings, but recent builds were green even though they were warnings. For example, build #377 [1] has a -Wshadow warning, which should have caused that build to result in buildbot.status.results.WARNINGS [2] vi

Re: Announcing MaxSVN

2015-09-23 Thread Daniel Shahaf
Stefan wrote on Wed, Sep 23, 2015 at 08:39:24 +0200: > On 21/09/2015 23:10, Daniel Shahaf wrote: > >Johan Corveleyn wrote on Sun, Sep 20, 2015 at 00:00:42 +0200: > >>On Sat, Sep 19, 2015 at 11:35 PM, Stefan wrote: > >>>On 19/09/2015 22:48, Johan Corveleyn wrote: > On Sat, Sep 19, 2015 at 10:14

Re: No-op changes no longer dumped by 'svnadmin dump' in 1.9

2015-09-23 Thread Daniel Shahaf
Julian Foad wrote on Tue, Sep 22, 2015 at 12:54:58 +0200: > Daniel Shahaf wrote: > > Johan Corveleyn wrote: > >> [...], revision N-1 contains a real > >> change, but only a short log message; and revision N has a no-op > >> change to that same path, and a very informative log message [...] > > > >

Re: svn commit: r1704317 - in /subversion/trunk/subversion/libsvn_ra_serf: commit.c options.c ra_serf.h serf.c

2015-09-23 Thread Daniel Shahaf
Evgeny Kotkov wrote on Tue, Sep 22, 2015 at 15:54:01 +0300: > Daniel Shahaf writes: > > > Perhaps invent an "I speak svndiff1" wire capability and make 1.10 > > servers advertise it? I get that the workaround implemented is > > necessary for interoperating with released servers, but we could at

Re: svn commit: r1704374 - in /subversion/trunk/subversion: include/svn_diff.h include/svn_error_codes.h libsvn_diff/binary_diff.c libsvn_diff/diff.h libsvn_diff/parse-diff.c tests/cmdline/patch_tests

2015-09-23 Thread Johan Corveleyn
On Tue, Sep 22, 2015 at 12:30 PM, Julian Foad wrote: > Bert Huijben wrote: >> Stefan Sperling wrote: >>> > + unsigned info = 0; > [...] >>> > + for (i = 0; i < 5; i++) >>> > +{ >>> > + int value; >>> > + >>> > + SVN_ERR(base85_value(&value, base85_data[i])); >>>

Re: No-op changes no longer dumped by 'svnadmin dump' in 1.9

2015-09-23 Thread Julian Foad
> Brane wrote: >> I also suggest adding a note to >> http://subversion.apache.org/docs/release-notes/1.9.html#issues . > > And we need to file an issue. > > I'll do both of those things (issue and rel-notes) now. Issue #4598 "No-op changes no longer dumped by 'svnadmin dump' in 1.9", http://subver

Re: No-op changes no longer dumped by 'svnadmin dump' in 1.9

2015-09-23 Thread Johan Corveleyn
On Wed, Sep 23, 2015 at 12:55 PM, Julian Foad wrote: >> Johan Corveleyn wrote: >>> [...] stefan2 told me in person that that part of the >>> change in r1572363 was unintentional :-). IIUC, he didn't realize that >>> it would have this effect on the output of dump. > [...] > I think the dump.c

Re: No-op changes no longer dumped by 'svnadmin dump' in 1.9

2015-09-23 Thread Julian Foad
> Johan Corveleyn wrote: >> [...] stefan2 told me in person that that part of the >> change in r1572363 was unintentional :-). IIUC, he didn't realize that >> it would have this effect on the output of dump. [...] I think the dump.c part of r1572363 and r1573111 should be reverted / fixed

Re: No-op changes no longer dumped by 'svnadmin dump' in 1.9

2015-09-23 Thread Branko Čibej
On 23.09.2015 11:58, Johan Corveleyn wrote: > On Wed, Sep 23, 2015 at 11:44 AM, Branko Čibej wrote: >> On 23.09.2015 11:03, Johan Corveleyn wrote: >>> TBH, I'm not really interested in having a really fundamental >>> discussion about this (but feel free to drive that of course). What I >>> am inte

Re: No-op changes no longer dumped by 'svnadmin dump' in 1.9

2015-09-23 Thread Johan Corveleyn
On Wed, Sep 23, 2015 at 11:44 AM, Branko Čibej wrote: > On 23.09.2015 11:03, Johan Corveleyn wrote: >> TBH, I'm not really interested in having a really fundamental >> discussion about this (but feel free to drive that of course). What I >> am interested in, is that we have a regression, and that

Re: No-op changes no longer dumped by 'svnadmin dump' in 1.9

2015-09-23 Thread Branko Čibej
On 23.09.2015 11:03, Johan Corveleyn wrote: > TBH, I'm not really interested in having a really fundamental > discussion about this (but feel free to drive that of course). What I > am interested in, is that we have a regression, and that 'dump' is > losing information (namely, not dumping correctl

Re: No-op changes no longer dumped by 'svnadmin dump' in 1.9

2015-09-23 Thread Johan Corveleyn
On Tue, Sep 22, 2015 at 12:54 PM, Julian Foad wrote: > Daniel Shahaf wrote: >> Johan Corveleyn wrote: >>> [...], revision N-1 contains a real >>> change, but only a short log message; and revision N has a no-op >>> change to that same path, and a very informative log message [...] >> >> The FreeBS