Re: Improve svn warning/error message to faciliate troubleshooting

2016-05-13 Thread Daniel Shahaf
Daniel Shahaf wrote on Wed, May 11, 2016 at 16:21:42 +: > Cosmere Infahm wrote on Wed, May 11, 2016 at 14:40:53 +0200: > > Could you please improve the warning/error to include the external involved > > so that troubleshooting is easier? > > I think this patch will do the trick: > > [[[ >

Re: svn commit: r1743236 - in /subversion/trunk/subversion/tests/cmdline: merge_tests.py svntest/actions.py svntest/tree.py

2016-05-13 Thread Evgeny Kotkov
Stefan Fuhrmann writes: >> The new condition looks fairly suspicious. > > Sure, but no worse than before. I think it's actually worse than before, as now it looks like this function was updated for Python 3, whereas in fact it gets all the special cases like "value[0] ==

Re: svn commit: r1743556 - /subversion/trunk/build/run_tests.py

2016-05-13 Thread Stefan Fuhrmann
On 13.05.2016 02:54, Branko Čibej wrote: On 13.05.2016 00:00, Evgeny Kotkov wrote: Stefan Fuhrmann writes: TestHarness._run_test): The log is binary data, so write byte strings to it. [...] if self.opts.list_tests: -

Re: svn commit: r1743556 - /subversion/trunk/build/run_tests.py

2016-05-13 Thread Evgeny Kotkov
Stefan Fuhrmann writes: >> And sys.stdout.write() works with strings, so this probably won't work >> if tests are run with the --log-to-stdout option. > > That looks like a win-tests.py -only feature, although run_tests.py has > remnants of that. If not, I'd have to add a