RE: [PATCH] Re: ra_local doesn't report post-commit errors

2016-09-19 Thread bert
-1 on just returning non errors from the commit info callback and making callers suffer. I added that comment after finding that all callers suffer and there is no way to see the difference, causing all kinds of problems. You can only return errors there to fail fast. You will cause broken work

Re: [PATCH] Re: ra_local doesn't report post-commit errors

2016-09-19 Thread Daniel Shahaf
Daniel Shahaf wrote on Sat, Sep 17, 2016 at 06:52:44 +: > What concerns me at the moment is that the patch makes deltify_etc() > return an error in situations where previously it did not. I think > there are three possible solutions to this: revv the API deltify_etc() > implements; make the ch