fsfsfixer script not compatible with 1.8+ repos

2017-01-30 Thread James Prestwood
Hi all, I'm attempting to fix a corrupt repository which is reporting "Checksum mismatch while reading representation" (the possible cause has been raised by Julian - https://svn.haxx.se/dev/archive-2017-01/0080.shtml). I'm wanting to run the fsfsfixer script from https://svn.apache.org/repos/asf

Re: fsfsfixer script not compatible with 1.8+ repos

2017-01-30 Thread Julian Foad
James Prestwood wrote: I'm attempting to fix a corrupt repository which is reporting "Checksum mismatch while reading representation" Thanks for bring this issue to the dev list, James. I was the author of "fsfsfixer". I'd be grateful however if any other devs could comment or assist. I am

Re: fsfsfixer script not compatible with 1.8+ repos

2017-01-30 Thread Julian Foad
Julian Foad wrote: James Prestwood wrote: [...] I'm wanting to run the fsfsfixer script from https://svn.apache.org/repos/asf/subversion/trunk/contrib/server-side/fsfsfixer/ but this isn't compatible with repositories created in 1.8+, as per the error I'm seeing: ('error:', FixError("Filesyste

Re: rep_read_contents() edge case checksum error, FSFS f7

2017-01-30 Thread Stefan Fuhrmann
On 29.01.2017 22:27, Julian Foad wrote: Stefan, is this an edge case bug? rep_read_contents() in libsvn_fs_fs/cached_data.c@1780363 is quoted below. rep_read_contents() potentially reads one or more times from the fulltext cache and then finds the fulltext cache is no longer available. I suppos

Re: segfault with new conflict resolver

2017-01-30 Thread Stefan Kueng
On 28.01.2017 15:38, Stefan Sperling wrote: On Sat, Jan 28, 2017 at 01:47:03PM +0100, Stefan Sperling wrote: On Sat, Jan 28, 2017 at 01:31:46PM +0100, Stefan Kueng wrote: Hi, trying out the new conflict resolver. Ran into a segfault on my first try: Thank you! I will fix this ASAP. Shoul

verify_as_revision_before_current_plus_plus() on a production repo?

2017-01-30 Thread Julian Foad
Would this be safe? In subversion/libsvn_fs_fs/transaction.c, just before commit_body() bumps the revision number in the "current" file, it calls verify_as_revision_before_current_plus_plus(), quoted below. verify_as_revision_before_current_plus_plus() is currently compiled in to debug build

Re: verify_as_revision_before_current_plus_plus() on a production repo?

2017-01-30 Thread Daniel Shahaf
Julian Foad wrote on Mon, Jan 30, 2017 at 21:40:00 +: > Please could anybody cast a second pair of eyes over this code and say > whether it looks safe to enable in production. It looks low risk to me, but > it is a little "tricky": in particular, it opens a second FS instance and > fakes the "y

Re: Svndumpfilter crash on Windows 10

2017-01-30 Thread Daniel Shahaf
Daniel Shahaf wrote on Thu, Jan 19, 2017 at 07:41:03 +: > zsh: segmentation fault svndumpfilter include / > ]]] > > The fix should be just a matter of not dereferencing 'propstring' in > svn_repos__dump_revision_record() in at the point > SVN_REPOS_DUMPFILE_CONTENT_LENGTH is printed. Ping?