Re: svn commit: r1813898 - in /subversion/trunk/subversion: libsvn_fs_fs/transaction.c libsvn_repos/reporter.c tests/cmdline/basic_tests.py tests/cmdline/svnadmin_tests.py

2017-11-22 Thread Evgeny Kotkov
Stefan Sperling writes: > However, if rep-sharing is enabled, svn_fs_props_changed() does not work > as advertised because properties do not carry a SHA1 checksum with a > "uniquifier" which identifies the transaction they were created in. > The uniquifier is used by svn_fs_props_changed() to tel

Re: svn commit: r1816069 - /subversion/branches/1.8.x-issue4707/subversion/svnrdump/dump_editor.c

2017-11-22 Thread Julian Foad
Evgeny Kotkov wrote: Julian Foad writes: -": %lu\n", -(unsigned long)info->size)); +": %" APR_SIZE_T_FMT "\n", +info->size)); I think that using APR_SIZE_T_FMT woul

Re: svn commit: r1816069 - /subversion/branches/1.8.x-issue4707/subversion/svnrdump/dump_editor.c

2017-11-22 Thread Evgeny Kotkov
Julian Foad writes: > -": %lu\n", > -(unsigned long)info->size)); > +": %" APR_SIZE_T_FMT "\n", > +info->size)); I think that using APR_SIZE_T_FMT would still lead to t

Re: Error E140001: Sum of subblock sizes larger than total block content length

2017-11-22 Thread Julian Foad
Julian Foad wrote: (dropping users@) Julian Foad wrote: The attached patch should fix it; not yet tested. Proposed for backport to 1.8.x. - Julian I have opened https://issues.apache.org/jira/browse/SVN-4707 and attached the patch there. (Patch v2 is same as v1 but with tweaked log messag

Re: Error E140001: Sum of subblock sizes larger than total block content length

2017-11-22 Thread Julian Foad
(dropping users@) Julian Foad wrote: The attached patch should fix it; not yet tested. I have opened https://issues.apache.org/jira/browse/SVN-4707 and attached the patch there. (Patch v2 is same as v1 but with tweaked log message.) We briefly discussed testing. It's a pretty obvious fix, b

Re: Subversion 1.10 RC1?

2017-11-22 Thread Julian Foad
Re. shelving... Branko Čibej wrote: Unless you're absolutely certain that the format and semantics of the CLI commands won't change, I do suggest adding an "experimental" warning to the help text. Done. Thanks. - Julian

Re: Subversion 1.10 RC1?

2017-11-22 Thread Julian Foad
Re. shelving... Evgeny Kotkov wrote: Julian Foad writes: * shelving v1: is isolated -- doesn't affect anything else; is limited but already useful; will be changed in the next release so APIs are marked "SVN_EXPERIMENTAL"; changes shelved by this release could be detected and 'upgraded' by

Re: svn commit: r1803143 - in /subversion/trunk/subversion: include/ libsvn_delta/ libsvn_ra_serf/ mod_dav_svn/

2017-11-22 Thread Evgeny Kotkov
Evgeny Kotkov writes: > Daniel Shahaf writes: > >>> + * >>> + * Any temporary allocations may be performed in @a scratch_pool. >> >> Need to add an @since tag here. > > [...] > >>> + */ >>> + svn_error_t *(*apply_textdelta_stream)( >> >> Could you update the docstring of svn_delta_editor_

Re: svn commit: r1815799 - in /subversion/trunk/subversion: libsvn_ra_serf/commit.c tests/libsvn_ra/ra-test.c

2017-11-22 Thread Julian Foad
Evgeny Kotkov wrote: Julian Foad writes: Don't replace it with 'relpath &&' instead, however. If relpath is null then I think the next line (svn_hash_gets(..., relpath)) would immediately crash anyway, so allowing it here is useless and therefore confusing. Remove that condition entirely. That'

Re: svn commit: r1815799 - in /subversion/trunk/subversion: libsvn_ra_serf/commit.c tests/libsvn_ra/ra-test.c

2017-11-22 Thread Evgeny Kotkov
Evgeny Kotkov writes: > (2) I am going to tweak the new test so that it would properly open the > parent directory and commit to a locked file, to have this case > covered with a native test. Committed in r1816060. Julian Foad writes: >> (1) Keep the new simpler check in maybe_set_loc

Re: Subversion 1.10 RC1?

2017-11-22 Thread Evgeny Kotkov
Julian Foad writes: > At the hackathon today we (me, Stefan Hett, Bert, Johan) have been talking > about how to progress 1.10. > > We think all the features and changes are safe to release and are not going > to get more testing until we produce a "release candidate". (For example, at > that poin

Re: Error E140001: Sum of subblock sizes larger than total block content length

2017-11-22 Thread Julian Foad
> *From:* Ronald Taneza [mailto:ronald.tan...@gmail.com] > *Sent:* dinsdag 21 november 2017 15:44 > *To:* us...@subversion.apache.org > > I got the error below while running "svnadmin load -M 0" to load a dump > file created by "svnrdump dump". > >   svnadmin: E140001: Sum of subblock sizes lar

Re: svn commit: r1815812 - /subversion/site/staging/quick-start.html

2017-11-22 Thread Johan Corveleyn
On Mon, Nov 20, 2017 at 3:58 PM, wrote: > Author: lyalyakin > Date: Mon Nov 20 14:58:39 2017 > New Revision: 1815812 > > URL: http://svn.apache.org/viewvc?rev=1815812&view=rev > Log: > * staging/quick-start.html > Make TOC (Table of Contents) contain h2 sections only for now. > > Modified: >

Re: Subversion 1.10 RC1?

2017-11-22 Thread Stefan Fuhrmann
On 22.11.2017 11:53, Julian Foad wrote: At the hackathon today we (me, Stefan Hett, Bert, Johan) have been talking about how to progress 1.10. We think all the features and changes are safe to release and are not going to get more testing until we produce a "release candidate". (For example,

inheriting enviroment variables by hooks

2017-11-22 Thread marcin
Hi, We're trying to build a generic integration system for RhodeCode that would also support Subversion. The problem we're now having is how to transmit some data during e.g commit operation from our system into running hooks. Our idea now is to use apache and set some special HTTP headers, and

Re: Subversion 1.10 RC1?

2017-11-22 Thread Stefan Sperling
On Wed, Nov 22, 2017 at 11:53:11AM +0100, Julian Foad wrote: > At the hackathon today we (me, Stefan Hett, Bert, Johan) have been talking > about how to progress 1.10. > > We think all the features and changes are safe to release and are not going > to get more testing until we produce a "release

org.apache.subversion.javahl.ClientException: Found invalid algorithm in certificate

2017-11-22 Thread Marc Strapetz
One of our users is encountering following exception: svn: Java exception svn: Wrapped Java Exception at org.apache.subversion.javahl.remote.RemoteFactory.open (Native Method) at org.apache.subversion.javahl.remote.RemoteFactory.openRemoteSession (RemoteFactory.java:228) ... Caused by:

Re: Subversion 1.10 RC1?

2017-11-22 Thread Branko Čibej
On 22.11.2017 11:53, Julian Foad wrote: > At the hackathon today we (me, Stefan Hett, Bert, Johan) have been > talking about how to progress 1.10. > > We think all the features and changes are safe to release and are not > going to get more testing until we produce a "release candidate". (For > exa

Subversion 1.10 RC1?

2017-11-22 Thread Julian Foad
At the hackathon today we (me, Stefan Hett, Bert, Johan) have been talking about how to progress 1.10. We think all the features and changes are safe to release and are not going to get more testing until we produce a "release candidate". (For example, at that point Stefan will be able to just