Re: rep-cache sanity checks Re: Script to obliterate the most recent revision(s)

2018-03-26 Thread Philip Martin
Daniel Shahaf writes: > While we're at it, do we check, before using a rep-cache reference, that the > revision:offset coordinates we obtained do in fact refer to a representation? The SHA1 collision detection code means Subversion now does very exact verification of

Re: Rolling 1.10.0-rc2

2018-03-26 Thread Julian Foad
Julian Foad wrote: Can anyone volunteer to review this important block-read fix? (adding to CC: some people who might) Thanks for your review, stefan2! We now need one more review. - Julian Philip Martin wrote: Julian Foad writes: How do you feel about the amount of test coverage we

Shelving: documenting the storage location [was: svn commit: r1825045 ...]

2018-03-26 Thread Julian Foad
Daniel Shahaf wrote: julianf...@apache.org wrote on Thu, 22 Feb 2018 11:02 +: +++ subversion/trunk/subversion/svn/svn.c Thu Feb 22 11:02:02 2018 + " Shelved changes are stored in /.svn/shelves/\n" I noticed this line while reviewing the backport and wanted to ask, why do we document

Re: Wiki migration to Confluence: test conversion ready for review

2018-03-26 Thread Daniel Shahaf
Johan Corveleyn wrote on Mon, 26 Mar 2018 00:49 +0200: > Sorry, this should have long been done by now, but things got in the > way and I lost focus. > > I'll try to pick up the pieces again and get this done sometime during > next week. No problem; we need it to eventually happen but we needn't

Re: Script to obliterate the most recent revision(s)

2018-03-26 Thread Daniel Shahaf
Johan Corveleyn wrote on Mon, 26 Mar 2018 00:32 +0200: > During the Aachen hackathon we brainstormed a bit about obliterate, > and figured it would be wonderful if a client, acting on a working > copy, could detect that "history has been changed". Even if only to > give an fatal error message