Re: change release signature requirements?

2018-07-02 Thread Stefan
On 29/06/2018 17:38, Julian Foad wrote: > Stefan wrote: >> new: >> [...] Before a release is officially made public, it must receive >> three +1 votes from members of the Subversion PMC. In addition, as a >> matter of project policy, we require testing and signatures from at >> least one PMC member

Re: svn commit: r1834612 - in /subversion/branches/1.10.x-issue4758/subversion: libsvn_client/shelve.c tests/cmdline/shelve_tests.py

2018-07-02 Thread Daniel Shahaf
Julian Foad wrote on Mon, 02 Jul 2018 12:20 +0100: > Philip Martin wrote: > > I did also worry about thread safety: it's not safe to modify the > > context like that if the context can be shared across multiple threads. > > However the context also includes batons and those typically point to > > m

Re: svn commit: r1834612 - in /subversion/branches/1.10.x-issue4758/subversion: libsvn_client/shelve.c tests/cmdline/shelve_tests.py

2018-07-02 Thread Julian Foad
There are three issues here: 1. Philip Martin wrote: > There are SVN_ERR between these two hunks. If one of these returns an > error we will fail to restore the old config. There are four other places where libsvn_client functions modify ctx in place. They are all modifying the notification ca