Re: [swig-py3][patch] interfacing bytes object instead of str

2018-12-16 Thread Yasuhito FUTATSUKI
On 12/17/18 2:08 AM, Troy Curtis Jr wrote: On Sun, Dec 16, 2018 at 11:28 AM Daniel Shahaf wrote: Troy Curtis Jr wrote on Sun, 16 Dec 2018 09:59 -0500: But there was one item I wanted to talk about related to the patch. I agree that "svn_stringbuf_t" => "bytes" and "svn_string_t" => "str" is

Re: [swig-py3][patch] interfacing bytes object instead of str

2018-12-16 Thread Troy Curtis Jr
On Sun, Dec 16, 2018 at 11:28 AM Daniel Shahaf wrote: > Troy Curtis Jr wrote on Sun, 16 Dec 2018 09:59 -0500: > > But there was one item I wanted to talk about related to the patch. I > > agree that "svn_stringbuf_t" => "bytes" and "svn_string_t" => "str" is > the > > right general path, > > Are

Re: [swig-py3][patch] interfacing bytes object instead of str

2018-12-16 Thread Daniel Shahaf
Troy Curtis Jr wrote on Sun, 16 Dec 2018 09:59 -0500: > But there was one item I wanted to talk about related to the patch. I > agree that "svn_stringbuf_t" => "bytes" and "svn_string_t" => "str" is the > right general path, Are you sure about this? Property values can be binary data (so not rep

Re: [swig-py3][patch] interfacing bytes object instead of str

2018-12-16 Thread Troy Curtis Jr
On Wed, Nov 28, 2018 at 10:40 AM Daniel Shahaf wrote: > Yasuhito FUTATSUKI wrote on Tue, Nov 27, 2018 at 06:50:46 +0900: > > I've revised typemaps and APIs using svn_stringbuf_t *, then I found > > almost all those APIs include svn_stream_readline() use svn_stringbuf_t > > for file contents. So