Re: svn commit: r1850513 - /subversion/site/publish/upcoming.part.html

2019-01-05 Thread Daniel Shahaf
svn-r...@apache.org wrote on Sat, 05 Jan 2019 21:41 +: > Author: svn-role > Date: Sat Jan 5 21:41:01 2019 > New Revision: 1850513 > > URL: http://svn.apache.org/viewvc?rev=1850513&view=rev > Log: > * upcoming.part.html: Automatically regenerated > > Modified: > subversion/site/publish/up

Re: extending the blame callback

2019-01-05 Thread Daniel Shahaf
Stefan Kueng wrote on Sat, 05 Jan 2019 21:15 +0100: > here's a patch using svn_stringbuf_t for review. Change "Provided for backwards compatibility with the 1.6 API" to "Provided for backwards compatibility with the 1.11 API" in svn_client_blame5()'s docstring.

Re: extending the blame callback

2019-01-05 Thread Stefan Kueng
On 05.01.2019 17:53, Julian Foad wrote: Stefan Kueng wrote: When running blame on an utf16 text file, the lines can not be used since the blame callback only passes a 'char *' parameter which means it ends at the first zero char. But actually, svn knows if the line has more content. +1 on do

Re: extending the blame callback

2019-01-05 Thread Stefan Kueng
On 05.01.2019 18:05, Mark Phippard wrote: On Jan 5, 2019, at 10:58 AM, Stefan Kueng wrote: So, with this patch I'm able to do a blame on utf16 files, so I'd like to commit this if there are no objections. I have no objections, just a question. I thought SVN treated utf16 files as bina

Re: extending the blame callback

2019-01-05 Thread Stefan Kueng
On 05.01.2019 17:53, Julian Foad wrote: Stefan Kueng wrote: When running blame on an utf16 text file, the lines can not be used since the blame callback only passes a 'char *' parameter which means it ends at the first zero char. But actually, svn knows if the line has more content. +1 on d

Re: extending the blame callback

2019-01-05 Thread Mark Phippard
> On Jan 5, 2019, at 10:58 AM, Stefan Kueng wrote: > > So, with this patch I'm able to do a blame on utf16 files, so I'd like to > commit this if there are no objections. > I have no objections, just a question. I thought SVN treated utf16 files as binary. How does blame work at all? I th

Re: extending the blame callback

2019-01-05 Thread Julian Foad
Stefan Kueng wrote: > When running blame on an utf16 text file, the lines can not be used > since the blame callback only passes a 'char *' parameter which means it > ends at the first zero char. But actually, svn knows if the line has > more content. +1 on doing something to fix the problem.

extending the blame callback

2019-01-05 Thread Stefan Kueng
Hi, When running blame on an utf16 text file, the lines can not be used since the blame callback only passes a 'char *' parameter which means it ends at the first zero char. But actually, svn knows if the line has more content. So I'd like to propose the following patch which extends the blame