Re: [PATCH] configure.ac: don't mangle CFLAGS

2020-09-09 Thread Branko Čibej
On 10.09.2020 07:36, Fabrice Fontaine wrote: > Hello Brane, > > Le jeu. 10 sept. 2020 à 05:53, Branko Čibej a écrit : >> On 10.09.2020 05:41, Branko Čibej wrote: >> >> On 09.09.2020 23:34, Fabrice Fontaine wrote: >> >> Ensure that the sed expression to strip debugging options from CFLAGS >> doesn'

Re: [PATCH] configure.ac: don't mangle CFLAGS

2020-09-09 Thread Branko Čibej
On 10.09.2020 05:41, Branko Čibej wrote: > On 09.09.2020 23:34, Fabrice Fontaine wrote: >> Ensure that the sed expression to strip debugging options from CFLAGS >> doesn't mangle flags like -mfloat-gprs=double, breaking the build. >> >> Patch by: Peter Korsgaard and Vicente Olivert Riera >> (See >

Re: [PATCH] configure.ac: don't mangle CFLAGS

2020-09-09 Thread Branko Čibej
On 09.09.2020 23:34, Fabrice Fontaine wrote: > Ensure that the sed expression to strip debugging options from CFLAGS > doesn't mangle flags like -mfloat-gprs=double, breaking the build. > > Patch by: Peter Korsgaard and Vicente Olivert Riera > (See > https://git.buildroot.net/buildroot/tree/packag

[PATCH] configure.ac: don't mangle CFLAGS

2020-09-09 Thread Fabrice Fontaine
Ensure that the sed expression to strip debugging options from CFLAGS doesn't mangle flags like -mfloat-gprs=double, breaking the build. Patch by: Peter Korsgaard and Vicente Olivert Riera (See https://git.buildroot.net/buildroot/tree/package/subversion/0001-dont-mangle-cflags.patch?h=2020.08) --

Re: [ISSUE] Cancelling svn checkout leaves an open file handle

2020-09-09 Thread Daniel Shahaf
Daniel Sahlberg wrote on Wed, 09 Sep 2020 10:35 +0200: > Would it be a better approach to enumerate all open fd:s before and after > the call to 'checkout' and compare the list of open fd:s (after any pool > cleanup required). Of course enumerating open fd:s most probably require > platform specifi

Re: [ISSUE] Cancelling svn checkout leaves an open file handle

2020-09-09 Thread Daniel Shahaf
Branko Čibej wrote on Wed, 09 Sep 2020 09:39 +0200: > On 09.09.2020 08:18, Daniel Sahlberg wrote: > > For a regression test (as well as trying to pinpoint what goes wrong), > > wouldn't it be enough if the cancel_func check for the presence of a > > file in .svn/tmp (maybe even checking if it is op

Re: [ISSUE] Cancelling svn checkout leaves an open file handle

2020-09-09 Thread Daniel Shahaf
[ Moving to dev@ since earlier replies in the thread moved there. Please un-Cc users@ from replies. ] Uroš Jovanović wrote on Tue, 08 Sep 2020 11:31 +0200: > Hi Daniel, > > Not sure what are "relevant pools", I am not really too familiar with SVN :) > The C API manages lifetime of various resou

Re: [PATCH] Fix JavaHL crash in TunnelAgent.CloseTunnelCallback after GC

2020-09-09 Thread Thomas Singer
Has this patch been merged yet? If not, what input is needed to get it accepted? Tom On 2020-08-07 20:47, Alexandr Miloslavskiy wrote: Please find test snippet and patch attached. [[[ Fix JavaHL crash in TunnelAgent.CloseTunnelCallback after GC When jobject reference is kept across differen

Re: [PATCH] Fix JavaHL crash in RequestChannel.nativeRead

2020-09-09 Thread Thomas Singer
Has this patch been merged yet? If not, what input is needed to get it accepted? Tom On 2020-08-10 21:30, Alexandr Miloslavskiy wrote: Please find test snippet and patch attached. [[[ Fix JavaHL crash in RequestChannel.nativeRead The problem here is that when 'RemoteSession' is destroyed, i

Re: [ISSUE] Cancelling svn checkout leaves an open file handle

2020-09-09 Thread Uroš Jovanović
> > Do you know if SharpSvn is maintained? When I checked your previous test > code it seemed the NuGet package of SharpSvn is based on Subversion 1.9 and > any bugfix will (at maximum) be applied to 1.10 and 1.14. So maybe you are > out of luck even if we find it is a bug in Subversion and fix it.

Re: [ISSUE] Cancelling svn checkout leaves an open file handle

2020-09-09 Thread Uroš Jovanović
Hi Nathan, Hi Daniel, Thank you both for your replies. As a workaround I ended up doing exactly the things you mentioned. After the cancellation of the operation I call additional code to "cleanup". This code goes through open file handles held by the current process and closes the ones left over

Re: [ISSUE] Cancelling svn checkout leaves an open file handle

2020-09-09 Thread Daniel Sahlberg
Den ons 9 sep. 2020 kl 10:38 skrev Uroš Jovanović : > Hi Nathan, > Hi Daniel, > > Thank you both for your replies. > > As a workaround I ended up doing exactly the things you mentioned. After > the cancellation of the operation I call additional code to "cleanup". > This code goes through open fil

Re: [ISSUE] Cancelling svn checkout leaves an open file handle

2020-09-09 Thread Daniel Sahlberg
Den ons 9 sep. 2020 kl 09:39 skrev Branko Čibej : > On 09.09.2020 08:18, Daniel Sahlberg wrote: > > Den ons 9 sep. 2020 kl 06:44 skrev Nathan Hartman < > hartman.nat...@gmail.com>: > >> On Tue, Sep 8, 2020 at 6:08 AM Uroš Jovanović wrote: >> > >> > Then, mid downloading some of the larger files a

Re: [ISSUE] Cancelling svn checkout leaves an open file handle

2020-09-09 Thread Branko Čibej
On 09.09.2020 08:18, Daniel Sahlberg wrote: > Den ons 9 sep. 2020 kl 06:44 skrev Nathan Hartman > mailto:hartman.nat...@gmail.com>>: > > On Tue, Sep 8, 2020 at 6:08 AM Uroš Jovanović > wrote: > > > > Then, mid downloading some of the larger files a temp fi