Re: svn commit: r1926360 - in /subversion/trunk: CMakeLists.txt subversion/include/svn_utf.h

2025-06-11 Thread Branko Čibej
On 12. 6. 25 00:30, Timofei Zhakov wrote: Revert most of the changes in svn_utf.h from r1926293. Instead, tell the CMake build to expose APR and APR-Util include paths everywhere. (...) * CMakeLists.txt: Add APR and APR-Util include paths to the top-level    directory prop

Re: svn commit: r1926293 - in /subversion/trunk/subversion: include/svn_utf.h libsvn_subr/utf.c

2025-06-11 Thread Nathan Hartman
On Wed, Jun 11, 2025 at 7:26 PM Timofei Zhakov wrote: > (snip) > > Branko, I'm so confused from the entire thread and all those points you > are mentioning. > > 1. I would like to clarify this change. This wasn't made to fix that > problem in the first place. I noticed two unrelated things which

Re: svn commit: r1926293 - in /subversion/trunk/subversion: include/svn_utf.h libsvn_subr/utf.c

2025-06-11 Thread Timofei Zhakov
(snip) Branko, I'm so confused from the entire thread and all those points you are mentioning. 1. I would like to clarify this change. This wasn't made to fix that problem in the first place. I noticed two unrelated things which were wrong (in my opinion) in the utf header file/implementation. Fi

Re: svn commit: r1926360 - in /subversion/trunk: CMakeLists.txt subversion/include/svn_utf.h

2025-06-11 Thread Timofei Zhakov
> > Revert most of the changes in svn_utf.h from r1926293. Instead, tell the > CMake build to expose APR and APR-Util include paths everywhere. > > (...) > > * CMakeLists.txt: Add APR and APR-Util include paths to the top-level >directory properties. > (...) > --- subversion/trunk/CMakeList

Re: svn commit: r1926293 - in /subversion/trunk/subversion: include/svn_utf.h libsvn_subr/utf.c

2025-06-11 Thread Nathan Hartman
On Wed, Jun 11, 2025 at 10:25 AM Branko Čibej wrote: > On 11. 6. 25 06:21, Nathan Hartman wrote: > > (snip) > So that's obviously something to be fixed. I wonder why this particular > #include in this specific place? After all, we're including other APR > headers elsewhere. > > > > I'll explain

Re: svn commit: r1926293 - in /subversion/trunk/subversion: include/svn_utf.h libsvn_subr/utf.c

2025-06-11 Thread Branko Čibej
On 11. 6. 25 06:21, Nathan Hartman wrote: On Tue, Jun 10, 2025 at 8:00 PM Branko Čibej wrote: The CMake build is broken with regard to include directories, that's a given, and it's easy to fix. Perhaps not in such a cmake-purist way that some people around here appear to advocate,

Re: svn commit: r1926293 - in /subversion/trunk/subversion: include/svn_utf.h libsvn_subr/utf.c

2025-06-11 Thread Branko Čibej
On 9. 6. 25 19:26, Branko Čibej wrote: On 9. 6. 25 18:31, rin...@apache.org wrote: Author: rinrab Date: Mon Jun 9 16:31:15 2025 New Revision: 1926293 URL:http://svn.apache.org/viewvc?rev=1926293&view=rev Log: Do not include apr_xlate.h into svn_utf.h, but manually wrap the SVN_APR_*_CHARSET co

Re: svn commit: r1926350 - /subversion/trunk/CMakeLists.txt

2025-06-11 Thread Branko Čibej
On 11. 6. 25 00:07, rin...@apache.org wrote: Author: rinrab Date: Tue Jun 10 22:07:50 2025 New Revision: 1926350 URL:http://svn.apache.org/viewvc?rev=1926350&view=rev Log: cmake: Prevent re-definition of APR and Serf targets by using different prefixes for version '1' and '2'. * CMakeLists.txt

Re: svn commit: r1926293 - in /subversion/trunk/subversion: include/svn_utf.h libsvn_subr/utf.c

2025-06-11 Thread Branko Čibej
On 11. 6. 25 06:21, Nathan Hartman wrote: On Tue, Jun 10, 2025 at 8:00 PM Branko Čibej wrote: On 11. 6. 25 01:19, Nathan Hartman wrote: On Tue, Jun 10, 2025 at 12:26 PM Branko Čibej wrote: On 10. 6. 25 17:32, Timofei Zhakov wrote: On Tue, Jun 10, 2025 at 5:24 PM