All Things Open

Are any Subversion devs planning on being at All Things Open in Raleigh? It'll be my first time (made easy since I'm local now) and I thought it might be interesting to meetup with anyone that happened to be going. Troy

Re: The run up to Subversion 1.13.0

On Fri, Aug 30, 2019, 7:13 PM James McCoy wrote: > On Fri, Aug 30, 2019 at 05:12:21PM +0100, Julian Foad wrote: > > 2. As 1.13 is only weeks away, there is little point in making any > further > > 1.12.x patch releases from now on, so I will not plan to do so. > > > > Any other thoughts on anythi

Re: [PATCH]On branch swig-py3: accept both of bytes/str for inputchar * args

On Sun, Feb 17, 2019, 10:32 AM Daniel Shahaf wrote: > Yasuhito FUTATSUKI wrote on Sun, 17 Feb 2019 06:13 +00:00: > > On 2/17/19 9:04 AM, Daniel Shahaf wrote: > > > > > I was wondering what are the blockers for merging swig-py3 into trunk? > > > The only item in BRANCH-README is "Fix a compile err

Fwd: Regarding service request 630262

FYI -- Forwarded message - From: CVE Request Date: Tue, Feb 5, 2019 at 11:55 AM Subject: Regarding service request 630262 To: troycurti...@apache.org Subject: CVE Request 630262 for Publication Request From: cve-requ...@mitre.org To: troycurti...@apache.org Date: 1/22/2019 11:05

Re: [CVE-2018-11803] Apache Subversion Denial of Service Vulnerability

On Thu, Jan 24, 2019 at 2:17 PM Julian Foad wrote: > > Thanks, Troy. > > I have noted this CVE fix in the CHANGES file in r1852014 and pushed it to > 1.10 and 1.11 branches so people looking there can find it. > Thanks Julian! That was on my TODO list, but didn't get to it last night. I also was

Re: [PATCH]On branch swig-py3: accept both of bytes/str for input char * args

On Thu, Jan 10, 2019 at 9:50 AM Yasuhito FUTATSUKI wrote: > > Hi, > > I've made a patch swig-py3@1850520, to accept both of bytes and str > objects for input args correspondings char * args of Subversion API > on Python 3 wrapper functions. It is just a interim report, because > I have some points

ctypes-python errors with Subversion 1.9.10

On Fedora, python 2.7 & ctypesgen==0.post125 When I attempt to compile I get this error message: $ make ctypes-python /bin/sh /home/tscurti/working/oss/subversion/releases/test2/subversion-1.9.10/build/run_ctypesgen.sh "/bin/sh "/home/tscurti/working/oss/subversion/releases/test2/subversion-1.9.1

Re: svn commit: r1850519 - in /subversion/branches/swig-py3: Makefile.in build/ac-macros/swig.m4 build/generator/gen_make.py build/generator/templates/build-outputs.mk.ezt

On Sun, Jan 6, 2019 at 11:09 AM Daniel Shahaf wrote: > troycurti...@apache.org wrote on Sun, Jan 06, 2019 at 00:42:27 -: > > Author: troycurtisjr > > Date: Sun Jan 6 00:42:27 2019 > > New Revision: 1850519 > > > > URL: http://svn.apache.org/viewvc?rev=1850519&view=rev > > Log: > > On branch

Re: Subversion 1.9.10 up for testing/signing

On Mon, Jan 7, 2019 at 7:46 AM Julian Foad wrote: > The 1.9.10 release artifacts are now available for testing/signing. > Please get the tarballs from > https://dist.apache.org/repos/dist/dev/subversion > and add your signatures there. > > Thanks! > > Summary: +1 to release Tested: [bdb | fsfs

[PATCH] RFC on providing a more meaningful error message for swig-py

Howdy guys, One of the TODO items I put in the swig-py3 branch README is to provide a more useful error message if the user tries to build the swig-py bindings, but they are disabled/failed to configure. There are several failure modes that would prevent the Python binding from building, however c

Re: [swig-py3][patch] interfacing bytes object instead of str

On Fri, Dec 28, 2018 at 8:20 AM Yasuhito FUTATSUKI wrote: > On 12/28/18 4:09 AM, Troy Curtis wrote: > > LGTM, committed as r1849804, but without the unnecessary gymnastics to > continue supporting str() in those two cases mentioned above. I also > tweaked the log message to use complete sentences

Re: Common header(s) for C and C++ API

On Sun, Dec 30, 2018 at 6:07 PM Branko Čibej wrote: > Summary: I propose to create one or possibly several new public header > files that will be used by both the C and C++ public APIs. > > > I would like to completely hide the dependency on APR from the public > parts of the C++ API. In order to

Re: [swig-py3][patch] interfacing bytes object instead of str

On Mon, Dec 24, 2018 at 1:11 PM Yasuhito FUTATSUKI wrote: > On 12/17/18 5:50 AM, Yasuhito FUTATSUKI wrote: > > On 12/17/18 2:08 AM, Troy Curtis Jr wrote: > [snip] > Status update: I've done to make patch that default to map bytes > from char *, svn_string_t, and svn_st

Re: [swig-py3][patch] interfacing bytes object instead of str

On Sun, Dec 16, 2018 at 11:28 AM Daniel Shahaf wrote: > Troy Curtis Jr wrote on Sun, 16 Dec 2018 09:59 -0500: > > But there was one item I wanted to talk about related to the patch. I > > agree that "svn_stringbuf_t" => "bytes" and "svn_string_

Re: [swig-py3][patch] interfacing bytes object instead of str

On Wed, Nov 28, 2018 at 10:40 AM Daniel Shahaf wrote: > Yasuhito FUTATSUKI wrote on Tue, Nov 27, 2018 at 06:50:46 +0900: > > I've revised typemaps and APIs using svn_stringbuf_t *, then I found > > almost all those APIs include svn_stream_readline() use svn_stringbuf_t > > for file contents. So

Re: [swig-py3][patch] interfacing bytes object instead of str

On Wed, Nov 28, 2018, 10:40 AM Daniel Shahaf Yasuhito FUTATSUKI wrote on Tue, Nov 27, 2018 at 06:50:46 +0900: > > I've revised typemaps and APIs using svn_stringbuf_t *, then I found > > almost all those APIs include svn_stream_readline() use svn_stringbuf_t > > for file contents. So I've modifie

Re: swig-py3 svn_stream_read

On Fri, Mar 23, 2018, 3:10 AM Daniel Shahaf wrote: > Trying to merge trunk@HEAD into branches/swig-py3, the py2 tests pass > but the py3 tests fail: > > [[[ > E/usr/lib/python3.5/unittest/case.py:629: > ResourceWarning: unclosed file <_io.BufferedWriter

Re: Updating swig-py bindings

On Tue, Mar 13, 2018 at 9:44 AM Julian Foad wrote: > Troy (or others), I want to use swig-py bindings for my new shelving API > (in svn_client.h) so I am trying to update them. I started by looking at > the 'Missing argout typemap' warnings for svn_client.h. > > As well as svn_shelf_* functions,

Re: diff --normal is not portable (Re: svn commit: r1824410 - in /subversion/trunk/subversion/bindings/swig/python: svn/fs.py tests/fs.py)

On Sat, Feb 17, 2018, 6:38 AM Stefan Sperling wrote: > Hi Troy, > > The diff --normal option is a GNU extension and hence not portable to > systems which do not use GNU diff. > > See > https://ci.apache.org/builders/svn-bb-openbsd/builds/27/steps/Test%20bindings/logs/stdio > which fails with: > >

Re: Review Request: svn.fs.FileDiff

On Sun, Feb 11, 2018 at 4:33 PM Daniel Shahaf wrote: > Troy Curtis Jr wrote on Sun, 11 Feb 2018 16:10 +: > > I'm asking for comments because the actual diff output given when > > 'diffoptions' is None, is changed. > ... > > Thoughts? > > 1. We hav

Review Request: svn.fs.FileDiff

In parallel to the other discussion on import order of svn.fs.FileDiff, I'd like some comments on the attached patch. Mostly, this is to address the failing tests on Windows [0], since there isn't a 'diff' executable necessarily available. The attached patch uses the internal Subversion diff impl

Re: mailer.py commit says TypeError: must be unicode, not str

On Sun, Feb 11, 2018 at 2:38 AM Daniel Shahaf wrote: > Troy Curtis Jr wrote on Sun, 11 Feb 2018 02:28 +: > > I committed the fix to the bindings in > > https://svn.apache.org/viewvc?view=revision&revision=1823802 . In > addition > > to Kenneth's sugges

Re: mailer.py commit says TypeError: must be unicode, not str

On Sat, Feb 10, 2018 at 8:28 PM Troy Curtis Jr wrote: > On Thu, Feb 8, 2018 at 12:22 PM Kenneth Porter > wrote: > >> On 2/8/2018 4:35 AM, Daniel Shahaf wrote: >> > So, just to be clear, the problem is that svn/fs.py is not py3 >> > compatible, and having the &

Re: mailer.py commit says TypeError: must be unicode, not str

On Thu, Feb 8, 2018 at 12:22 PM Kenneth Porter wrote: > On 2/8/2018 4:35 AM, Daniel Shahaf wrote: > > So, just to be clear, the problem is that svn/fs.py is not py3 > > compatible, and having the 'builtins' module under py2 merely > > exposes that? I.e., we have no reason to suspect a bug in the

Re: mailer.py commit says TypeError: must be unicode, not str

On Wed, Feb 7, 2018 at 8:53 PM Kenneth Porter wrote: > --On Thursday, February 08, 2018 2:30 AM +0000 Troy Curtis Jr > wrote: > > > If that package was being imported, I'd definitely expect that kind of > > behavior, but merely it's presence on your system shoul

Re: mailer.py commit says TypeError: must be unicode, not str

On Wed, Feb 7, 2018 at 11:54 AM Kenneth Porter wrote: > --On Wednesday, February 07, 2018 9:35 AM -0800 Kenneth Porter > wrote: > > > So there's a builtins package hiding in this system somewhere. > > Found it. The system has the python2-future package which is a dependency > of the certbot pack

Re: mailer.py commit says TypeError: must be unicode, not str

On Wed, Feb 7, 2018 at 1:06 PM Daniel Shahaf wrote: > Kenneth Porter wrote on Wed, 07 Feb 2018 09:35 -0800: > > The overload of type was happening due to the unprefix stuff in fs.py. > Red > > herring, though interesting. > > This should only happen with 1.7 and earlier, see > https://subversion.

Re: mailer.py commit says TypeError: must be unicode, not str

Proposed edit to fs.py: Change 'w+' to 'wb' when copying svn stream object >> to temporary file. Update isn't needed, and the code just needs to dump >> the >> raw data into a file for the external diff to access, so no >> encoding/decoding should occur. Hence we should open the file in binary >> m

Re: mailer.py commit says TypeError: must be unicode, not str

On Thu, Feb 1, 2018, 12:34 PM Kenneth Porter wrote: > [moving discussion to dev list as I think this is now the correct fix.] > > --On Wednesday, January 31, 2018 7:40 PM -0800 Kenneth Porter > wrote: > > > --On Wednesday, January 31, 2018 7:23 PM -0800 Kenneth Porter > > wrote: > > > >> fp

Re: swig-py3 branch review for trunk merge

On Wed, Jan 31, 2018 at 7:16 AM Daniel Shahaf wrote: > Troy Curtis Jr wrote on Wed, 31 Jan 2018 04:30 +: > > I'm now asking for swig-py3 merge to trunk review with fewer caveats. > > > > [...] The biggest update is addition of Windows support with the new py3c >

Re: swig-py3 branch review for trunk merge

On Wed, Dec 27, 2017 at 11:47 PM Troy Curtis Jr wrote: > I finally have the swig-py3 branch in a state that I believe is ready to > be merged into trunk. All the tests pass under python 2 and 3 now, and I > successfully tested viewvc 1.1.26 against the python 2 bindings. In order

Re: Windows Compile Help

On Tue, Jan 30, 2018 at 5:49 AM Jan Ehrhardt wrote: > Bert Huijben in gmane.comp.version-control.subversion.devel (Mon, 29 Jan > 2018 14:43:15 +0100): > >If you build ZLib with the Windows specific assembly optimizations you > >introduce known issues. Please make sure that you run the Subversion

Re: Windows Compile Help

[..snip..] > Glad I could help. Out of curiosity is this a 64-bit build and did you > have to do anything out of the ordinary because of that? > I'm basically taking defaults, and considering the zlib asm I built was x86 and not x64 (and linking finally worked), I'm guessing it is a 32-bit build

Re: Windows Compile Help

On Sun, Jan 28, 2018 at 12:21 AM Nathan Hartman wrote: > On Jan 27, 2018, at 11:44 PM, Troy Curtis Jr > wrote: > > I'm hoping someone can point me in the right direction with an issue I'm > having compiling Subversion on Windows 10 using Visual Studio 2015 tools. >

Re: SVN-4709 shelve: deleted file becomes 'replaced'

On Wed, Jan 24, 2018 at 6:49 PM Branko Čibej wrote: > On 24.01.2018 22:32, Julian Foad wrote: > > When 'svn patch' applies an 'add file' patch onto a WC path whose > > local schedule is 'delete', it changes the schedule to 'replace'. > > > > Sequences such as this... > > > > > svn rm foo > > > sv

Re: [PATCH] swig-py svn_stream_t read() glue

On Wed, Jan 3, 2018 at 10:55 PM Daniel Shahaf wrote: > svn_swig_py_make_stream() is a function that wraps a PyObject in an > svn_stream_t. Its read implementation, read_handler_pyio(), just calls > the PyObject's .read() method. > > According to

Re: svn commit: r1818995 - in /subversion/branches/swig-py3: build/ac-macros/swig.m4 subversion/bindings/swig/include/proxy.py subversion/bindings/swig/include/proxy.swg

On Tue, Jan 2, 2018 at 3:12 AM Branko Čibej wrote: > On 31.12.2017 03:05, Troy Curtis Jr wrote: > > > > This all makes sense and seems nice on the surface, but I'm not > > sure we > > can just change the behaviour of the bindings from old-style t

Re: [PATCH] svn diff --summarize changed to show left and right revision numbers

On Tue, Jan 2, 2018 at 7:03 AM Branko Čibej wrote: > On 02.01.2018 13:43, Nagy Peter wrote: > > > It only shows that the two are not the same, but nothing more. If I > change the left and right side, > > the output also changes, as follows: > > svn diff --summarize --ignore-properties https:///D

Re: svn commit: r1818995 - in /subversion/branches/swig-py3: build/ac-macros/swig.m4 subversion/bindings/swig/include/proxy.py subversion/bindings/swig/include/proxy.swg

On Sat, Dec 30, 2017 at 12:49 PM Branko Čibej wrote: > On 30.12.2017 16:11, Troy Curtis Jr wrote: > > > > > > On Fri, Dec 29, 2017 at 11:46 PM Daniel Shahaf > <mailto:d...@daniel.shahaf.name>> wrote: > > > > Good morning Troy, > >

Re: svn commit: r1818995 - in /subversion/branches/swig-py3: build/ac-macros/swig.m4 subversion/bindings/swig/include/proxy.py subversion/bindings/swig/include/proxy.swg

On Fri, Dec 29, 2017 at 11:46 PM Daniel Shahaf wrote: > Good morning Troy, > > troycurti...@apache.org wrote on Fri, Dec 22, 2017 at 03:52:59 -: > > On branch swig-py3: Correctly manage swig objects with Python new style > classes. > > > > * build/ac-macros/swig.m4 > > (SVN_FIND_SWIG): > >

swig-py3 branch review for trunk merge

I finally have the swig-py3 branch in a state that I believe is ready to be merged into trunk. All the tests pass under python 2 and 3 now, and I successfully tested viewvc 1.1.26 against the python 2 bindings. In order to have shared code for python 2 and 3, there were a fair number of substitut

Re: svn commit: r1819110 - /subversion/branches/swig-py3/subversion/bindings/swig/include/proxy.swg

On Sat, Dec 23, 2017 at 2:57 PM Daniel Shahaf wrote: > Troy Curtis Jr wrote on Sat, 23 Dec 2017 15:27 +: > > On Fri, Dec 22, 2017 at 11:11 PM Daniel Shahaf > > wrote: > > > > > troycurti...@apache.org wrote on Sat, 23 Dec 2017 04:43 +: > > > >

Re: svn commit: r1819110 - /subversion/branches/swig-py3/subversion/bindings/swig/include/proxy.swg

On Sat, Dec 23, 2017 at 2:57 PM Daniel Shahaf wrote: > Troy Curtis Jr wrote on Sat, 23 Dec 2017 15:27 +: > > On Fri, Dec 22, 2017 at 11:11 PM Daniel Shahaf > > wrote: > > > > > troycurti...@apache.org wrote on Sat, 23 Dec 2017 04:43 +: > > > >

Re: svn commit: r1819110 - /subversion/branches/swig-py3/subversion/bindings/swig/include/proxy.swg

On Fri, Dec 22, 2017 at 11:11 PM Daniel Shahaf wrote: > troycurti...@apache.org wrote on Sat, 23 Dec 2017 04:43 +: > > Author: troycurtisjr > > Date: Sat Dec 23 04:43:26 2017 > > New Revision: 1819110 > > > > URL: http://svn.apache.org/viewvc?rev=1819110&view=rev > > Log: > > On branch swig-p

Swig py3 branch

I am currently having some home internet problems, so replying to Daniel's irc query here via mobile. I think the swig py3 branch is very close. My latest commit does cause one py2 test to start failing (probably resulting from going to new style classes) , but I hope to get that nailed down tonig

Re: svn_client_status6() and svn_client_patch_func_t doc strings

On Fri, Dec 8, 2017, 3:49 AM Julian Foad wrote: > Troy Curtis Jr wrote: > > Julian Foad wrote: > > [[[ > > Index: subversion/include/svn_client.h > > === > > --- subversion/include/s

Re: svn_client_status6() and svn_client_patch_func_t doc strings

On Thu, Dec 7, 2017 at 11:03 AM Julian Foad wrote: > Queries/suggestions on svn_client_status6() and svn_client_patch_func_t... > > [[[ > Index: subversion/include/svn_client.h > === > --- subversion/include/svn_client.h (revisio

Re: svn commit: r1816596 - /subversion/branches/swig-py3/Makefile.in

On Thu, Nov 30, 2017 at 9:03 AM Daniel Shahaf wrote: > Troy Curtis Jr wrote on Thu, 30 Nov 2017 02:20 +: > > On Wed, Nov 29, 2017, 10:08 AM Daniel Shahaf > > > But if you think it should go ahead and get put to trunk I'd be happy to > do > > so, you may be wor

Re: svn commit: r1816596 - /subversion/branches/swig-py3/Makefile.in

On Wed, Nov 29, 2017, 10:08 AM Daniel Shahaf wrote: > troycurti...@apache.org wrote on Wed, 29 Nov 2017 03:50 +: > > Author: troycurtisjr > > Date: Wed Nov 29 03:50:09 2017 > > New Revision: 1816596 > > > > URL: http://svn.apache.org/viewvc?rev=1816596&view=rev > > Log: > > On branch swig-py3

Re: svn commit: r1814386 - in /subversion/branches/swig-py3: build/generator/swig/ build/generator/util/ subversion/bindings/swig/python/svn/ subversion/bindings/swig/python/tests/ subversion/bindings

On Mon, Nov 6, 2017 at 7:33 AM Daniel Shahaf wrote: > troycurti...@apache.org wrote on Mon, 06 Nov 2017 01:58 +: > > +++ > subversion/branches/swig-py3/subversion/bindings/swig/python/tests/trac/versioncontrol/tests/svn_fs.py > Mon Nov 6 01:58:20 2017 > > @@ -53,17 +53,19 @@ import shutil >

Re: svn commit: r1814387 - in /subversion/branches/swig-py3: BRANCH-README Makefile.in build.conf build/ac-macros/swig.m4 configure.ac subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.c

On Mon, Nov 6, 2017, 7:41 AM Daniel Shahaf wrote: > troycurti...@apache.org wrote on Mon, 06 Nov 2017 02:33 +: > > +++ subversion/branches/swig-py3/build/ac-macros/swig.m4 Mon Nov 6 > 02:33:27 2017 > > @@ -133,6 +134,18 @@ AC_DEFUN(SVN_FIND_SWIG, > > +AC_CACHE_CHECK([for Python >= 3]

Python3 Swig Bindings Branch (was Re: Python 3 Bindings Query)

Howdy guys, I thought I'd point out my first (useful) commit to the ^/subversion/branches/swig-py3 branch, r1813665. This adds the py3c library to the build and replaces (hopefully all) the various functions that are incompatible between 2 and 3 with the appropriate py3c provided interfaces. The

Possibly dead link in community guide?

Currently the link http://subversion.tigris.org/servlets/ReadMsg?list=dev&msgNo=132746 referenced in https://subversion.apache.org/docs/community-guide/roles.html#committers results in a Tomcat error. It may just be a temporary downtime issue, but I'm not sure so I though I'd point it out. Troy

Re: Python 3 Bindings Query

On Wed, Oct 18, 2017 at 10:11 PM Daniel Shahaf wrote: > Troy Curtis Jr wrote on Wed, Oct 18, 2017 at 03:49:57 +: > > > > > 3. Is the assumption of utf8 encoding sufficiently reasonable? > > > > > > In Subversion, we assume that argv and stdout are enc

Re: Python 3 Bindings Query

On Wed, Oct 18, 2017, 4:11 AM Julian Foad wrote: > Troy Curtis Jr wrote: > >>> 2. Do you want to pick up 'py3c' as a new dep, or implement the > >>> handful of necessary wrappers? > >> > >> I don't know the swig-py bindings well e

Re: Python 3 Bindings Query

> Thanks for posting that. Is that patch ready for commit, or is it > intended just as a proof of concept / basis for discussions? > Definitely not ready for commit, it is the WIP of what I was hacking on Sunday. I was just getting a feel for the kinds of things involved, and attached it to give

Re: Python 3 Bindings Query

swig functions and syntax with Py2/Py3 cross-compatible versions or wrappers. 2. Ensure existing full Py2 support works correctly. 3. Update build to build both, Py2 and Py3, and get Py3 working. 4. Look at the remainder of the python usage to ensure Py3 compliance. Cheers, > > Daniel

Python 3 Bindings Query

Howdy guys, It has been quite some time since I was last on here, but as I was looking through Fedora's Python 3 porting status list [1] I saw the familiar Subversion project showed as not yet supporting Python 3. So I was wondering if you are interested in having me take a shot at getting it wor