;>> session = client.open_ra_session('svn+ssh://svn-agent-sysadmin@localhost/',
>>> ctx)
>>> ra.get_latest_revnum(session)
2221
>>> session2 =
>>> client.open_ra_session('https://svn.apache.org/repos/asf/non-existent/',ctx)
>>> ra.get_latest_revnum(session2)
1917447
>>> quit()
]]]
Cheers,
--
Yasuhito FUTATSUKI
On 2024/04/24 6:33, Branko Čibej wrote:
> On 23. 04. 24 20:29, Yasuhito FUTATSUKI wrote:
>> On 2024/04/24 1:30, Branko Čibej wrote:
>>> On 23. 04. 24 17:24, Yasuhito FUTATSUKI wrote:
>>>> Hello,
>>>>
>>>> On 2024/04/23 20:42, Khairul Azhar Kas
On 2024/04/24 1:30, Branko Čibej wrote:
> On 23. 04. 24 17:24, Yasuhito FUTATSUKI wrote:
>> Hello,
>>
>> On 2024/04/23 20:42, Khairul Azhar Kasmiran wrote:
>>> I've reattached the patch as a .txt file.
>>>
>>> On 2024/04/23 10:46:41 Khairul A
`*` becomes a wildcard on
>> Windows.
Just a question (not checked on Windows). What part of the code
does treat '*' as a wildcard? Even if subprocess.call() is
called with shell=False (it is default), did it expand '*'?
Cheers,
--
Yasuhito FUTATSUKI
> I think, I should have used d...@santuario.apache.org.
>
>
>
> Yours sincerely,
> Danilov Alexander
> alexander.dani...@cma.se
>
> ____
> From: Yasuhito FUTATSUKI
> Sent: Tuesday, February 27, 2024 8:11:56 PM
> To: Alexander Dan
tatus 1
> configure: failed program was:
As long as I read Subversion's configure.ac, there does not exist such
a test for getcwd().
Did you intend to post to some other mailing list than here,
dev@subversion.apache.org ?
Regards,
--
Yasuhito FUTATSUKI
I've used it with Python 3.6 since
2021-03-03(at latest) but those conditions are satisfid. Also my local
test did not cover opposit of the former condition. That's why
it wasn't fixed since then until r1915337, after 1.14.3 was released.
Anyways, I'd be glad if those fix would released with Subversion 1.14.4.
Cheers,
--
Yasuhito FUTATSUKI
Hi, I'd like to publish the fix of swig-py bug in r1915316, the bug
which can cause crash, in the release note for Subversion 1.14.
Here is a draft I wrote, but I have no confidence about it.
Could anyoune please refine it?
[[[
Index: 1.14.html
=
; C:\research\svn\dev\subversion-1.14.3\build\generator\gen_win_dependencies.py:283:
> SyntaxWarning: invalid escape sequence '\d'
> elif re.match('^20\d+$', val):
> C:\research\svn\dev\subversion-1.14.3\build\generator\gen_win_dependencies.py:290:
> SyntaxWarning: invalid escape sequence '\d'
> elif re.match('^1\d+$', val):
> C:\research\svn\dev\subversion-1.14.3\build\transform_sql.py:53:
> SyntaxWarning: invalid escape sequence '\('
> re_statement = re.compile('-- *STMT_([A-Z_0-9]+)( +\(([^\)]*)\))?')
> Generating for Visual Studio 2019
> ]]]
>
> That is using Python 3.12.1.
>
> When downgrading to Python 3.9 those errors are gone. Just wanted to
> let you guys know ...
Should we backport r1912632?
Cheers,
--
Yasuhito FUTATSUKI /
On 2023/12/11 12:54, Yasuhito FUTATSUKI wrote:
> On 2023/12/10 4:22, Yasuhito FUTATSUKI wrote:
>> Thank you for the review. However, it turned out that even with this
>> patch, mailer.py did not work for post-revprop-change hook.
>> It caused exception like
>>
>>
ontent, but
it seems it worked on Python 2, where generator object has next()
method instead of .__next__() method. So it is a missed feature
while porting Python 3.
Cheers,
--
Yasuhito FUTATSUKI
On 2023/12/10 4:22, Yasuhito FUTATSUKI wrote:
> Hi,
>
> On 2023/12/09 0:04, Daniel Sahlberg wrote:
>
>> Den fre 8 dec. 2023 kl 05:40 skrev Yasuhito FUTATSUKI <
>> futat...@yf.bsdclub.org>:
>
>
>
>>> Then, how about this patch? It at least mail
Hi,
On 2023/12/09 0:04, Daniel Sahlberg wrote:
> Den fre 8 dec. 2023 kl 05:40 skrev Yasuhito FUTATSUKI <
> futat...@yf.bsdclub.org>:
>> Then, how about this patch? It at least mailer-t1.sh passed both
>> on python=python2.7 and on python=python3.9.
>>
>&
s_params, search_logmsg_re in
self._group_re:
- match = pattern.match(to_str(path))
+ match = pattern.match(path)
if match:
-if exclude_pattern and exclude_pattern.match(to_str(path)):
+if exclude_pattern and exclude_pattern.match(path):
continue
params = repos_params.copy()
params.update(match.groupdict())
]]]
Cheers,
--
Yasuhito FUTATSUKI
a hashable object and stash it away
param_list = sorted(params.items())
self.groups[group, tuple(param_list)] = params
If I would get a go ahead here on list I would commit.
Regards
Rüdiger
Thanks,
--
Yasuhito FUTATSUKI
t; (including a pair of double
quotatation characters) to svnmucc from shell command line,
we should escape it like '"-"' or \"-\".
Cheers,
--
Yasuhito FUTATSUKI
t but the command of
shbang line did not actually exist.
Since the error can be found after forking, this error cannot be reported
on svn_io_start_cmd3() and apr_proc_create(), then it is reported as
exit process code on apr_proc_wait()/svn_io_wait_for_cmd().
Cheers,
--
Yasuhito FUTATSUKI
are satisfied, below may work.
[[[
#!/bin/sh
if [ ! -n ${ZSH_VERSION} ]; then
exec zsh "$0" "$@"
fi
...
]]]
Cheers,
--
Yasuhito FUTATSUKI
anmaster/man3/SSL_library_init.html says:
"The SSL_library_init() and OpenSSL_add_ssl_algorithms() functions were
deprecated in OpenSSL 1.1.0 by OPENSSL_init_ssl(). "
Cheers,
--
Yasuhito FUTATSUKI
from one I intended.
I'd like someone (Yasuhito?) to crosscheck, if you agree feel free to
modify my vote back to the old +0 with comment and move to approved.
As it had contained wrong revision numbers, I kept your vote -1.
Thanks,
--
Yasuhito FUTATSUKI /
behaviour there are some odd
logic in composing Subject header. Since we are now in being phased out
of support for Python 2.7, we can use new API of email.message introduced
in Python 3.6, I think. I was willing to rewrite by using it, but I didn't.
So, I'm glad if you also do it.
Cheers,
--
Yasuhito FUTATSUKI
On 2023/10/09 21:14, Yasuhito FUTATSUKI wrote:
> And even if the
test pattern is wrong for the purpose, I think this pit fall should
be tested here, or elsewhere (even if it is a bug in test case itself).
This was somewhat pointless, because
On 2023/10/09 18:05, Daniel Sahlberg wrote:
Den mån 9 okt. 2023 kl 10:30 skrev Yasuhito FUTATSUKI <
futat...@yf.bsdclub.org>:
On 2023/10/09 4:14, Daniel Sahlberg wrote:
Den lör 7 okt. 2023 kl 06:52 skrev Yasuhito FUTATSUKI <
futat...@yf.bsdclub.org>:
If svn is called with relati
On 2023/10/09 4:14, Daniel Sahlberg wrote:
Den lör 7 okt. 2023 kl 06:52 skrev Yasuhito FUTATSUKI <
futat...@yf.bsdclub.org>:
If svn is called with relative paths, it can only see
cwd as a realpath, and absolute paths of argment paths
are composed from it. So the paths in error mess
bsolute real paths or relative paths
only (It assumes that relative paths passed from the
command line don't contain symlinks).
Cheers,
--
Yasuhito FUTATSUKI
On 2023/10/05 5:28, Nathan Hartman wrote:
On Wed, Oct 4, 2023 at 10:59 AM Yasuhito FUTATSUKI
wrote:
Nothing but I don't want that we actively drop Python 2 support,
at least SWIG Python bindings even in trunk, at least now.
I agree we shouldn't break Python 2 support if it&#
n in trunk, at least now.
Cheers,
--
Yasuhito FUTATSUKI
Hi,
Thank you for the review and test.
On 2023/10/02 0:43, Daniel Sahlberg wrote:
Den sön 24 sep. 2023 kl 12:55 skrev Yasuhito FUTATSUKI <
futat...@yf.bsdclub.org>:
Hi,
On 2023/09/24 17:53, Daniel Sahlberg wrote:
Den sön 24 sep. 2023 kl 07:06 skrev :
Author: futatuki
Date: Sun Sep
s for
Python 2 bindings, because 1.15.0 might not support Python 2 bindings
even if the trunk supports it now.
Cheers,
--
Yasuhito FUTATSUKI
visible from Python interpreter.
I'll commit it later.
Cheers,
--
Yasuhito FUTATSUKI
Hello,
On 2023/07/19 6:16, Daniel Sahlberg wrote:
Den tis 18 juli 2023 kl 21:23 skrev Yasuhito FUTATSUKI <
futat...@yf.bsdclub.org>:
I'm not fluent in Python to the level of these changes (although as far as
I've been able to test they are good). Could one of you commit?
Hi,
On 2023/06/25 19:22, Daniel Sahlberg wrote:
Den ons 31 maj 2023 kl 05:29 skrev Yasuhito FUTATSUKI <
futat...@yf.bsdclub.org>:
Hello,
On 2023/05/30 17:04, Daniel Sahlberg wrote:
> Den tis 30 maj 2023 kl 04:46 skrev Jun Omae :
[...]
However, in attached patch, correct t
y/SVN/Subversion%27s+Python+3+Support+Status
It seems that those tools in the section "Not Checked For Python 3 Yet"
are now unmantained.
[PEP 594]: https://peps.python.org/pep-0594/#deprecated-modules
Cheers,
Cheers,
--
Yasuhito FUTATSUKI
f not re.match(b'.*\\$LastChangedRevision:\\s*\\d+\\s*\\$',
>> line_contents[3]):
>> ]]]
>>
>> The patch fixes many "invalid escape sequences" which exist in also other
>> Python scripts (verified unit tests with Python 3.5 and 3.12 on Ubuntu, and
>> Python 3.12 on Windows).
>
> I checked the changes and it looks good as far as I understand. I've also
> run the testsuite (make check, make davautocheck, make svnserveautocheck)
> with Python 3.11.2 on Ubuntu (WSL), all seems fine.
Of course, this form of literals is less incompatible between Python versions.
Cheers,
--
Yasuhito FUTATSUKI
g
> index 7d2d0dd03..5949c52e0 100644
> --- a/subversion/bindings/swig/include/proxy.swg
> +++ b/subversion/bindings/swig/include/proxy.swg
> @@ -75,7 +75,7 @@
>_set_instance_attr =
> _swig_setattr_nondynamic_instance_variable(object.__setattr__)
>
> %}
> -#elif defined(SWIGPYTHON_PY3)
> +#elif !defined(SWIG_PYTHON_CLASSIC)
> %pythoncode %{
># SWIG classes generated with -modern do not define this variable
>try:
> ]]]
It looks good to me.
... and for "./autogen.sh --release",
[[[
Index: build/generator/gen_make.py
===
--- build/generator/gen_make.py (revision 1904286)
+++ build/generator/gen_make.py (working copy)
@@ -511,8 +511,9 @@
standalone.write('top_srcdir = .\n')
standalone.write('top_builddir = .\n')
standalone.write('SWIG = swig\n')
+# Assume we are using SWIG >= 4.0 in release mode
swig_py_opts = os.environ.get('SWIG_PY_OPTS',
- '-python -py3 -nofastunpack -modern')
+ '-python -nofastunpack')
standalone.write('SWIG_PY_OPTS = %s\n' % (swig_py_opts))
standalone.write('PYTHON = ' + sys.executable + '\n')
standalone.write('\n')
]]]
Cheers,
--
Yasuhito FUTATSUKI
On 2022/09/20 15:16, Yasuhito FUTATSUKI wrote:
> On 2022/09/20 1:09, Jitka Plesnikova wrote:
>> I reported it to swig upstream
>> https://github.com/swig/swig/issues/2373 and got answer that it is related
>> to change "Remove -py3 command line option"
>>
verride it, please use
env SWIG_PY_OPT='-python -nofastpack' ./autogen.sh --release
for SWIG after commit a343b7e254567a64761bc1be7dc55b7b7424ec52
(or use ./autogen.sh without --release, and make clean-swig after
doing ./configure with appropriate options, for supported
SWIG version).
Cheers,
--
Yasuhito FUTATSUKI
A thing I forgot to write
On 2022/09/19 15:09, Yasuhito FUTATSUKI wrote:
> On 2022/09/19 11:37, Vincent Lefevre wrote:
>> On 2022-09-19 11:02:05 +0900, Yasuhito FUTATSUKI wrote:
> I wrote the second paragraph just for to show where the behaivor
> comes from, i.e. where to f
On 2022/09/19 11:37, Vincent Lefevre wrote:
> On 2022-09-19 11:02:05 +0900, Yasuhito FUTATSUKI wrote:
>> I can't determine whether this behavior is a bug or not.
>>
>> As svn_cl__propedit() calls svn_cmdline__edit_string_externally()[1]
>> for editing revprop
n any scheme, even "file" scheme,
by rejecting the change of revprop values in pre-revprop-change
hook.
[1] subversion/include/private/svn_cmdline_private.h, line 1688
https://svn.apache.org/viewvc/subversion/trunk/subversion/include/private/svn_cmdline_private.h?annotate=1821224#l168
[2] subversion/svn/propedit-cmd.c,line 143
https://svn.apache.org/viewvc/subversion/trunk/subversion/svn/propedit-cmd.c?annotate=1885997#l143
Cheers,
--
Yasuhito FUTATSUKI
.developer.usingapi.html
[2]
https://subversion.apache.org/docs/community-guide/conventions.html#apr-pools
[3]
https://subversion.apache.org/docs/community-guide/conventions.html#exception-handling
Cheers,
--
Yasuhito FUTATSUKI
an svn_error_t object which was allocated from global pool, and
it should be cleared by svn_error_clear(). Otherwise it causes
memory leak.
I think the problem is not svn_fs_node_id() (in this case it is
actually svn_fs_fs__id_node_id()) itself but how use it.
Cheers,
--
Yasuhito FUTATSUKI
quot;\r\n" if we run gen_make.py on Windows (but I not sure it
needs or not).
I think templates in tools/dist/templates are only for
tools/dist/release.py and it is assumed that it runs only on
Unix, so I didn't check them.
Cheers,
--
Yasuhito FUTATSUKI
first part of LICENSE file shoud be equal to
https://www.apache.org/licenses/LICENSE-2.0.txt, so we should not
change the URLs in it.
(I didn't check wheter other changes are safe or not.)
Cheers,
--
Yasuhito FUTATSUKI
On 2022/04/04 17:50, Julian Foad wrote:
> Yasuhito FUTATSUKI wrote:
>>> ./build/__pycache__
>>> ./build/generator/__pycache__
>>> ./build/generator/swig/__pycache__
>>>
>>> Are they supposed to be present in the tarball?
>>
>> I don&#x
="`./build/find_python.sh`"; export PYTHON
>
> solves the issue. I've attached the corresponding patch.
I think there is no other simple solution for it, so I committed
as r1903245(but move the export command, after checking
$PYTHON is not empty).
Cheers,
--
Yasuhito FUTATSUKI
27;s not in the thread
https://lists.apache.org/thread/qf1tfohrwjrjk4qm1j1l8z11hfthlcq3 but a part of
the thread https://lists.apache.org/thread/o59b91vmg9gcm3v1gmnzgw957kcbsp1p .
However, for some reason, its whole message body is quoted.
Link for the raw message is:
https://lists.apache.org/api/source.lua?id=8sffbo95yxp0gdd2spwd1y74nxodblto
Cheers,
--
Yasuhito FUTATSUKI
, on 1.14.x. So I'll nominate r1900890
separately.
> If we do nominate r1900890, here's my +0 for it. (Not +1 because
> I haven't audited all callsites that «import gen_base».)
The change on r1900890 is to restore the behavior before r1900882
only if gen_base.py uses ConfigParser instead of configparser
(i.e. Python < 3).
Cheers,
--
Yasuhito FUTATSUKI
an't be applied against 1.14.x.
Cheers,
--
Yasuhito FUTATSUKI Index: Makefile.in
===
--- Makefile.in (revision 1899544)
+++ Makefile.in (working copy)
@@ -460,6 +460,7 @@
$(abs_srcdir)/build
$(top_srcdir)/su
ile.NamedTemporaryFile(mode='w+', encoding='UTF-8')
+if b'' == '':
+# Python 2
+fd = tempfile.NamedTemporaryFile(mode='w+')
+else:
+ # Python 3
+fd = tempfile.NamedTemporaryFile(mode='w+', encoding='UTF-8')
url = branch_url + '/' + relpath
fd.url = url
subprocess.check_call(['svn', 'cat', '%s@%d' % (url, HEAD)],
]]]
Cheers,
--
Yasuhito FUTATSUKI
t;> was a parameter I was supposed to pass to that. It seemed to work OK
>> though.
>
> I went back and tried again using the 1.14.1 tarball. This works once
> I run autogen.sh. So I am guessing the 1.14.2 branch is just currently
> broken?
Yes, it is my fault. To fix it, r1885199 should be merged.
I just voted for it.
Cheers,
--
Yasuhito FUTATSUKI
On 2021/05/18 12:46, Jun Omae wrote:
> Hi,
>
> On Sun, May 9, 2021 at 3:18 AM Yasuhito FUTATSUKI
> wrote:
>> Jun found that an error message on failing editor invocation on
>> commit/propchange or edit to resolve confilict is still corrupted if
>> editor or file nam
string_from_utf8 and svn_path_cstring_to_utf8 to
transcode file paths.
Found by: jun66j5
]]]
Thanks,
--
Yasuhito FUTATSUKI
Index: subversion/libsvn_subr/cmdline.c
===
--- subversion/libsvn_subr/cmdline.c(rW 1889531)
+++ subversion/l
+1: jun66j5
>> + +1: jun66j5, futatuki
>
> Bindings changes require only two votes, so you can move this to the Approved
> section.
>
> https://subversion.apache.org/docs/community-guide/releasing.html#release-stabilization-how-many-votes
Thank you for the guidance. I've done it.
Cheers,
--
Yasuhito FUTATSUKI
subversion/po/de.po, subversion/po/sv.po ():
>> Fix a msgid and its msgstr corresponding to the changes on r1866587,
>> r1866588 and above.
>
> It seems that r1866587 in the message is incorrect. It might be
> actually r1865987.
Yes, indeed. Even r1866587 is not our project's. I fixed it.
Thank you for the report.
Cheers,
--
Yasuhito FUTATSUKI
confirmed that the test crash before
apply patch to proxy_apr.swg with signal 10 or signal 11 and that
the test passed without crash on Python 3.7 and 3.9, on FreeBSD 12.
On Python 2.7, the test passed without crash both with/without patch
to proxy_apr.swg, as it would be expected.
+1 to commit.
Cheers,
--
Yasuhito FUTATSUKI
On 2021/04/01 3:57, Julian Foad wrote:
> Yasuhito FUTATSUKI wrote:
>> Follow up to r188732: Fix the invocation of svneditor.sh on out of tree
>> build.
>
> I confirm this patch makes it work properly in my out-of-tree build. Thank
> you!
>
Commited in r1888273. Th
ath.abspath('.'))),
+ 'tests/cmdline/svneditor.sh')
# Username and password used by the working copies
wc_author = 'jrandom'
]]]
Cheers,
--
Yasuhito FUTATSUKI
On 2021/03/03 4:05, Daniel Shahaf wrote:
> Yasuhito FUTATSUKI wrote on Tue, 02 Mar 2021 03:21 +00:00:
>> On 2021/03/02 0:41, Daniel Shahaf wrote:
>>> Yasuhito FUTATSUKI wrote on Mon, Mar 01, 2021 at 10:55:51 +0900:
>>>> +++ subversion/tests/cmdline/svneditor.sh.in
On 2021/03/02 0:41, Daniel Shahaf wrote:
> Yasuhito FUTATSUKI wrote on Mon, Mar 01, 2021 at 10:55:51 +0900:
>> On 2021/02/26 22:52, Daniel Shahaf wrote:
>>> Yasuhito FUTATSUKI wrote on Thu, Feb 25, 2021 at 21:43:15 +0900:
>>>> On 2021/02/22 13:39, Karl Fogel wrote:
On 2021/02/26 22:52, Daniel Shahaf wrote:
> Yasuhito FUTATSUKI wrote on Thu, Feb 25, 2021 at 21:43:15 +0900:
>> On 2021/02/22 13:39, Karl Fogel wrote:
>>> I felt I should close the loop in this thread:
>>>
>>> I decided to leave this be for now. Even though
On 2021/02/26 7:02, Karl Fogel wrote:
> On 25 Feb 2021, Yasuhito FUTATSUKI wrote:
>> Then, I made patches. It also allows pypy to run the test without 'python'.
>> (A) Replace the shebang line of svneditor.py from svneditor.py at running
>> the configure scrip
As @PYTHON@ can be basename only, relative path, or absolute path,
"/usr/bin/env" is still needed.
(B) Make a script to launch svneditor.py using @PYTHON@, svneditor.sh
at running the configure scriptt. (fix-svneditor-in-test-patch-b.txt)
If @PYTHON@ is always absolute path, we ca
On 2021/01/29 0:27, Johan Corveleyn wrote:
> On Thu, Jan 28, 2021 at 4:22 PM Yasuhito FUTATSUKI
> wrote:
>>
>> On 2021/01/28 20:13, Johan Corveleyn wrote:
>>> On Thu, Jan 28, 2021 at 12:55 AM Yasuhito FUTATSUKI
>>> wrote:
>>>>
>>>> On
On 2021/01/28 20:13, Johan Corveleyn wrote:
> On Thu, Jan 28, 2021 at 12:55 AM Yasuhito FUTATSUKI
> wrote:
>>
>> On 2021/01/28 7:33, Johan Corveleyn wrote:
>>> On Wed, Jan 27, 2021 at 10:19 PM Yasuhito FUTATSUKI
>>> wrote:
>>>>
>>>> On
On 2021/01/28 7:33, Johan Corveleyn wrote:
> On Wed, Jan 27, 2021 at 10:19 PM Yasuhito FUTATSUKI
> wrote:
>>
>> On 2021/01/28 5:43, Johan Corveleyn wrote:
>>> On Mon, Mar 16, 2020 at 5:11 AM wrote:
>>> [[[
>>> C:\test>set EDITOR="C:\Program
; operable program or batch file.
> svn: E200012: system('"C:\Program Files\Notepad++\notepad++"
> -nosession -multiInst "svn-prop.tmp"') returned 1
> ]]]
Perhaps my pending patch also fix this.
Please see
https://lists.apache.org/thread.html/r2b8b0b4ca0f833e371590fadb33ee24c6335127e967664c6e612e154%40%3Cdev.su
> os.path.join(sys.path[0], 'svneditor.py')))
> svneditor_script_st = os.stat(svneditor_script)
> os.chmod(svneditor_script, svneditor_script_st.st_mode | stat.S_IEXEC)
>
> Pretty straightforward, right? I know, I know: it doesn't clean up the
> shell script afterwards or anything yet. I'm just experimenting.
How about using configure to generate svneditor.sh?
Cheers,
--
Yasuhito FUTATSUKI
reter explicitly for this purpose or not.
[[[
configure: Search Python 3 before searching Python 2 for tests suite.
* build/find_python.sh: Add option to specify version to search for.
* configure.ac: Search Python 3 before searching Python 2 for tests suite.
]]]
Cheers,
--
Yasuhito FUTATSUKI
f remove_leading_slashes(path):
>> - while path and path[0] == '/':
>> + while path and path[0:1] == b'/':
>> path = path[1:]
>>return path
>>
Cheers,
--
Yasuhito FUTATSUKI
completed as tests yet, and my script didn't hit the error
pattern (perhaps my test case is always base_path is None). I'm still working
to add my script as additional tests, because current tests also don't
covered SMTPOutput and PipeOutput for Output, and propchange, propchange2,
lock and unlock commands, although my check script don't propchange
commnand yet.
Cheers,
--
Yasuhito FUTATSUKI
On 2021/01/20 14:24, Nathan Hartman wrote:
> [cc -= users]
>
> On Tue, Jan 19, 2021 at 10:50 PM Yasuhito FUTATSUKI
> wrote:
> It looks like a simple copy-paste mistake when the new macros were
> introduced in r1687415.
>
> Two more fixes are needed: a similar patte
tion(&repos_relpath,
&peg_rev,
&node_kind,
conflict,
]]]
Cheers,
--
Yasuhito FUTATSUKI
On 2021/01/15 7:30, Stefan Sperling wrote:
> On Fri, Jan 15, 2021 at 01:44:43AM +0900, Yasuhito FUTATSUKI wrote:
>> On 2020/12/29 0:49, Stefan Sperling wrote:
>>> On Tue, Dec 15, 2020 at 07:47:59PM +0900, Yasuhito FUTATSUKI wrote:
>>>> As far as I read the code a
On 2020/12/29 0:49, Stefan Sperling wrote:
> On Tue, Dec 15, 2020 at 07:47:59PM +0900, Yasuhito FUTATSUKI wrote:
>> As far as I read the code again, it seems this is already support
>> locales other than C/C.UTF-8 if mailer.py is kicked with appropriate
>> LC_CTYPE enviro
On 2020/12/31 8:59, Yasuhito FUTATSUKI wrote:
> During writing the test above I also found that on swig-py for Python 3
> wrapper functions using svn_string_t * or svn_stringbuf_t * for in
> input arguments don't accept str objects for their values. This was
> my overloo
On 2020/12/31 8:59, Yasuhito FUTATSUKI wrote:
> On 2020/12/28 19:10, Daniel Shahaf wrote:
>> Yasuhito FUTATSUKI wrote on Sat, 26 Dec 2020 11:02 +00:00:
>>> On 2020/12/26 3:38, Nathan Hartman wrote:
>>>
>>>> But the solution you suggest above, adding a new_
On 2020/12/28 19:10, Daniel Shahaf wrote:
> Yasuhito FUTATSUKI wrote on Sat, 26 Dec 2020 11:02 +00:00:
>> On 2020/12/26 3:38, Nathan Hartman wrote:
>>
>>> But the solution you suggest above, adding a new_rev attribute to the
>>> exception and leaving the return va
I'm sorry, but I'd like to make a correction.
On 2020/12/26 20:02, Yasuhito FUTATSUKI wrote:
> [[[
> Index: subversion/bindings/swig/python/svn/fs.py
> ===
> --- subversion/bindings/swig/python/svn/fs.
7;svn_fs_')
_unprefix_names(locals(), 'SVN_FS_')
]]]
Of course, we can use svn_fs_commit_txn2 instead of _svn_fs_commit_txn
in above patch, then it will satisfy the Daniel's proposal.
Cheers,
--
Yasuhito FUTATSUKI
On 2020/12/23 14:09, Nathan Hartman wrote:
> On Tue, Dec 22, 2020 at 10:13 AM Yasuhito FUTATSUKI
> wrote:
>>
>> On 2020/08/29 2:49, C. Michael Pilato wrote:
>>>>> Committed revision 1880967.
>>>>>
>>>>> I made only minor comment/f
-PATH and it is not desirable behavior.
For Python 2/3 support, I don't want to drop Python 2 support for mailer.py
if we can easily, but I also think Python 3 support is higher priority.
And as also I wrote another thread, it seems still incomplete to support
Python 3. I'll take a look this, but it has not made progress at all
since I then, sorry.
Cheers,
--
Yasuhito FUTATSUKI
On 2020/12/21 15:50, Daniel Shahaf wrote:
> Johan Corveleyn wrote on Sun, 20 Dec 2020 23:05 +0100:
>> On Sat, May 23, 2020 at 2:17 PM Yasuhito FUTATSUKI
>> wrote:
>>>
>>> On 2020/05/23 12:16, Daniel Shahaf wrote:
>>>> Yasuhito FUTATSUKI wrote on Sat
exception. In addtion, we introduce framework
to add attributes to 'SubversionException' to return values to caller
if argments for output in C API are useful when the API returns an error
(however this new feature actually is not a part of the errata).
If an API user expects that
trepo
]]]
This can be also occured if we use some tools to import commits
including svnadmin itself.
Cheers,
--
Yasuhito FUTATSUKI
On 2020/12/04 6:56, Yasuhito FUTATSUKI wrote:
> On 2020/12/04 6:40, Yasuhito FUTATSUKI wrote:
>> Many thanks for the reviw. Then I've amended the patch.
>> (attached file, introduce-release-mode-configure-patch-v2.txt)
>
> I'm very sorry the patch attached p
On 2020/12/15 5:06, Stefan Sperling wrote:
> On Tue, Dec 15, 2020 at 03:51:03AM +0900, Yasuhito FUTATSUKI wrote:
>> First of all, thank you for doing this. I worried that mailer.py didn't
>> support Python 3 for a long time.
>>
>> In message <20201214165710.d
if a subject contains
multi-byte characters.
The issue of RFC5321 violation of max line length I pointed out on
Janunary might be fixed by this commit because of fix on
email.header.Header implementation of Python 3 library, but I've not
confirmed yet.
Cheers,
--
Yasuhito FUTATSUKI
On 2020/12/12 12:33, Daniel Shahaf wrote:
> futat...@apache.org wrote on Thu, 10 Dec 2020 14:45 +00:00:
Thank you for the review. I've replaced the commit message.
Cheers,
--
Yasuhito FUTATSUKI
On 2020/11/12 0:52, Yasuhito FUTATSUKI wrote:
> On 2020/11/11 23:58, Nathan Hartman wrote:
>> On Wed, Nov 11, 2020 at 2:15 AM Yasuhito FUTATSUKI
>> wrote:
>>
>>>
>>> I don't think we support to run tests on PyPy but also I don't think
>>>
On 2020/12/04 6:40, Yasuhito FUTATSUKI wrote:
> Many thanks for the reviw. Then I've amended the patch.
> (attached file, introduce-release-mode-configure-patch-v2.txt)
I'm very sorry the patch attached previous mail is a bit old.
It contains an extra tweak on style in relea
On 2020/12/02 4:24, Branko Čibej wrote:
> On 01.12.2020 17:34, Yasuhito FUTATSUKI wrote:
>> On 2020/11/17 11:01, Yasuhito FUTATSUKI wrote:
>>> On 2020/11/17 2:16, Daniel Shahaf wrote:
>>>> Yasuhito FUTATSUKI wrote on Sat, 14 Nov 2020 14:52 +0900:
>>>
On 2020/11/17 11:01, Yasuhito FUTATSUKI wrote:
> On 2020/11/17 2:16, Daniel Shahaf wrote:
>> Yasuhito FUTATSUKI wrote on Sat, 14 Nov 2020 14:52 +0900:
>>> +++ subversion/bindings/swig/INSTALL(working copy)
>>> @@ -141,7 +141,15 @@
>>> - Make sure that
se make to return an
> error:
Though it is already resolved and I have no objection to the solution
It seems that it happens only when run configure out of source tree and
do 'make clean' before mkdir-init target has done. In this case,
$(SWIG_PY_DIR) does not exists.
Cheers,
--
Yasuhito FUTATSUKI
On 2020/11/23 13:43, Daniel Shahaf wrote:
> Yasuhito FUTATSUKI wrote on Sun, Nov 22, 2020 at 18:24:35 +0900:
>> On 2020/11/22 17:54, Branko Čibej wrote:
>>> On 22.11.2020 08:24, futat...@apache.org wrote:
>>>> Author: futatuki
>>>> Date: Sun Nov 2
On 2020/11/22 18:24, Yasuhito FUTATSUKI wrote:
> On 2020/11/22 17:54, Branko Čibej wrote:
>> On 22.11.2020 08:24, futat...@apache.org wrote:
>>> Author: futatuki
>>> Date: Sun Nov 22 07:24:46 2020
>>> New Revision: 1883719
>>>
>>> URL: htt
uired" if it's not mentioned in configure options.
Ah, I overlooked the usage of value 'check' for the argument 'where'.
I restored the usage of this in r1883722. Thank you.
Also, I'll change this behavor to warn only if users correctly specified some
of --with-swig-* but swig is not found in "release mode".
Cheers.
--
Yasuhito FUTATSUKI
On 2020/11/20 18:58, Branko Čibej wrote:
> On 20.11.2020 10:05, Yasuhito FUTATSUKI wrote:
>> On 2020/11/20 10:44, Yasuhito FUTATSUKI wrote:
>>> On 2020/11/20 10:22, Branko Čibej wrote:
>>>> On 20.11.2020 01:45, Yasuhito FUTATSUKI wrote:
>>
>>> Th
On 2020/11/20 10:44, Yasuhito FUTATSUKI wrote:
> On 2020/11/20 10:22, Branko Čibej wrote:
>> On 20.11.2020 01:45, Yasuhito FUTATSUKI wrote:
> Then if users want to rebuild bindings C source, they can do by using
> --with-swig option in configure and doing
> "make ext
On 2020/11/20 10:22, Branko Čibej wrote:
> On 20.11.2020 01:45, Yasuhito FUTATSUKI wrote:
>> Hi,
>>
>> As I wrote in another thread, Subversion's configure script in release
>> mode still has an issue that it detects SWIG executable which is never
>> used in
1 - 100 of 302 matches
Mail list logo
