Re: [PATCH] Add serf library version information to svn --version

2013-08-15 Thread Philip Martin
Ivan Zhakov i...@visualsvn.com writes: Log message: [[[ Add serf library version to svn --version output. * subversion/libsvn_ra_serf/serf.c (RA_SERF_DESCRIPTION): Add version placeholders. (ra_serf_get_description): Add serf library version information to RA layer description.

Re: [PATCH] Add serf library version information to svn --version

2013-08-15 Thread Ivan Zhakov
On Thu, Aug 15, 2013 at 3:59 PM, Philip Martin philip.mar...@wandisco.com wrote: Ivan Zhakov i...@visualsvn.com writes: Log message: [[[ Add serf library version to svn --version output. * subversion/libsvn_ra_serf/serf.c (RA_SERF_DESCRIPTION): Add version placeholders.

Re: [PATCH] Add serf library version information to svn --version

2013-08-15 Thread Philip Martin
Ivan Zhakov i...@visualsvn.com writes: Good point. I'll fix it in separate commit. What do you think about patch itself? Is there any reason for the static optimisation? Does performance matter? Why not simply format each time? -- Philip Martin | Subversion Committer WANdisco // *Non-Stop

Re: [PATCH] Add serf library version information to svn --version

2013-08-15 Thread Ivan Zhakov
On Thu, Aug 15, 2013 at 4:14 PM, Philip Martin phi...@codematters.co.uk wrote: Philip Martin philip.mar...@wandisco.com writes: Ivan Zhakov i...@visualsvn.com writes: Good point. I'll fix it in separate commit. What do you think about patch itself? Is there any reason for the static

Re: [PATCH] Add serf library version information to svn --version

2013-08-15 Thread Philip Martin
Ivan Zhakov i...@visualsvn.com writes: On Thu, Aug 15, 2013 at 4:14 PM, Philip Martin phi...@codematters.co.uk wrote: Philip Martin philip.mar...@wandisco.com writes: Ivan Zhakov i...@visualsvn.com writes: Good point. I'll fix it in separate commit. What do you think about patch itself?

Re: [PATCH] Add serf library version information to svn --version

2013-08-15 Thread Ivan Zhakov
On Thu, Aug 15, 2013 at 5:38 PM, Philip Martin philip.mar...@wandisco.com wrote: Ivan Zhakov i...@visualsvn.com writes: On Thu, Aug 15, 2013 at 4:14 PM, Philip Martin phi...@codematters.co.uk wrote: Philip Martin philip.mar...@wandisco.com writes: Ivan Zhakov i...@visualsvn.com writes:

Re: [PATCH] Add serf library version information to svn --version

2013-08-15 Thread Ben Reser
On 8/15/13 4:48 AM, Ivan Zhakov wrote: Thoughts? It'd be nice if this was printed under the linked dependencies section of `svn --version --verbose`, but I don't see a good way of adding that since serf is required by the dynamically loadable ra layer and isn't a core dependency. Maybe we

Re: [PATCH] Add serf library version information to svn --version

2013-08-15 Thread Ivan Zhakov
On Thu, Aug 15, 2013 at 8:07 PM, Ben Reser b...@reser.org wrote: On 8/15/13 4:48 AM, Ivan Zhakov wrote: Thoughts? It'd be nice if this was printed under the linked dependencies section of `svn --version --verbose`, but I don't see a good way of adding that since serf is required by the