Re: [PATCH] Compiling subversion trunk with httpd trunk code fails

2011-03-02 Thread Kamesh Jayachandran
Thanks Vijay. Committed your in r1076234. With regards Kamesh Jayachandran On 03/02/2011 03:18 PM, vijay wrote: Attached the patch that uses macro based solution. APLOG_USE_MODULE is used only in case of HTTPD 2.3. Thanks & Regards, Vijayaguru On Wednesday 02 March 2011 12:20 AM, Stefan Spe

Re: [PATCH] Compiling subversion trunk with httpd trunk code fails

2011-03-02 Thread vijay
Attached the patch that uses macro based solution. APLOG_USE_MODULE is used only in case of HTTPD 2.3. Thanks & Regards, Vijayaguru On Wednesday 02 March 2011 12:20 AM, Stefan Sperling wrote: On Tue, Mar 01, 2011 at 11:08:22PM +0530, Kamesh Jayachandran wrote: On the whole I preferred the mac

Re: [PATCH] Compiling subversion trunk with httpd trunk code fails

2011-03-01 Thread Stefan Sperling
On Tue, Mar 01, 2011 at 11:08:22PM +0530, Kamesh Jayachandran wrote: > >On the whole I preferred the macro solution. > > Me to prefer the orignal macro based solution. OK. Let's go for that, then.

RE: [PATCH] Compiling subversion trunk with httpd trunk code fails

2011-03-01 Thread Kamesh Jayachandran
>No! If you are going to use separate functions then write: >static void log_access_verdict(...) >{ It still needs a signature change to log_access_verdict. >#if AP_MODULE_MAGIC_AT_LEAST(...) > log_access_verdict_httpd_v23(...) >#else > log_access_verdict_httpd_v22(...) >#endif >} >so that

Re: [PATCH] Compiling subversion trunk with httpd trunk code fails

2011-03-01 Thread Philip Martin
vijay writes: > * This function is used as a provider to allow mod_dav_svn to bypass the > @@ -580,7 +624,11 @@ >if (!conf->anonymous >|| (! (conf->access_file || conf->repo_relative_access_file))) > { > - log_access_verdict(APLOG_MARK, r, 0, repos_path, NULL); > +#if AP_M

Re: [PATCH] Compiling subversion trunk with httpd trunk code fails

2011-03-01 Thread vijay
Herewith attached the updated patch and log message. Thanks & Regards, Vijayaguru On Tuesday 01 March 2011 06:30 PM, Stefan Sperling wrote: On Tue, Mar 01, 2011 at 11:59:28AM +0530, vijay wrote: [[[ Update log_access_verdict to make it work with httpd trunk as well as older versions. The funct

Re: [PATCH] Compiling subversion trunk with httpd trunk code fails

2011-03-01 Thread Stefan Sperling
On Tue, Mar 01, 2011 at 11:59:28AM +0530, vijay wrote: > [[[ > Update log_access_verdict to make it work with httpd trunk as well as older > versions. The function is being called with APLOG_MACRO in few places. > The macro APLOG_MARK expands to 2 arguments till httpd-2.2.x but 3 > arguments in htt

Re: [PATCH] Compiling subversion trunk with httpd trunk code fails

2011-03-01 Thread Philip Martin
vijay writes: > Index: subversion/mod_authz_svn/mod_authz_svn.c > === > --- subversion/mod_authz_svn/mod_authz_svn.c (revision 1075316) > +++ subversion/mod_authz_svn/mod_authz_svn.c (working copy) > @@ -32,6 +32,7 @@ > #include

[PATCH] Compiling subversion trunk with httpd trunk code fails

2011-02-28 Thread vijay
Hi, I tried to compile subversion trunk with httpd trunk code. make fails with the attached error. Then I got that there is a macro APLOG_MARK which expands differently in httpd-2.2.x and httpd-2.3-dev. From httpd-2.2.x, #define APLOG_MARK __FILE__,__LINE__ From httpd-2.3-dev, #define AP