Re: [PATCH] Fix JavaHL crash in TunnelAgent.CloseTunnelCallback after GC

2020-10-15 Thread Alexandr Miloslavskiy
Now available on branch 'javahl-1.14-fixes', r1882522.

Re: [PATCH] Fix JavaHL crash in TunnelAgent.CloseTunnelCallback after GC

2020-09-09 Thread Thomas Singer
Has this patch been merged yet? If not, what input is needed to get it accepted? Tom On 2020-08-07 20:47, Alexandr Miloslavskiy wrote: Please find test snippet and patch attached. [[[ Fix JavaHL crash in TunnelAgent.CloseTunnelCallback after GC When jobject reference is kept across differen

Re: [PATCH] Fix JavaHL crash in TunnelAgent.CloseTunnelCallback after GC

2020-08-16 Thread Nathan Hartman
On Fri, Aug 7, 2020 at 3:07 PM Alexandr Miloslavskiy wrote: > > Please find test snippet and patch attached. > > [[[ > Fix JavaHL crash in TunnelAgent.CloseTunnelCallback after GC > > When jobject reference is kept across different JNI calls, a new global > reference must be requested with NewGlob

Re: [PATCH] Fix JavaHL crash in TunnelAgent.CloseTunnelCallback after GC

2020-08-11 Thread Alexandr Miloslavskiy
On 11.08.2020 3:56, James McCoy wrote: Is this superceded by your other patch? No, these are two different patches.

Re: [PATCH] Fix JavaHL crash in TunnelAgent.CloseTunnelCallback after GC

2020-08-10 Thread James McCoy
On Fri, Aug 07, 2020 at 08:47:07PM +0200, Alexandr Miloslavskiy wrote: > Please find test snippet and patch attached. > > [[[ > Fix JavaHL crash in TunnelAgent.CloseTunnelCallback after GC > > When jobject reference is kept across different JNI calls, a new global > reference must be requested wi

[PATCH] Fix JavaHL crash in TunnelAgent.CloseTunnelCallback after GC

2020-08-07 Thread Alexandr Miloslavskiy
Please find test snippet and patch attached. [[[ Fix JavaHL crash in TunnelAgent.CloseTunnelCallback after GC When jobject reference is kept across different JNI calls, a new global reference must be requested with NewGlobalRef(). Otherwise, GC is free to remove the object. Even if Java code kee