Hello
Could you review my patch?
2013-09-08 23:25 GMT+09:00 Masaru Tsuchiyama m.tma...@gmail.com:
Ben Reser wrote:
On 8/18/13 5:34 AM, Daniel Shahaf wrote:
Haven't looked at the rest of the patch, perhaps Ben will as he reviewed
an earlier iteration. (but I know he is a bit busy this
I updated for head revision.
[[[
add support for svnrdump to svn-backup-dumps.py
* tools/server-side/svn-backup-dumps.py
() : fix comment
() : update to ver 0.7
() : import urlparse
(SvnBackup.__init__) : fix message in SvnBackupException constructor.
(SvnBackup.__init__) : check
Ben Reser wrote:
On 8/18/13 5:34 AM, Daniel Shahaf wrote:
Haven't looked at the rest of the patch, perhaps Ben will as he reviewed
an earlier iteration. (but I know he is a bit busy this week, including
a release tomorrow and several other things..)
It's starred in my mailbox.
Hello Ben
Masaru Tsuchiyama wrote on Thu, Aug 15, 2013 at 15:06:12 +0900:
I added -- to the command line options.
Thanks.
+# pass -- to tell commands that 'self.__repospath' is not a
command-line option.
+cmd = [ self.__svn_path, log, -l 1, -q, --, self.__repospath
]
[-l 1] should
Daniel Shahaf wrote:
+# pass -- to tell commands that 'self.__repospath' is not a
command-line option.
+cmd = [ self.__svn_path, log, -l 1, -q, --, self.__repospath ]
[-l 1] should be either [-l1] or [-l, 1].
Fixed in the attached patch.
--
Masaru Tsuchiyama
On 8/18/13 5:34 AM, Daniel Shahaf wrote:
Haven't looked at the rest of the patch, perhaps Ben will as he reviewed
an earlier iteration. (but I know he is a bit busy this week, including
a release tomorrow and several other things..)
It's starred in my mailbox.
Hello
(2013/08/08 22:47), C. Michael Pilato wrote:
On 08/08/2013 09:40 AM, Daniel Shahaf wrote:
On Thu, Aug 08, 2013 at 09:26:09AM -0400, C. Michael Pilato wrote:
This tells the options parser that there are no command-line options
which follow, which would keep self.__repospath from being
Hello
(2013/08/08 22:47), C. Michael Pilato wrote:
On 08/08/2013 09:40 AM, Daniel Shahaf wrote:
On Thu, Aug 08, 2013 at 09:26:09AM -0400, C. Michael Pilato wrote:
This tells the options parser that there are no command-line options
which follow, which would keep self.__repospath from being
Typo, revision_regex
fixed at the attached patch.
+cmd = [ self.__svnadmin_path, dump,
+--incremental, -r, revparam,
self.__repospath ]
That doesn't look right. If self.__repospath can be a local path to a
repository root, you shouldn't pass it as an
Masaru Tsuchiyama wrote on Thu, Aug 08, 2013 at 22:17:05 +0900:
+cmd = [ self.__svnadmin_path, dump,
+--incremental, -r, revparam,
self.__repospath ]
That doesn't look right. If self.__repospath can be a local path to a
repository root, you shouldn't
On 08/08/2013 09:17 AM, Masaru Tsuchiyama wrote:
Also, it'd be good practice to pass -- in front of self.__repospath,
but that
appears to be a preexisting problem in the code (i.e., not introduced
by your
patch).
What is the purpose in passing --?
This tells the options parser that there
On Thu, Aug 08, 2013 at 09:26:09AM -0400, C. Michael Pilato wrote:
This tells the options parser that there are no command-line options
which follow, which would keep self.__repospath from being treated as an
option in the unlikely scenario that it begins with a hyphen.
Right. 99% of the time
On 08/08/2013 09:40 AM, Daniel Shahaf wrote:
On Thu, Aug 08, 2013 at 09:26:09AM -0400, C. Michael Pilato wrote:
This tells the options parser that there are no command-line options
which follow, which would keep self.__repospath from being treated as an
option in the unlikely scenario that it
support for svnrdump to svn-backup-dumps.py
* tools/server-side/svn-backup-dumps.py
() : fix comment
() : update to ver 0.7
() : import urlparse
(SvnBackup.__init__) : fix message in SvnBackupException constructor.
(SvnBackup.__init__) : check whether the second parameter is a local
Thanks for sending text/plain patches!
+++ tools/server-side/svn-backup-dumps.py (working copy)
+def get_head_rev_for_url(self):
+extra_param = self.get_extra_param()
+
+# use 'svn yougest' to get the HEAD revision of URL
+# 'svn yougest' is supported on
+revison_regex = re.compile(^r(\d+))
Typo, revision_regex
... and while at it, use r literals to avoid clashes with a potential future
r\d backslash escape sequence.
Hi.
Does anybody comment my patch?
(2013/08/04 9:36), Masaru Tsuchiyama wrote:
Hello
I attach a patch to add support for svnrdump to svn-backup-dumps.py.
[[[
add support for svnrdump to svn-backup-dumps.py
* tools/server-side/svn-backup-dumps.py
() : fix comment
() : update to
On Sat, Aug 3, 2013 at 5:36 PM, Masaru Tsuchiyama m.tma...@gmail.com wrote:
Hello
I attach a patch to add support for svnrdump to svn-backup-dumps.py.
[[[
add support for svnrdump to svn-backup-dumps.py
* tools/server-side/svn-backup-dumps.py
() : fix comment
() : update to ver 0.7
Hello
I attach a patch to add support for svnrdump to svn-backup-dumps.py.
[[[
add support for svnrdump to svn-backup-dumps.py
* tools/server-side/svn-backup-dumps.py
() : fix comment
() : update to ver 0.7
() : import urlparse
(SvnBackup.__init__) : fix message in SvnBackupException
19 matches
Mail list logo
