Re: [PATCH] extend svn_subst_translate_string() to record whether re-encoding and/or line ending translation were performed (v. 3)

2010-11-15 Thread Julian Foad
On Sat, 2010-11-13, Daniel Trebbien wrote: > > The only difference between translate_newline() and translate_newline_alt() > > is the lines of code from here to the end of the function. I think you > > could keep translate_newline() as is, and just move these checks elsewhere > > (to a new functio

Re: [PATCH] extend svn_subst_translate_string() to record whether re-encoding and/or line ending translation were performed (v. 3)

2010-11-13 Thread Daniel Trebbien
> The only difference between translate_newline() and translate_newline_alt() > is the lines of code from here to the end of the function.  I think you > could keep translate_newline() as is, and just move these checks elsewhere > (to a new function or to the caller; I haven't thought about this in

Re: [PATCH] extend svn_subst_translate_string() to record whether re-encoding and/or line ending translation were performed (v. 3)

2010-11-09 Thread Daniel Shahaf
[ @dtrebbien, please read the whole email before starting to reply or act on the feedback; some of the earlier comments are mooted by the later ones ] [ @all, I have a question about the cost of creating subpools; search for #subpool_question to find it ] Daniel Trebbien wrote on Sun, Nov 07,

Re: [PATCH] extend svn_subst_translate_string() to record whether re-encoding and/or line ending translation were performed (v. 3)

2010-11-07 Thread Daniel Trebbien
Hi Daniel, Thank you for your feedback. I have attached a new patch and log message that addresses the points that you have mentioned. > If we can provide the information cheaply, I see no reason not to let > the APIs provide it.  As some of these APIs are already revved for 1.7, > we might as w