Re: [PATCH] fix a crash in libsvn_wc

2012-08-29 Thread Daniel Shahaf
Philip Martin wrote on Wed, Aug 29, 2012 at 15:50:08 +0100: > George Gugulea writes: > > > does this function exist in subversion-1.7.6 ? > >> > >>svn_client_ctx_t *ctx; > >>svn_error_t *err; > >> > >>err = svn_client_create_context(&ctx, pool) > > Yes, it exists in all Subversion ve

Re: [PATCH] fix a crash in libsvn_wc

2012-08-29 Thread Philip Martin
George Gugulea writes: > does this function exist in subversion-1.7.6 ? >> >>svn_client_ctx_t *ctx; >>svn_error_t *err; >> >>err = svn_client_create_context(&ctx, pool) Yes, it exists in all Subversion versions back to 1.0. -- Certified & Supported Apache Subversion Downloads: http

Re: [PATCH] fix a crash in libsvn_wc

2012-08-29 Thread George Gugulea
does this function exist in subversion-1.7.6 ? On Wed, Aug 29, 2012 at 5:08 PM, C. Michael Pilato wrote: > On 08/29/2012 09:47 AM, George Gugulea wrote: > > (sorry, for me subversion is code at-first-sight) > > > > in the plugin it seems that this code happens: > > //=

Re: [PATCH] fix a crash in libsvn_wc

2012-08-29 Thread C. Michael Pilato
On 08/29/2012 09:47 AM, George Gugulea wrote: > (sorry, for me subversion is code at-first-sight) > > in the plugin it seems that this code happens: > //== > svn_client_ctx_t ctx; > memset(&ctx, 0, sizeof(ctx)); > > // get the

Re: [PATCH] fix a crash in libsvn_wc

2012-08-29 Thread George Gugulea
not enough) > > ** ** > > Bert**** > > ** ** > > *From:* George Gugulea [mailto:[email protected]] > *Sent:* dinsdag 28 augustus 2012 18:10 > *To:* [email protected] > *Subject:* Re: [PATCH] fix a crash in libsvn_wc > > ** ** >

RE: [PATCH] fix a crash in libsvn_wc

2012-08-29 Thread Bert Huijben
From: George Gugulea [mailto:[email protected]] Sent: dinsdag 28 augustus 2012 18:10 To: [email protected] Subject: Re: [PATCH] fix a crash in libsvn_wc [[[ Used from the kdevelop subversion plugin, the db pointers comes NULL. This should be treated one way or another, I choose to

Re: [PATCH] fix a crash in libsvn_wc

2012-08-29 Thread Philip Martin
George Gugulea writes: > [[[ > Used from the kdevelop subversion plugin, the db pointers comes NULL. This > should be treated one way or another, I choose to return error and not an > assert because it might be a recoverable error. This should be reviewed and > an appropriate action should be tak

Re: [PATCH] fix a crash in libsvn_wc

2012-08-29 Thread George Gugulea
[[[ Used from the kdevelop subversion plugin, the db pointers comes NULL. This should be treated one way or another, I choose to return error and not an assert because it might be a recoverable error. This should be reviewed and an appropriate action should be taken. ]]] attached is the patch for

[PATCH] fix a crash in libsvn_wc

2012-08-29 Thread George Gugulea
[[[ Used from the kdevelop subversion plugin, the db pointers comes NULL. This should be treated one way or another, I choose to return error and not an assert because it might be a recoverable error. This should be reviewed and an appropriate action should be taken. ]]] -- gg