Re: [PATCH] fix potentially undefined operation warning

2014-05-16 Thread Branko Čibej
On 10.05.2014 05:26, Andreas Stieger wrote: Hello, I found a compiler warning in trunk on a potentially undefined operation when using an increment operator on a variable referenced in the same expression. This is on gcc 4.3.4, does not happen in gcc 4.7 and up. Treated as an error in some

Re: [PATCH] fix potentially undefined operation warning

2014-05-16 Thread Andreas Stieger
Hi, On 15 May 2014, at 15:49, Branko Čibej br...@wandisco.com wrote: Good catch, the result of these operations is indeed undefined, according to the C standard. However, I don't know if your fix is correct ... the other interpretation is: foo(data, data + 1); ++data;

Re: [PATCH] fix potentially undefined operation warning

2014-05-16 Thread Stefan Fuhrmann
On Sat, May 10, 2014 at 2:26 PM, Andreas Stieger andreas.stie...@gmx.dewrote: Hello, I found a compiler warning in trunk on a potentially undefined operation when using an increment operator on a variable referenced in the same expression. This is on gcc 4.3.4, does not happen in gcc 4.7 and

Re: [PATCH] fix potentially undefined operation warning

2014-05-16 Thread Mattias Engdegård
16 maj 2014 kl. 19.24 skrev Andreas Stieger: I think he has. Further, the call is to svn__base36toui64() which, if I read correctly, uses the pointer as a return, e.g. in this case it does not matter whether the first parameter was incremented. Never versions of gcc might detect this and

[PATCH] fix potentially undefined operation warning

2014-05-13 Thread Andreas Stieger
Hello, I found a compiler warning in trunk on a potentially undefined operation when using an increment operator on a variable referenced in the same expression. This is on gcc 4.3.4, does not happen in gcc 4.7 and up. Treated as an error in some build configurations.