Re: [PATCH] fsfs7 index offset validation

2015-05-20 Thread Stefan Fuhrmann
On Mon, May 18, 2015 at 1:16 AM, Daniel Shahaf wrote: > Stefan, > > How about the following patch to sanity check the rev file footer? > Committed as r1680460 with a minor modification. > > Index: subversion/libsvn_fs_fs/low_level.c >

Re: [PATCH] fsfs7 index offset validation

2015-05-20 Thread Stefan Fuhrmann
On Mon, May 18, 2015 at 11:27 AM, Ivan Zhakov wrote: > On 18 May 2015 at 02:16, Daniel Shahaf wrote: > > Stefan, > > > > How about the following patch to sanity check the rev file footer? > > > [...] > > > > > The error looks like this: > > > > subversion/libsvn_fs_fs/rev_file.c:263, > >

Re: [PATCH] fsfs7 index offset validation

2015-05-18 Thread Daniel Shahaf
Ivan Zhakov wrote on Mon, May 18, 2015 at 12:27:38 +0300: > On 18 May 2015 at 02:16, Daniel Shahaf wrote: > > subversion/libsvn_fs_fs/rev_file.c:263, > > subversion/libsvn_fs_fs/low_level.c:212: > > (apr_err=SVN_ERR_INCORRECT_PARAMS) > > svn: E24: Invalid L2P offset in revision fo

Re: [PATCH] fsfs7 index offset validation

2015-05-18 Thread Ivan Zhakov
On 18 May 2015 at 02:16, Daniel Shahaf wrote: > Stefan, > > How about the following patch to sanity check the rev file footer? > [...] > > The error looks like this: > > subversion/libsvn_fs_fs/rev_file.c:263, > subversion/libsvn_fs_fs/low_level.c:212: > (apr_err=SVN_ERR_INCORRECT_PARAMS

[PATCH] fsfs7 index offset validation

2015-05-17 Thread Daniel Shahaf
Stefan, How about the following patch to sanity check the rev file footer? [[[ fsfs7: Validate index offsets in rev file footer. * subversion/libsvn_fs_fs/low_level.c (svn_fs_fs__parse_footer): Take FILESIZE argument, use it for validation. * subversion/libsvn_fs_fs/low_level.h (svn_fs_fs__