This patch is a followup of the following thread. All tests pass with
this patch.
http://svn.haxx.se/dev/archive-2011-01/0210.shtml
Log
[[[
Make 'svn ls' continue processing targets after printing warning if one
or more of the targets is a non-existent URL or wc-entry. Also return a
non-zero er
Noorul Islam K M writes:
> This patch is a followup of the following thread. All tests pass with
> this patch.
>
> http://svn.haxx.se/dev/archive-2011-01/0210.shtml
>
> Log
> [[[
>
> Make 'svn ls' continue processing targets after printing warning if one
> or more of the targets is a non-existent
Noorul Islam K M writes:
> Noorul Islam K M writes:
>
>> This patch is a followup of the following thread. All tests pass with
>> this patch.
>>
>> http://svn.haxx.se/dev/archive-2011-01/0210.shtml
>>
>> Log
>> [[[
>>
>> Make 'svn ls' continue processing targets after printing warning if one
>>
Noorul Islam K M wrote on Thu, Feb 10, 2011 at 16:50:39 +0530:
> Index: subversion/tests/cmdline/basic_tests.py
> +def ls_multiple_url_targets(sbox):
> + "ls multiple url targets"
> +
> + sbox.build()
> +
> + alpha = sbox.repo_url + '/A/B/E/alpha'
> + beta = sbox.repo_url + '/A/B/E/beta'
> +
Daniel Shahaf writes:
> Noorul Islam K M wrote on Thu, Feb 10, 2011 at 16:50:39 +0530:
>
>> Index: subversion/tests/cmdline/basic_tests.py
>> +def ls_multiple_url_targets(sbox):
>> + "ls multiple url targets"
>> +
>> + sbox.build()
>> +
>> + alpha = sbox.repo_url + '/A/B/E/alpha'
>> + beta =
Hi Noorul,
comments inline:
On Fri, Feb 11, 2011 at 12:49:04PM +0530, Noorul Islam K M wrote:
> ===
> --- subversion/tests/cmdline/basic_tests.py (revision 1068757)
> +++ subversion/tests/cmdline/basic_tests.py (working copy)
> @
On Mon, Feb 14, 2011 at 01:18:58PM +0100, Stefan Sperling wrote:
> > @@ -301,5 +318,8 @@
> >if (opt_state->xml && ! opt_state->incremental)
> > SVN_ERR(svn_cl__xml_print_footer("lists", pool));
> >
> > - return SVN_NO_ERROR;
> > + if (saw_a_problem)
> > +return svn_error_create(SVN
Stefan Sperling writes:
>> + alpha = os.path.join(wc_dir, 'A/B/E/alpha')
>> + beta = os.path.join(wc_dir, 'A/B/E/beta')
>
> I think you need this here instead:
> alpha = os.path.join(wc_dir, 'A', 'B', 'E', alpha')
> beta = os.path.join(wc_dir, 'A', 'B', 'E', 'beta')
>
> Otherwise you'll get
Stefan Sperling wrote on Mon, Feb 14, 2011 at 13:25:13 +0100:
> On Mon, Feb 14, 2011 at 01:18:58PM +0100, Stefan Sperling wrote:
> > > @@ -301,5 +318,8 @@
> > >if (opt_state->xml && ! opt_state->incremental)
> > > SVN_ERR(svn_cl__xml_print_footer("lists", pool));
> > >
> > > - return SV
Philip Martin writes:
> Stefan Sperling writes:
>
>>> + alpha = os.path.join(wc_dir, 'A/B/E/alpha')
>>> + beta = os.path.join(wc_dir, 'A/B/E/beta')
>>
>> I think you need this here instead:
>> alpha = os.path.join(wc_dir, 'A', 'B', 'E', alpha')
>> beta = os.path.join(wc_dir, 'A', 'B', 'E',
Daniel Shahaf writes:
> Stefan Sperling wrote on Mon, Feb 14, 2011 at 13:25:13 +0100:
>
>> On Mon, Feb 14, 2011 at 01:18:58PM +0100, Stefan Sperling wrote:
>> > > @@ -301,5 +318,8 @@
>> > >if (opt_state->xml && ! opt_state->incremental)
>> > > SVN_ERR(svn_cl__xml_print_footer("lists", po
On Mon, Feb 14, 2011 at 07:32:51PM +0530, Noorul Islam K M wrote:
> Daniel Shahaf writes:
>
> > Stefan Sperling wrote on Mon, Feb 14, 2011 at 13:25:13 +0100:
> >
> >> On Mon, Feb 14, 2011 at 01:18:58PM +0100, Stefan Sperling wrote:
> >> > > @@ -301,5 +318,8 @@
> >> > >if (opt_state->xml && !
Stefan Sperling writes:
> On Mon, Feb 14, 2011 at 07:32:51PM +0530, Noorul Islam K M wrote:
>
>> Daniel Shahaf writes:
>>
>> > Stefan Sperling wrote on Mon, Feb 14, 2011 at 13:25:13 +0100:
>> >
>> >> On Mon, Feb 14, 2011 at 01:18:58PM +0100, Stefan Sperling wrote:
>> >> > > @@ -301,5 +318,8 @@
On Mon, Feb 14, 2011 at 07:55:17PM +0530, Noorul Islam K M wrote:
> Incorporated all review comments. Please find attached latest patch.
Thanks! Committed in r1070510 (with similar log message tweak as
I did for the 'add' diff).
Also, I did not commit the change for svn info, because I wasn't sur
Stefan Sperling writes:
> On Mon, Feb 14, 2011 at 07:55:17PM +0530, Noorul Islam K M wrote:
>
>> Incorporated all review comments. Please find attached latest patch.
>
> Thanks! Committed in r1070510 (with similar log message tweak as
> I did for the 'add' diff).
>
> Also, I did not commit the ch
15 matches
Mail list logo