Re: [PATCH]On branch swig-py3: accept both of bytes/str for inputchar * args

2019-02-22 Thread Yasuhito FUTATSUKI
On 2/20/19 11:05 PM, Troy Curtis Jr wrote: On Sun, Feb 17, 2019, 10:32 AM Daniel Shahaf wrote: Yasuhito FUTATSUKI wrote on Sun, 17 Feb 2019 06:13 +00:00: On 2/17/19 9:04 AM, Daniel Shahaf wrote: * If we want to install py2 bindings and py3 bindings at the same time, we must rename libs

Re: [PATCH]On branch swig-py3: accept both of bytes/str for inputchar * args

2019-02-20 Thread Troy Curtis Jr
On Sun, Feb 17, 2019, 10:32 AM Daniel Shahaf wrote: > Yasuhito FUTATSUKI wrote on Sun, 17 Feb 2019 06:13 +00:00: > > On 2/17/19 9:04 AM, Daniel Shahaf wrote: > > > > > I was wondering what are the blockers for merging swig-py3 into trunk? > > > The only item in BRANCH-README is "Fix a compile err

Re: [PATCH]On branch swig-py3: accept both of bytes/str for inputchar * args

2019-02-17 Thread Daniel Shahaf
Yasuhito FUTATSUKI wrote on Sun, 17 Feb 2019 06:13 +00:00: > On 2/17/19 9:04 AM, Daniel Shahaf wrote: > > > I was wondering what are the blockers for merging swig-py3 into trunk? > > The only item in BRANCH-README is "Fix a compile error on windows with > > py3", but I don't even know if that's a

Re: [PATCH]On branch swig-py3: accept both of bytes/str for inputchar * args

2019-02-16 Thread Yasuhito FUTATSUKI
On 2/17/19 9:04 AM, Daniel Shahaf wrote: I was wondering what are the blockers for merging swig-py3 into trunk? The only item in BRANCH-README is "Fix a compile error on windows with py3", but I don't even know if that's a current issue or an old one that has since been fixed. I'm sorry I'm no

Re: [PATCH]On branch swig-py3: accept both of bytes/str for inputchar * args

2019-02-16 Thread Daniel Shahaf
Yasuhito FUTATSUKI wrote on Sat, 16 Feb 2019 07:37 +00:00: > On 1/20/19 5:50 PM, Yasuhito FUTATSUKI wrote: > > Patch updated. > > I've commited it with modifications below, as r1853592. Thanks! I was wondering what are the blockers for merging swig-py3 into trunk? The only item in BRANCH-README

Re: [PATCH]On branch swig-py3: accept both of bytes/str for inputchar * args

2019-02-15 Thread Yasuhito FUTATSUKI
On 1/20/19 5:50 PM, Yasuhito FUTATSUKI wrote: Patch updated. I've commited it with modifications below, as r1853592. * Add support to convert py_file from unicode file name in svn_swig_py_make_file() * Revise test case for svn_stream_write() in python/tests/core.py Thanks, -- Yasuhito FUTATS

Re: [PATCH]On branch swig-py3: accept both of bytes/str for inputchar * args

2019-01-20 Thread Yasuhito FUTATSUKI
Patch updated. In article troycurti...@gmail.com writes: On Thu, Jan 10, 2019 at 9:50 AM Yasuhito FUTATSUKI wrote: The patch attached modifies 4 kind of input argment translations. (1) typemap(in) char * (with/without const modifiers); not allow NULL, typemap(in) const char * MAY_BE_N

Re: [PATCH]On branch swig-py3: accept both of bytes/str for inputchar * args

2019-01-15 Thread Yasuhito FUTATSUKI
On 1/14/19 6:30 PM, Yasuhito FUTATSUKI wrote: On 1/14/19 3:10 PM, Yasuhito FUTATSUKI wrote: In article troycurti...@gmail.com writes: On Thu, Jan 10, 2019 at 9:50 AM Yasuhito FUTATSUKI PyBytes: Sequence of byte values, e.g. "raw data"     In Py2: str     In Py3: bytes PyStr: Character dat

Re: [PATCH]On branch swig-py3: accept both of bytes/str for inputchar * args

2019-01-14 Thread Yasuhito FUTATSUKI
On 1/14/19 3:10 PM, Yasuhito FUTATSUKI wrote: In article troycurti...@gmail.com writes: On Thu, Jan 10, 2019 at 9:50 AM Yasuhito FUTATSUKI wrote: The patch attached modifies 4 kind of input argment translations. (1) typemap(in) char * (with/without const modifiers); not allow NULL, t

Re: [PATCH]On branch swig-py3: accept both of bytes/str for inputchar * args

2019-01-13 Thread Yasuhito FUTATSUKI
In article troycurti...@gmail.com writes: > On Thu, Jan 10, 2019 at 9:50 AM Yasuhito FUTATSUKI > wrote: >> The patch attached modifies 4 kind of input argment translations. >> >> (1) typemap(in) char * (with/without const modifiers); not allow NULL, >> typemap(in) const char * MAY_BE_NULL;